10278 Commits

• Merge pull request #34087 from peppy/song-select-v2-deletion-handling

  Improve song select's automatic selection behaviour when current selection is no longer valid

  Dean Herbert · 2025-07-10 21:52:29 +09:00
  8ff2100560
• Simplify post-hide selection
  Dean Herbert · 2025-07-10 21:08:57 +09:00
  acdd246518
• Add test coverage of ruleset changes, ensuring same beatmap is preferred if possible
  Dean Herbert · 2025-07-10 18:13:38 +09:00
  5bc1dd1415
• Disallow hiding beatmap difficulties if only one difficulty remains
  Dean Herbert · 2025-07-10 17:57:45 +09:00
  789ddcf395
• Ensure adjacent selection when currently selected beatmap is hidden
  Dean Herbert · 2025-07-10 17:46:10 +09:00
  44bbb7f029
• Ensure adjacent selection when currently selected beatmap(set) is deleted
  Dean Herbert · 2025-07-10 17:46:09 +09:00
  994bd4abfe
• Merge pull request #34046 from minetoblend/feature/ruleset-select-sample-support

  Add support for `ruleset-select` sample for custom rulesets

  Dan Balasescu · 2025-07-09 20:56:26 +09:00
  f1c8b1e1b2
• Merge pull request #33889 from frenzibyte/source-grouping

  Add mode for grouping beatmaps by their source

  Dean Herbert · 2025-07-08 17:09:45 +09:00
  3406303060
• Merge pull request #33818 from diquoks/ssv2-localisation-overlap

  Define separate strings for song select's difficulty statistics display (and add a maximum width limit)

  Dean Herbert · 2025-07-07 12:25:19 +09:00
  3becc61c53
• Add support for ruleset-select sample for custom rulesets
  marvin · 2025-07-06 14:50:13 +02:00
  26ede9ca59
• Remove duplicated test method
  Dean Herbert · 2025-07-01 17:34:52 +09:00
  99220408f6
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Update TestGroupingByDifficulty to account for floored star rating
  Chris Ehmann · 2025-06-30 19:52:40 -07:00
  8ae8d847d5
• Fix player settings no longer collapsing correctly

  Regressed with https://github.com/ppy/osu/pull/33621 for obvious
  reasons. Tachyon doing its job, caught this before hitting a proper
  release.

  Dean Herbert · 2025-06-30 16:57:51 +09:00
  d1c0d58f2e
• Merge pull request #33670 from bdach/ensure-replays-are-played-to-end

  Ensure partial failed replays are played to their end

  Dean Herbert · 2025-06-30 15:56:13 +09:00
  768d44596a
• Fix flaky TestSceneGameplaySamplePlayback test

  See: https://github.com/ppy/osu/actions/runs/15924307907/job/44920278903
  
  Similar null-checks within `Update()` are present in the
  `PlayerTestScene` superclass.

  Dan Balasescu · 2025-06-29 00:24:12 +09:00
  5c89644d58
• Attempt to fix flaky test TestExitWithHoldDisabled

  See
  https://github.com/ppy/osu/actions/runs/15915618971/job/44892620536#step:5:203.
  
  Note that the `DialogOverlay` only finishes loading after the until step
  failure.

  Dean Herbert · 2025-06-27 14:32:58 +09:00
  e713a68c49
• Merge pull request #33858 from frenzibyte/multiplayer-match-link

  Add external link button to multiplayer/playlists room panels

  Dan Balasescu · 2025-06-26 23:16:05 +09:00
  bc07aba692
• Add test coverage
  Salman Alshamrani · 2025-06-26 10:05:21 +03:00
  7a1c7fbd7d
• Add test coverage
  Salman Alshamrani · 2025-06-26 03:03:22 +03:00
  3ac557907e
• Merge pull request #33880 from bdach/user-tag-reorders

  Fix user tags moving in the control after voting

  Dean Herbert · 2025-06-25 20:55:21 +09:00
  5a01b76c35
• Remove no longer used method
  Dan Balasescu · 2025-06-25 18:31:35 +09:00
  d42fcabcf4
• Merge pull request #33875 from bdach/hitwindow-refactor

  Refactor hit windows class structure to reduce rigidity

  Dan Balasescu · 2025-06-25 18:22:01 +09:00
  09e31b7b01
• Add failing test case
  Bartłomiej Dach · 2025-06-25 11:01:53 +02:00
  ee2a247c66
• Add failing test
  Bartłomiej Dach · 2025-06-25 09:47:53 +02:00
  57bfb37888
• Fix flaky carousel test due to out of range async filter operation

  See
  https://github.com/ppy/osu/actions/runs/15868654672/job/44740248052?pr=33873#step:5:49.

  Dean Herbert · 2025-06-25 15:45:41 +09:00
  f1e23595e7
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Merge pull request #33773 from peppy/fix-carousel-random-not-respecting-group

  SongSelectV2: Refine random selection to currently open group (and support difficulty split panels better)

  Bartłomiej Dach · 2025-06-24 14:37:09 +02:00
  a797c46d75
• Expand test even further to cover even more potential weirdness
  Bartłomiej Dach · 2025-06-24 13:32:42 +02:00
  0de964b10b
• Merge pull request #33830 from EYHN/eyhn/fix/pp-rounding

  Fix inconsistent rounding strategy for PP

  Bartłomiej Dach · 2025-06-24 13:29:12 +02:00
  1c2e56cd9b
• Expand test to cover more potential weirdness and fix said weirdness
  Dean Herbert · 2025-06-24 19:21:04 +09:00
  7b6ecbd10b
• Merge pull request #33679 from bdach/truncate-sr

  Floor star rating to 2 decimal places rather than rounding

  Dan Balasescu · 2025-06-24 19:04:56 +09:00
  6057c6c4d4
• Add testing
  Bartłomiej Dach · 2025-06-24 11:46:40 +02:00
  a78dc31d8b
• Fix potential crash when attempting random selection after changing grouping mode
  Dean Herbert · 2025-06-24 17:48:38 +09:00
  a1ec71e677
• Merge pull request #33664 from peppy/footer-metrics

  Remove fade from footer display transition

  Bartłomiej Dach · 2025-06-24 07:45:29 +02:00
  02ce399150
• Merge branch 'master' into ssv2-localisation-overlap
  Denis Titovets · 2025-06-23 08:25:41 +03:00
  522b7a2fff
• Add maximum limit to wedge difficulty statistics
  Salman Alshamrani · 2025-06-23 03:34:19 +03:00
  4203f2cdeb
• Switch to IconPills, add storyboard icon
  StanR · 2025-06-22 13:45:07 +05:00
  25eb9914a4
• Add beatmapset This beatmap contains video badge
  StanR · 2025-06-22 01:24:58 +05:00
  9b7c722d97
• Merge pull request #33775 from peppy/fix-another-case-of-keyboard-weird

  SongSelectV2: Fix pressing multiple traversal keys in same frame causing weirdness

  Bartłomiej Dach · 2025-06-20 19:58:37 +02:00
  8f8b02249f
• Fix tests
  Dean Herbert · 2025-06-20 20:37:58 +09:00
  3af0ce7e5e
• Merge pull request #33765 from frenzibyte/autoplay-retain-mod-settings

  Fix incompatible mods not retaining settings after selecting autoplay via ctrl+enter

  Dean Herbert · 2025-06-20 18:58:59 +09:00
  21eb4a6260
• Merge branch 'master' into fix-another-case-of-keyboard-weird
  Dean Herbert · 2025-06-20 02:16:54 +09:00
  0e34752e5f
• Merge pull request #33668 from peppy/ssv2-group-key-bindings
  Bartłomiej Dach · 2025-06-19 17:35:28 +02:00
  267a6a0ac7
• SongSelectV2: Fix pressing multiple traversal keys in same frame causing weirdness

  Closes #33453.

  Dean Herbert · 2025-06-19 18:30:57 +09:00
  6350e6d1a7
• SongSelectV2: Fix random selection not working as expected when displaying individual difficulties

  Previously, random selection would always be done at a *set* level. The
  final operation of a random action would be "select the user's
  recommended difficulty from this randomly selected set".
  
  This makes no sense when sets are not grouped together at song select.
  In fact, it is completely broken with the previous commit which adds
  group-isolated random support – if we're grouping by difficulty and the
  user's recommendation is not in the current group it would throw the
  user into another group unexpectedly.
  
  This fixes the issue by splitting out the random implementation into two
  separate pathways depending on the carousel display mode.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  f676206331
• SongSelectV2: Fix random button not respecting open group

  Closes https://github.com/ppy/osu/issues/33569.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  d200a59902
• Add failing test case
  Salman Alshamrani · 2025-06-18 19:19:54 +03:00
  9cb824df6f
• Merge pull request #33575 from smoogipoo/package-manager-tachyon

  Add Tachyon support for package managed installations

  Dean Herbert · 2025-06-18 19:46:18 +09:00
  b870ac0f03
• Adjust rank formatting logic to avoid getting cut in score
  Salman Alshamrani · 2025-06-18 01:52:26 +03:00
  1ceb59d78e