3539 Commits

• Merge branch 'master' into song-select-v2-random
  Dean Herbert · 2025-05-28 20:06:50 +09:00
  0b527ce14b
• Merge pull request #33301 from peppy/remember-group-expansion

  SongSelectV2: Fix expanded group not being persisted over filter operations

  Bartłomiej Dach · 2025-05-28 12:55:23 +02:00
  d9d74696df
• Merge pull request #33303 from bdach/song-select-v2-holding-traversal-resets-to-start-end

  SongSelectV2: Fix holding beatmap carousel previous / next traversal actions resetting position to start / end when update frame rate is low

  Dean Herbert · 2025-05-28 19:39:18 +09:00
  13f0f6d7bf
• Fix difficulty grouping not working with random
  Dean Herbert · 2025-05-28 12:14:27 +02:00
  dca839211c
• SongSelectV2: Fix holding beatmap carousel previous / next traversal actions resetting position to start / end when update frame rate is low
  Bartłomiej Dach · 2025-05-28 11:45:59 +02:00
  c56c7b7239
• SongSelectV2: Fix expanded group not being persisted over filter operations
  Dean Herbert · 2025-05-28 18:15:40 +09:00
  df66bab31f
• SongSelectV2: Fix group panels being recreated every filter

  This also allows *all* panels to be re-used based on equality, as
  originally intended. Beatmap updates should be handled correctly without
  a full (flashing) recreation of panels now.

  Dean Herbert · 2025-05-28 17:46:14 +09:00
  c2bd4a9827
• SongSelectV2: Add back basic random selection support

  This is a minimal implementation in order to keep moving forward.
  
  For simplicity I've copied over the old implementation verbatim. Note
  that this is beatmap*set* based randomisation, which means that when
  panels are split up by difficulty, it is still randomising by set (with
  the difficulty choice being left up to the user recommendation system).
  I think this is what we want, but if it isn't, any changes can come
  later.

  Dean Herbert · 2025-05-28 16:54:11 +09:00
  1b56ce9a39
• Merge pull request #33288 from peppy/song-select-v2-sounds

  SongSelectV2: Add back missing song select sound effects

  Bartłomiej Dach · 2025-05-28 08:08:17 +02:00
  7926a26b0b
• Use global sample debounce period
  Dean Herbert · 2025-05-27 22:57:22 +09:00
  cc6c274d98
• Mode BDL method to proper region
  Dean Herbert · 2025-05-27 22:55:49 +09:00
  5ad1e05861
• Merge pull request #33287 from peppy/fix-selection

  SongSelectV2: Fix carousel not correctly handling traversal when current selection is filtered away

  Bartłomiej Dach · 2025-05-27 12:33:04 +02:00
  e5ba517f9c
• Add back beatmap carousel sound effects
  Dean Herbert · 2025-05-27 19:10:02 +09:00
  b01b0daf70
• Fix carousel not correctly handling traversal when current selection is filtered away

  Closes https://github.com/ppy/osu/issues/33215.

  Dean Herbert · 2025-05-27 18:32:56 +09:00
  046db53857
• Merge pull request #33281 from peppy/fix-switching-difficulty-split-modes

  Fix panels not updating visually when changing between difficulty sort modes

  Bartłomiej Dach · 2025-05-27 10:59:44 +02:00
  790a2f8f37
• Merge pull request #33279 from peppy/song-select-v2-reset-scroll

  SongSelectV2: Scroll to selection when mouse moves to left area

  Bartłomiej Dach · 2025-05-27 10:50:12 +02:00
  f34980ba54
• Fix panels not updating visually when changing between difficulty sort modes

  I'm going with the simplest approach for this for now. If there's a
  discrepancy, clear all panels and start from scratch.
  
  Closes #33204.

  Dean Herbert · 2025-05-27 17:21:15 +09:00
  907d680188
• Expose ability to scroll to selected in Carousel (and handle screen-wide input to allow scrolling outside of bounds)
  Dean Herbert · 2025-05-27 15:53:32 +09:00
  a50ee3b3d2
• Simplify logo tracking logic since we never have more than one logo
  Dean Herbert · 2025-05-27 02:18:25 +09:00
  4335b51edc
• Add basic "eager" selection to ensure something is selected at song select after import
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  4a03240ee6
• Add icon specification to OsuMenuItem

  This isn't used visually for context menus, but is handy to have when
  using this class to convey more general information about actions,
  including usages outside of context menus where an icon is relevant to
  have.

  Dean Herbert · 2025-05-23 15:46:52 +09:00
  1cf4636d31
• Use larger offset to ensure depth is still backmost even with DepthLayer is in use
  Dean Herbert · 2025-05-16 19:08:54 +09:00
  bfc23c98f1
• Avoid animating list tail

  At very high scroll speeds (using pageup/pagedown) you would see a weird
  animation of panels appearing. This removes the animation for that edge
  case.

  Dean Herbert · 2025-05-16 17:45:32 +09:00
  a32da2ea10
• Add new panels to carousel with a better initial Y position

  Previously, carousel panels would appear immediately at their required Y
  position. This didn't look great when they appear with other panels
  surrounding them.
  
  Now they will spawn in underneath the nearest item before them, making
  the animation feel much more correct.

  Dean Herbert · 2025-05-16 17:23:08 +09:00
  615d4accfb
• Add fade animation when carousel panels are expired

  This fixes the hard cut that was previously very jarring.

  Dean Herbert · 2025-05-16 17:21:49 +09:00
  6a2337dbea
• Fix depth flip-flopping during initial animation
  Dean Herbert · 2025-05-16 17:14:27 +09:00
  7efa724a8a
• Remove misplaced assert
  Dean Herbert · 2025-05-16 17:14:11 +09:00
  0302a37190
• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec
• Tidy up ScreenFooter and back button action flow
  Dean Herbert · 2025-05-15 18:37:42 +09:00
  087e054708
• Code quality fixes
  Dean Herbert · 2025-05-15 12:14:54 +03:00
  bb8d3bcf66
• Allow starting beatmap with autoplay via ctrl-enter
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  8e7c093476
• Make carousel handle pressing enter with modifier keys
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  87c97ad0b5
• Merge branch 'master' into full-sorting-support
  Bartłomiej Dach · 2025-05-14 14:42:29 +02:00
  a57ca72ccf
• Allow tests to accedss CarouselItems post filter operation
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  8e15af2b2d
• Fix new (beatmap) carousel not correctly accounting for user scroll overrides

  The new carousel implementation was lacking some scroll related
  behaviours. This makes sure that post-filter, the selection is
  re-centered *unless* the user has scrolled away manually.
  
  This matches the old carousel's behaviour. See
  https://github.com/ppy/osu/pull/16647 for original implementation.
  
  Closes https://github.com/ppy/osu/issues/33052.

  Dean Herbert · 2025-05-14 17:32:44 +09:00
  a8d8d2d84c
• Fix exceptions being hidden by async task usage
  Dean Herbert · 2025-05-13 17:43:57 +09:00
  36317bc459
• Use fast invert helper in hot path
  Dan Balasescu · 2025-05-11 13:05:15 +09:00
  ff0a80751a
• Update filter control's status text with beatmap displayed count

  This also fixes code running in `Update` which shouldn't be, by
  consuming the new `NewItemsPresented` callback.
  
  Fields and properties are renamed to knock some sense into things (was
  previously called two or three different things).

  Dean Herbert · 2025-05-09 15:05:41 +09:00
  1edbdc5aac
• Expose a way of knowing when carousel's displayed items are updated
  Dean Herbert · 2025-05-09 14:49:38 +09:00
  a957f41ffc
• Merge pull request #33039 from frenzibyte/song-select-filter-support

  Hook up filter control with beatmap carousel

  Dean Herbert · 2025-05-07 19:28:24 +09:00
  724176458f
• Change ICarouselFilter interface return type rather than manual ToList

  I was hung up on keeping `IEnumerable` but there doesn't seem to be a
  good reason to do so.

  Dean Herbert · 2025-05-07 16:40:23 +09:00
  ebd6776898
• Ensure carousel filters are manifested to lists at each step

  The original `IEnumerable` flow prioritised slight performance gains,
  but a filter's implementation could actually make this detrimental to
  overall performance.
  
  I noticed in passing that there were already potentially multiple
  enumerations, via `updateYPositions` and the final `ToList` call. Rather
  than faffing around, let's keep things simple and require lists.
  
  In benchmarking, the difference is (currently) negiligible. Slight
  improvement if anything.

  Dean Herbert · 2025-05-07 15:55:20 +09:00
  cc0c21a216
• Add test coverage for song select filtering
  Salman Alshamrani · 2025-05-07 09:17:54 +03:00
  d34e040b4e
• Fix sheared components getting masked away due to negative margins
  Dean Herbert · 2025-04-30 18:33:49 +09:00
  c2a7687a66
• Add song select filter control
  Salman Alshamrani · 2025-04-30 17:53:14 +09:00
  9d3ee2a573
• Add ShearedSearchTextBox variant with "N matches" note
  Salman Alshamrani · 2025-04-30 17:42:09 +09:00
  8576ef247f
• Limit input inside slider bar pieces instead
  Salman Alshamrani · 2025-04-30 11:08:30 +03:00
  84cb4da1ec
• Fix masking bleed
  Dean Herbert · 2025-04-30 16:00:00 +09:00
  10c546dced
• Add ability to click/drag in between nubs for better control
  Dean Herbert · 2025-04-30 15:32:58 +09:00
  9871acd618
• Introduce sheared range slider
  Salman Alshamrani · 2025-04-30 14:52:51 +09:00
  f3e23def90