Dean Herbert
f4c505709a
Use parsing methods in more places
...
Limiting scope to beatmap decoding for this pass. Can expand to skin/storyboard in the future.
2019-03-13 13:56:31 +09:00
Dean Herbert
f8b5cf8c8e
Add extra clamping of endTime to startTime
2019-03-13 13:46:41 +09:00
Dean Herbert
f0114d776d
Use interface to access API
...
Allows for better testability.
2019-03-13 12:58:18 +09:00
Dan Balasescu
a35d9ccc09
Apply clamping suggestion
...
Co-Authored-By: peppy <pe@ppy.sh>
2019-03-13 12:35:05 +09:00
Dean Herbert
0241148385
Add extensive tests
2019-03-13 11:30:38 +09:00
Dean Herbert
93b774104a
Fix NaN handling
2019-03-13 11:30:33 +09:00
Dean Herbert
73d9aef5bd
Fix filename
2019-03-12 20:38:04 +09:00
Dean Herbert
cc09ecbfcf
Increase validation performed on .osu files to avoid hard crashes
2019-03-12 20:31:15 +09:00
David Zhao
527b77b07d
Make all inheritors of drawablejudgement use new method
2019-03-12 19:52:44 +09:00
David Zhao
7eb253b687
Fix incorrect scale duration
2019-03-12 19:44:53 +09:00
David Zhao
3b3b1e51ee
Move hit animation logic into virtual method
2019-03-12 19:41:33 +09:00
David Zhao
9850122245
Fix incorrect delay
2019-03-12 19:24:46 +09:00
David Zhao
12f334035f
Create properties for use in DrawableManiaJudgement
2019-03-12 19:23:24 +09:00
Dean Herbert
a10cd2288d
Improve ModRamp's handling of external rate changes
2019-03-12 18:15:18 +09:00
Dean Herbert
6832e384a9
Simplify DT/HT/NC/DC
2019-03-12 18:14:41 +09:00
Dean Herbert
c1a356161f
Allow use rate adjust to fallback to clock rate adjust
2019-03-12 18:14:01 +09:00
Dan Balasescu
13f84e8d50
Merge pull request #4445 from Joehuu/direct-stats-offset
...
Fix direct panel stats being misaligned by one pixel
2019-03-12 17:22:30 +09:00
Dan Balasescu
e6e0cf1957
Merge branch 'master' into direct-stats-offset
2019-03-12 16:17:36 +09:00
Dan Balasescu
47e28e8ad6
Merge pull request #4453 from peppy/ensure-import-sanity
...
Ensure import continues if an existing item's online IDs are in a bad state
2019-03-12 14:38:31 +09:00
Dan Balasescu
05358fa458
Merge branch 'master' into ensure-import-sanity
2019-03-12 14:24:07 +09:00
Dan Balasescu
716df570bb
Merge pull request #4454 from peppy/4439-alternative
...
Refactor UpdateableBeatmapBackground lookup logic for clarity
2019-03-12 13:17:03 +09:00
Dan Balasescu
c92ecc4808
Merge branch 'master' into 4439-alternative
2019-03-12 13:07:06 +09:00
Dan Balasescu
8897739a53
Merge pull request #4456 from peppy/fix-direct-queries
...
Fix osu!direct firing excess queries during initial search characters
2019-03-12 12:54:31 +09:00
Dan Balasescu
448e3da429
Merge branch 'master' into fix-direct-queries
2019-03-12 12:47:33 +09:00
Dan Balasescu
fc7cb14388
Merge pull request #4459 from Joehuu/fix-chan-sel-dimming-forever
...
Fix channel selection overlay leaving background dimmed when popped out
2019-03-12 12:32:50 +09:00
Joehu
ad3b956cec
Fix channel selection overlay dimming bg forever when popped out
2019-03-11 20:10:59 -07:00
Dan Balasescu
61ba39d89f
Merge branch 'master' into fix-direct-queries
2019-03-12 12:02:17 +09:00
Dan Balasescu
246b214fa6
Merge pull request #4457 from peppy/fix-hold-to-quit
...
Fix HoldForMenuButton getting stuck in a confirming state
2019-03-12 11:58:43 +09:00
Dean Herbert
cdeaa80fea
Call ResetSpeedAdjustments before adjusting clock
2019-03-12 11:35:25 +09:00
Dean Herbert
13b3036ec6
Fix "wind" mods adjusting rate twice
...
This is a hotfix for incorrect framework behaviour.
Closes #4442
2019-03-12 02:45:45 +09:00
Dean Herbert
1be4c7b813
Fix excess newline
2019-03-12 02:23:23 +09:00
Dean Herbert
38e75421ab
Fix HoldForMenuButton getting stuck in a confirming state
...
Closes #4446 .
2019-03-12 02:21:34 +09:00
Dean Herbert
941a72d69a
Fix osu!direct firing excess queries during initial search characters
...
Due to faulty debounce fire logic, a web request would always fire with a single character search, followed by the real search. This caused unwanted delays and display weirdness.
2019-03-12 01:49:47 +09:00
Dean Herbert
59897bbeb5
Refactor UpdateableBeatmapBackground lookup logic for clarity
...
Closes #4401 . Alternative to #4439 .
2019-03-11 19:00:39 +09:00
Dean Herbert
d0ae75af6e
Add tests and fix scenario where all matching are contained by duplicate candidate
2019-03-11 18:13:33 +09:00
Dean Herbert
3a8c32d41b
Add the ability for ArchiveModelManager to re-import even when existing entry is present
2019-03-11 17:04:18 +09:00
Dan Balasescu
7805b95a1e
Merge pull request #4438 from peppy/extract-slider-tick-creation
...
Extract slider tick creation so it can be shared with osu!catch
2019-03-11 15:01:32 +09:00
Dean Herbert
63fea65c0c
Clarify repeat index
2019-03-11 14:53:21 +09:00
Dean Herbert
489153579a
Add xmldoc and clarify struct variables
2019-03-11 14:36:29 +09:00
Dean Herbert
2029cf93fd
Rename and reuse variables
2019-03-11 14:33:21 +09:00
Dean Herbert
26f78b659b
Merge remote-tracking branch 'upstream/master' into extract-slider-tick-creation
2019-03-11 14:31:12 +09:00
Dean Herbert
61330a690e
Merge pull request #4448 from Joehuu/naming-convention-1
...
Fix file naming on ParticipantCountDisplay
2019-03-10 20:48:34 +09:00
Joehu
0fc6fa7245
Fix file naming on ParticipantCountDisplay
2019-03-09 20:29:56 -08:00
Joehu
7311ccabfb
Fix direct panel stats being misaligned by one pixel
2019-03-08 20:27:50 -08:00
Dean Herbert
9df27f3a5f
Merge branch 'master' into prevent-null-lookup
2019-03-09 11:14:54 +09:00
Dean Herbert
312efbdc34
Merge pull request #4440 from peppy/update-framework
...
Update framework
2019-03-08 22:46:43 +09:00
Dean Herbert
10734b774c
Update framework
2019-03-08 20:48:50 +09:00
Dean Herbert
c6194d5487
Merge branch 'master' into extract-slider-tick-creation
2019-03-08 20:40:03 +09:00
Dean Herbert
843a37721d
Merge pull request #4157 from LeNitrous/mod-wind
...
Add "Wind Up" and "Wind Down" mods
2019-03-08 20:32:43 +09:00
Dean Herbert
48e54c84c1
Merge branch 'master' into mod-wind
2019-03-08 20:23:02 +09:00
