1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-30 07:12:58 +08:00
Commit Graph

59505 Commits

Author SHA1 Message Date
ansel
c2bb0949f5 Take type and id from container directly on submit 2023-01-14 22:57:23 +03:00
ansel
cdf3aafddd Add check for any drawables in content before looking for placeholder 2023-01-14 22:37:05 +03:00
Bartłomiej Dach
a9facc076f
Fix difficulty creation flow failing for some ruleset combinations
In current `master`, the difficulty creation flow would retrieve a
"reference beatmap" to copy metadata and timing points from using
`GetPlayableBeatmap()`. But, importantly, it was calling that method
using *the ruleset of the new difficulty* rather than the ruleset of the
existing one. This would make the difficulty creation flow fail if the
beatmap couldn't be converted between rulesets (like taiko to catch).

Fixing to use the reference beatmap's actual ruleset would be trivial,
but there's no real reason to do all of that work anyway when a
`WorkingBeatmap` is available. Because getting a playable beatmap is not
required to copy across metadata and timing points, remove the
`GetPlayableBeatmap()` step entirely to fix the bug.

Closes #22145.
2023-01-14 19:46:55 +01:00
Joseph Madamba
e7ab543799 Add ability to view converted beatmaps on beatmap set overlay 2023-01-14 10:26:21 -08:00
ansel
88c3eef8e1 Add test case with no existing comments 2023-01-14 20:59:13 +03:00
Dean Herbert
efe6dae672
Merge pull request #22200 from bdach/user-profile/update-design-basics
Update user profile appearance to closer match web
2023-01-15 02:50:11 +09:00
Bartłomiej Dach
3102044d00
Add failing test for new difficulty creation 2023-01-14 18:46:14 +01:00
Dean Herbert
4906f37109
Merge pull request #22181 from frenzibyte/attempt-fix-song-select-test-failure
Fix intermittent failure in beatmap carousel tests
2023-01-15 02:35:36 +09:00
ansel
fbb674d8e9 Rename parent comment id field 2023-01-14 20:15:19 +03:00
Bartłomiej Dach
67a3ea2c59
Fix wrong date colour of kudosu history items 2023-01-14 17:50:18 +01:00
Bartłomiej Dach
bfca75395b
Adjust colour of top header container 2023-01-14 17:37:33 +01:00
Bartłomiej Dach
6a9d842660
Adjust user profile header detail appearance 2023-01-14 17:37:31 +01:00
Bartłomiej Dach
de077403e9
Adjust visual appearance of profile value displays 2023-01-14 17:37:28 +01:00
Bartłomiej Dach
f80dddbb5e
Rearrange and adjust header components where simple 2023-01-14 17:17:28 +01:00
Bartłomiej Dach
e39eb089ce
Update colouring of some profile section elements 2023-01-14 17:17:26 +01:00
Bartłomiej Dach
5b1111c6b1
Adjust appearance of user profile sections 2023-01-14 17:17:24 +01:00
Bartłomiej Dach
3f81f173fb
Adjust appearance of section navigation 2023-01-14 17:17:21 +01:00
Bartłomiej Dach
49e08c06a6
Adjust general appearance of user profile overlay 2023-01-14 16:59:51 +01:00
Bartłomiej Dach
3fa81a52b4
Add other profile sections to test scene 2023-01-14 16:59:47 +01:00
Bartłomiej Dach
43c0f8b95f
Merge pull request #22191 from Joehuu/move-overlay-ruleset-selectors
Move overlay ruleset selectors to tab control in line with web
2023-01-14 16:01:55 +01:00
Bartłomiej Dach
5e1ea8b34f
Merge branch 'master' into move-overlay-ruleset-selectors 2023-01-14 15:22:14 +01:00
integer
2831db53f7 fix wrong control flow on hover lost 2023-01-14 14:19:02 +00:00
Bartłomiej Dach
d9045b5fa8
Merge pull request #22198 from frenzibyte/fix-mgcc-test-failure
Fix intermittent failure in GCC seeking test
2023-01-14 13:18:14 +01:00
Dean Herbert
2f2ab445c9
Merge pull request #22182 from stanriders/status-icon
Update status icon design
2023-01-14 21:05:44 +09:00
Salman Ahmed
befb275512 Fix intermittent failure in GCC seeking test 2023-01-14 14:34:22 +03:00
ekrctb
8a55dcec11
Merge pull request #21522 from Mogiiii/18469
Show distance snap for first juice stream object.
2023-01-14 20:25:06 +09:00
ekrctb
e610d19d55
Merge branch 'master' into 18469 2023-01-14 19:53:08 +09:00
Dean Herbert
cfc8fd0aa1
Merge pull request #22188 from Feodor0090/nofs-locale
Localise some notifications
2023-01-14 18:12:54 +09:00
Dean Herbert
a6e7efa62c
Merge pull request #22194 from Feodor0090/more-editor-nrt
Enable nullability for setup, design and timing editor screens
2023-01-14 18:11:46 +09:00
Bartłomiej Dach
b37c3203e5
Merge pull request #22192 from stanriders/fix-group-badges
Fix `GroupBadge` crashing on `null` group colour
2023-01-14 01:17:58 +01:00
StanR
e07c0c7c1f Using 2023-01-14 02:58:18 +03:00
ansel
bb8bcd7248 Move avatar update bind to LoadComplete 2023-01-14 02:50:30 +03:00
ansel
c95d8645f3 Revert "Use existing string"
This reverts commit f950b624ae.
2023-01-14 02:42:04 +03:00
ansel
9e7ecbf4a1 Adapt to changes in base class 2023-01-14 02:41:11 +03:00
ansel
e9995410e8 Merge branch 'master' into comment-editor-3 2023-01-14 02:32:06 +03:00
StanR
cb4f32e7bd Use StatusIcon in UserDropdown 2023-01-14 02:31:27 +03:00
ansel
77e8315ee2 Adjust naming 2023-01-14 02:30:10 +03:00
StanR
e2d6e31314 Using 2023-01-14 02:26:26 +03:00
ansel
f70dedfd17 Enable nullability for design screen 2023-01-14 02:24:48 +03:00
ansel
4b42240fba Enable nullability for setup screen 2023-01-14 02:24:28 +03:00
ansel
78adaa9b03 Enable nullability for timing screen 2023-01-14 02:23:21 +03:00
StanR
660bf748d5 Fix GroupBadge crashing on null group colour 2023-01-14 02:23:08 +03:00
integer
c3c1d77e8e make PlayerSettingsGroup expand on hover 2023-01-13 23:07:59 +00:00
integer
0b5c89d01f revert additions to SessionStatics 2023-01-13 23:07:21 +00:00
Bartłomiej Dach
7782bfb80b
Merge pull request #21448 from Feodor0090/comment-editor-1
Update comment editor component
2023-01-13 23:51:31 +01:00
StanR
85b2154f3a Set border colour to white 2023-01-14 01:12:17 +03:00
Bartłomiej Dach
ab3d39a940
Merge branch 'master' into comment-editor-1 2023-01-13 22:41:41 +01:00
ansel
d67184bd80 Autoformat code 2023-01-14 00:26:44 +03:00
ansel
f950b624ae Use existing string 2023-01-14 00:26:35 +03:00
Bartłomiej Dach
92062e4bb1
Merge pull request #22186 from frenzibyte/fix-score-test-failure
Fix intermittent failure in score submission tests
2023-01-13 22:22:57 +01:00