53917 Commits

This Branch

This Branch

All Branches

• Remove caching of GameplayClockContainer in favour of GameplayClock

  Also fixes `SongProgress` being displayed in skin editor on non-gameplay
  screens, due to `GameplayClock` not marked as a required dependency.

  Salman Ahmed · 2022-07-29 16:45:29 +03:00
  905bbdc8ee
• Expose StartTime from gameplay clock
  Salman Ahmed · 2022-07-29 16:18:05 +03:00
  3f72e76348
• Remove unnecessary LoadTrack call
  Dean Herbert · 2022-07-28 22:19:46 +09:00
  e664690fe2
• Merge branch 'master' into pie-chart-progress
  Dean Herbert · 2022-07-28 22:19:27 +09:00
  3005ff1b9f
• Merge pull request #19441 from peppy/test-working-beatmap-unfuck

  Reduce calls to `LoadTrack` by implicitly running on test/dummy classes

  Dan Balasescu · 2022-07-28 22:05:25 +09:00
  aa03df905f
• Merge pull request #19430 from peppy/realm-collections

  Move beatmap collections to realm

  Dan Balasescu · 2022-07-28 22:05:10 +09:00
  5003eb5629
• Merge branch 'master' into realm-collections
  Dan Balasescu · 2022-07-28 21:00:08 +09:00
  11e0022fad
• Adjust metrics
  Dean Herbert · 2022-07-28 18:50:46 +09:00
  4b140e1f5a
• Apply nullability to DefaultSongProgress and clean up more stuff
  Dean Herbert · 2022-07-28 18:37:17 +09:00
  86c2b7e449
• Move initial show to base implementation and add transition for legacy version
  Dean Herbert · 2022-07-28 18:29:49 +09:00
  ea027eda46
• Remove pointless null check
  Dean Herbert · 2022-07-28 18:28:03 +09:00
  bfa026879c
• Fix DefaultSongProgress graph not resetting if time is in intro
  Dean Herbert · 2022-07-28 18:25:24 +09:00
  d5e5761892
• Tidy up various things everywhere
  Dean Herbert · 2022-07-28 18:25:14 +09:00
  7108553883
• Reduce calls to LoadTrack by implicitly running on test/dummy classes
  Dean Herbert · 2022-07-28 18:11:40 +09:00
  a21aee4e9c
• Remove incorrect TrackLoaded override from TestWorkingBeatmap
  Dean Herbert · 2022-07-28 17:49:17 +09:00
  628a30193f
• Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store

  Remove unused `RulesetStore` from `BeatmapManager` constructor

  Dan Balasescu · 2022-07-28 17:46:12 +09:00
  1da9830145
• Merge pull request #19433 from peppy/beatmap-model-documentation

  Add more comprehensive xmldoc for beatmap model classes

  Dan Balasescu · 2022-07-28 16:40:29 +09:00
  ebe64422d6
• Fix assertion
  Dan Balasescu · 2022-07-28 16:34:31 +09:00
  cd01c5d3ac
• apply code quality fixes
  Nitrous · 2022-07-28 15:30:45 +08:00
  0d36907cad
• set FirstHitTime and LastHitTime once
  Nitrous · 2022-07-28 15:25:12 +08:00
  bca3994d91
• Merge pull request #19432 from peppy/fix-update-test-failures

  Add realm refresh calls to fix intermittent test failures on new update tests

  Dan Balasescu · 2022-07-28 16:19:46 +09:00
  fe6b487d75
• simplify helper methods
  Nitrous · 2022-07-28 15:19:35 +08:00
  70ed347b06
• Remove unused RulesetStore from BeatmapManager constructor
  Dean Herbert · 2022-07-28 16:19:05 +09:00
  2b9d46d803
• apply suggestions

  - refactor `SongProgress`
  - make`UpdateProgress` more readable
  - enable NRT on new classes
  - refactor `TestSceneSongProgress` to use `GameplayClockContainer`

  Nitrous · 2022-07-28 15:15:41 +08:00
  db62d4be3a
• Link to correct model in xmldoc
  Dan Balasescu · 2022-07-28 16:02:19 +09:00
  c1aaf27c54
• Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting
  Dean Herbert · 2022-07-28 15:51:18 +09:00
  525e4a2019
• Fix managed object reused between test runs
  Dan Balasescu · 2022-07-28 15:45:33 +09:00
  6bf293e130
• Add more comprehensive xmldoc for beatmap model classes
  Dean Herbert · 2022-07-28 15:41:28 +09:00
  452d82f292
• Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset

  Remove nullable disable annotation in mods for taiko ruleset.

  Salman Ahmed · 2022-07-28 09:32:35 +03:00
  ce48984bda
• Update test to account for sort order
  Dean Herbert · 2022-07-28 15:20:25 +09:00
  8ac886a247
• Add realm refresh calls to fix intermittent test failures on new update tests
  Dean Herbert · 2022-07-28 15:15:41 +09:00
  485d140a21
• Merge branch 'master' into remove-nullable-disable-in-the-mods-for-taiko-ruleset
  Salman Ahmed · 2022-07-28 09:01:50 +03:00
  1f13d89205
• Merge pull request #19418 from andy840119/remove-nullable-disable-in-the-mods-for-mania-ruleset

  Remove nullable disable annotation in mods for mania ruleset.

  Salman Ahmed · 2022-07-28 08:57:12 +03:00
  61bdcab651
• Make NotificationOverlay dependency optional in CollectionSettings
  Dean Herbert · 2022-07-28 14:35:27 +09:00
  ca68574473
• Merge branch 'master' into remove-nullable-disable-in-the-mods-for-mania-ruleset
  Salman Ahmed · 2022-07-28 08:21:23 +03:00
  c74ffea236
• Force alphabetical ordering for now
  Dean Herbert · 2022-07-28 14:07:42 +09:00
  392cb352cc
• Add missing realm subscription cleanup
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  da06467891
• Tidy up naming of collection dropdowns
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  ad482b8afc
• Add note about hash storage
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  226eefcc5c
• Add migration of existing collections database
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  1669208a54
• Fix ManageCollectionsDialog and remove weird placeholder logic
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  34a2d1a6e1
• Simplify CollectionFilterDropdown filter flow weirdness
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  67c7f324ee
• Merge pull request #19410 from novialriptide/add-notif-externalbutton

  Add Toast notification to ExternalLinkButton's context menu

  Dean Herbert · 2022-07-28 13:43:14 +09:00
  4332b409be
• Split out tests and fix variable conflict
  Dean Herbert · 2022-07-28 13:24:14 +09:00
  0913cf013c
• Merge branch 'master' into add-notif-externalbutton
  Dean Herbert · 2022-07-28 12:17:36 +09:00
  aa65b73f19
• Add proper test coverage
  Dean Herbert · 2022-07-28 12:16:21 +09:00
  8da499fb0f
• Reorder file content to match expectations
  Dean Herbert · 2022-07-28 12:13:47 +09:00
  f44a4c8652
• Apply nullability
  Dean Herbert · 2022-07-28 12:12:46 +09:00
  f01c397220
• Adjust to reviews
  Andrew Hong · 2022-07-27 21:52:38 -04:00
  f097064eea
• "Copied URL" -> "URL copied"
  Andrew Hong · 2022-07-27 21:52:28 -04:00
  ac39d3a142