Dean Herbert
85e5d74a16
Apply proposed changes
2023-12-20 12:42:06 +09:00
Dan Balasescu
ff6a02be82
Merge pull request #25916 from OliBomby/fix-zero-length
...
Fix near zero-length sliders being placeable and crashing the game
2023-12-20 12:38:45 +09:00
rushiiMachine
1b004dbebc
Allow Relax to fail and remove failable mod exclusions
...
Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion
ref: https://github.com/ppy/osu/discussions/13229
2023-12-19 12:33:00 -08:00
OliBomby
c167f10ad5
fix crash from dragging near zero-length repeating object in timeline
2023-12-19 21:20:45 +01:00
OliBomby
ec578e1d9f
fix near-zero length sliders n stuff being placeable
2023-12-19 21:20:21 +01:00
Bartłomiej Dach
1ebb6262fd
Merge pull request #25895 from peppy/fix-beatmap-statsitics-reprocessing
...
Fix some beatmaps being reprocessed each startup
2023-12-19 18:05:40 +01:00
Bartłomiej Dach
322cfaae1d
Merge branch 'master' into fix-standardised-score-conversion
2023-12-19 17:41:38 +01:00
Bartłomiej Dach
3f41c20ac6
Use safer fix for now
2023-12-19 17:25:15 +01:00
Bartłomiej Dach
64b0534fb8
Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust
...
Fix mod search textbox having focus while settings are visible
2023-12-19 15:44:17 +01:00
Bartłomiej Dach
b86997318b
Merge pull request #25838 from peppy/fix-song-select-realm-refresh-performance
...
Fix song select realm refresh performance
2023-12-19 15:04:20 +01:00
Bartłomiej Dach
d793d1cea1
Add test coverage of desired input handling behaviour
2023-12-19 14:52:16 +01:00
Bartłomiej Dach
e306cc35ba
Merge branch 'master' into fix-song-select-realm-refresh-performance
2023-12-19 14:14:46 +01:00
Dean Herbert
bbfdd6892d
Allow choosing "Edit" from any beatmap carousel item
2023-12-19 19:58:49 +09:00
Dean Herbert
c556475c2c
Revert to using a more manual approach to holding focus
2023-12-19 19:46:30 +09:00
Dean Herbert
502e3edac3
Add missing invalidation call
2023-12-19 19:39:48 +09:00
Dean Herbert
2c5ca9c1c8
Change default song select tab display to local leaderboard
2023-12-19 19:31:05 +09:00
Dean Herbert
3b848e8503
Tidy up visual look
2023-12-19 19:28:02 +09:00
Dean Herbert
07bb0805e9
Move advanced stats to a more permanent location on song select
2023-12-19 19:10:43 +09:00
Dean Herbert
0a64d631e2
Add support for dual-column advanced stats
2023-12-19 19:09:47 +09:00
Bartłomiej Dach
1161e0ad0e
Merge pull request #25893 from smoogipoo/fix-early-slide-sample
...
Fix sliding sample playing before Slider's start time
2023-12-19 10:37:41 +01:00
Bartłomiej Dach
c078d63e90
Merge pull request #25888 from peppy/fix-sort-failures
...
Fix incorrect ordering of items at song select when certain sort modes are used
2023-12-19 10:37:20 +01:00
Dean Herbert
372f930f8b
Refactor usage of object counts for mania key count lookup to be a bit safer
...
Protects against non-initialised values and also div-by-zero.
2023-12-19 18:28:04 +09:00
Dean Herbert
f09c6b8c1b
Change default values of new object counts to -1
to identify non-processed values
2023-12-19 18:20:02 +09:00
Dean Herbert
8f5d21dc70
Actually fix realm selection retention regression
2023-12-19 18:10:55 +09:00
Dean Herbert
7e9c1b2acb
Use sender
's realm (because we can)
2023-12-19 17:27:52 +09:00
Dan Balasescu
fe5e071e70
Fix sliding sample playing before Slider's start time
2023-12-19 17:01:52 +09:00
Bartłomiej Dach
7c05d66bd7
Add more detail to exception
2023-12-19 08:57:18 +01:00
Dan Balasescu
011bd61e7d
Give sliders in test scene a sample
2023-12-19 16:47:49 +09:00
Bartłomiej Dach
ddb67c87a8
Roll back incorrect change in ShouldMigrateToNewStandardised()
2023-12-19 08:13:02 +01:00
Dean Herbert
44efa2c540
Fix incorrect ordering of items at song select when certain sort modes are used
2023-12-19 15:09:03 +09:00
Dan Balasescu
30957f847c
Rename class/file (this is not a test scene)
2023-12-19 14:27:29 +09:00
Dan Balasescu
f2edb3ea54
Add test
2023-12-19 14:01:08 +09:00
Dan Balasescu
35c0eaee1c
Make taiko OKs worth 150 points
2023-12-19 14:01:05 +09:00
Dan Balasescu
c1b55c7fac
Add ScoreProcessor methods to override numeric result
2023-12-19 13:50:31 +09:00
Dean Herbert
469a659938
Fix arrow pointing to wrong place
2023-12-19 13:35:02 +09:00
Dean Herbert
ee8a5d5a30
Update bug-issue.yml with new workflow for exporting logs
2023-12-19 13:33:45 +09:00
Dan Balasescu
b6ed792a41
Merge pull request #25871 from Susko3/fix-logfile-notification
...
Fix opening log files from notification not presenting the correct file
2023-12-19 10:21:18 +09:00
Bartłomiej Dach
9c8df4e6d1
Run score conversion for previously-imported scores
2023-12-18 22:27:51 +01:00
Bartłomiej Dach
017003deea
Fix osu! standardised score conversion sometimes exceeding bounds
...
Co-authored-by: Zyf <zyfarok@gmail.com>
Closes https://github.com/ppy/osu/issues/25860
Users reported that some stable scores would convert to large negative
total scores in lazer after the introduction of combo exponent. Those
large negative total scores were actually mangled NaNs.
The root cause of this was the following calculation going below zero
unexpectedly:
8e8d9b2cd9/osu.Game/Database/StandardisedScoreMigrationTools.cs (L323)
which then propagates negative numbers onward until
8e8d9b2cd9/osu.Game/Database/StandardisedScoreMigrationTools.cs (L337)
which yields a NaN due to attempting to take the square root of a
negative number.
To fix, clamp `comboPortionInScoreV1` to sane limits: to
`comboPortionFromLongestComboInScoreV1` from below, and to
`maximumAchievableComboPortionInScoreV1` from above. This is a less
direct fix than perhaps imagined, but it seems like a better one as it
will also affect the calculation of both the lower and the upper
estimate of the score.
2023-12-18 22:05:19 +01:00
Susko3
cc800a18b2
Fix opening log files from notification not presenting the correct file
2023-12-18 21:11:00 +01:00
Bartłomiej Dach
8e8d9b2cd9
Merge pull request #25832 from peppy/more-background-processing-progress-notifications
...
Show more comprehensive background processing progress notifications
2023-12-18 20:05:47 +01:00
Bartłomiej Dach
b8bcf7a097
Merge pull request #25856 from peppy/fix-keybaord-adjust-nc-dc
...
Fix keyboard precision of nightcore/daycore adjustments being incorrect
2023-12-18 19:54:17 +01:00
Dean Herbert
9594ae7802
Update framework
2023-12-19 03:22:22 +09:00
Bartłomiej Dach
bf668174ec
Use nunit constraints in test for transparency
2023-12-18 19:02:23 +01:00
Dean Herbert
41485c19cf
Add realm refresh steps in an attempt to stabilise failing test
...
I think this is required because there is a higher chance of batched
updates with the new structure (and less calls to `BeatmapSetsChanged`
which causes re-selection).
2023-12-19 02:08:29 +09:00
Dean Herbert
51f4c7254c
Fix mod search textbox having focus while settings are visible
...
Stopped arrow key adjust on slider bars from working.
Also just felt wrong that you could type into an off-screen textbox.
2023-12-19 01:32:34 +09:00
Dean Herbert
374425ea75
Fix keyboard precision of nightcore/daycore adjustments being incorrect
...
Closes https://github.com/ppy/osu/issues/25854 .
2023-12-19 01:07:33 +09:00
Dean Herbert
c466775f78
Merge pull request #25821 from bdach/fix-collection-dropdown-crash
...
Fix collections dropdown crashing during storage migration
2023-12-19 01:01:23 +09:00
Dean Herbert
c88c25e77f
Merge pull request #25848 from 65-7a/dropdown-search-padding
...
Fix padding on dropdown search bar
2023-12-19 00:36:14 +09:00
Dean Herbert
da658bbf25
Merge pull request #25839 from bdach/collection-name-clashes-crashes
...
Fix crash when creating collections named "All beatmaps" or "Manage collections..."
2023-12-19 00:32:18 +09:00