Dean Herbert
8dc616738c
Merge pull request #31844 from bdach/fix-mp-players-appearing-as-spectators
...
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 21:49:06 +09:00
Dean Herbert
310700b4e7
Space out comment
2025-02-10 21:48:27 +09:00
Dean Herbert
6ff1a13b67
Merge pull request #31845 from frenzibyte/ios-threading-woes
...
Fix incorrect thread access in recent iOS orientation changes
2025-02-10 20:45:19 +09:00
Salman Alshamrani
4b8890ef0c
Fix incorrect thread access in recent iOS orientation changes
2025-02-10 05:55:21 -05:00
Bartłomiej Dach
ad642b8425
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 11:17:17 +01:00
Bartłomiej Dach
3ba56e009e
Privatise a few members
2025-02-10 10:41:10 +01:00
Bartłomiej Dach
3294450dc9
Merge pull request #31841 from peppy/add-editor-percent-progress
...
Add percent progress display to editor footer
2025-02-10 09:54:05 +01:00
Bartłomiej Dach
0e1b5802a9
Merge pull request #31825 from peppy/fix-slider-ball-rotation-rewind
...
Fix slider ball rotation not being updated when rewinding to a slider
2025-02-10 09:42:19 +01:00
Dean Herbert
274b422139
Add percent progress display to editor footer
2025-02-10 14:51:48 +09:00
Dean Herbert
43822458b3
Merge branch 'master' into fix-slider-ball-rotation-rewind
2025-02-09 22:37:50 +09:00
Dean Herbert
cf4c9e7f9e
Changed the Currently Playing Text when no track is selected ( #31835 )
...
Changed the currently playing text for when the track isnt selected/loaded
2025-02-09 21:39:58 +09:00
SebastianPeP
bcd4fcbeed
Changed the Currently Playing Text when no track is selected
...
Changed the currently playing text for when the track isnt selected/loaded
2025-02-09 01:29:22 -03:00
Dean Herbert
5ace8e911b
Fix failing test
2025-02-07 21:46:00 +09:00
Dean Herbert
fab5cfd275
Fix slider ball rotation not being updated when rewinding to a slider
2025-02-07 18:57:26 +09:00
Bartłomiej Dach
a068d88b84
Merge pull request #31823 from peppy/carousel-v2-optimisation-pass
...
Refactor grouping to be much more efficient
2025-02-07 10:44:53 +01:00
Bartłomiej Dach
ae179c8feb
Merge pull request #31824 from peppy/carousel-v2-group-click-transfer-keyboard
...
Always transfer keyboard selection on activation
2025-02-07 10:12:10 +01:00
Dean Herbert
cf4b501214
Merge pull request #31804 from bdach/bss/api-setup
...
Add API request & response structures for beatmap submission
2025-02-07 17:43:38 +09:00
Bartłomiej Dach
9af5ebbca9
Merge pull request #31822 from peppy/dont-submit-zero-scores
...
Don't attempt to submit zero scores
2025-02-07 09:42:38 +01:00
Dean Herbert
177ca4fb7c
Merge pull request #31799 from frenzibyte/carousel-v2-spacing
...
Support variable spacing between beatmap carousel panels
2025-02-07 17:41:28 +09:00
Dean Herbert
29b0b62ffa
Rename variables to something more sane
2025-02-07 17:39:38 +09:00
Dean Herbert
3da615481e
Change switch to simple conditional for now
2025-02-07 17:38:24 +09:00
Dean Herbert
41c8f64806
Simplify naming of endpoints
2025-02-07 17:33:32 +09:00
Dean Herbert
cef9d2eac5
Reduce number of beatmaps added in selection test
...
This is because with the new keyboard selection logic, adding too many
can cause the re-added selection to be off-screen in the headless test
setup.
2025-02-07 17:02:53 +09:00
Dean Herbert
c935c3154b
Always transfer keyboard selection on activation
2025-02-07 17:02:53 +09:00
Dean Herbert
9d979dc3f4
Refactor grouping to be much more efficient
2025-02-07 16:35:20 +09:00
Bartłomiej Dach
a49b1b61b4
Add test coverage for scores with zero total not submitting
2025-02-07 08:21:34 +01:00
Dean Herbert
50d880e2ae
Fix unnecessary BeatmapSet.Metadata lookups
2025-02-07 16:09:36 +09:00
Dean Herbert
75ef6f6a0e
Use random generation in carousel stress test
2025-02-07 16:09:35 +09:00
Dean Herbert
0235928fda
Merge pull request #31815 from smoogipoo/score-panel-ruleset
...
Add ruleset icon to expanded score panel
2025-02-07 16:04:24 +09:00
Dean Herbert
4d1167fdcc
Don't attempt to submit zero scores
2025-02-07 15:36:59 +09:00
Dean Herbert
aa329f397e
Remove stray [Solo]s
2025-02-07 15:30:31 +09:00
Dean Herbert
d505c529cd
Adjust tests in line with new expectations
2025-02-07 15:27:28 +09:00
Dean Herbert
d73f275143
Don't inflate set / group panels for simplicity
2025-02-07 15:15:59 +09:00
Dean Herbert
1cf375e329
Merge branch 'master' into carousel-v2-spacing
2025-02-07 14:34:59 +09:00
Dean Herbert
975c35f5ac
Also add difficulty icon to contracted panel
2025-02-07 14:27:37 +09:00
Dean Herbert
25846b2327
Adjust results screen designs and tests slightly
2025-02-07 14:21:43 +09:00
Bartłomiej Dach
91bc23e39e
Merge pull request #31801 from peppy/carousel-v2-artist-grouping
...
Add support for grouping by artist to beatmap carousel v2
2025-02-06 13:13:35 +01:00
Dan Balasescu
736fe78a02
Merge pull request #31817 from peppy/carousel-v2-invalidation
...
Add invalidation on draw size change in beatmap carousel v2
2025-02-06 19:54:49 +09:00
Dean Herbert
cb42ef95c5
Add invalidation on draw size change in beatmap carousel v2
...
Matching old implementation.
2025-02-06 17:48:42 +09:00
Dean Herbert
33035f0206
Merge branch 'master' into carousel-v2-spacing
2025-02-06 17:30:49 +09:00
Dean Herbert
f4bb3bc422
Merge pull request #31802 from frenzibyte/carousel-v2-depth-ordering
...
Allow ordering certain carousel panels behind others
2025-02-06 17:29:56 +09:00
Dean Herbert
bff686f012
Avoid double iteration when updating group states
2025-02-06 17:22:50 +09:00
Dean Herbert
024fbde0fd
Refactor selection and activation handling
...
I had a bit of a struggle getting header traversal logic to work well.
The constraints I had in place were a bit weird:
- Group panels should toggle or potentially fall into the prev/next
group
- Set panels should just traverse around them
The current method of using `CheckValidForGroupSelection` return type
for traversal did not mesh with the above two cases. Just trust me on
this one since it's quite hard to explain in words.
After some re-thinking, I've gone with a simpler approach with one
important change to UX: Now when group traversing with a beatmap set
header currently keyboard focused, the first operation will be to reset
keyboard selection to the selected beatmap, rather than traverse.
I find this non-offensive – at most it means a user will need to press
their group traversal key one extra time.
I've also changed group headers to always toggle expansion when doing
group traversal with them selected.
To make all this work, the meaning of `Activation` has changed somewhat.
It is now the primary path for carousel implementations to change
selection of an item. It is what the `Drawable` panels call when they
are clicked.
Selection changes are not performed implicitly by `Carousel` – an
implementation should decide when it actually wants to change the
selection, usually in `HandleItemActivated`.
Having less things mutating `CurrentSelection` is better in my eyes, as
we see this variable as only being mutated internally when utmost
required (ie the user has requested the change). With this change,
`CurrentSelection` can no longer become of a non-`T` type (in the
beatmap carousel implementation at least).
This might pave a path forward for making `CurrentSelection` typed, but
that comes with a few other concerns so I'll look at that as a
follow-up.
2025-02-06 17:02:44 +09:00
Dean Herbert
4026ca84f8
Move selected retrieval functions to base class
2025-02-06 16:48:17 +09:00
Dean Herbert
a25e1f4f9b
Add test coverage of artist grouping
2025-02-06 16:48:17 +09:00
Bartłomiej Dach
5e74d82fc1
Suppress inspections for now
2025-02-06 08:32:08 +01:00
Bartłomiej Dach
5bcd79956b
Merge branch 'master' into bss/api-setup
2025-02-06 08:30:01 +01:00
Dan Balasescu
5b8b9589d8
Add ruleset icon to expanded score panel
2025-02-06 15:25:38 +09:00
Dean Herbert
bf377e081a
Reorganise tests to make more logical when manually testing
2025-02-06 15:09:41 +09:00
Dean Herbert
342a66b9e2
Fix keyboard traversal on a collapsed group not working as intended
2025-02-06 14:49:58 +09:00
