73151 Commits

This Branch

This Branch

All Branches

• Fix gameplay leaderboard not always being expanded in gameplay leaderboard

  I'd have preferred a `get; init;` property but tests were also attached
  at the hip to the public bindable. Without some extra composition this
  is the best that I can do.

  Bartłomiej Dach · 2025-05-07 12:09:26 +02:00
  8cc2af4060
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Dean Herbert · 2025-05-07 18:10:35 +09:00
  efc3e17630
• Fix return type git somehow didn't notice
  Dean Herbert · 2025-05-07 17:46:12 +09:00
  ecc0c94521
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Merge pull request #33046 from frenzibyte/carousel-filtering

  Add filtering support in carousel v2

  Dean Herbert · 2025-05-07 17:42:33 +09:00
  d286a27da2
• Merge pull request #32971 from bdach/open-playlist-link

  Add support for opening multiplayer / playlist room links directly

  Dean Herbert · 2025-05-07 17:31:41 +09:00
  66f77701a9
• Merge pull request #33049 from peppy/carousel-manifest-filters

  Ensure carousel filters are manifested to lists at each step

  Bartłomiej Dach · 2025-05-07 10:20:25 +02:00
  cf9acc97a3
• Change ICarouselFilter interface return type rather than manual ToList

  I was hung up on keeping `IEnumerable` but there doesn't seem to be a
  good reason to do so.

  Dean Herbert · 2025-05-07 16:40:23 +09:00
  ebd6776898
• Allow falling back to opening multiplayer room history in browser if it's ended
  Bartłomiej Dach · 2025-05-07 09:40:10 +02:00
  9b3812210c
• Merge branch 'master' into open-playlist-link
  Bartłomiej Dach · 2025-05-07 09:31:58 +02:00
  810346ab34
• Ensure BeatmapItemsCount is stable during filter operations
  Dean Herbert · 2025-05-07 16:29:11 +09:00
  7789f4dbb0
• Add SortAndGroupBy method to simplify usages
  Salman Alshamrani · 2025-05-07 10:28:09 +03:00
  8775731c24
• Expose matched beatmaps count from BeatmapCarousel
  Salman Alshamrani · 2025-05-07 10:22:20 +03:00
  1c6e998c95
• Merge pull request #33050 from bdach/ignore-weird-test

  Ignore "image proxying" test scene

  Dean Herbert · 2025-05-07 16:21:28 +09:00
  370f26f75f
• Ignore "image proxying" test scene

  Because it just failed thrice
  (https://github.com/ppy/osu/runs/41775675413#r0) and to me it seems like
  a profoundly bad idea.
  
  I considered having it retry like the framework precedent of this
  (https://github.com/ppy/osu-framework/blob/dd2b701ed84c687ff71f5c50338d3b325159ee45/osu.Framework.Tests/IO/TestWebRequest.cs#L69)
  before I noticed that it was also hitting hardcoded production endpoints
  at which point I decided it was just too weird to live.

  Bartłomiej Dach · 2025-05-07 09:15:15 +02:00
  1f2fba6e23
• Merge pull request #33047 from peppy/song-select-transition-update

  Adjust song select beatmap background transition to better support transparent backgrounds

  Bartłomiej Dach · 2025-05-07 09:08:53 +02:00
  9fb4ca7a95
• Adjust matching filter's code to conform to other filter implementations
  Dean Herbert · 2025-05-07 16:01:30 +09:00
  5d04cc045d
• Ensure carousel filters are manifested to lists at each step

  The original `IEnumerable` flow prioritised slight performance gains,
  but a filter's implementation could actually make this detrimental to
  overall performance.
  
  I noticed in passing that there were already potentially multiple
  enumerations, via `updateYPositions` and the final `ToList` call. Rather
  than faffing around, let's keep things simple and require lists.
  
  In benchmarking, the difference is (currently) negiligible. Slight
  improvement if anything.

  Dean Herbert · 2025-05-07 15:55:20 +09:00
  cc0c21a216
• Merge pull request #33045 from peppy/cache-supporter-status

  Fix startup "welcome" sound sometimes not loading from skin for supporters

  Bartłomiej Dach · 2025-05-07 08:49:11 +02:00
  79c4426725
• Merge pull request #33044 from peppy/argon-slider-body-transparency

  Add minimal slider body transparency to "Argon" skins

  Bartłomiej Dach · 2025-05-07 08:47:21 +02:00
  9389e63d49
• Improve count check test assertions
  Salman Alshamrani · 2025-05-07 09:09:40 +03:00
  725187245a
• Add test coverage for filtering
  Salman Alshamrani · 2025-05-07 09:09:40 +03:00
  90abd11ca5
• Add carousel filter for matching items against criteria (i.e. actually filter)
  Salman Alshamrani · 2025-05-07 09:09:40 +03:00
  a3aa4c7ba5
• Adjust song select beatmap background transition to better support transparent backgrounds

  The new background now briefly fades in. The reason we didn't do this to
  date is that there could be a perceived decrease in brightness as the old
  and new background transition through opacity.
  
  But a quick fade in, it doesn't seem to cause any visual artifacting.
  
  I've also added a scale effect because it felt quite nice. Willing to
  pull that if anyone has an issue with it, but it's a step in the
  direction of "adding more motion to song select", which is still an area
  I see lacking greatly – even compared to stable.

  Dean Herbert · 2025-05-07 14:59:29 +09:00
  34119aab8e
• Cache local user supporter status between game executions

  Fixes startup sounds from potentially being fetched from the wrong
  source if API connection establishment takes longer than the intro
  screen takes to load.
  
  Closes https://github.com/ppy/osu/issues/22492.

  Dean Herbert · 2025-05-07 14:02:09 +09:00
  84f44eb3ad
• Fix update handling test selecting wrong beatmap

  Order has changed after carousel was made to sort by title.

  Salman Alshamrani · 2025-05-07 07:58:40 +03:00
  af874ca730
• Add minimal slider body transparency to "Argon" skins

  Addresses concerns in https://github.com/ppy/osu/discussions/24226.
  
  I basically adjusted opacity down until it started to visually detract
  from the skin. The pro level is lower than I'd want to see, but feels
  like a midpoint that some users may find usable.
  
  This is a band-aid fix until we can get proper support for settings like
  this into the skin editor.

  Dean Herbert · 2025-05-07 13:23:18 +09:00
  981383b52b
• Support mutating existing active filter criteria in carousel tests

  Allows maintaining sorting mode while modifying other filter criterias,
  thus simplifying some tests.

  Salman Alshamrani · 2025-05-05 09:46:42 +03:00
  540cfc92da
• WaitForSorting -> WaitForFiltering
  Salman Alshamrani · 2025-05-05 09:46:06 +03:00
  cc46cbf780
• Merge pull request #33016 from frenzibyte/old-song-select-fix-test
  Dean Herbert · 2025-05-03 14:52:32 +09:00
  6fe29addde
• Fix test in old song select not working on Apple platforms
  Salman Alshamrani · 2025-05-03 05:38:00 +03:00
  109b29c1da
• Merge pull request #32986 from frenzibyte/mania-tap-between-gaps

  Fix mania columns not handling touch input in gaps

  Dean Herbert · 2025-05-02 20:29:50 +09:00
  a81c24bcd4
• Merge pull request #33002 from frenzibyte/song-select-async-beatmap-load

  Fix song select title wedge not accessing beatmap asynchronously

  Dean Herbert · 2025-05-02 19:57:49 +09:00
  3629f72bf0
• Add note about multiple usage of GetPlayableBeatmap
  Dean Herbert · 2025-05-02 19:55:45 +09:00
  e46434731e
• Merge pull request #32998 from frenzibyte/mobile-limit-ui-scale

  Limit maximum UI scale to 1.1x on mobile platforms

  Dean Herbert · 2025-05-02 01:57:14 +09:00
  97962d93d2
• Limit maximum UI scale to 1.1x on mobile platforms
  Salman Alshamrani · 2025-05-01 23:48:55 +09:00
  acb9eba475
• Extract beatmap variable and comment to better show why async is required
  Dean Herbert · 2025-05-01 17:02:18 +09:00
  512460e9f7
• Fix count statistics causing direct beatmap load
  Salman Alshamrani · 2025-05-01 09:24:28 +03:00
  e8161778b9
• Fix length & BPM statistics computation causing direct beatmap load
  Salman Alshamrani · 2025-05-01 09:24:28 +03:00
  4f79dcb411
• Add test stressing title wedge performance with a heavy beatmap
  Salman Alshamrani · 2025-05-01 09:24:28 +03:00
  b84105d93b
• Merge pull request #33000 from frenzibyte/fix-beatmap-title-test-scene

  Fix beatmap title wedge sheared incorrectly in test scene

  Dean Herbert · 2025-05-01 15:16:33 +09:00
  d666de7b59
• Fix beatmap title wedge sheared incorrectly in test scene
  Salman Alshamrani · 2025-05-01 08:34:09 +03:00
  e744102b1c
• Merge pull request #32854 from frenzibyte/song-select-v2-integration

  Bring all new song select components together

  Dean Herbert · 2025-05-01 13:06:37 +09:00
  bf43803824
• Clarify purpose of helper lookup entries in osu!mania skinning
  Salman Alshamrani · 2025-05-01 06:30:32 +03:00
  3151fe7ef1
• Merge pull request #32990 from Marvefect/Marvefect-patch-1

  Change tooltip text to better cover mod setting scenarios

  Dean Herbert · 2025-04-30 22:06:44 +09:00
  2242331d8e
• Update AdjustedAttributesTooltip.cs

  Mods don't necessarily have to change speed, to change beatmap attributes. Also, speed mods don't affect beatmap attributes in mania, making the text misleading.

  Marvefect · 2025-04-30 13:01:23 +03:00
  3f17d7227a
• Fix sheared components getting masked away due to negative margins
  Dean Herbert · 2025-04-30 18:33:49 +09:00
  c2a7687a66
• Integrate all subcomponents with the main screen
  Salman Alshamrani · 2025-04-30 18:31:40 +09:00
  dc4b0f8df1
• Add beatmap details/rankings area drawable

  This intentionally removes shear specification from root level of
  `BeatmapTitleWedge` since shearing is moved one level higher (see fill
  flow containing `BeatmapTitleWedge` in `SongSelect`).

  Salman Alshamrani · 2025-04-30 18:31:39 +09:00
  437b1fa70f
• Merge pull request #32852 from frenzibyte/song-select-v2-filter-control

  Add song select filter control

  Dean Herbert · 2025-04-30 18:31:30 +09:00
  4b42980d5c