Nitrous
0d36907cad
apply code quality fixes
2022-07-28 15:30:45 +08:00
Nitrous
bca3994d91
set FirstHitTime and LastHitTime once
2022-07-28 15:25:12 +08:00
Dan Balasescu
fe6b487d75
Merge pull request #19432 from peppy/fix-update-test-failures
...
Add realm refresh calls to fix intermittent test failures on new update tests
2022-07-28 16:19:46 +09:00
Nitrous
70ed347b06
simplify helper methods
2022-07-28 15:19:35 +08:00
Dean Herbert
2b9d46d803
Remove unused RulesetStore from BeatmapManager constructor
2022-07-28 16:19:05 +09:00
Nitrous
db62d4be3a
apply suggestions
...
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
Dan Balasescu
c1aaf27c54
Link to correct model in xmldoc
2022-07-28 16:02:19 +09:00
Dean Herbert
525e4a2019
Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting
2022-07-28 15:51:18 +09:00
Dan Balasescu
6bf293e130
Fix managed object reused between test runs
2022-07-28 15:45:33 +09:00
Dean Herbert
452d82f292
Add more comprehensive xmldoc for beatmap model classes
2022-07-28 15:41:28 +09:00
Salman Ahmed
ce48984bda
Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset
...
Remove nullable disable annotation in mods for taiko ruleset.
2022-07-28 09:32:35 +03:00
Dean Herbert
8ac886a247
Update test to account for sort order
2022-07-28 15:20:25 +09:00
Dean Herbert
67c44552cb
Add realm Refresh calls to ensure tests are stable
2022-07-28 15:18:04 +09:00
Dean Herbert
485d140a21
Add realm refresh calls to fix intermittent test failures on new update tests
2022-07-28 15:15:41 +09:00
Dean Herbert
070f56c30c
Add collection transfer logic to beatmap import-as-update flow
2022-07-28 15:03:23 +09:00
Dean Herbert
2209afd0e8
Mark Live methods as InstantHandleAttribute
2022-07-28 15:03:08 +09:00
Dean Herbert
2ae5a34c0e
Add test coverage of beatmap updates transferring collection hashes
2022-07-28 15:02:58 +09:00
Salman Ahmed
1f13d89205
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-taiko-ruleset
2022-07-28 09:01:50 +03:00
Salman Ahmed
61bdcab651
Merge pull request #19418 from andy840119/remove-nullable-disable-in-the-mods-for-mania-ruleset
...
Remove nullable disable annotation in mods for mania ruleset.
2022-07-28 08:57:12 +03:00
Dean Herbert
ca68574473
Make NotificationOverlay dependency optional in CollectionSettings
2022-07-28 14:35:27 +09:00
Salman Ahmed
c74ffea236
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-mania-ruleset
2022-07-28 08:21:23 +03:00
Dean Herbert
392cb352cc
Force alphabetical ordering for now
2022-07-28 14:07:42 +09:00
Salman Ahmed
72961ec336
Flip method parameters to make sense
...
See 537f64c75e (r931785228)
2022-07-28 08:04:55 +03:00
Dean Herbert
da06467891
Add missing realm subscription cleanup
2022-07-28 13:57:21 +09:00
Dean Herbert
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
Dean Herbert
226eefcc5c
Add note about hash storage
2022-07-28 13:57:21 +09:00
Dean Herbert
1669208a54
Add migration of existing collections database
2022-07-28 13:57:21 +09:00
Dean Herbert
34a2d1a6e1
Fix ManageCollectionsDialog and remove weird placeholder logic
2022-07-28 13:57:21 +09:00
Dean Herbert
67c7f324ee
Simplify CollectionFilterDropdown filter flow weirdness
2022-07-28 13:57:21 +09:00
Dean Herbert
4332b409be
Merge pull request #19410 from novialriptide/add-notif-externalbutton
...
Add Toast notification to ExternalLinkButton's context menu
2022-07-28 13:43:14 +09:00
Dean Herbert
0913cf013c
Split out tests and fix variable conflict
2022-07-28 13:24:14 +09:00
Dean Herbert
aa65b73f19
Merge branch 'master' into add-notif-externalbutton
2022-07-28 12:17:36 +09:00
Dean Herbert
8da499fb0f
Add proper test coverage
2022-07-28 12:16:21 +09:00
Dean Herbert
f44a4c8652
Reorder file content to match expectations
2022-07-28 12:13:47 +09:00
Dean Herbert
f01c397220
Apply nullability
2022-07-28 12:12:46 +09:00
Andrew Hong
f097064eea
Adjust to reviews
2022-07-27 21:52:38 -04:00
Andrew Hong
ac39d3a142
"Copied URL" -> "URL copied"
2022-07-27 21:52:28 -04:00
Dean Herbert
706b6e01ff
Merge pull request #19426 from LeNitrous/move-legacy-combo-counter
...
Move `LegacyComboCounter` to `osu.Game.Skinning`
2022-07-28 10:43:42 +09:00
Nitrous
9088caa377
move LegacyComboCounter to osu.Game.Skinning
2022-07-28 08:36:26 +08:00
Nitrous
45c11f2b7b
account for gameplay start time
2022-07-28 08:01:38 +08:00
andy840119
3510c16566
Remove nullable disable annotation in the Taiko test case.
2022-07-27 22:31:48 +08:00
為什麼
860e9d42ff
Mark the property as nullable and add some assert check.
2022-07-27 22:31:48 +08:00
為什麼
d766052be4
Remove nullable disable annotation in the Taiko ruleset.
2022-07-27 22:28:13 +08:00
andy840119
9f79e80d8b
Remove nullable disable annotation in the Mania test case.
2022-07-27 22:24:14 +08:00
為什麼
4120c20968
Remove the nullable disable annotation in the Mania ruleset.
2022-07-27 22:24:02 +08:00
andy840119
537f64c75e
Make original hit objects and random properties as local variable.
2022-07-27 22:15:41 +08:00
Dean Herbert
804bb33aed
Hook up remaining data flows
2022-07-27 19:35:09 +09:00
Dean Herbert
438067a18b
Convert realm data propagation to more correctly use Live<T>
...
wip
2022-07-27 19:35:09 +09:00
Dean Herbert
41393616d8
Replace BeatmapCollection with RealmBeatmapCollection
2022-07-27 19:35:09 +09:00
Dean Herbert
9c543fef48
Remove CollectionManager
2022-07-27 18:45:33 +09:00
