Dean Herbert
1b0aadcc6f
Merge branch 'master' into transformers-per-skin
2021-06-22 16:03:15 +09:00
Dan Balasescu
d8b23bb841
Merge pull request #13611 from ekrctb/remove-unused-argument
...
Remove unused constructor argument from `CatchPlayfield`
2021-06-22 15:54:31 +09:00
Henry Lin
fc224c53f4
Remove extra usings
2021-06-22 14:49:37 +08:00
Henry Lin
3745101f32
Extract seed setting control to IHasSeed
2021-06-22 14:43:41 +08:00
ekrctb
b54e82eb99
Remove unused argument from CatchPlayfield
2021-06-22 15:23:50 +09:00
Dean Herbert
e9339d6100
Move some inline comments on const
s to xmldoc instead
2021-06-22 15:16:19 +09:00
JimmyC7834
0d17fb4259
fixed code
2021-06-22 13:53:21 +08:00
Gagah Pangeran Rosfatiputra
5c3129f1a2
add font size in HeadingTextFlowContainer
2021-06-22 12:24:56 +07:00
Gagah Pangeran Rosfatiputra
f89c154e18
change GetFontSizeByLevel
to return actual font size
2021-06-22 12:24:25 +07:00
Joseph Madamba
2cdbada87e
Fix screen breadcrumb control updating on click
2021-06-21 21:10:24 -07:00
Joseph Madamba
db86098062
Fix dialog not closing after spamming OS window close
2021-06-21 20:23:11 -07:00
Joseph Madamba
9bcd1e6922
Move confirm dialog logic to OnExiting
2021-06-21 20:22:18 -07:00
Joseph Madamba
00b4cf1829
Handle sub screen OnExiting
logic on main screen
2021-06-21 20:20:43 -07:00
Salman Ahmed
ec040ff3fc
Fix leak due to not properly unbinding SourceChanged
event on disposal
2021-06-22 05:05:41 +03:00
Salman Ahmed
caa90bccc6
Fix default skin potentially added twice in RulesetSkinProvidingContainer
2021-06-22 03:45:43 +03:00
Salman Ahmed
627c857da8
Propagate SourceChanged
events from SkinManager
down in the ruleset skin container
2021-06-22 03:45:24 +03:00
Salman Ahmed
9e5bb146d3
Add xmldoc to SkinManager
...
The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.
2021-06-22 03:07:31 +03:00
Salman Ahmed
97dbc7f20e
Add back SkinManager.DefaultSkin
to the ruleset skin lookup sources
2021-06-22 02:54:34 +03:00
Salman Ahmed
d53a43cf3c
Isolate RulesetSkinProvidingContainer
from falling back to parent skin sources
...
For simplicity of lookup order, and which sources are used for the lookup.
2021-06-22 02:53:22 +03:00
Salman Ahmed
ebe0d43790
Add ability to disallow falling back to parent skins
2021-06-22 02:51:17 +03:00
aitani9
36e459e97e
Use margin instead of padding
2021-06-21 13:42:15 -07:00
Naxess
629c98e6a0
Add time distance equality tests
2021-06-21 15:34:11 +02:00
Naxess
e11139eadf
Add low difficulty overlap tests
...
Moq is introduced to mock sliders' end time/position. This is already used similarly in `osu.Game.Tests`.
2021-06-21 15:33:50 +02:00
Naxess
2f3f4f3e4b
Add new checks to verifier
2021-06-21 15:30:45 +02:00
Naxess
fcb918d0e1
Add time distance equality check
2021-06-21 15:30:23 +02:00
Naxess
3eb088f89a
Add low difficulty overlaps check
2021-06-21 15:30:04 +02:00
Dean Herbert
5b9bf54f1f
Merge pull request #13545 from frenzibyte/legacy-spinner-approach-circle
...
Add support for legacy spinner approach circles
2021-06-21 18:52:06 +09:00
Salman Ahmed
999bf27eae
Remove unnecessary abstraction of ApproachCircle
property
2021-06-21 12:07:00 +03:00
JimmyC7834
b162da5ee0
minor code change
2021-06-21 15:47:47 +08:00
Salman Ahmed
ba15f7c19b
Move ApproachCircle
out of the scale container and revert relevant changes
2021-06-21 10:47:38 +03:00
JimmyC7834
22cc1e1452
fixed code style base on code analysis
2021-06-21 15:31:47 +08:00
JimmyC7834
b42aedeb81
fixed code style
2021-06-21 14:43:54 +08:00
JimmyC7834
3367456304
fixed SupporterRequiredDrawable style
2021-06-21 14:30:54 +08:00
JimmyC7834
044c2aa99d
Merge branch 'master' of https://github.com/JimmyC7834/osu into supporter-only-filter-content
2021-06-21 14:27:54 +08:00
JimmyC7834
0707642b76
fixed SupporterRequiredDrawable
2021-06-21 14:25:20 +08:00
Dan Balasescu
7d31943ff5
Merge pull request #13597 from Joehuu/fix-beatmap-discussion-links
...
Fix beatmap discussion links wrongly leading to beatmap page
2021-06-21 14:52:55 +09:00
Salman Ahmed
036b745425
Remove no longer needed LegacySpinnerApproachCircle
2021-06-21 08:41:10 +03:00
Salman Ahmed
42edbe4fb9
Move ApproachCircle
implementation into per-style
2021-06-21 08:40:38 +03:00
Joseph Madamba
6fda5e569a
Fix beatmap discussion links wrongly leading to beatmap page
2021-06-20 21:37:00 -07:00
Joseph Madamba
8b2110c048
Add failing discussion links test
2021-06-20 21:36:08 -07:00
Salman Ahmed
68e28f4903
Implement IHasApproachCircle
in DrawableHitCircle
as well
2021-06-21 07:35:07 +03:00
Salman Ahmed
11b78ad849
Make TestPlayer
skin assigning logic not flaky
2021-06-21 06:46:00 +03:00
Dean Herbert
2d1794f7d8
Merge pull request #13596 from Joehuu/update-rulesets-link
...
Update custom rulesets directory link in readme
2021-06-21 12:09:34 +09:00
Joseph Madamba
e4705abee2
Update custom rulesets directory link in readme
2021-06-20 20:07:46 -07:00
Salman Ahmed
5cfd0e3223
Remove implicit LegacySkin
check and refactor anything using it
2021-06-21 04:16:58 +03:00
Salman Ahmed
01478d780d
Generalize IHasSpinnerApproachCircle
from being spinner-specifc
2021-06-21 03:43:11 +03:00
Salman Ahmed
72155a7c52
Replace if pattern-matching check with switch cases instead
2021-06-21 03:37:50 +03:00
JimmyC7834
d0a8b74823
fixed filter text order
2021-06-20 21:28:57 +08:00
JimmyC7834
996503eb2d
fixed filter text display, added visual tests
2021-06-20 21:23:54 +08:00
Dean Herbert
c624ec79b1
Merge pull request #13575 from bdach/realm-on-xamarin
...
Add direct references to Realm from Xamarin projects
2021-06-20 21:51:25 +09:00