46699 Commits

This Branch

This Branch

All Branches

• Add owner id to PlaylistItem
  Dan Balasescu · 2021-11-25 21:41:03 +09:00
  8a941fa422
• Merge pull request #15782 from peppy/realm-beatmap-set-status

  Add online status to `RealmBeatmapSet`

  Dan Balasescu · 2021-11-24 20:28:45 +09:00
  593f11d0ff
• Merge branch 'master' into realm-beatmap-set-status
  Dan Balasescu · 2021-11-24 19:47:10 +09:00
  b7308283e4
• Merge pull request #15783 from peppy/close-failed-update-notification

  Close a failed update notification immediately

  Dan Balasescu · 2021-11-24 19:46:33 +09:00
  88b968fbe8
• Merge pull request #15781 from peppy/beatmap-set-status

  Rename `BeatmapSetOnlineStatus` to `BeatmapOnlineStatus`

  Dan Balasescu · 2021-11-24 19:25:29 +09:00
  e176083898
• Merge pull request #15780 from peppy/combine-test-beatmap-set-info-usage

  Combine all test data `BeatmapSetInfo` creation into a single method

  Dan Balasescu · 2021-11-24 19:09:35 +09:00
  30037fbec1
• Close a failed update notification immediately

  Fixes visual issue pointed out at
  https://github.com/ppy/osu/discussions/15653#discussioncomment-1679263.

  Dean Herbert · 2021-11-24 19:05:53 +09:00
  1dc1de3d1f
• Give a more correct default value to beatmap and set statuses
  Dean Herbert · 2021-11-24 18:48:12 +09:00
  61009013cc
• Add online status to RealmBeatmapSet
  Dean Herbert · 2021-11-24 18:48:02 +09:00
  052ed8f930
• Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus

  This variable is used at more than just a set level.

  Dean Herbert · 2021-11-24 18:42:49 +09:00
  183b95cbc2
• Replace one more usage
  Dean Herbert · 2021-11-24 18:29:33 +09:00
  0fe27cc8a1
• Fix a few incorrectly updated arguments
  Dean Herbert · 2021-11-24 18:14:18 +09:00
  7603f7eb36
• Combine all test data BeatmapSetInfo creation into a single method
  Dean Herbert · 2021-11-24 18:07:32 +09:00
  0c819b9cfb
• Merge pull request #15779 from peppy/remaining-misc-fixes

  Apply some various code quality fixes that don't fit elsewhere

  Dan Balasescu · 2021-11-24 16:59:49 +09:00
  5ff62a8e04
• Merge pull request #15778 from peppy/ruleset-info-id-usage

  Update usages of `RulesetInfo.ID` to use `OnlineID` instead

  Dan Balasescu · 2021-11-24 16:55:28 +09:00
  74b6c33fab
• Merge pull request #15776 from peppy/non-null-beatmapset-metadata

  Make `BeatmapSet.Metadata` non-null

  Dan Balasescu · 2021-11-24 16:48:28 +09:00
  834bdd8e5c
• Merge pull request #15772 from peppy/remove-model-list-inits

  Initialise `BeatmapSet.Beatmaps` list at construction time

  Dan Balasescu · 2021-11-24 16:41:19 +09:00
  8ce5324c8b
• Remove unnecessary user assign in HitObjectSampleTest
  Dean Herbert · 2021-11-24 16:30:00 +09:00
  2dabedebff
• Move bookmark parsing logic into LegacyBeatmapDecoder
  Dean Herbert · 2021-11-24 16:29:51 +09:00
  3e0e01abdb
• Remove unnecessary mainTrackMixer parameter from BeatmapManager
  Dean Herbert · 2021-11-24 16:27:17 +09:00
  9c61ec217b
• Merge pull request #15760 from peppy/realm-move-data-migration-to-context-factory

  Move realm data migrations inside the `RealmContextFactory`

  Dan Balasescu · 2021-11-24 16:23:56 +09:00
  2ec3fb2e9e
• Merge pull request #15777 from smoogipoo/revert-nunit-blame

  Revert "Run nunit in blame mode"

  Dan Balasescu · 2021-11-24 16:23:22 +09:00
  f6e91f1824
• Update all actual usages of RulesetInfo.ID to use OnlineID instead
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  bbd3ea5b77
• Update mock RulesetInfo usage to set OnlineID instead of ID
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  f283770f34
• Add helper setter to EF RulesetInfo.OnlineID to allow updating usages
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  e57c343531
• Revert "Run nunit in blame mode"

  This reverts commit 215c179b92.

  Dan Balasescu · 2021-11-24 15:26:40 +09:00
  eff1293b5b
• Fix ruleset instance creation null checks
  Dean Herbert · 2021-11-24 15:25:56 +09:00
  db2d8b6d8b
• Merge pull request #15771 from peppy/ruleset-config-cache-shortname

  Update `RulesetConfigCache` to cache via `ShortName` instead of `ID`

  Dan Balasescu · 2021-11-24 15:24:57 +09:00
  33d95fbb9c
• Merge pull request #15775 from peppy/update-framework

  Update framework

  Dan Balasescu · 2021-11-24 15:24:43 +09:00
  73e50af9cc
• Remove reundant self-sets of metadata
  Dean Herbert · 2021-11-24 15:08:04 +09:00
  cb093e1e01
• Make BeatmapSet.Metadata non-null
  Dean Herbert · 2021-11-24 15:03:34 +09:00
  3946a39b65
• Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests
  Dean Herbert · 2021-11-24 14:52:08 +09:00
  44c34ca7b2
• Merge branch 'master' into realm-move-data-migration-to-context-factory
  Dan Balasescu · 2021-11-24 14:40:26 +09:00
  c4b5a07f4b
• Merge pull request #15741 from peppy/realm-ruleset-keybinding-short-name

  Switch realm ruleset key bindings to use ruleset's `ShortName` as key

  Dan Balasescu · 2021-11-24 14:38:57 +09:00
  5b88e4d7b5
• Fix cases of known-non-null
  Dean Herbert · 2021-11-24 14:26:25 +09:00
  a7853fc9cc
• Update framework
  Dean Herbert · 2021-11-24 14:09:25 +09:00
  ec89dfa043
• Fix incorrect fallback logic causing test failure
  Dean Herbert · 2021-11-24 14:04:55 +09:00
  0aedbbe165
• Merge pull request #15770 from peppy/fix-incorrect-id-usage-in-tests

  Fix incorrect usage of `ID` in `TestSceneMultiplayerResults`

  Dan Balasescu · 2021-11-24 13:51:30 +09:00
  cf17c51df2
• Trim whitespace
  Dan Balasescu · 2021-11-24 13:48:59 +09:00
  5a0a95f9d4
• Merge branch 'master' into realm-ruleset-keybinding-short-name
  Dan Balasescu · 2021-11-24 13:48:48 +09:00
  84268c3d85
• Merge pull request #15769 from peppy/model-equality-consistency

  Update cases where equality can be used instead of primary key equality

  Dan Balasescu · 2021-11-24 13:45:57 +09:00
  6183d1cd46
• Merge pull request #15768 from peppy/standardise-ruleset-create-instance

  Remove nullability of `Ruleset.CreateInstance`

  Dan Balasescu · 2021-11-24 13:43:23 +09:00
  6ffba8a546
• Avoid json serialisation of aggregate helper properties

  Also avoids `throw`ing when there are no beatmaps available. Until now
  this wasn't an issue due to the `Beatmaps` list being null instead of empty.

  Dean Herbert · 2021-11-24 13:36:34 +09:00
  a3fdab34d5
• Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment
  Dean Herbert · 2021-11-24 13:27:37 +09:00
  8c60f37508
• Initialise BeatmapSet.Beatmaps list to line up with realm expectations
  Dean Herbert · 2021-11-24 13:25:55 +09:00
  49c2cb9125
• Update RulesetConfigCache to cache via ShortName instead of ID
  Dean Herbert · 2021-11-24 13:10:18 +09:00
  ee22c24370
• Fix incorrect usage of ID in TestSceneMultiplayerResults
  Dean Herbert · 2021-11-24 13:05:51 +09:00
  b1f3e98045
• Update cases where equality can be used instead of primary key equality
  Dean Herbert · 2021-11-24 12:49:57 +09:00
  729f681938
• Merge branch 'master' into realm-move-data-migration-to-context-factory
  Dean Herbert · 2021-11-24 12:38:44 +09:00
  6aed41eacc
• Rewrite commments to read better
  Dean Herbert · 2021-11-24 12:37:09 +09:00
  63b09b356f