1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 04:27:34 +08:00
Commit Graph

27 Commits

Author SHA1 Message Date
Bartłomiej Dach
cebd5f6dc2
Fix restore default button having a minuscule hit area
Another casualty of edc78205d5. This
particular button was actually *relying* on receiving positional events
from its entire bounding box rather than `Content`, in order for the
button to be htitable more easily, which broke as other buttons were
fixed to behave more in line with expectations.

Upon closer inspection this is another case of a weird carried-over
construction. The button doesn't really need to inherit `OsuButton` or
do any of the arcane stuff that it was doing, so it's now a plain
`OsuClickableContainer` with less `Content` hackery.
2022-12-20 20:47:58 +01:00
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Bartłomiej Dach
830f49bca6
Remove doubled-up opacity specification 2021-10-18 19:43:48 +02:00
Bartłomiej Dach
818f35c35f
Restyle default value indicator 2021-10-17 21:50:03 +02:00
Dean Herbert
bc86bafc08 Fix RestoreDefaultValueButton's colour weirdness 2021-08-17 12:48:30 +09:00
Dean Herbert
c191b38125 Reduce transform overhead of RestoreDefaultValueButton 2021-08-16 18:55:50 +09:00
Salman Ahmed
c44558e3c8 Add back LoadComplete override 2021-07-10 17:57:52 +03:00
Salman Ahmed
0223c569df Remove no longer necessary method definitions 2021-07-09 00:49:05 +03:00
Salman Ahmed
a7be632770
Improve documentation
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-07-09 00:39:09 +03:00
Salman Ahmed
28adb43a4a Add detailed explaination for the reason of using old binding method 2021-07-07 09:26:17 +03:00
Salman Ahmed
83578e7c9d Hold a bound copy reference instead 2021-07-02 23:24:51 +03:00
Salman Ahmed
612ed6353c Resolve RestoreDefaultValueButton issue by internal management 2021-07-02 22:30:26 +03:00
Salman Ahmed
2b366e04fd Revert "Fix RestoreDefaultValueButton not behaving correctly on number types"
This reverts commit bc0ab7dd4f.
2021-07-02 21:06:57 +03:00
Salman Ahmed
bc0ab7dd4f Fix RestoreDefaultValueButton not behaving correctly on number types 2021-06-29 23:39:46 +03:00
Bartłomiej Dach
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
Dean Herbert
7c9383b586 Combine RestorableKeyBindingRow back into KeyBindingRow 2021-05-26 18:17:28 +09:00
Swords
441e4e7d56 Formatting 2021-05-24 22:08:34 +10:00
Swords
ca1d1c58ab RestoreDefaultValueButton implements OsuButton 2021-05-24 21:34:47 +10:00
Bartłomiej Dach
0e91a00a7e Revert to previous width spec instead of size 2021-05-17 21:18:45 +02:00
Bartłomiej Dach
30d7768971 Remove now-redundant null check 2021-05-17 20:47:56 +02:00
Bartłomiej Dach
33fe843ba9 Move value change bindings to LoadComplete()
Also removes a redundant one from the setter of `Current`. If the set to
current comes with an associated value change, the bind-unbind flow that
`BindableWithCurrent` implements will handle that change anyway.
2021-05-17 20:46:30 +02:00
Swords
90f00a7663 Fixes ResotreDefaultValue to use the BindableWithCurrent correctly 2021-05-16 15:01:19 +10:00
Swords
50d5af9662 Removed unused method 2021-05-15 12:05:22 +10:00
Swords
d988194dd3 Formatting 2021-05-15 11:40:42 +10:00
Swords
304caf8bdf Adding Requested changed 2021-05-15 11:24:08 +10:00
Swords
0725088fde Well it works, just pretty ugly looking. 2021-05-15 01:01:17 +10:00