71523 Commits

This Branch

This Branch

All Branches

• Refactor RoomSubScreen update
  Dan Balasescu · 2025-02-11 12:43:54 +09:00
  748c2eb390
• Refactor with a bit more null safety

  In particular I don't like the non-null assert around
  `GetCurrentItem()`, because there's no reason why it _couldn't_ be
  `null`.
  Consider, for example, if these panels are used in matchmaking where
  there are no items initially present in the playlist.
  
  The ruleset nullability part is debatable, but I've chosen to restore
  the original code here.

  Dan Balasescu · 2025-02-11 12:20:09 +09:00
  78e5e0eddd
• Adjust styling
  Dan Balasescu · 2025-02-06 14:25:08 +09:00
  885ae7c735
• Fix participant panels not displaying mods from other rulesets correctly
  Dan Balasescu · 2025-02-06 14:24:09 +09:00
  d93f7509b6
• Initial support for freemod+freestyle
  Dan Balasescu · 2025-02-06 13:29:16 +09:00
  84206e9ad8
• Add helper for testing mod/freemod validity
  Dan Balasescu · 2025-02-05 16:44:52 +09:00
  7f8f528ae2
• Merge pull request #31795 from peppy/update-framework

  Update framework

  Dean Herbert · 2025-02-04 23:53:55 +09:00
  2025.204.0 20c4badbba
• Merge pull request #31260 from smoogipoo/multiplayer-free-style

  Add support for "freestyle" in multiplayer

  Dean Herbert · 2025-02-04 22:40:38 +09:00
  15ed029dd1
• Merge pull request #31791 from bdach/unify-selection-behaviour

  Always select the closest control point group regardless of whether it has a timing point on entering timing screen

  Dean Herbert · 2025-02-04 22:32:22 +09:00
  87ff8778c6
• Update framework
  Dean Herbert · 2025-02-04 21:48:45 +09:00
  386fb55392
• Merge branch 'master' into multiplayer-free-style
  Dean Herbert · 2025-02-04 21:48:39 +09:00
  a93dabd33f
• Merge pull request #31783 from bdach/bss/form-button

  Implement "form button" control

  Dean Herbert · 2025-02-04 21:45:11 +09:00
  82ccce8099
• Merge pull request #31787 from peppy/carousel-v2-expanded-state

  Add expanded state tracking to beatmap carousel v2

  Bartłomiej Dach · 2025-02-04 13:07:21 +01:00
  c5c1861d4b
• Select timing point on enter if no effect point is active at the time

  Noticed during testing.

  Bartłomiej Dach · 2025-02-04 12:44:05 +01:00
  2dbf30a096
• Always select the closest control point group regardless of whether it has a timing point
  Bartłomiej Dach · 2025-02-04 12:35:02 +01:00
  a0b6610054
• Merge branch 'master' into bss/form-button
  Bartłomiej Dach · 2025-02-04 12:29:22 +01:00
  7402f3e508
• Merge branch 'master' into carousel-v2-expanded-state
  Bartłomiej Dach · 2025-02-04 12:07:23 +01:00
  07ab5a5ace
• Merge pull request #31785 from peppy/fix-carousel-tests

  Fix carousel tests failing due to dependency on depth ordering

  Bartłomiej Dach · 2025-02-04 12:06:57 +01:00
  95a1b0e7cb
• Remove Scheduler.AddOnce from updateSpecifics

  To keep things simple, let's not bother debouncing this. The debouncing
  was causing spectating handling to fail because of two interdependent
  components binding to `BeatmapAvailability`:
  
  Binding to update the screen's `Beatmap` after a download completes:
  
  https://github.com/ppy/osu/blob/58747061171c4ebe70201dfe4d3329ed7f4343f5/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs#L266-L267
  
  Binding to attempt a load request:
  
  https://github.com/ppy/osu/blob/8bb7bea04e56fab9247baa59ae879e16c8b4bd9b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSubScreen.cs#L67
  
  The first must update the beatmap before the second runs, else gameplay
  will not load due to `Beatmap.IsDefault`.

  Dean Herbert · 2025-02-04 18:41:28 +09:00
  6c6063464a
• Add expanded state to sample drawable representations
  Dean Herbert · 2025-02-04 18:06:16 +09:00
  599b59cb14
• Add tracking of expansion states for groups and sets
  Dean Herbert · 2025-02-04 17:51:51 +09:00
  58560f8acf
• Fix carousel tests failing due to dependency on depth ordering
  Dean Herbert · 2025-02-04 17:50:16 +09:00
  ccdb6e4c48
• Ensure test step doesn't consider pooled instances of drawables
  Dean Herbert · 2025-02-04 17:45:02 +09:00
  2f2dc158e0
• Implement "form button" control
  Bartłomiej Dach · 2025-02-04 09:05:33 +01:00
  3893303988
• Merge pull request #31764 from peppy/beatmap-carousel-v2-grouping

  Add group support to beatmap carousel v2

  Bartłomiej Dach · 2025-02-04 08:13:54 +01:00
  6e59cab928
• Merge pull request #31734 from bdach/simplify-slider-encoding-logic

  Fix multi-segment-type sliders getting mangled on legacy export

  Dean Herbert · 2025-02-04 15:08:44 +09:00
  1e1fb5476e
• Merge pull request #31776 from frenzibyte/carousel-v2-depth-ordering

  Fix depth ordering in new carousel not being relative to selected item

  Dean Herbert · 2025-02-04 13:02:21 +09:00
  ec88c5ed75
• Adjust group traversal logic to handle cases where keyboard selection redirects
  Dean Herbert · 2025-02-04 02:55:59 +09:00
  e454fa558c
• Add failing tests for traversal on group headers
  Dean Herbert · 2025-02-04 02:55:34 +09:00
  b5c4e3bc14
• Remove redundant conditional check
  Dean Herbert · 2025-02-04 02:41:39 +09:00
  b433eef138
• Refactor how grouping is performed
  Dean Herbert · 2025-02-03 20:40:52 +09:00
  c7780c9fdc
• Merge pull request #31775 from peppy/avoid-beatmap-access-beat-sync-container

  Avoid accessing `WorkingBeatmap.Beatmap` every update call

  Bartłomiej Dach · 2025-02-03 12:24:05 +01:00
  1793b8ccb4
• Merge pull request #31778 from peppy/editor-menu-mutual-exclusive

  Make distance snap settings mutually exclusive

  Bartłomiej Dach · 2025-02-03 11:58:34 +01:00
  b60a8341e4
• Tidy up WorkingBeatmap passing in ctor
  Dean Herbert · 2025-02-03 19:26:14 +09:00
  99192404f1
• Rename freestyle select screen classes for better discoverability
  Dean Herbert · 2025-02-03 19:21:21 +09:00
  8bb7bea04e
• Tidy up button construction code
  Dean Herbert · 2025-02-03 19:09:58 +09:00
  37abb1a21b
• Standardise naming to use "Freestyle" not "FreeStyle"
  Dean Herbert · 2025-02-03 19:01:59 +09:00
  444e0970d6
• Merge pull request #31743 from bdach/fix-limit-distance-snap-to-current

  Avoid moving already placed objects temporally when "limit distance snap to current time" is active

  Dean Herbert · 2025-02-03 17:48:24 +09:00
  56000ddb37
• Make distance snap settings mutually exclusive
  Dean Herbert · 2025-02-03 17:34:55 +09:00
  26a8fb6984
• Merge branch 'master' into fix-limit-distance-snap-to-current
  Bartłomiej Dach · 2025-02-03 08:57:27 +01:00
  ee7d281e73
• Merge pull request #31737 from bdach/fix-post-refactor

  Fix distance snap time part ceasing to work when grid snap is also active

  Dean Herbert · 2025-02-03 16:56:28 +09:00
  5668a90781
• Merge pull request #31742 from smoogipoo/fix-results-persistent-sounds

  Fix results screen sounds persisting after exit

  Dean Herbert · 2025-02-03 16:39:47 +09:00
  b9f840c32e
• Apply depth ordering relative to selected item
  Salman Alshamrani · 2025-02-03 02:34:29 -05:00
  c587958f38
• Avoid accessing WorkingBeatmap.Beatmap every update call

  Notice in passing.
  
  Comes with overheads that can be easily avoided. Left a note for a
  future (slightly more involved) optimisation.

  Dean Herbert · 2025-02-03 16:30:31 +09:00
  a23de0b188
• Remove unused using
  Dan Balasescu · 2025-02-03 14:20:56 +09:00
  9033a4d480
• Play sound via results screen instead
  Dan Balasescu · 2025-02-03 14:15:46 +09:00
  210fa14759
• Fix null handling when no items are populated but a selection is made
  Dean Herbert · 2025-02-03 02:39:45 +09:00
  6a18d18feb
• Add test coverage for grouped selection
  Dean Herbert · 2025-02-03 02:39:45 +09:00
  9c34819ff4
• Simplify keyboard traversal logic
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  645c26ca19
• Fix backwards traversal of groupings and allow toggling groups without updating selection
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  d74939e6e9