72821 Commits

This Branch

This Branch

All Branches

• Fix sheared button alignment in preset popovers
  Salman Alshamrani · 2025-04-29 05:34:10 +03:00
  72987aa166
• Make mod preset shear buttons take up full width
  Dean Herbert · 2025-04-22 17:30:03 +09:00
  5e06b3d1b4
• Add padding around footer content to avoid sheared overflow
  Dean Herbert · 2025-04-22 17:19:16 +09:00
  066b036466
• Remove weird default for slider nub X value
  Salman Alshamrani · 2025-04-18 07:37:23 -04:00
  af991d3b29
• Fix ShearedSliderBar left/right boxes not resized correctly
  Salman Alshamrani · 2025-04-18 07:36:55 -04:00
  4c911d3d91
• Add slider step for resizing nub width
  Salman Alshamrani · 2025-04-18 07:36:21 -04:00
  c75ff30c43
• Allow disabling focus indicator in ShearedSliderBar
  Salman Alshamrani · 2025-04-18 07:28:25 -04:00
  715396e5c4
• Add drop shadow support in ShearedNub

  Used for range sliders

  Salman Alshamrani · 2025-04-18 07:28:25 -04:00
  6aab473150
• Remove padding from ShearedButton for better sheared flow alignment
  Salman Alshamrani · 2025-04-18 07:23:39 -04:00
  62b96466c4
• Update sheared slider bar test scene
  Salman Alshamrani · 2025-04-17 09:02:30 -04:00
  ac54735376
• Update sheared button flow test case to be useful
  Salman Alshamrani · 2025-04-17 09:02:30 -04:00
  2a332896c1
• Merge pull request #32823 from smoogipoo/fix-mp-results-background

  Fix multiplayer background changing in results screen

  Bartłomiej Dach · 2025-04-17 14:16:20 +02:00
  0138f78845
• Merge pull request #29816 from peppy/no-high-performance-in-results

  End high performance session when showing results screen

  Bartłomiej Dach · 2025-04-17 14:16:00 +02:00
  772f71d275
• Fix incorrect assertion message

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2025-04-17 20:05:34 +09:00
  47d943afd7
• Merge pull request #32830 from bdach/refuse-to-import-replays-with-dodgy-mods

  Refuse to import scores specifying incompatible mods

  Dean Herbert · 2025-04-17 19:57:01 +09:00
  df1411fc08
• Merge pull request #32829 from peppy/fix-mania-beatmap-corruption-update-background

  Fix osu!mania beatmap objects getting corrupted when updating beatmap background

  Bartłomiej Dach · 2025-04-17 12:31:44 +02:00
  b2855ce57d
• Adjust PlayerLoader logic to avoid threading safety requirements
  Dean Herbert · 2025-04-17 19:21:33 +09:00
  708d9ae1b0
• Fix garbage data in test case
  Bartłomiej Dach · 2025-04-17 11:37:28 +02:00
  5f4afe156f
• Merge pull request #32770 from bdach/replay-stability-tests

  Add test cases for lazer-specific replay instability due to truncation issue

  Dean Herbert · 2025-04-17 18:33:27 +09:00
  66802d2a97
• Add theoretically-valid-but-practically-not commented-out test cases
  Bartłomiej Dach · 2025-04-17 10:36:04 +02:00
  a82bb5c2f6
• Refuse to import scores specifying incompatible mods

  Supersedes https://github.com/ppy/osu/pull/32817.
  
  The messaging of the failure to the user is maybe not the cleanest, but
  I'm not sure it's worth putting time in to improve it?

  Bartłomiej Dach · 2025-04-17 10:10:07 +02:00
  485c3e8e53
• Add failing test
  Bartłomiej Dach · 2025-04-17 10:05:57 +02:00
  1fad2a8f2c
• Centralise calls to end high performance sessions
  Dean Herbert · 2025-04-17 16:55:33 +09:00
  a15230eba1
• End high performance session when showing results screen
  Dean Herbert · 2025-04-17 16:54:45 +09:00
  67c6f8acdd
• Fix osu!mania beatmap objects getting corrupted when updating beatmap background

  Closes https://github.com/ppy/osu/issues/32825.
  
  Tested manually to fix the issue. Setting up test coverage for this is
  going to likely take over an hour compared to the 30 second fix, so
  please advise if required. I couldn't find any existing tests which
  perform this flow.

  Dean Herbert · 2025-04-17 16:11:03 +09:00
  b71281bec8
• Fix multiplayer background changing in results screen
  Dan Balasescu · 2025-04-17 03:30:55 +09:00
  6052fbb4f9
• Add failing test
  Dan Balasescu · 2025-04-17 03:30:55 +09:00
  1a68edfa58
• Merge pull request #32819 from peppy/song-select-v2-unrelated-changes

  Apply various minor refactors (split out from song select v2 ongoing work)

  Bartłomiej Dach · 2025-04-16 14:54:53 +02:00
  81fb058c9a
• Add animated fade when online status pill has an unknown status
  Dean Herbert · 2025-04-16 19:41:50 +09:00
  07d0c7443c
• Disable masking of Carousel

  The default for carousels should be unmasked as their usage generally
  sees them overflowing outside their main usage area (see `bleed`
  variables).

  Dean Herbert · 2025-04-16 19:41:49 +09:00
  376b4e8929
• Add global screen margin for new screen designs
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  1cca936e28
• Avoid adding arbitrary background in SongSelectComponentsTestScene
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  4c1f4a512c
• Make some test methods static for future reuse
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  2ac1b89037
• Add keywords for converted setting
  Dean Herbert · 2025-04-16 19:41:48 +09:00
  6021d85e63
• Merge pull request #32757 from smoogipoo/playlist-completion-icon

  Add display to show completed playlist items

  Dean Herbert · 2025-04-16 19:41:12 +09:00
  435f03745f
• Use full namespace isntead of weird using statement
  Dean Herbert · 2025-04-16 19:40:47 +09:00
  6fe1695d39
• Merge pull request #32818 from peppy/rename-everything

  Rename song select v2 classes and namespaces

  Dean Herbert · 2025-04-16 19:36:10 +09:00
  3d72644cd3
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Merge pull request #32815 from peppy/global-shear

  Change global shear definition to be a `Vector2`

  Dean Herbert · 2025-04-16 18:34:39 +09:00
  572bc6d8b4
• Merge pull request #32816 from bdach/oops

  Fix local leaderboards not showing when starting game offline

  Bartłomiej Dach · 2025-04-16 11:17:57 +02:00
  054f8a04b7
• Merge pull request #32814 from peppy/beatmap-store-thread-safety

  Fix thread safety when calling `BeatmapStore.GetBeatmapSets`

  Bartłomiej Dach · 2025-04-16 11:17:02 +02:00
  f8af848764
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Fix local leaderboards not showing when starting game offline

  Broke in https://github.com/ppy/osu/pull/32494. Oops.

  Bartłomiej Dach · 2025-04-16 10:27:33 +02:00
  cf2f6d7233
• Add failing test
  Bartłomiej Dach · 2025-04-16 10:27:05 +02:00
  64b9d4642a
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Fix thread safety when calling BeatmapStore.GetBeatmapSets

  While usually we'd handle this locally by moving bind operations to
  `LoadComponent`, this component was explicitly made to be used in
  asynchronous scenarios (to allow cases like song select to coexist with
  realm without adding huge compliexities to the classes locally).
  
  So I think it makes sense to hide this as an implementation detail. The
  locked segments should all be quite fast to run so I do not see a
  performance issue with lock contention here.

  Dean Herbert · 2025-04-16 15:53:20 +09:00
  e8af0dabea
• Merge pull request #32772 from frenzibyte/beatmap-statistic-bars

  Introduce numeric data in beatmap object count statistics

  Bartłomiej Dach · 2025-04-14 13:32:31 +02:00
  9e112bc16b
• Don't include spinner types in note sums
  Dean Herbert · 2025-04-14 19:21:36 +09:00
  3d47a2b5b2
• Merge pull request #32802 from smoogipoo/fix-doubled-condition

  Combine "spinnable time" conditions

  Bartłomiej Dach · 2025-04-14 12:15:36 +02:00
  434a0392dd
• Rename new property to better explain visual-only usage
  Dean Herbert · 2025-04-14 18:38:04 +09:00
  f05a50f4e1