3681 Commits

• Merge pull request #36103 from bdach/form-sample-set

  Implement form control for adding/removing custom samples in editor

  Dean Herbert · 2025-12-25 15:11:33 +09:00
  0bcb3c5839
• Update switch button visuals
  Salman Alshamrani · 2025-12-23 20:18:59 -05:00
  033a73e969
• Make setter protected to fix build error
  Salman Alshamrani · 2025-12-23 06:31:26 -05:00
  95cf050298
• Expose constant for max decimal digits display
  Salman Alshamrani · 2025-12-23 06:14:48 -05:00
  fa32be37d6
• Seal tooltip text overrides
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  e4d7bc3896
• Add explanatory note
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  520baf6c50
• Revert unintended change
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  a1d4d44151
• Make sound playback consistent across all disabled controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  cb32d2da3e
• Add label and tooltip formatting to form sliders
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  4ee7e6f787
• Add right margin to form dropdown chevron
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c2c1fa4d4c
• Use switch button for form checkbox controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  339aad42a7
• Update "disabled" visual feedback of form controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  a2872ee870
• Merge branch 'master' into form-slider-bar-disabled
  Dean Herbert · 2025-12-22 23:44:33 +09:00
  dbcc7cc09d
• Merge pull request #36055 from frenzibyte/new-settings/item

  Implement new settings item component

  Dean Herbert · 2025-12-22 22:55:53 +09:00
  d9dad4c3a8
• Adjust colour of inactive slider bar
  Dean Herbert · 2025-12-22 22:06:39 +09:00
  0787345a84
• Implement form control for adding/removing custom samples in editor

  The test scene doesn't exercise the custom sample playback, but I hope I
  can be forgiven for this as setting up a custom editor beatmap just for
  this to work is rather cumbersome.

  Bartłomiej Dach · 2025-12-22 13:48:31 +01:00
  9d07ad2761
• Move disable to better place
  Bartłomiej Dach · 2025-12-22 10:04:29 +01:00
  df524d68fd
• Fix disabled form slider bars being half-baked

  In order of severity:
  
  - You could actually click on the textbox portion of a disabled textbox,
    focus it, select text, input stuff, and commit, which would die
    on the spot.
  
  - The slider part had no visual indication that it's not interactable
    anymore.

  Bartłomiej Dach · 2025-12-19 12:17:46 +01:00
  ecc51d4701
• Use menu item labels as filter terms instead
  Salman Alshamrani · 2025-12-18 19:48:42 -05:00
  4fee1547e3
• Remove Value from {Is,Set}ValueDefault
  Salman Alshamrani · 2025-12-18 05:50:35 -05:00
  f5bd888078
• Limit form dropdown height by default
  Salman Alshamrani · 2025-12-18 05:19:54 -05:00
  90d7615432
• Expose common interface for form controls
  Salman Alshamrani · 2025-12-18 05:15:01 -05:00
  729cd722bd
• Add osu!-style undo icon
  Salman Alshamrani · 2025-12-18 04:08:16 -05:00
  8da1fde981
• Merge branch 'master' into custom-sample-set-selection
  Dean Herbert · 2025-12-17 19:30:24 +09:00
  61bf68f336
• Merge branch 'master' into screen-scaling-tablet-output
  Bartłomiej Dach · 2025-12-09 08:05:20 +01:00
  07ea9fe2a4
• Merge pull request #35757 from peppy/settings-wank

  Adjust settings buttons and general section to feel better

  Bartłomiej Dach · 2025-11-25 08:46:00 +01:00
  9e3486d4e6
• Adjust some more visual metrics to feel better
  Dean Herbert · 2025-11-25 01:05:31 +09:00
  64668eafb9
• Reduce abstractions of rounded button
  Dean Herbert · 2025-11-25 00:55:42 +09:00
  b0762fc8ec
• Add double-click-nub-to-reset function to form slider bars

  See https://github.com/ppy/osu/pull/35742#issuecomment-3561517030.

  Bartłomiej Dach · 2025-11-24 10:32:42 +01:00
  9d88c761d3
• Merge pull request #35751 from bdach/seek-differently

  Debounce continuous track seeks to at most one every 200ms

  Dean Herbert · 2025-11-21 17:59:57 +09:00
  2c40e116e1
• Update rounded button to be less rounded

  Intended to match the rest of the UI which is less rounded these days.
  See inline comment for reason for not matching `FormControl` corner
  radius just yet.

  Dean Herbert · 2025-11-21 16:23:53 +09:00
  34146b8bcb
• Debounce continuous track seeks to at most one every 500ms

  See https://github.com/ppy/osu/pull/35677#issuecomment-3555903209.

  Bartłomiej Dach · 2025-11-20 12:23:31 +01:00
  6052ed790d
• Fix tests
  Bartłomiej Dach · 2025-11-20 10:12:43 +01:00
  47faf774b0
• Use new sliders-with-text-input in editor toolboxes

  Addresses https://github.com/ppy/osu/discussions/35732.
  
  And yes, I renamed "perfect curve threshold" to "bias" so that the text
  can fit. Sue me.

  Bartłomiej Dach · 2025-11-19 13:22:20 +01:00
  4b59a4657f
• Move application of scaling to tablet output area to scaling container

  It's the safest place for it to be there, really.

  Bartłomiej Dach · 2025-11-18 14:49:01 +01:00
  80fbcd5fbd
• Fix various screens not registering themselves as IPreviewTrackOwner
  Dan Balasescu · 2025-11-17 13:34:02 +09:00
  ce5e54c9d2
• Alleviate song select post-filter update thread hitches by caching a model-to-carousel-item mapping (#35628)
  Bartłomiej Dach · 2025-11-13 23:21:14 +09:00
  b64abbf1f5
• Delay seeking the current track when dragging now playing overlay progress bar until commit (#35677)

  RFC. Written to address
  https://osu.ppy.sh/community/forums/topics/2150023.
  
  Few other things we might want to happen here:
  
  - pause the track when starting the drag
  - figure out what to do when a drag is held while the track changes in
    the background (which was impossible to happen before this)
  
  but I want to see the reaction to this first.

  Bartłomiej Dach · 2025-11-11 14:18:40 +09:00
  4c72a60ee2
• Fix pressing Enter on song select with IME active advancing to gameplay instead of confirming choice (#35619)

  Closes https://github.com/ppy/osu/issues/35568.

  Bartłomiej Dach · 2025-11-06 16:06:52 +09:00
  dbefba57ce
• Fix DrawableDate not updating

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2025-10-29 11:51:31 +01:00
  4c60df21db
• SongSelectV2: Scroll to selection instantly after a filter

  Closes https://github.com/ppy/osu/issues/33379.
  
  Pretty sure this matches song select V1. The two call sites where the
  old one does instant scrolls are:
  
  	https://github.com/ppy/osu/blob/30412ba3f2c5b6debb9a0e3b930da6cc156852db/osu.Game/Screens/Select/BeatmapCarousel.cs#L672
  
  which happens just after a filter, and
  
  	https://github.com/ppy/osu/blob/30412ba3f2c5b6debb9a0e3b930da6cc156852db/osu.Game/Screens/Select/BeatmapCarousel.cs#L683
  
  which is a bit more difficult to pin down, but generally appears to
  happen on changes to the visible items, which on `SongSelectV2` triggers
  a re-filter anyway.

  Bartłomiej Dach · 2025-10-24 13:24:47 +02:00
  819da1bc38
• Add sample set selection controls to sample popovers

  - Below 20 custom sample sets, they are shown as ternary buttons.
  - Above 20 custom sample sets, they are shown in a dropdown (yes there
    are actual cases of this as I've been informed by the NAT; one example
    being https://osu.ppy.sh/beatmapsets/1018061#osu/2197383)
  
  As a bonus, to make determining what the heck is actually changing when
  adjusting these controls, the full set of applicable sounds now plays on
  adding/removing additions, changing their banks, as well as changing the
  custom set (if any).
  
  For now there are no user-facing controls to add the samples to the map
  yourself, you have to know how to name the `.wav`s and edit-externally
  them in yourself. *For now.*

  Bartłomiej Dach · 2025-10-24 12:09:27 +02:00
  e2681c4163
• Make bank selection controls dropdowns instead of text boxes

  Longstanding complaint. Text boxes make no sense if anything that isn't
  the three legacy values gets deleted on save anyway.

  Bartłomiej Dach · 2025-10-24 11:52:45 +02:00
  1f2f86b016
• Fix performance overhead when computing spacing between standalone panels

  The equality check that was supposed to replace the read of
  `CurrentSelectionItem` showed up as a hotspot in profiling.
  
  The selection updating code looks a little stupid after this, but all in
  the name of performance...

  Bartłomiej Dach · 2025-10-22 11:46:34 +02:00
  c34b2ffc05
• Improve design of quick play endgame results (#35267)
  Dean Herbert · 2025-10-13 22:07:21 +09:00
  f488974d39
• Attempt to scroll carousel to nearest expanded panel when the current selection is filtered out

  Addresses https://github.com/ppy/osu/issues/33443, maybe.
  
  I considered adding tests but they'd likely be janky and take a long
  time to write, so decided against until there's a demand for it.

  Bartłomiej Dach · 2025-10-02 14:28:39 +02:00
  007de10e2b
• Fix pressing Enter not starting current global beatmap if carousel is fully filtered out

  Closes https://github.com/ppy/osu/issues/34693.

  Bartłomiej Dach · 2025-10-01 14:31:48 +02:00
  9b78187d29
• Refactor spritesheet-based icons to be single-file based (#34976)

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Jinkku · 2025-10-01 13:30:06 +02:00
  b7d36cffd4
• Merge pull request #35159 from bdach/carousel-target-vertical-center

  Add half-height-of-selected-panel adjustment to carousel scroll target

  Dean Herbert · 2025-10-01 15:00:14 +09:00
  e26e44cd45
• Add half-height-of-selected-panel adjustment to carousel scroll target

  Intended to address https://github.com/ppy/osu/issues/35147, maybe?
  
  The old carousel would target the vertical center of the active panel
  when scrolling:
  
  	https://github.com/ppy/osu/blob/b9e1b6969e78dfa798bb4afed8afae55e9e4adb1/osu.Game/Screens/Select/BeatmapCarousel.cs#L948
  
  This was not in place in the new carousel, weirdly, which was targeting
  the top-left corner of the selected panel.

  Bartłomiej Dach · 2025-09-30 12:57:24 +02:00
  2edd49d2c0