73702 Commits

This Branch

This Branch

All Branches

• Decouple velocity change bonus from wide angle bonus (#33541)

  * Decouple velocity change bonus from wide angle bonus
  
  * Replace sin with smoothstep
  
  * Set multiplier back to 0.75
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  StanR · 2025-06-09 11:02:49 +00:00
  699fbb1a85
• osu!taiko new miss penalty using consistency factor (#33409)

  * New formulas for effective miss count and penalty
  
  * More elaborate comments
  
  * More comment stuff

  Eloise · 2025-06-08 22:47:26 +00:00
  5df41c08f4
• Refactor and re-comment osu! standard deviation calculations (#33218)

  * Refactor
  
  * Fix typo
  
  * Prevent double.PositiveInfinity from occuring
  
  * Fix leftover code branch
  
  * Fix some idiot putting Math.Max instead of Math.Min
  
  * Address NaN values
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Natelytle · 2025-06-08 22:41:13 +00:00
  c4b07413b1
• osu!taiko simplify pp summing and make performance attributes accurate (#33500)

  * Change pp summing and adjust multipliers
  
  * Add back convert consideration for hidden
  
  * And the other one whoops
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Eloise · 2025-06-08 08:48:28 +00:00
  6ae8a68389
• Reduce combo scaling for osu!catch (#33417)

  * Reduce combo scaling for osu!catch
  
  This is a conservative reduction, a middle point between the current
  scaling and the CSR proposals.
  
  * Reduce osu!catch combo scaling further
  
  0.45 makes little difference so let's reduce it a bit more.
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Wulpey · 2025-06-07 14:17:46 +00:00
  642b938358
• Remove multipliers nerfing ez (#33415)
  Eloise · 2025-06-06 16:46:33 +03:00
  6a9aeda5d4
• Remove stamina skill buff from strain length bonus (#33380)

  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Eloise · 2025-06-03 14:47:42 +01:00
  b982c3cd20
• Fix incorrect limit for sliderbreak estimation (#33110)

  * fix incorrect clamp
  
  * Add inline comment to explain `possibleBreaks` calculation
  
  * move limit to aim and speed functions
  
  * fix negative okMehAdjustment
  
  * fix cases where lazer effective misscount gets reduced
  
  * Simplify scope of changes
  
  * Correct variable name
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Givikap120 · 2025-06-03 09:29:16 +01:00
  366f2469ef
• Merge branch 'master' into pp-dev
  Bartłomiej Dach · 2025-05-31 19:55:56 +02:00
  737ec8b2a8
• Merge pull request #33348 from bdach/song-select-v2-gap-between-beatmap-panel-and-set-panel

  SongSelectV2: Fix input gap between last beatmap panel in set and next set panel

  Dean Herbert · 2025-05-31 12:07:58 +09:00
  ccb47baa8c
• Merge pull request #33345 from bdach/song-select-v2-human-fuzzers

  SongSelectV2: Fix more crashes resulting from users deliberately trying to break things

  Dean Herbert · 2025-05-31 11:46:07 +09:00
  b569de3343
• SongSelectV2: Fix more crashes resulting from users deliberately trying to break things

  See https://github.com/ppy/osu/issues/33336#issuecomment-2922443444.
  
  Can't wait for even more human fuzzing to come later.

  Bartłomiej Dach · 2025-05-30 19:54:49 +02:00
  d2abfe4370
• Merge pull request #33321 from peppy/song-select-v2-scroll-to-selected

  SongSelectV2: Fix scroll to selected not always scrolling

  Dean Herbert · 2025-05-31 02:46:39 +09:00
  28342c51b1
• SongSelectV2: Fix input gap between last beatmap panel in set and next set panel
  Bartłomiej Dach · 2025-05-30 19:13:42 +02:00
  f462c683ee
• Merge pull request #33333 from nekodex/rank-display-sfx

  Adds SFX for rank changes to the in-game rank display

  Dean Herbert · 2025-05-31 01:21:00 +09:00
  d18efc9ab4
• Fix abhorrently incorrect bindable usage
  Dean Herbert · 2025-05-31 00:41:28 +09:00
  43b7171f5c
• Update resources
  Dean Herbert · 2025-05-30 23:12:53 +09:00
  1b9d6dab2e
• Merge pull request #33338 from nekodex/songselect-v2-sfx-fixes

  SongSelectV2: Fix some missing/incorrect SFX

  Dean Herbert · 2025-05-30 22:14:26 +09:00
  b597f3eb17
• Replace assertion with hard guard

  Closes https://github.com/ppy/osu/issues/33336.
  
  I was worried that doing that was going to cause terminal breakage but
  in testing it does not appear to so I'm just going to do this and call
  it a day.

  Bartłomiej Dach · 2025-05-30 15:05:14 +02:00
  ba1148c59e
• Delay scroll to after children update

  Without it the layout height set does not take effect for the scroll to
  correctly execute.

  Bartłomiej Dach · 2025-05-30 14:49:03 +02:00
  b6fa9c9dca
• Fix selection's carousel Y position being read too early

  `updateItemYPosition()` mutates `item.CarouselYPosition`, so storing
  that to the selections before it's updated is storing stale values.

  Bartłomiej Dach · 2025-05-30 14:49:03 +02:00
  a3db764008
• Fix scroll layout height not being set early enough

  Because of this it was possible for a scroll to not be able to scroll
  to the panel it wanted to scroll to because its layout height was
  too small for the target Y position of the panel that it wanted to
  scroll to.
  
  The scroll height was set in `updateDisplayedRange()` which is notably
  after attempting to scroll to the current selection.

  Bartłomiej Dach · 2025-05-30 14:49:00 +02:00
  b6335e9847
• SongSelectV2: Fix some missing/incorrect SFX
  Jamie Taylor · 2025-05-30 21:31:26 +09:00
  cf6e9f8ad8
• Merge branch 'master' into song-select-v2-scroll-to-selected
  Bartłomiej Dach · 2025-05-30 14:27:38 +02:00
  735244fb8d
• Merge pull request #33334 from peppy/song-select-v2-fix-carousel-never-load

  SongSelectV2: Fix carousel never displaying if too many beatmap updates are arriving in background

  Bartłomiej Dach · 2025-05-30 14:26:32 +02:00
  9e615718e9
• Merge pull request #33327 from smoogipoo/stabilise-hot-reload

  Attempt to stabilise hot-reload

  Dean Herbert · 2025-05-30 21:03:40 +09:00
  2025.530.0 f4320a8f41
• Fix carousel never displaying if too many beatmap updates are arriving in background
  Dean Herbert · 2025-05-30 19:39:50 +09:00
  5e397d9d1f
• Fix missing ConfigureAwait causing Items to potentially be copied on non-update thread
  Dean Herbert · 2025-05-30 19:39:49 +09:00
  7025c2cf2f
• Fix incorrect cross-thread access of beatmap list
  Dean Herbert · 2025-05-30 19:39:49 +09:00
  5cf173196e
• Add test showing carousel never loading under high beatmap churn
  Dean Herbert · 2025-05-30 19:39:48 +09:00
  671c08df8e
• Merge pull request #33332 from peppy/song-select-v2-fix-double-filter

  SongSelectV2: Fix carousel filtering twice on entering song select

  Bartłomiej Dach · 2025-05-30 12:29:32 +02:00
  559ddd1ec9
• Merge pull request #33335 from bdach/song-select-v2-single-items-arent-shown
  Dean Herbert · 2025-05-30 19:29:15 +09:00
  8cea1e2e1d
• Merge pull request #33331 from peppy/song-select-v2-fix-incorrect-gameplay-start

  SongSelectV2: Fix carousel activating selection when only one valid item in list

  Bartłomiej Dach · 2025-05-30 12:09:47 +02:00
  1a1354e907
• Merge branch 'master' into song-select-v2-fix-incorrect-gameplay-start
  Bartłomiej Dach · 2025-05-30 11:40:28 +02:00
  74c7d6603c
• Merge branch 'master' into song-select-v2-single-items-arent-shown
  Bartłomiej Dach · 2025-05-30 11:38:06 +02:00
  e4cd8bcc59
• Merge pull request #33329 from peppy/song-select-v2-polish-2

  SongSelectV2: Various polish, pass 2

  Bartłomiej Dach · 2025-05-30 11:36:31 +02:00
  f74ecdd688
• SongSelectV2: Fix carousel not displaying anything if there is only one panel to display

  If there is only one panel to display, a `DisplayRange` of (0, 0) is
  *very much* valid.

  Bartłomiej Dach · 2025-05-30 11:20:00 +02:00
  2d900c55cf
• Add failing test case
  Bartłomiej Dach · 2025-05-30 11:20:00 +02:00
  68504e9639
• Use nullable Criteria instead of ctor flag
  Dean Herbert · 2025-05-30 18:15:27 +09:00
  5bf235f2dc
• Fix unintentional initial filter delay on entering song select
  Dean Herbert · 2025-05-30 18:08:28 +09:00
  5222c30139
• Merge branch 'master' into song-select-v2-polish-2
  Bartłomiej Dach · 2025-05-30 11:07:11 +02:00
  4915e4d266
• Add sfx to ingame rank display
  Jamie Taylor · 2025-05-30 17:52:36 +09:00
  04f1e59d0e
• Merge pull request #33330 from peppy/song-select-v2-collections-context-menus

  SongSelectV2: Add back ability to manage collections from beatmap / set panel context menus

  Bartłomiej Dach · 2025-05-30 10:50:34 +02:00
  5d0c2a6876
• Merge branch 'master' into song-select-v2-collections-context-menus
  Bartłomiej Dach · 2025-05-30 10:21:17 +02:00
  9e49d66e1f
• Hide all unsupported grouping modes for now
  Dean Herbert · 2025-05-30 17:02:52 +09:00
  27fe9485bd
• Fix test being sensitive to selected tab on new song select
  Bartłomiej Dach · 2025-05-30 10:02:40 +02:00
  9d0d3bb97a
• Also hide any popovers when footer sets new buttons (ie we're moving to a new screen)
  Dean Herbert · 2025-05-30 16:49:24 +09:00
  40d801d2c1
• Adjust panel content alignment slightly
  Dean Herbert · 2025-05-30 16:48:48 +09:00
  9bf111c66a
• Inflate padding to left of difficulty icon to make more visually even
  Dean Herbert · 2025-05-30 16:33:58 +09:00
  6e1a1bb562
• Separate out expanded/selected set and difficulty panels with extra padding
  Dean Herbert · 2025-05-30 16:27:19 +09:00
  017cef4255