36258 Commits

Author	SHA1	Message	Date
Dean Herbert	5c640d15a0	Stop requesting messages as part of initial chat presence	2022-11-21 15:17:54 +09:00
Dean Herbert	4a79141824	Merge pull request #21338 from RATCM/fix-leaderboard-filter ... Match leaderboard filter behaviour to web	2022-11-21 14:01:55 +09:00
Dean Herbert	dfa92b3de9	Merge pull request #21326 from bdach/fix-phantom-beatmap-sets ... Fix phantom beatmap sets appearing on carousel after delete/update	2022-11-21 13:25:14 +09:00
Dean Herbert	92aea22cd3	Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup ... Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-21 12:16:56 +09:00
vegguid	a431b793b9	Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-20 23:18:19 +01:00
RATCM	f5fbb7c8de	Changed comments	2022-11-20 19:27:40 +01:00
RATCM	d20a357c0e	Fixed ordering bug	2022-11-20 19:24:51 +01:00
RATCM	9040dfbd4e	Match leaderboard filter behaviour to web	2022-11-20 17:39:46 +01:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu ... Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Bartłomiej Dach	0f382590e6	Remove unnecessary #nullable disable	2022-11-20 15:31:51 +01:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update ... Regressed in c40c70509e. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
Salman Ahmed	4b0ba86bd0	Identify scrolling rulesets using temporary DrawableRuleset instances	2022-11-20 04:12:52 +03:00
Salman Ahmed	58296bd4f0	Introduce IDrawableScrollingRuleset for editor consumption	2022-11-20 04:11:10 +03:00
Bartłomiej Dach	0c671a2a82	Merge branch 'master' into fix-tablet-aspect-ratio-values	2022-11-19 14:32:24 +01:00
Bartłomiej Dach	c05c1625f2	Merge branch 'master' into editor-test-play-dont-retain-test-time	2022-11-19 12:09:04 +01:00
Salman Ahmed	60c424837b	Merge branch 'master' into disable-scroll-speed-on-osu	2022-11-19 12:13:45 +03:00
Salman Ahmed	2e3af97892	Remove unused using	2022-11-19 12:13:36 +03:00
Dean Herbert	130f776427	Merge pull request #21267 from peppy/catch-file-enumeration-errors ... Catch and gracefully handle file/directory enumeration failures during stable import	2022-11-19 15:38:40 +09:00
Salman Ahmed	290369db47	Hide scroll speed slider on rulesets which don't support it	2022-11-19 06:42:27 +03:00
Salman Ahmed	016de2f5a0	Fix editor not always playing hitsounds with clock offsets applied	2022-11-19 05:15:22 +03:00
Salman Ahmed	1be8c6bd9c	Fix "perform from screen" not considering screen load state	2022-11-18 17:23:10 +03:00
Dawid Sośnia	9ad484a0f4	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-18 12:11:22 +01:00
Dan Balasescu	e4fc14faee	Merge pull request #21270 from peppy/auto-advance-bindings ... Auto-advance binding for ruleset key bindings	2022-11-18 16:19:54 +09:00
Dan Balasescu	9d33a6568e	Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding ... Fix being able to bind two non-modifier keys to the same binding	2022-11-18 16:19:38 +09:00
Dan Balasescu	d8e99d811d	Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling ... Fix timeline potentially scrolling at extents while not dragging	2022-11-18 16:19:30 +09:00
Dean Herbert	d59befc9d3	Fix initial visual state of positions before sort runs	2022-11-18 16:08:27 +09:00
Dean Herbert	aff218dfd5	Redirect through validity function rather than overriding Sort	2022-11-18 16:03:40 +09:00
Dean Herbert	20af8217f4	Tidy up bindable flow	2022-11-18 15:50:41 +09:00
Dean Herbert	e4f522aad1	Fix inspections / typos	2022-11-18 15:47:37 +09:00
Dean Herbert	d17c091d63	Move constant to a better location	2022-11-18 15:47:31 +09:00
Dean Herbert	3faa7f5f74	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-18 15:44:30 +09:00
Salman Ahmed	90cd386323	Fix timeline potentially scrolling at extents while not dragging	2022-11-18 09:43:16 +03:00
Dean Herbert	bab5be8dee	Merge pull request #21290 from smoogipoo/multiplayer-test-debug ... Add some debugging for multiplayer test failures	2022-11-18 15:39:33 +09:00
Dean Herbert	e658efbefa	Fix being able to bind two non-modifier keys to the same binding	2022-11-18 15:34:41 +09:00
Dan Balasescu	c2a127dc68	Merge pull request #21289 from peppy/fix-triangle-button-flash ... Fix triangle button flash effect looking incorrect	2022-11-18 15:26:43 +09:00
Dan Balasescu	219d049edf	Merge pull request #21140 from maromalo/long-standard ... Standardise scores to `long` type	2022-11-18 15:26:33 +09:00
Dan Balasescu	cc434c9113	Merge pull request #21288 from peppy/fix-no-network-slow-gameplay-load ... Fix entering gameplay while network connection is in a bad state taking too long	2022-11-18 15:24:31 +09:00
Dan Balasescu	7e9d2ecaf5	Merge pull request #21287 from peppy/fix-null-ref-persistent-endpoint-connector ... Fix potential incorrect connection state resulting in null reference	2022-11-18 15:08:33 +09:00
Dan Balasescu	b0faa009c1	Add some debugging for multiplayer test failures	2022-11-18 14:52:11 +09:00
Dean Herbert	5fc0d45675	Fix triangle button flash effect looking incorrect	2022-11-18 14:30:59 +09:00
Dan Balasescu	57b8495c7a	Merge branch 'master' into long-standard	2022-11-18 14:24:04 +09:00
Dan Balasescu	d47c46d144	Compute raw score in-line ... Saves on an allocation (though it seems to only be a ValueType so it shouldn't be a big deal) and a tail-call.	2022-11-18 14:22:28 +09:00
Dean Herbert	964ceddf83	Fix API queue only being flushed once while in a failing state	2022-11-18 14:21:37 +09:00
Dean Herbert	e4d134a820	Reduce time waited on a score submission token from 60 to 30s	2022-11-18 14:07:40 +09:00
Dan Balasescu	1b1fed723d	Merge pull request #21269 from peppy/fix-key-bindings-keyword ... Move "keybindings" keyword to correct section	2022-11-18 14:05:08 +09:00
Dan Balasescu	551192b413	Refactor a bit for readability	2022-11-18 13:55:37 +09:00
Dean Herbert	a5d22195f2	Fix potential incorrect connection state resulting in null reference	2022-11-18 13:45:46 +09:00
Dean Herbert	1ff1738988	Merge pull request #21244 from nanashi-1/beatmapoptions-disabled ... Disable certain beatmap option buttons when there are no beatmaps selected	2022-11-18 12:55:07 +09:00
Dan Balasescu	a776622ce0	Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction ... Fix `NowPlayingOverlay` loading background texture too early (and permanently)	2022-11-18 12:09:16 +09:00
Dan Balasescu	c34dd27674	Merge pull request #21276 from peppy/eager-triangles-disposal ... Eagerly dispose of triangles intro textures to avoid holding for full length of game session	2022-11-18 11:58:39 +09:00