Bartłomiej Dach
1e1c07ced1
Merge pull request #12279 from bdach/fix-editor-clock-test-interference
...
Fix editor clock test scene not re-enabling beatmap
2021-04-03 13:32:56 +02:00
Bartłomiej Dach
7d4b0e3f0a
Fix editor clock scene not re-enabling beatmap
...
Could interfere with other tests due to causing crashes on attempts to
change `Beatmap.Value`.
2021-04-03 12:34:48 +02:00
Samuel Cattini-Schultz
85d2b1232a
Refactor to abstract out strain logic into StrainSkill class
...
While it is the case for the existing official Skills, Skill implementations shouldn't be required to conform to a strain based approach.
There are other valid approaches to calculating skill difficulty that can be supported by abstracting the strain logic into its own StrainSkill class.
2021-04-03 20:52:39 +11:00
Samuel Cattini-Schultz
5b2dcea8a8
Refactor to encapsulate strain logic into Skill class
...
As strains are an implementation detail of the current Skill calculations, it makes sense that strain related logic should be encapsulated within the Skill class.
2021-04-03 20:47:43 +11:00
Samuel Cattini-Schultz
fe66b84bed
Implement dynamic previous hitobject retention for Skill class
...
There is no reason we should be limiting skills to knowing only the previous 2 objects. This originally existed as an angle implementation detail of the original pp+ codebase which made its way here, but didn't get used in the same way.
2021-04-03 20:28:51 +11:00
Dean Herbert
eb1e850f99
Merge pull request #12254 from smoogipoo/spectator-refactor
...
Move frame-handling spectator logic into abstract base class
2021-04-03 17:23:33 +09:00
Dean Herbert
dc3163ccf2
Merge pull request #12271 from hbnrmx/filechooser-preselect-folder
...
Open editor file selector in the directory of the previous selection
2021-04-03 14:31:19 +09:00
Dean Herbert
f0e656fb12
Merge pull request #12276 from PercyDan54/beatmap-info-unicode
...
Make beatmap listing use unicode title & artist name
2021-04-03 14:30:27 +09:00
Dean Herbert
e94d9febb7
Merge pull request #12275 from peppy/update-framework
...
Update framework
2021-04-03 13:57:21 +09:00
PercyDan54
dde255980b
Fix formatting
2021-04-03 12:45:42 +08:00
PercyDan54
bd7da9eb39
Make beatmap title use unicode
2021-04-03 12:43:17 +08:00
Dean Herbert
0dce4b8894
Update framework
2021-04-03 13:01:08 +09:00
Dean Herbert
67f0c0ceb9
Merge branch 'master' into spectator-refactor
2021-04-03 12:55:11 +09:00
hbnrmx
824fb9f398
reopen FileSelector in the directory of the previous selection
2021-04-02 18:01:26 +02:00
hbnrmx
438f3e6349
move fallback text to PlaceholderText
2021-04-02 17:57:21 +02:00
PercyDan54
a5a19319cc
Fix code style
2021-04-02 21:15:28 +08:00
Dan Balasescu
0c35128ead
Merge pull request #11849 from Syriiin/diffcalc/fix/clockrate-adjusted-decay
...
Fix clockrate adjusted difficulty calculations bug in strain decay
2021-04-02 21:41:58 +09:00
smoogipoo
cd53074941
Schedule spectator callbacks
2021-04-02 21:27:20 +09:00
PercyDan54
1ff77754fd
Use OnlineViewContainer
2021-04-02 20:14:31 +08:00
Dan Balasescu
345779b19a
Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay
2021-04-02 20:58:29 +09:00
smoogipoo
d2950105fb
Add comment explaining use of lock
2021-04-02 20:31:34 +09:00
Dan Balasescu
dac8e5fdf4
Merge pull request #12265 from amberkowalski/classic-slidertail
...
Add classic mod setting to always play slider tail samples
2021-04-02 19:45:21 +09:00
Dan Balasescu
143b8c422c
Merge pull request #12259 from frenzibyte/fix-ruleset-file-loading
...
Guard against same ruleset file with filenames of loaded assembly location instead
2021-04-02 19:21:33 +09:00
smoogipoo
9c3d15171c
Reword xmldoc slightly
2021-04-02 18:00:28 +09:00
Amber
5ac36a2462
Switch AlwaysPlaySample to SamplePlaysOnlyOnHit in DrawableSliderTail for conformity
2021-04-02 03:56:23 -05:00
Amber
48e9985782
Make "AlwaysPlayTailSample" a mod setting rather than a hardcoded constant.
2021-04-02 03:10:28 -05:00
Dean Herbert
45d16fb916
Rename event parameter for clarity
2021-04-02 16:56:47 +09:00
Amber
5063cd957f
Force hit sample to play when Classic mod is enabled
2021-04-02 02:54:35 -05:00
Dean Herbert
c564f6b8ec
Merge pull request #12262 from smoogipoo/add-score-export
...
Add dropdown option to export score
2021-04-02 15:28:53 +09:00
Dean Herbert
6d4d574a65
Fix exported replay filenames not having full metadata
2021-04-02 14:10:25 +09:00
smoogipoo
e1aa927827
Add dropdown option to export score
2021-04-02 13:20:15 +09:00
Salman Ahmed
5b1dc7d2b4
Remove unused using directive
2021-04-02 02:45:26 +03:00
Salman Ahmed
fcd56dba44
Guard against same ruleset file with loaded assembly filenames instead
2021-04-02 02:12:25 +03:00
Dean Herbert
133c529b2d
Merge pull request #12255 from ppy/dependabot/nuget/Microsoft.NET.Test.Sdk-16.9.4
...
Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
2021-04-02 04:11:14 +09:00
Naxess
8621a6b4fe
Add margin to large segment test
...
Test ran fine on my end, but apparently not on the CI. This should make results a bit more consistent, hopefully.
2021-04-01 20:34:04 +02:00
dependabot-preview[bot]
6a286c5e21
Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.9.1 to 16.9.4.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.1...v16.9.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-04-01 17:16:02 +00:00
Naxess
b8479a979f
Remove unused blueprint variable
2021-04-01 18:06:12 +02:00
Naxess
7e47922fb7
Merge branch 'master' into circular-arc-freeze
2021-04-01 17:09:45 +02:00
smoogipoo
c3c7c18549
Fix tests
2021-04-01 23:48:26 +09:00
smoogipoo
9bc2a486e0
Make SoloSpectator use the new SpectatorScreen class
2021-04-01 22:10:17 +09:00
smoogipoo
9e95441aa6
Rename Spectator -> SoloSpectator
2021-04-01 22:08:52 +09:00
smoogipoo
af478fb2eb
Add abstract spectator screen class
2021-04-01 22:02:32 +09:00
Naxess
25afae5671
Fix broken test case
...
Seems this technically works, but only because of the edge case of being entirely linear, which the framework catches.
This fixes that.
2021-03-31 20:48:17 +02:00
Naxess
7b684339ed
Undo public -> internal for PathControlPoint.Changed
...
No longer used.
2021-03-31 20:32:49 +02:00
Naxess
5022a78e80
Check current point instead of start point
...
Since each control point will call this when the path updates, the previous would correct the start segment 3 times instead of just once.
This fixes that.
2021-03-31 20:25:46 +02:00
Naxess
75b8f2535f
Move updatePathTypes to PathControlPointPiece
...
Here we produce a local bound copy of the path version, and bind it to update the path type.
This way, if the path version updates (i.e. any control point changes type or position), we check that all control points have a well-defined path.
Additionally, if the control point piece is disposed of, the GB should also swoop up the subscription because of the local bound copy.
2021-03-31 20:09:56 +02:00
Naxess
1718084dbc
Update/remove determinant tests
...
We now only change the path type based on the bounding box.
If the control points are too linear, the framework now handles the fallback to Bezier.
2021-03-31 20:08:39 +02:00
Dan Balasescu
f6f1ef6986
Merge pull request #12220 from peppy/editor-fix-speed-multiplier-precision
...
Fix legacy control point precision having an adverse effect on the editor
2021-03-31 18:00:11 +09:00
Dan Balasescu
f8c1dfe57f
Merge branch 'master' into editor-fix-speed-multiplier-precision
2021-03-31 17:17:25 +09:00
Dan Balasescu
ef1f133fb1
Merge pull request #12238 from peppy/fix-mass-drag-drop-imports
...
Group large drag drop imports into a single operation
2021-03-31 16:15:26 +09:00
