9 Commits

• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Refactor exposed mod retrieval methods for better safety
  Dean Herbert · 2021-09-10 11:09:13 +09:00
  cf633973a9
• Remove empty <returns> xmldoc
  Dean Herbert · 2021-04-12 17:46:14 +09:00
  b5954a55ad
• Add base method for testing conversion in other direction
  Bartłomiej Dach · 2020-11-15 14:48:23 +01:00
  8b74298567
• Rename existing method to allow for new one
  Bartłomiej Dach · 2020-11-15 14:17:41 +01:00
  9899687bfe
• Add helper method to convert to legacy mods enums
  Dean Herbert · 2020-03-24 13:07:51 +09:00
  546772192c
• Fix PF/SD legacy mod conversion

  Upon investigating an user report in #6091 that indicated that viewing
  replays using the Perfect mod would also display the Sudden Death mod
  icon despite Perfect being the more restrictive of the two, it turned
  out that the logic of importing legacy scores was missing that corner
  case. A similar case of Double Time/Nightcore mutual exclusion was
  handled, but PF/SD was missed.
  
  Add analogous handling of PF/SD legacy mods for all four rulesets,
  and additionally cover a tiny fraction of all cases with unit tests.
  The most problematic cases (NC+HD and PF+SD) are covered in all four
  basic rulesets.

  Bartłomiej Dach · 2019-09-15 22:55:25 +02:00
  a407e267a2