94 Commits

• Avoid recomputing full path vertices in SliderPath when possible (#36285)

  In some cases `SliderPath.GetPathToProgress` used to compute the whole
  path when it can be not needed since it can be already stored inside
  `calculatedPath` list.
  Also some of these use cases will no longer require additional array
  wheen only readonly access is all we need.

  Andrei Zavatski · 2026-04-17 21:35:27 +09:00
  b36f8f9c47
• Fix edge case allowing almost-zero-length sliders to be placed during distance snapping
  Dean Herbert · 2025-03-11 16:17:44 +09:00
  23891b1994
• Updated comments
  Aurelian · 2024-05-31 08:20:19 +02:00
  9111da81d2
• Reduced subpoints limit to be a more practical value
  Aurelian · 2024-05-29 09:39:46 +02:00
  542809a748
• Added check for infinite subpoints for PerfectCurve
  Aurelian · 2024-05-27 20:32:18 +02:00
  6c4def1c09
• Reworked linear line check, and optimized scaled flat slider test
  Aurelian · 2024-05-24 14:05:56 +02:00
  b2c4e0e951
• Addressed code quality issues
  Aurelian · 2024-05-24 09:30:24 +02:00
  fff52be59a
• Nearly straight sliders are treated as linear
  Aurelian · 2024-05-24 08:26:17 +02:00
  d948e0fc5c
• Only optimise Catmull segments in osu ruleset
  Dan Balasescu · 2024-04-01 17:22:50 +09:00
  4806ea54f1
• Fix bulbs on Catmull sliders
  Dan Balasescu · 2024-03-27 04:05:04 +09:00
  600098d845
• Reduce allocations during beatmap selection
  Andrei Zavatski · 2024-02-17 15:46:38 +03:00
  22f5a66c02
• fix near-zero length sliders n stuff being placeable
  OliBomby · 2023-12-19 21:20:21 +01:00
  ec578e1d9f
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18
• Add free-hand drawing of sliders to the editor
  cs · 2023-11-11 13:33:25 +01:00
  3f85aa79c5
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Check if path lists are empty
  Magnus-Cosmos · 2023-09-19 02:28:28 -04:00
  73db68a49a
• Fix slider path calculations for edge cases
  Magnus-Cosmos · 2023-09-19 01:31:26 -04:00
  a9b45c6fdc
• Fix extension check using control points instead of path points
  Magnus-Cosmos · 2023-09-18 11:40:00 -04:00
  83584519e6
• Reformat xmldoc
  Bartłomiej Dach · 2023-08-21 08:29:51 +02:00
  dd1ac461db
• expand xmldoc
  OliBomby · 2023-08-19 19:39:29 +02:00
  56b1062c2f
• Add braces for clarification

  I like no-braces for single-line ifs as much as anyone, but with inline
  comments involved it gets rather dicey.

  Bartłomiej Dach · 2023-08-19 14:34:20 +02:00
  0a55830c16
• fix GetSegmentEnds
  OliBomby · 2023-08-18 12:20:40 +02:00
  ff07fbae15
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Merge pull request #21559 from OliBomby/stream-tool-1

  Add segment end completions list to SliderPath

  Dean Herbert · 2023-01-11 15:31:04 +09:00
  d1ca4ebd40
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Fix segmentEnds incorrect on shortened paths
  OliBomby · 2022-12-07 09:52:09 +01:00
  98a312ca96
• Add segmend end completions to SliderPath
  OliBomby · 2022-12-07 09:51:22 +01:00
  cd46ca31f9
• Remove unnecessary null casts
  Dean Herbert · 2022-06-24 14:50:11 +09:00
  f71f6302fd
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Fix slider paths being extended even when the last two points are equal
  Dean Herbert · 2021-10-26 15:47:59 +09:00
  81fee02c2b
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Centralise length validation function
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  d38e294d96
• Remove empty <returns> xmldoc
  Dean Herbert · 2021-04-12 17:46:14 +09:00
  b5954a55ad
• Move path type correction

  This is better because `PathControlPointVisualizer` is local to the editor, meaning there is no chance that this could affect gameplay.

  Naxess · 2021-03-24 03:02:19 +01:00
  4ae3eaaac6
• Fix inverted return statement

  Forgot to run tests, all passing now.

  Naxess · 2021-03-22 19:48:21 +01:00
  e922e67c98
• Add method documentation
  Naxess · 2021-03-22 19:42:27 +01:00
  3fa5852e00
• Separate condition logic from math logic
  Naxess · 2021-03-22 19:41:48 +01:00
  b11fd7972a
• Improve fallback conditions

  It's possible to create a `PerfectCurve` type path with more than 3 points currently, so this accounts for that.

  Naxess · 2021-03-22 19:10:56 +01:00
  92f713a30e
• Invert if statement
  Naxess · 2021-03-22 19:09:28 +01:00
  80e7c3aba7
• Fix missing newline
  Naxess · 2021-03-22 19:03:55 +01:00
  6911a1b415
• Fix null checks
  Naxess · 2021-03-22 17:32:55 +01:00
  a7076c329c
• Fix newlines/spaces
  Naxess · 2021-03-22 17:32:40 +01:00
  323b875cea
• Add path type update logic

  Only attempts to change points to bezier if points in the slider are modified.

  Naxess · 2021-03-22 15:57:57 +01:00
  c82218627f
• Add PointsInSegment method
  Naxess · 2021-03-22 15:55:30 +01:00
  7a2cb526e4
• Undo subpath limiting
  Naxess · 2021-03-22 15:54:33 +01:00
  bee2f55d00
• Fix freeze due to large circular arc radius

  Seems to stem from the osu!framework's PathApproximator not catching a few edge cases wherein the radius approaches infinity.

  Naxess · 2021-03-21 06:34:55 +01:00
  fcd1f4930f
• Fix SliderPath not handling Clear correctly
  Dean Herbert · 2020-10-09 06:31:59 +09:00
  eacc7dca9a
• Fix accessing incorrect items list in event
  Dean Herbert · 2020-02-18 19:00:02 +09:00
  a1bfb18ce0
• Update with framework-side bindable list changes
  smoogipoo · 2020-02-17 15:06:14 +09:00
  958c891d15