osu-lazer

Add already existing localisation support from CommonStrings (#37401 )

decided to do this mostly because of the non-localised `BackButton` that
was bothering my eyes

changes can be reviewed commit by commit

Denis Titovets · 2026-05-07 00:07:28 +09:00

b8729cb7fd

Allow reporting users from their profile page (#36335 )

This PR refactors the report popover to have an optional confirmation
message after completing the request. This was initially meant for
#32584, but then I realized I can first test it out on the user
profiles, so I've implemented it here as well. Can be reviewed commit by
commit.



https://github.com/user-attachments/assets/cd59c560-c824-4a5e-bab6-5ecbf5125af1

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Krzysztof Gutkowski · 2026-05-05 19:49:24 +09:00

2006485d60

Update editor icons (#37201 )

Brings in new fresh icons for the toolbox (select, hitcircle, slider,
spinner, grid) and toggles (new combo, whistle, finish, clap,
grid/distance snap).

Depends on https://github.com/ppy/osu-resources/pull/416.

| Before | After |
|--------|--------|
| <img width="300" height="897" alt="image"
src="https://github.com/user-attachments/assets/279ea162-c3e2-4312-a0a2-39ad08df16f9"
/> | <img width="304" height="889" alt="image"
src="https://github.com/user-attachments/assets/aab2a143-0e6b-45c1-bf84-8998c12bd960"
/> |

Krzysztof Gutkowski · 2026-04-10 20:27:21 +09:00

3e6233072c

Add ability to search for users (#37225 )

This was a private request for roundtable event usage. It’s also a
common feature request, so I decided to spend a bit of time getting this
working well-enough.


https://github.com/user-attachments/assets/acceb57f-2979-43d0-9fc2-33e977bd2dd5


---

### Delay loading spinner / loading layer initial load briefly to avoid
flickering

There's cases in this overlay where loading takes a few milliseconds.
The loading spinner gets annoying. This also happens elsewhere, so this
could be considered a global fix. Separate PR? probably...

### Ingest loading state of dashboard child content to show more correct
loading layer

Each display had their own loading layer implementation, but this is
already too deep (inside the scroll content) and doesn't display great
when for instance, results don't take up the full screen height.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-04-07 14:14:49 +02:00

c570db6c40

Ranked play general UI/UX fixes (#37220 )

Dean Herbert · 2026-04-07 15:33:29 +09:00

e80e5f37ec

Fix song select dropdowns not being navigable with keyboard (#37158 )

- Closes https://github.com/ppy/osu/issues/31684

Uses the global action variant of up and down for dropdown menus. It is
already used in multiplayer/playlist room/beatmap navigation and
gameplay menu overlays.

Comment wording is derived from:

https://github.com/ppy/osu/blob/fc817627e56b7db1c46e2f00fc9a3bd14af51211/osu.Game/Graphics/UserInterface/FocusedTextBox.cs#L73-L74

Joseph Madamba · 2026-04-01 20:59:47 +09:00

556be552c3

Fix editor not showing beatmap background in some cases

Dean Herbert · 2026-04-01 02:03:11 +09:00

5c20254f76

Switch online play screens to new header (#37074 )

Specifically the one used on the daily challenge screen. Was bugging me
that playlists/multi have that old yellow header design used, so I've
changed it. Will probably come in handy once the footer/leaderboard
changes are in.

Also localized the headers while at it.

Multiplayer:


![osu_2026-03-23_20-03-22](https://github.com/user-attachments/assets/1f262aea-8bf9-412d-9c4a-89addd65bf38)

Playlists:


![osu_2026-03-23_20-34-18](https://github.com/user-attachments/assets/3f7d349e-7c03-4f56-8e57-1c65ae746235)

The only thing I'm wondering about is whether the detail thing
(participant count/playlist length) should be using the highlight colour
here. The old design had them be yellow, but I feel like the pink on
this one stands out too much.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Krzysztof Gutkowski · 2026-03-25 16:36:18 +09:00

86ef145f56

Fix editor background taking too long to load with certain storyboards (#37038 )

TL;DR the clock was being set too late, causing more transforms to be
created than necessary.

This solves the issue by way of a refactor (sorry). Overall this should
simplify handling of things as more of the logic is shared with the
known good-state `BeatmapBackgroundWithStoryboard`.

I did try without a refactor (just delaying the creation until the clock
arrives) but this version made more sense because background generally
expect to do their main load in BDL to aid in smooth transitions. And we
can't get the clock by there. (although arguably we could just use a
similar method to `BeatmapBackgroundWithStoryboard` and forego using the
editor clock).

Of note, I removed the black background overdraw hack. There are edge
cases where it will lead to weird transitions, but these are far and few
between. Basically you need a storyboard which sets the flag to hide the
beatmap background and has transparency in it. This is no longer as
flagrantly bad as things used to be (which led to the inline fix) as far
as I can tell, but feel free to prove me wrong. If this is a blocker
I'll probably just add a permanent black box (which does fix this).

Closes #36875.

Dean Herbert · 2026-03-23 09:26:34 +01:00

95648a3d27

Keep any stateful dropdown menu open on click (#37021 )

Right click is a very obfuscated UX which most users won't find. This
makes more sense to the average user (probably).

Caveat: clicking away actually sends clicks to underlying UI. This is
not the case in macOS or windows (locally, same app; globally it still
sends clicks to other windows).

Coming from https://github.com/ppy/osu/discussions/36926.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-03-21 22:18:02 +09:00

1016bca280

Tooling updates (#37031 )

Most of this is as everywhere else, but there's also interesting code
inspection fixes from the InspectCode bump, so I'll talk about that a
little.

## [Fix suspicious equality in
`Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)

Inspection:
https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html

Pretty annoying to fix, nullable array types are a pain. Does look legit
though.

## [Fix `StarDifficulty` using inefficient struct
equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)

Inspection:
https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html

This is a dodgy one because there's no real sane way to define equality
on `StarDifficulty` now that it has difficulty and performance
attributes jammed into it. So I just basically shut the inspection up
with a `record` modifier and move on.

Unclear where the equality is used precisely. It's from a global
inspection. F12 is very unhelpful when trying to track down usages of
`Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
those do use equality. Maybe more than that.

## [Use `nameof` expressions to reference enum member
names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)

Inspection:
https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html

Pretty quaint.

## [Prefer using concrete values over `default` or
`new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)

Inspection:
https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html

I could see this one going both ways, but I'm kinda sold on this
inspection. Explicit is always better. Saves some allocations in the
`CancellationToken` cases as well.

## [Explicitly call `.AsEnumerable()` in some realm
usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)

Inspection:
https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html

Not fully sold on this one but it's quick and simple so might as well.

## [Simplify dictionary removal with single `.Remove()`
call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)

Inspection:
https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html

Not much to say.

Bartłomiej Dach · 2026-03-19 00:05:52 +09:00

18d4ba5874

Reuse existing triangles in Triangles background (#36951 )

As [per
comment](https://github.com/ppy/osu/pull/36943#issuecomment-4045361755).
Unfortunately I'm not able to reproduce such a big impact of triangles
using linked pr (or at all really). In my case usage was low in the
first place and went from 0.9% to 0.6% with this pr, so outside
benchmarking would be great

Improvement list:
* No more sorted list. Basic list is being used which is sorted once
after all the triangles added.
* Out-of-bounds triangles are reused rather than removed and re-added.
* On `Reset` if `AimCount` stays the same, all triangles are reused
instead of being cleared and re-added.

Andrei Zavatski · 2026-03-13 14:54:19 +09:00

2380fcd36d

Update editor hitsound icons with new designs from Adarin (#36940 )

| Before | After |
| :---: | :---: |
| <img width="584" height="672" alt="2026-03-12 00 56 58@2x"
src="https://github.com/user-attachments/assets/f1714f4d-ba78-4e41-a8f8-1a22dac01d9f"
/> | <img width="584" height="672" alt="2026-03-12 01 06 04@2x"
src="https://github.com/user-attachments/assets/4fc2d7ed-c9e0-45c7-8ff7-394d7ee2eff8"
/> |

Dean Herbert · 2026-03-12 08:03:01 +01:00

94c9f16b27

Fix song select navigation with home/end keys (#36879 )

It's a continuation of https://github.com/ppy/osu/pull/36293, but for
the home and end keys.

Now when using home or end keys, it selects respectively the first or
last item in the carousel, instead of just scrolling.

## Before: 


https://github.com/user-attachments/assets/6ab08d2f-1da4-4740-9d9e-574d7a8a10c9

## After:


https://github.com/user-attachments/assets/30bab836-0006-4830-b4e9-2d85017a15e6

Rudi Herouard · 2026-03-10 14:20:59 +09:00

14bde85263

Fix missed using statement

Dean Herbert · 2026-03-09 08:22:16 +09:00

7227afebbb

Update a few sample playback usages to use new helper method

Dean Herbert · 2026-03-07 23:39:20 +09:00

e3a0464e90

Fix LoadingLayer centering

oops.

Dean Herbert · 2026-03-07 02:51:50 +09:00

de9cf751d2

Fix loading spinner not being centered correctly (#36849 )

One of those things you can't un-see.

Closes https://github.com/ppy/osu/issues/36832.

Dean Herbert · 2026-03-06 12:11:16 +01:00

b46656e7d3

Refactor ShearedButton to allow easier relative sizing (#36802 )

This commit rearranges the contents of `ShearedButtons` to be more
independent of each other in regards to sizing. Thanks to that, the
custom logic related to enabling autosizing is no longer necessary.
Witdh and height are no longer set via the constructor, and can be
freely configured using the initializer syntax.

Additionally, this allows the button to use relative sizing without
having to resort to any hackery with `Size` (this will come in handy for
me when implementing the new footer on multiplayer screens).

Given that most of the `ShearedButton`s currently in use set their width
explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by
default previously. Instead it is set on the only two such buttons (show
converts/selected mods on ssv2). I suppose it might be a good idea to
have it set that by default if no `Width` is specified, as right now
it'll just not show anything.

Also I've set the margin on the text field by default in all cases
instead of only when autosizing like how it was previously, since
otherwise it would be a pain to set that on each button instance when
needed. I've checked all affected components and could not find any text
overflowing issues that this could cause.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Krzysztof Gutkowski · 2026-03-06 02:09:05 +09:00

b76a7e1bb6

Merge branch 'master' into song-select-v1-salute

Bartłomiej Dach · 2026-03-04 08:39:58 +01:00

f74a21c1e1

Merge pull request #36795 from peppy/carousel-scrollbar-state-capture

Fix song select carousel state capture

Bartłomiej Dach · 2026-03-03 10:40:25 +01:00

d748470754

Remove all song select v1 files

This contains no code changes (that would need review), only file
deletion and extraction where required in a few odd cases.

Dean Herbert · 2026-03-03 16:45:14 +09:00

1a8d2855d4

Fix song select carousel state capture

Closes #36776.

Dean Herbert · 2026-03-03 15:36:46 +09:00

b0759ff34d

Fix custom tooltip formats no longer displaying in settings

Closes #36793.

Dean Herbert · 2026-03-03 12:59:23 +09:00

ee9f8d5e92

Fix song select navigation with page up/down (#36293 )

Resolves #36099 

This PR fixes keyboard navigation in the beatmap select carousel for
lazer by implementing page-wise traversal with the Page Up and Page Down
keys and changing it from only scrolling to actually selecting items.

**Changes:**
- Added handling for `TraversalType.Page` in the keyboard traversal
switch.
- Implemented `traverseKeyboardPage(int direction)` method to move the
selection by approximately one "page" of visible items, accounting for
partially obscured items like the search bar. Also it does not wrap
around (like the current PageUp/Down functionality).
- Added new key bindings:
    - `PageUp` → SelectPreviousPage
    - `PageDown` → SelectNextPage

The code may be very explicit for the scroll logic with the page keys,
so I would appreciate some feedback when the PR is reviewed.
The naming of the keybinds may need to be adjusted. `Next page` and
`previous page` may be somewhat misleading.

**Behavior after the change:**
- Pressing Page Up/Down now moves the selection by a page of items.
- After navigating, pressing Left/Right selects the navigated song
instead of moving relative to the previous position.

**See:**
https://www.youtube.com/watch?v=JXmKAhhKiCc

---------

Signed-off-by: Linus Genz <linuslinuxgenz@gmail.com>
Co-authored-by: Dean Herbert <pe@ppy.sh>

Linus Genz · 2026-03-02 02:08:19 +09:00

033e13cb3b

Add ability for LoadingLayer to block all keyboard input

Dean Herbert · 2026-02-18 20:01:38 +09:00

83587e2265

Fix revert to default button not resizing correctly after changing languages

Closes #36519.

Dean Herbert · 2026-02-03 18:17:53 +09:00

b8b6327624

Add localisation support for DirectorySelector (#36371 )

- depends on https://github.com/ppy/osu-framework/pull/6700
- closes https://github.com/ppy/osu/issues/36340
- supersedes and closes https://github.com/ppy/osu/pull/36352

<img width="676" height="451" alt="image"
src="https://github.com/user-attachments/assets/4f11c761-175b-495a-8b24-16fb6c481a15"
/>

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Denis Titovets · 2026-01-29 19:13:02 +09:00

14d8cf7275

Fix some text boxes no longer having borders (#36526 )

Regressed in d6bf4fd90d.

One very visible instance of this regression is the login form.


https://github.com/user-attachments/assets/5ba10ac5-4cb1-49af-b55c-89cf58ca0b44

The `CommentEditor` usage was discovered with one of my favourite tricks
which is doing

```diff
diff --git a/osu.Game/Graphics/UserInterface/OsuTextBox.cs b/osu.Game/Graphics/UserInterface/OsuTextBox.cs
index fefe776b01..c17cca726b 100644
--- a/osu.Game/Graphics/UserInterface/OsuTextBox.cs
+++ b/osu.Game/Graphics/UserInterface/OsuTextBox.cs
@@ -42,6 +42,12 @@ public partial class OsuTextBox : BasicTextBox
             Margin = new MarginPadding { Left = 2 },
         };
 
+        public new bool Masking
+        {
+            get => base.Masking;
+            set => base.Masking = value;
+        }
+
         protected bool DrawBorder { get; init; } = true;
 
         private OsuCaret? caret;

```

and then looking for usages of the setter. That's all due diligence
you're getting here, I'm not auditing every single text box in the game.

And yes, the `CommentEditor` usage is OMEGA dodgy but the change applied
here is the only one that preserves its visual appearance. I'm not
putting in time to fix it.

Bartłomiej Dach · 2026-01-29 19:11:10 +09:00

7d476b4b7c

Fix FormCheckbox playing sounds twice

This removes the disabled sound, but I think that's fine. If we want
that, it should be handled by `HoverClickSounds` (which I'm currently
intentionally not using because it can be a bit noisy).

Closes #36503.

Dean Herbert · 2026-01-28 16:55:43 +09:00

7b7777bb56

Fix dropdown margins and animations being weird

This was attempted to be fixed by frenzibyte using some hack workaround
logic, but this is the true fix.

Things were never matching due to `UpdateSize` spamming `Resize`
transforms every frame, causing the fade out to complete before
transforms have reached a final state.

Dean Herbert · 2026-01-28 14:22:41 +09:00

6bdb0e1cbb

Remove workaround for dropdowns animating weirdly

Dean Herbert · 2026-01-28 14:22:31 +09:00

0d3b7ab6be

Use enum for background states

Dean Herbert · 2026-01-27 18:58:03 +09:00

fa22d1f202

Fix mismatching spacing in dropdown form menus

Dean Herbert · 2026-01-27 18:49:53 +09:00

b5e93b98c9

Fix border showing for inner text boxes incorrectly

I turned masking back on on these for better visuals (text masking
aligns with rest of elements) but turns out this implicitly makes
borders draw.

Dean Herbert · 2026-01-27 18:36:37 +09:00

d6bf4fd90d

Standardise hover sounds for form elements

Closes #36444.

Dean Herbert · 2026-01-27 17:06:14 +09:00

dba17b1fa6

Standardise animations

Dean Herbert · 2026-01-27 17:06:13 +09:00

42dc73d849

Various metrics and visual tweaks

Dean Herbert · 2026-01-27 17:06:13 +09:00

6983227240

Make switch buttons look more like old version

Dean Herbert · 2026-01-27 17:06:11 +09:00

1c537a3278

Standardise background across form controls

Dean Herbert · 2026-01-27 17:06:11 +09:00

c88f10ca1b

Increase size of caption text

Dean Herbert · 2026-01-27 03:04:45 +09:00

7fef2ce1de

Remove enabled/disabled text from FormCheckbox

Dean Herbert · 2026-01-27 03:04:45 +09:00

9a5fd0addb

Adjust tooltip response speed and avoid using per-frame transforms

Dean Herbert · 2026-01-27 03:04:45 +09:00

9c0b1a4914

Work around flaky TestSceneFirstRunSetupOverlay tests

See inline commentary. I don't really have any energy left to provide
anything else, other than maybe a demonstration of how this dies in
framework:

diff --git a/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs b/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs
new file mode 100644
index 000000000..c74ce6636
--- /dev/null
+++ b/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs
@@ -0,0 +1,59 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using NUnit.Framework;
+using osu.Framework.Allocation;
+using osu.Framework.Graphics.UserInterface;
+using osu.Framework.Screens;
+
+namespace osu.Framework.Tests.Visual.UserInterface
+{
+    public partial class TestSceneScreenStackUnbindOnExit : FrameworkTestScene
+    {
+        [Cached]
+        private ScreenStack screenStack = new ScreenStack();
+
+        [Test]
+        public void TestScreenExitUnbindDoesNotInterruptLoadComplete()
+        {
+            AddStep("set up the scenario", () =>
+            {
+                Child = screenStack;
+                screenStack.Push(new Screen());
+                screenStack.Push(new BrokenScreen());
+            });
+            AddUntilStep("wait to get to target screen", () => screenStack.CurrentScreen, Is.InstanceOf<Screen>);
+        }
+
+        private partial class BrokenSlider : BasicSliderBar<float>
+        {
+            [Resolved]
+            private ScreenStack screenStack { get; set; } = null!;
+
+            protected override void LoadComplete()
+            {
+                // exiting the current screen provokes the behaviour of unbinding all bindables in the screen's subtree
+                screenStack.CurrentScreen.Exit();
+
+                // ...but the following calls should still take correct effect inside `SliderBar`
+                // (namely one consisting of propagating `{Min,Max}Value` into `currentNumberInstantaneous`)
+                // so that it doesn't have its internal invariants violated
+                CurrentNumber.MinValue = -10;
+                CurrentNumber.MaxValue = 10;
+
+                // this notably calls `Scheduler.AddOnce(updateValue)` inside, which will happen *in the imminent future, in the same frame as `LoadComplete()` here.
+                // if the above mutations of `{Min,Max}Value` don't correctly propagate inside the slider bar due to an overly eager unbind, this will cause a crash.
+                base.LoadComplete();
+            }
+        }
+
+        private partial class BrokenScreen : Screen
+        {
+            [BackgroundDependencyLoader]
+            private void load()
+            {
+                InternalChild = new BrokenSlider();
+            }
+        }
+    }
+}

I attempted to address what I perceive to be the root issue here which
is that `ScreenStack` is allowed to arbitrarily unbind bindables under
drawables which are by all means still in the scene graph. The attempt
consisted of scheduling the unbind until after children of the screen
stack, but that caused 150 game-side tests to fail, seemingly on
something relevant to bindable leases, so I give up.

Bartłomiej Dach · 2026-01-23 13:07:42 +01:00

b7559f93f2

Fix broken percentage formatting in form slider bars

closes https://github.com/ppy/osu/issues/36428

this one's my bad:
https://github.com/ppy/osu/pull/36195#discussion_r2698388405

Bartłomiej Dach · 2026-01-23 08:01:41 +01:00

225f4d8814

Add failing tests

Bartłomiej Dach · 2026-01-23 07:50:20 +01:00

d80934c344

Merge branch 'master' into new-settings/overlay

Dean Herbert · 2026-01-22 18:38:17 +09:00

42302c45ec

Fix carousel items becoming incorrectly selected due to bindable leakage (#36414 )

As discussed in discord. Fixed from multiple angles.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-01-22 01:06:40 +09:00

10dc1314f6

Improve input handling in percentage-based slider bars (#36195 )

Reported in
https://github.com/ppy/osu/pull/36193#issuecomment-3703406223.

Preview:


https://github.com/user-attachments/assets/ac2b86cf-ad92-496b-b3dd-19ad47753a9b

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Salman Alshamrani · 2026-01-17 16:39:28 +09:00

676b7a36da

Fix form dropdown open animation not being smooth (#36358 )

Preview:


https://github.com/user-attachments/assets/07cb58b7-5980-4fed-bb4c-2443ba1e9635

Salman Alshamrani · 2026-01-17 02:54:12 +09:00

b5a989d31e

3756 Commits