39 Commits

• Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646)

  Fixes a bug that allowed for selecting the same mod twice in multiplayer
  if the playlist entry has non-default settings for a required mod.
  This happens due to a strict equality mod check in the mod set
  compatibility check function, which only considers mods duplicates if
  their settings are exactly the same. Replacing with a more lenient
  `Type` check fixes this.
  
  Adds a regression test for this behavior
  
  Fixes https://github.com/ppy/osu/issues/37625.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  triacontakai · 2026-05-07 08:59:54 +02:00
  3f5c113394
• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Remove test warning

  It does more bad than good at this stage.

  Bartłomiej Dach · 2025-07-03 14:29:42 +02:00
  f613e78b75
• Make test fail
  Bartłomiej Dach · 2025-07-03 14:26:30 +02:00
  8a5ca85b10
• Adjust test cases to pass
  Bartłomiej Dach · 2025-06-05 15:01:26 +02:00
  e3259f7a7f
• Add failing test
  Bartłomiej Dach · 2025-06-05 14:41:57 +02:00
  e335704c83
• Reorder function parameters, hopefully improve documentation
  Dan Balasescu · 2025-04-17 19:12:13 +09:00
  f0a8ddd513
• Apply changes from reviews
  Dan Balasescu · 2025-04-17 02:19:31 +09:00
  64aafa4e4c
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Only apply freestyle validation to required mods
  Dan Balasescu · 2025-04-14 19:34:21 +09:00
  b4c7d7f498
• Update test with stricter assertions
  Dan Balasescu · 2025-04-10 13:04:40 +09:00
  69630263a8
• Merge mod validity checks to closer match osu!web
  Dan Balasescu · 2025-04-10 13:02:25 +09:00
  05e70cd938
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Add helper for testing mod/freemod validity
  Dan Balasescu · 2025-02-05 16:44:52 +09:00
  7f8f528ae2
• Add test cases for helper method
  Salman Ahmed · 2024-01-16 14:27:24 +03:00
  2935bd4809
• Add a bit more test coverage
  Dean Herbert · 2024-01-04 18:02:37 +09:00
  fc1a2c594c
• Add Test: floating point errors
  CaffeeLake · 2024-01-03 20:17:05 +09:00
  4312e9e9a9
• Add test coverage
  Salman Ahmed · 2023-12-31 05:18:10 +03:00
  cd9250d08c
• Fix test failures
  Bartłomiej Dach · 2023-11-02 21:24:58 +01:00
  ef555ed0cf
• Change ruleset mod description types
  naoei · 2022-08-10 16:09:11 -04:00
  3e38baca3c
• Use array.empty instead of null value.
  為什麼 · 2022-07-19 20:39:41 +08:00
  2a83404dbe
• Remove the nullable disable annotation in the test project and fix the api broken.
  為什麼 · 2022-07-19 20:39:41 +08:00
  d9addebc93
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Bring back separate bool properties as non-cascading
  Salman Ahmed · 2022-05-05 14:37:38 +03:00
  8501a41619
• Add test coverage for multiplayer mod validity methods
  Salman Ahmed · 2022-05-05 08:13:29 +03:00
  86aa2125fe
• Bring back behaviour of checking incompatibility on gameplay validity
  Salman Ahmed · 2022-05-04 17:21:19 +03:00
  8f04db5df5
• Fix failing test scenes
  Salman Ahmed · 2022-03-20 16:17:19 +03:00
  145fca2704
• Fix incorrect existing test case
  Dean Herbert · 2021-06-22 17:41:27 +09:00
  6e0801b852
• Ensure duplicate mods cannot be defined
  Dean Herbert · 2021-06-22 17:41:20 +09:00
  c4fde635c6
• Change CheckCompatibleSet to never deselect the current candidat when checking incompatibility
  Dean Herbert · 2021-06-18 13:17:32 +09:00
  5933e0d2d9
• Use conditional nullability attribute

  As it turns out, C# 8 provides an attribute that allows annotating that
  an `out` parameter's nullability depends on the method's return value,
  which is exactly what is desired here.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  c9facf70f9
• Remove unused using statement
  Dean Herbert · 2021-02-02 19:22:13 +09:00
  8e70a50af0
• Use TestCaseSource and add multi-mod test
  smoogipoo · 2021-02-02 18:51:13 +09:00
  0a9861d0ab
• Merge branch 'add-mod-utils' into mod-consistency-function
  smoogipoo · 2021-02-02 18:41:35 +09:00
  5881b8be96
• Make more tests use the custom mod classes

  For safety purposes... In implementing the previous tests, I found that
  using mod.Object.GetType() can lead to bad assertions since the same
  ModProxy class is used for all mocked classes.

  smoogipoo · 2021-02-02 18:33:14 +09:00
  9955e02898
• Fix incorrect handling of multi-mod incompatibilities
  smoogipoo · 2021-02-02 18:31:08 +09:00
  1df412a03c
• Add failing tests
  smoogipoo · 2021-02-02 18:01:33 +09:00
  7c29386717
• Add basic test coverage of CheckValidForGameplay function
  Dean Herbert · 2021-02-02 14:13:50 +09:00
  80d88024d6
• Add ModUtils class for validating mod usages
  smoogipoo · 2021-02-01 19:37:24 +09:00
  b9832c1b2d