1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-07 20:47:26 +08:00
Commit Graph

36871 Commits

Author SHA1 Message Date
Dean Herbert
435c85a2e7 Avoid executing selection twice on ModSelectOverlay load 2021-02-10 15:13:09 +09:00
Dean Herbert
a39263423c Fix externally changed settings from being reset when ModSelectOverlay is initialised 2021-02-10 15:12:29 +09:00
Dean Herbert
75bc9f607e Rename wrongly named method 2021-02-10 14:55:15 +09:00
Dean Herbert
de8a60435f Add failing test covering reported breaking case 2021-02-10 14:44:37 +09:00
Dean Herbert
52f0f3f3b2 Add a note about SelectedMods behavioural quirks 2021-02-10 14:38:15 +09:00
Dean Herbert
e9ef4aaf88 Add test covering expectations of external mod changes 2021-02-10 14:34:45 +09:00
Dan Balasescu
d91e17542a
Merge pull request #11718 from EVAST9919/overlay-header-fix
Fix incorrect header depth in OnlineOverlay
2021-02-10 12:58:48 +09:00
Dean Herbert
e44667e5e0
Use MinValue instead
Co-authored-by: Salman Ahmed <slmanarendo1950@gmail.com>
2021-02-10 11:31:34 +09:00
Andrei Zavatski
d9dcf8a042 Fix incorrect header depth in OnlineOverlay 2021-02-09 20:30:31 +03:00
Dean Herbert
60cf89b366
Merge pull request #11530 from frenzibyte/user-beatmap-downloading-states-2
Add UI state display for multiplayer client's beatmap availability
2021-02-10 01:30:08 +09:00
Dan Balasescu
92599aa02b
Merge branch 'master' into user-beatmap-downloading-states-2 2021-02-09 21:06:09 +09:00
Dan Balasescu
15b3747945
Merge pull request #11716 from peppy/defer-playlist-load
Defer playlist load to improve load time of the now playing overlay
2021-02-09 20:59:51 +09:00
Dan Balasescu
8c56976ab8
Merge pull request #11712 from peppy/fix-autopilot-touch-device
Fix AutoPilot mod failing to block touch input
2021-02-09 20:46:40 +09:00
Dean Herbert
6f2630d906
Merge pull request #11527 from EVAST9919/overlay-header-refactor
Implement OnlineOverlay component
2021-02-09 19:50:51 +09:00
Dean Herbert
d8d830db6e Defer playlist load to improve load time of the now playing overlay 2021-02-09 19:46:57 +09:00
Dean Herbert
0a96f4d403 Avoid assigning null to a non-nullable property 2021-02-09 18:56:27 +09:00
Dean Herbert
17475e60b0 Fix missed test scene update 2021-02-09 18:48:50 +09:00
Dean Herbert
1670766633 Avoid unbinding external events 2021-02-09 18:42:15 +09:00
Dean Herbert
178d88bcf1 Change BackgroundColour into a property 2021-02-09 18:32:44 +09:00
Dean Herbert
b5fa950800 Remove unnecessary depth specification 2021-02-09 18:30:05 +09:00
Dean Herbert
3206c7cbae
Merge branch 'master' into overlay-header-refactor 2021-02-09 18:20:07 +09:00
Dean Herbert
4e3bb27cd5
Merge branch 'master' into fix-mod-settings-fuckery 2021-02-09 16:47:39 +09:00
Dean Herbert
1cb51fa8d2
Merge branch 'master' into autoplay-rate-independence 2021-02-09 16:05:34 +09:00
Dean Herbert
04c243386b Fix initial state transfer regressing 2021-02-09 16:02:56 +09:00
Dean Herbert
b87327841d Add test covering initial state propagation 2021-02-09 15:46:23 +09:00
Dean Herbert
695e46a358 Fix AutoPilot mod failing to block touch input 2021-02-09 15:31:55 +09:00
Dean Herbert
b96a594546 Remove unnecessary initial call to HitObjectApplied bound method
Was causing test failures. Looks to be unnecessary on a check of when
HitObjectApplied is invoked.
2021-02-09 15:11:59 +09:00
Dean Herbert
0efad9ded1 Add test coverage of setting reset on deselection 2021-02-09 13:54:13 +09:00
Dean Herbert
8204d360a8 Always reset local user settings when a mod is deselected in ModSelectOverlay 2021-02-09 13:44:42 +09:00
Dean Herbert
be379e0e3c Change CopyFrom to always overwrite all settings with incoming values 2021-02-09 13:44:11 +09:00
Dean Herbert
3133ccacfa Reset selected mods between each test method
This doesn't actually fix or change behaviour, but does seem like
something we probably want to do here.
2021-02-09 13:09:40 +09:00
Dan Balasescu
a886000fbf
Merge pull request #11707 from Joehuu/effect-attribute-tooltip-whitespace
Fix editor effect attribute tooltip having unnecessary whitespace when only one is enabled
2021-02-09 12:32:55 +09:00
smoogipoo
3ce605b5e5 Small refactoring to use .Trim() instead 2021-02-09 12:00:03 +09:00
Joehu
414e05affd Fix editor effect attribute tooltip having unnecessary whitespace when only one is enabled 2021-02-08 10:16:16 -08:00
Dean Herbert
9bf4f04339
Merge branch 'master' into classic-mode-flags 2021-02-09 01:13:15 +09:00
Dean Herbert
75bd28eea1
Merge pull request #11679 from smoogipoo/hit-policy-refactor
Refactor osu! ruleset hit policies for extensibility
2021-02-09 01:12:49 +09:00
Dean Herbert
b2b55ccc22
Merge branch 'master' into hit-policy-refactor 2021-02-09 00:22:26 +09:00
Dean Herbert
2cac373365
Merge pull request #11706 from smoogipoo/fix-failing-test
Fix failing test
2021-02-08 20:57:38 +09:00
Dean Herbert
4d42e0792a
Merge pull request #11705 from smoogipoo/fix-missing-using
Fix missing using
2021-02-08 20:57:21 +09:00
smoogipoo
7021d1dfdc Merge branch 'hit-policy-refactor' into classic-mode-flags 2021-02-08 20:12:33 +09:00
smoogipoo
f4a31287bf Add/use IHitObjectContainer interface instead of IEnumerables 2021-02-08 20:11:06 +09:00
Dean Herbert
0dd1b1026c
Merge pull request #11495 from smoogipoo/more-accurate-most-common-bpm
Make most common BPM more accurate
2021-02-08 20:08:58 +09:00
Dean Herbert
156f5bd5df
Add newline between statements 2021-02-08 20:05:16 +09:00
smoogipoo
19368f87fb Fix failing test 2021-02-08 19:59:07 +09:00
smoogipoo
d8c53e34ae Fix missing using 2021-02-08 19:42:17 +09:00
Dan Balasescu
7bc6010d90
Merge pull request #11703 from Joehuu/fix-timing-editor-attribute-column
Fix attributes header not being aligned with content in editor timing mode
2021-02-08 19:38:59 +09:00
Dean Herbert
5fbed05d04
Merge pull request #11551 from smoogipoo/fix-leave-room-race-2
Fix client potentially not leaving a room on exiting multiplayer
2021-02-08 19:23:14 +09:00
smoogipoo
a08c51f213 Remove duplicate code 2021-02-08 19:23:10 +09:00
Lucas A
f0dfa9f8f3 Use the newest config file available (where the local username matches the filename) 2021-02-08 11:12:25 +01:00
smoogipoo
6e34e7d750 Merge branch 'master' into user-beatmap-downloading-states-2 2021-02-08 19:08:53 +09:00