45 Commits

• Unify order of displaying map attributes on mod overlay with SongSelectV2
  Bartłomiej Dach · 2025-05-29 11:28:11 +02:00
  b20139e9dd
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Highlight diff attribute changes in mod select
  Zihad · 2025-03-13 17:50:14 +06:00
  17b17f4d71
• Fix beatmap attributes display in mod select recreating star difficulty bindable every setting change
  Salman Ahmed · 2024-07-19 03:25:26 +03:00
  2ad8eeb918
• Fix code quality and null handling
  Dean Herbert · 2024-06-07 00:01:50 +08:00
  dd3f4bcdab
• Creating method in ModUtils to calculate the rate for the song
  Xesquim · 2024-06-06 10:06:07 -03:00
  860afb8123
• Move SHEAR constant to OsuGame and revert back to 0.2x (i.e. master)

  Discussed in [discord](https://discord.com/channels/188630481301012481/188630652340404224/1240490608934653984).

  Salman Ahmed · 2024-05-16 07:28:02 +03:00
  310b4d90cc
• Bring back mod setting tracker in BeatmapAttributesDisplay
  Salman Ahmed · 2024-02-26 22:24:45 +03:00
  2b73d816a7
• Fix incorrect conflict resolution
  Salman Ahmed · 2024-02-23 18:42:07 +03:00
  d4bc3090e7
• Merge branch 'master' into freemod_mapinfo_fix
  Salman Ahmed · 2024-02-23 18:34:41 +03:00
  618819ba9f
• Add test coverage
  Salman Ahmed · 2024-02-23 18:16:44 +03:00
  c1db9d7819
• Rewrite mods flow and remove RoomBeatmapAttributesDisplay
  Salman Ahmed · 2024-02-23 17:30:13 +03:00
  9ce07a96b2
• Extract common helper for BPM rounding
  Bartłomiej Dach · 2024-02-22 10:27:37 +01:00
  81a9908c60
• minor look changes
  Givikap120 · 2024-02-20 13:11:19 +02:00
  8199a49ee2
• Changed override method

  now it overrides mods getter instead of calculate fuctions

  Givikap120 · 2024-02-20 12:57:28 +02:00
  54ef397d56
• Turn BPMDisplay to RollingCounter<int>
  maromalo · 2024-02-18 19:59:56 -03:00
  5a448ce02f
• Fixed NVika code quality errors
  Givikap120 · 2024-02-18 03:28:24 +02:00
  a6b63efe7d
• Update BeatmapAttributesDisplay.cs
  Givikap120 · 2024-02-18 03:16:18 +02:00
  9070e973d3
• quality improvements
  Givikap120 · 2024-02-18 03:15:53 +02:00
  4aaf016ee0
• Update BeatmapAttributesDisplay.cs
  Givikap120 · 2024-02-18 03:14:36 +02:00
  6fb3192648
• Packed changes into separate class
  Givikap120 · 2024-02-18 03:13:57 +02:00
  2df5787dc7
• Fixed bugs and added ranked status update
  Givikap120 · 2024-02-17 23:01:31 +02:00
  ed819fde15
• Update BeatmapAttributesDisplay.cs
  Givikap120 · 2024-02-17 22:12:15 +02:00
  cd8ac6a722
• Change rolling counters to use quicker easing types
  Dean Herbert · 2024-01-17 18:18:53 +09:00
  a66ddc7813
• Change LeftContent autosize duration to match main content to reduce visual awkwards
  Dean Herbert · 2023-12-15 16:01:07 +09:00
  4357bb1040
• Fix AdjustedAttributesTooltip being broken by design

  Fixes issue described in the following comment:
  https://github.com/ppy/osu/pull/25759#issuecomment-1855954637
  
  That is just not how the tooltip system is supposed to be used.
  
  To name the individual sins:
  
  - Caching and returning a tooltip instance like the classes that used
    tooltips is incorrect. The lifetime of tooltip instances is managed by
    the tooltip container. `GetCustomTooltip()` is called by it
    exclusively. It should return a fresh instance every time.
  
  - Not putting actual data in `IHasCustomTooltip.TooltipContent` is
    wrong.
  
  - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly*
    wrong.
  
  I'm not even sure which particular combination of the above
  transgressions caused the issue as it presented itself, but at this time
  I frankly do not care.

  Bartłomiej Dach · 2023-12-14 16:15:56 +01:00
  9e5b6b97ff
• change the order of attributes

  + simplifying the bug fix

  Givikap120 · 2023-12-14 14:31:19 +02:00
  c2373bb37b
• Refactor everything for sanity
  Dean Herbert · 2023-12-13 17:33:39 +09:00
  5062c53e36
• Update BeatmapAttributesDisplay.cs
  Givikap120 · 2023-12-10 00:42:02 +02:00
  78cdedf34d
• fixed test errors
  Givikap120 · 2023-12-10 00:40:05 +02:00
  1d0c37e138
• Made custom tooltip
  Givikap120 · 2023-11-23 23:30:18 +02:00
  c2a44cf118
• Rename method and adjust xmldoc to be very explicit about how wrong this is
  Dean Herbert · 2023-11-17 17:04:20 +09:00
  9172632b0b
• Fixed precision and updated AdvancedStats
  Givikap120 · 2023-11-12 18:05:18 +02:00
  26d493986c
• Refactor logic and tooltip formatting
  Dean Herbert · 2023-11-12 16:19:55 +09:00
  4df1eb1b37
• Merge branch 'master' into arod_rate_adjust
  Dean Herbert · 2023-11-12 15:49:07 +09:00
  6bd5eda2a0
• fixed naming incconvinence
  Givikap120 · 2023-11-10 15:13:40 +02:00
  60c3e7250b
• improved tooltip
  Givikap120 · 2023-11-04 21:55:46 +02:00
  820519c37d
• Basic rate-adjust tooltip
  Givikap120 · 2023-11-04 17:47:02 +02:00
  440d57fb48
• Improve code quality
  Givikap120 · 2023-11-04 17:25:09 +02:00
  57170501cd
• Move collapsed bindable back to BeatmapAttributesDisplay for now

  Better to have it only in one place that needs it, rather than have it
  not work as expected when someone inherits
  `ModFooterInformationDisplay`.

  Bartłomiej Dach · 2023-09-14 14:56:58 +02:00
  94cdcfd7ce
• Split base design out of BeatmapAttributesDisplay
  Dean Herbert · 2023-09-13 19:33:30 +09:00
  46d5aa59bf
• Use local shear definition
  Dean Herbert · 2023-09-13 18:51:50 +09:00
  491d94c5ac
• Added BeatmapAttributesDisplay support
  Givikap120 · 2023-09-12 16:44:44 +03:00
  1a70110a4e
• Adjust various class naming and add some xmldoc
  Dean Herbert · 2023-09-12 17:15:16 +09:00
  7e3652284d