10163 Commits

• Add failing test coverage showing bad selection logic
  Dean Herbert · 2025-06-04 15:45:36 +09:00
  b42b8ba0de
• Merge pull request #33373 from peppy/song-select-v2-more-sane-input-padding

  SongSelectV2: Store input padding adjustments in `CarouselItem` to allow more reliable inflation

  Bartłomiej Dach · 2025-06-04 07:41:18 +02:00
  3624c251a2
• Mark some more recent flaky tests
  Dean Herbert · 2025-06-03 16:23:31 +09:00
  ef29eda3e0
• Store input padding adjustments in CarouselItem to allow more reliable inflation
  Dean Herbert · 2025-06-02 19:11:47 +09:00
  90b9fb0809
• Merge branch 'master' into song-select-v2-fix-random-difficulty-filtered
  Bartłomiej Dach · 2025-06-02 09:57:05 +02:00
  d819dfc180
• Disable broken tests temporarily
  Dean Herbert · 2025-06-02 16:55:21 +09:00
  a0eb39d26d
• Add failing test showing random selecting filtered-away difficulties
  Dean Herbert · 2025-06-01 00:58:56 +09:00
  0fc129fbac
• SongSelectV2: Fix input gap between last beatmap panel in set and next set panel
  Bartłomiej Dach · 2025-05-30 19:13:42 +02:00
  f462c683ee
• Fix missing ConfigureAwait causing Items to potentially be copied on non-update thread
  Dean Herbert · 2025-05-30 19:39:49 +09:00
  7025c2cf2f
• Add test showing carousel never loading under high beatmap churn
  Dean Herbert · 2025-05-30 19:39:48 +09:00
  671c08df8e
• Merge pull request #33332 from peppy/song-select-v2-fix-double-filter

  SongSelectV2: Fix carousel filtering twice on entering song select

  Bartłomiej Dach · 2025-05-30 12:29:32 +02:00
  559ddd1ec9
• Merge pull request #33335 from bdach/song-select-v2-single-items-arent-shown
  Dean Herbert · 2025-05-30 19:29:15 +09:00
  8cea1e2e1d
• Merge branch 'master' into song-select-v2-fix-incorrect-gameplay-start
  Bartłomiej Dach · 2025-05-30 11:40:28 +02:00
  74c7d6603c
• Merge branch 'master' into song-select-v2-single-items-arent-shown
  Bartłomiej Dach · 2025-05-30 11:38:06 +02:00
  e4cd8bcc59
• Add failing test case
  Bartłomiej Dach · 2025-05-30 11:20:00 +02:00
  68504e9639
• Use nullable Criteria instead of ctor flag
  Dean Herbert · 2025-05-30 18:15:27 +09:00
  5bf235f2dc
• Merge branch 'master' into song-select-v2-polish-2
  Bartłomiej Dach · 2025-05-30 11:07:11 +02:00
  4915e4d266
• Fix test being sensitive to selected tab on new song select
  Bartłomiej Dach · 2025-05-30 10:02:40 +02:00
  9d0d3bb97a
• Add failing test showing double filter on entering song select
  Dean Herbert · 2025-05-30 16:03:31 +09:00
  666d9b153c
• Add failing tests showing carousel incorrectly requesting start when traversing single items
  Dean Herbert · 2025-05-30 15:50:19 +09:00
  9b77b958e0
• Adjust filter control copy and spacing to fit text better
  Dean Herbert · 2025-05-30 02:20:57 +09:00
  b1a11061f4
• Merge pull request #33318 from bdach/song-select-v2-footer-buttons-stupid

  SongSelectV2: Disable footer buttons when transitioning to another screen

  Dean Herbert · 2025-05-29 18:43:24 +09:00
  9e6d657ec8
• Add failing test case for mod select becoming visible after suspending song select
  Bartłomiej Dach · 2025-05-29 10:34:46 +02:00
  d328d3d6ed
• Add failing test coverage for osu! cookie attempting to start gameplay with nothing selected
  Bartłomiej Dach · 2025-05-29 09:32:38 +02:00
  d1d9749de5
• Add failing test showing selected beatmap is reset on zero result filter
  Dean Herbert · 2025-05-29 00:44:48 +09:00
  5d6868cdae
• Merge pull request #33306 from peppy/song-select-v2-select-single-result

  SongSelectV2: If only one results is visible after filter, select it automatically

  Bartłomiej Dach · 2025-05-28 14:05:33 +02:00
  f1b6814ff3
• Merge branch 'master' into song-select-v2-fix-loading-overlay
  Bartłomiej Dach · 2025-05-28 13:16:30 +02:00
  bbeb1be295
• Update existing test assertions in line with new selection logic
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  99ab76ba27
• SongSelectV2: If only one results is visible after filter, select it automatically
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  731a4968f5
• Merge branch 'master' into song-select-v2-random
  Dean Herbert · 2025-05-28 20:06:50 +09:00
  0b527ce14b
• Merge pull request #33301 from peppy/remember-group-expansion

  SongSelectV2: Fix expanded group not being persisted over filter operations

  Bartłomiej Dach · 2025-05-28 12:55:23 +02:00
  d9d74696df
• Remove unused using
  Bartłomiej Dach · 2025-05-28 12:36:38 +02:00
  86ae5043c1
• Fix difficulty grouping not working with random
  Dean Herbert · 2025-05-28 12:14:27 +02:00
  dca839211c
• SongSelectV2: Fix carousel loading state looking out of place
  Dean Herbert · 2025-05-28 18:31:37 +09:00
  7a4d9c7c9a
• Add test coverage showing expanded group getting reset on filter
  Dean Herbert · 2025-05-28 18:15:39 +09:00
  c94555388e
• Rename and expose BeatmapCarousel selection handling variables

  For test usage and consistency.

  Dean Herbert · 2025-05-28 18:15:39 +09:00
  ef39b8d9c0
• SongSelectV2: Fix group panels being recreated every filter

  This also allows *all* panels to be re-used based on equality, as
  originally intended. Beatmap updates should be handled correctly without
  a full (flashing) recreation of panels now.

  Dean Herbert · 2025-05-28 17:46:14 +09:00
  c2bd4a9827
• SongSelectV2: Add back basic random selection support

  This is a minimal implementation in order to keep moving forward.
  
  For simplicity I've copied over the old implementation verbatim. Note
  that this is beatmap*set* based randomisation, which means that when
  panels are split up by difficulty, it is still randomising by set (with
  the difficulty choice being left up to the user recommendation system).
  I think this is what we want, but if it isn't, any changes can come
  later.

  Dean Herbert · 2025-05-28 16:54:11 +09:00
  1b56ce9a39
• add test coverage
  WitherFlower · 2025-05-27 21:07:30 +02:00
  9d7a0eea51
• Merge pull request #33287 from peppy/fix-selection

  SongSelectV2: Fix carousel not correctly handling traversal when current selection is filtered away

  Bartłomiej Dach · 2025-05-27 12:33:04 +02:00
  e5ba517f9c
• Update test helper methods to use non-reference comparison

  This isn't strictly required, but there should be no gaurantee or
  requirement that the references are equal in these checks, so it's best
  change them as such.

  Dean Herbert · 2025-05-27 18:32:56 +09:00
  8ccd6a4e4a
• Add failing tests showing traversal failure after selection is filtered
  Dean Herbert · 2025-05-27 18:32:56 +09:00
  0a07aef594
• Merge pull request #33281 from peppy/fix-switching-difficulty-split-modes

  Fix panels not updating visually when changing between difficulty sort modes

  Bartłomiej Dach · 2025-05-27 10:59:44 +02:00
  790a2f8f37
• Fix panels not updating visually when changing between difficulty sort modes

  I'm going with the simplest approach for this for now. If there's a
  discrepancy, clear all panels and start from scratch.
  
  Closes #33204.

  Dean Herbert · 2025-05-27 17:21:15 +09:00
  907d680188
• Add test coverage of volume changing while at song select

  This passes without changes in this pull request. But I'm just copying
  across from https://github.com/ppy/osu/pull/33225 to stay in theme?

  Dean Herbert · 2025-05-27 15:53:31 +09:00
  7d8dc1bd0a
• Merge pull request #33266 from bdach/score-correct-processing-status

  Fix profile score display logic not matching website

  Dean Herbert · 2025-05-27 13:47:52 +09:00
  900cef8f20
• Merge pull request #33241 from bdach/participant-list-transform-spam

  Implement list virtualisation in multiplayer participants list

  Dean Herbert · 2025-05-26 23:58:27 +09:00
  7cc89dfd4e
• Adjust tests in line with new logic
  Bartłomiej Dach · 2025-05-26 13:22:18 +02:00
  d8546d909d
• Update tests to no longer require local selection
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  e33b92fa5c
• Add basic "eager" selection to ensure something is selected at song select after import
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  4a03240ee6