1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-24 04:22:54 +08:00
Commit Graph

45585 Commits

Author SHA1 Message Date
Dean Herbert
4e043e7cab
Change how values are applied to (hopefully) simplify things 2025-02-14 18:35:27 +09:00
Dean Herbert
74eae3cda3
Merge branch 'master' into ios-ui-scale 2025-02-14 18:22:47 +09:00
Dean Herbert
071a4ba9b0
Merge pull request #31821 from Layendan/playlist-collection
Add playlist to new collection button present on playlist room
2025-02-14 18:03:54 +09:00
Dean Herbert
22d6135cd5
Merge pull request #31596 from Rudicito/fix-settings-toolbox-hiding-when-dragging-a-slider
Fix toolbox settings hiding when dragging a slider
2025-02-14 17:58:33 +09:00
Dean Herbert
9456e376f3
Fix expanded state not updating on drag end 2025-02-14 15:15:05 +09:00
Rudi Herouard
3f3cb3df2a
Fix toolbox settings hiding when dragging a slider 2025-02-14 15:08:02 +09:00
Dean Herbert
f9b7a8ed10
Make realm operation asynchronous for good measure 2025-02-14 14:51:48 +09:00
Dean Herbert
8561df40c5
Add better messaging and handling of edge cases 2025-02-14 14:30:33 +09:00
Dean Herbert
601e6d8a70
Refactor pass for code quality 2025-02-14 13:54:29 +09:00
Dean Herbert
9650385989
Also disable sliderbar focus when disabled 2025-02-14 00:06:20 +09:00
Dean Herbert
315a480931
Disallow focus on difficulty range slider
Alternative to https://github.com/ppy/osu/pull/31749.
Closes https://github.com/ppy/osu/issues/31559.
2025-02-14 00:03:30 +09:00
Bartłomiej Dach
de9362dae5
Merge branch 'master' into bss/the-actual-submission 2025-02-13 08:45:23 +01:00
Dean Herbert
c049ae6937
Update height specification for playlist screen too 2025-02-12 18:45:00 +09:00
Dean Herbert
bc94ffe21e
Merge branch 'master' into freestyle-mods 2025-02-12 18:32:01 +09:00
Dean Herbert
218151bb3c
Flash footer freemod/freestyle buttons when active 2025-02-12 18:30:34 +09:00
Dean Herbert
9c3e9e7c55
Change free mods button to show "all" when freestyle is enabled 2025-02-12 18:27:10 +09:00
Dean Herbert
9aef95c381
Adjust some paddings and text
Mostly trying to give more space to the queue as we add more vertical
elements to the middle area of multiplayer / playerlists. This whole UI
will likely change – this is just a stop-gap fix.
2025-02-12 17:43:49 +09:00
Dean Herbert
b92e9f515b
Fix layout of user setting areas when aspect ratio is vertically tall 2025-02-12 17:31:55 +09:00
Marvin Schürz
a8f07ae7b1 Add comment warning about enum entry order in GlobalAction 2025-02-11 18:04:23 +01:00
Bartłomiej Dach
46e8187d48
Merge pull request #22932 from peppy/collection-counts
Show count of beatmaps in collections in manage dialog
2025-02-11 15:43:22 +01:00
Dan Balasescu
693ef8f538
Merge pull request #31846 from bdach/fix-missing-rank-on-results
Fix score position not being displayed in solo results screen
2025-02-11 21:55:35 +09:00
Dean Herbert
b9c4e23595
Fix potential bad realm access to collection name 2025-02-11 20:05:48 +09:00
Bartłomiej Dach
d8b3c28c2e
Use more neutral terminology to avoid contentious 'beatmap' term 2025-02-11 09:17:11 +01:00
Dean Herbert
b9ed217308
Add basic brighten animation instead 2025-02-11 17:13:34 +09:00
Bartłomiej Dach
884fa20b28
Remove completely unnecessary subscriptions per collection 2025-02-11 09:13:08 +01:00
Dean Herbert
1fa8d53232
Disable scale animation when holding editor "test" button 2025-02-11 17:11:20 +09:00
Dean Herbert
9bb108311f
Merge pull request #31848 from bdach/open-beatmap-in-browser-from-editor
Add menu items to open beatmap info & discussion pages in browser from editor
2025-02-11 16:55:02 +09:00
Bartłomiej Dach
18965fe0a2
Merge branch 'master' into collection-counts 2025-02-11 08:54:24 +01:00
Bartłomiej Dach
7db0a6f817
Update xmldoc 2025-02-11 16:14:47 +09:00
Bartłomiej Dach
daf0130b23
Reword copy to be less verbose 2025-02-11 08:06:12 +01:00
Dan Balasescu
e51c09ec3d
Fix inspection
Interestingly, this is not a compiler error nor does R# warn about it.
No problem, because this is just restoring the original code anyway.
2025-02-11 14:23:51 +09:00
Dan Balasescu
748c2eb390
Refactor RoomSubScreen update 2025-02-11 12:43:54 +09:00
Dan Balasescu
78e5e0eddd
Refactor with a bit more null safety
In particular I don't like the non-null assert around
`GetCurrentItem()`, because there's no reason why it _couldn't_ be
`null`.
Consider, for example, if these panels are used in matchmaking where
there are no items initially present in the playlist.

The ruleset nullability part is debatable, but I've chosen to restore
the original code here.
2025-02-11 12:20:09 +09:00
Dean Herbert
8dc616738c
Merge pull request #31844 from bdach/fix-mp-players-appearing-as-spectators
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 21:49:06 +09:00
Dean Herbert
310700b4e7
Space out comment 2025-02-10 21:48:27 +09:00
Bartłomiej Dach
38e2f793ca
Add menu items to open beatmap info & discussion pages in browser from editor 2025-02-10 12:47:38 +01:00
Bartłomiej Dach
288851c606
Fix score position not being displayed in solo results screen
Closes https://github.com/ppy/osu/issues/31842.

To be honest, I recall this working too, but I don't recall when it
might have broken, nor do I want to go look for the point of breakage
because it might be borderline impossible to find it now. So I'm just
fixing as if it was just a straight omission.

Opting for a client-side fix because server-side inclusion of the score
position for an entire leaderboard has been previously rejected as too
expensive:

	https://github.com/ppy/osu-web/pull/11354#discussion_r1689217450
2025-02-10 12:17:52 +01:00
Bartłomiej Dach
ad642b8425
Fix spectator list showing other users in multiplayer room even if they're not spectating 2025-02-10 11:17:17 +01:00
Bartłomiej Dach
3ba56e009e
Privatise a few members 2025-02-10 10:41:10 +01:00
Dean Herbert
b8e33a28d2
Minor code refactors 2025-02-10 17:41:38 +09:00
Bartłomiej Dach
45259b374a
Remove unused using 2025-02-10 09:09:43 +01:00
Bartłomiej Dach
895493877c
Allow performing beatmap reload after submission from song select 2025-02-10 09:03:40 +01:00
Layendan
5e9f195117 Fix tests failing if playlist was empty 2025-02-09 23:27:28 -07:00
Dean Herbert
eae1ea7e32
Adjust animations and induce some short delays to make things more graceful 2025-02-10 15:23:25 +09:00
Dean Herbert
930aaecd7f
Fix back button displaying before it should 2025-02-10 15:22:31 +09:00
Dean Herbert
7853456c06
Add delay before browser displays beatmap 2025-02-10 15:12:59 +09:00
Dean Herbert
274b422139
Add percent progress display to editor footer 2025-02-10 14:51:48 +09:00
Layendan
f9bda0524a Update button text to include downloaded beatmaps and collection status 2025-02-09 18:45:13 -07:00
SebastianPeP
bcd4fcbeed Changed the Currently Playing Text when no track is selected
Changed the currently playing text for when the track isnt selected/loaded
2025-02-09 01:29:22 -03:00
Bartłomiej Dach
64f0d234d8
Fix exiting being eternally blocked after successful beatmap submission 2025-02-07 15:37:27 +01:00