h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 16:47:24 +08:00
Code Issues Releases Wiki Activity
60,549 Commits 3 Branches 648 Tags 270 MiB
4c397085c5
Commit Graph

60549 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Robin Oger
d852883421 Merge remote-tracking branch 'origin/make_pause_menu_translatable' into make_pause_menu_translatable 2023-05-23 21:37:20 +02:00
Robin Oger
a24da89908 Change to sentence casing 
See: https://github.com/ppy/osu/pull/23640#discussion_r1202879352
 2023-05-23 21:37:12 +02:00
Stéén
b9b97069b3
Merge branch 'master' into make_pause_menu_translatable 2023-05-23 21:28:00 +02:00
Bartłomiej Dach
1671729b78
Merge pull request #23634 from peppy/fix-multiplayer-song-select-scene 
Fix weird state when attempting to enter gameplay skin editor scene from multiplayer
 2023-05-23 20:41:09 +02:00
Robin Oger
0ea3eea8d6 Make GameplayMenuOverlay translatable 
This allows translator to translate the pause and failed in game menus
 2023-05-23 19:21:44 +02:00
Gyoshi
7fe19d1992 Last instead of Max divisor to match code elsewhere 2023-05-23 18:45:49 +02:00
Gyoshi
c5ef3ae181 Code styling 2023-05-23 18:44:20 +02:00
Gyoshi
b5f8093941 Use RangePadding to align mouse with slider 2023-05-23 18:16:14 +02:00
Gyoshi
fa00f8b92a replace manual code with existing method 2023-05-23 18:16:12 +02:00
Gyoshi
921d7e4d89 More fitting tests for new layout 2023-05-23 18:16:10 +02:00
Gyoshi
7b1e8ede54 Small format 2023-05-23 15:11:27 +02:00
Gyoshi
1b32370c6a Remove duplicate code by making GetDivisorForBeatIndex method more general 2023-05-23 15:05:38 +02:00
Gyoshi
37a796306d Small format & comment 2023-05-23 14:30:35 +02:00
Johannes vd Berg
ebda35c3c9 Add ghost ticks to exhibit current divisor on BeatDivisorControl 2023-05-23 12:57:25 +02:00
Dan Balasescu
7658536b5a Fix CI issues 2023-05-23 19:32:19 +09:00
Dan Balasescu
fee3d43596 Merge branch 'master' into scorev2 2023-05-23 19:07:54 +09:00
Dan Balasescu
e467791d0b
Merge pull request #23636 from peppy/fix-updates-during-gameplay 
Disallow game to check for updates while gameplay is active
 2023-05-23 19:04:43 +09:00
Dean Herbert
02d8e3a11e Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead 2023-05-23 18:50:14 +09:00
Dean Herbert
6f4e2b37ed Add shadow to notifications and settings overlays to better distinguish from other overlays 2023-05-23 18:50:14 +09:00
Dan Balasescu
844c023fb7 Fix tests 2023-05-23 18:18:27 +09:00
Dan Balasescu
d45b54399b Add back minimum/maximum accuracy 2023-05-23 18:15:32 +09:00
Dean Herbert
7cf50b1e18 Disallow game to check for updates while gameplay is active 2023-05-23 18:06:04 +09:00
Dan Balasescu
3598ca9125 Adjust xmldoc 2023-05-23 18:05:10 +09:00
Dean Herbert
adf9a596b5 Fix weird state when attempting to enter gameplay skin editor scene from multiplayer 
Closes https://github.com/ppy/osu/issues/23626.
 2023-05-23 17:58:44 +09:00
Dan Balasescu
8570f825ed Consider all accuracy judgements in accuracy progress 2023-05-23 17:47:35 +09:00
Dan Balasescu
f8101fbbc7 Rename variables 2023-05-23 17:44:17 +09:00
Dean Herbert
ff5dde0ebe
Merge pull request #23575 from Joehuu/fix-inverted-video-only-check 
Fix old widescreen videos with black bars not correctly filling screen (again)
 2023-05-23 16:47:52 +09:00
Dean Herbert
7c039b0b67
Merge pull request #23618 from bdach/fix-taiko-swells-drumrolls-silent 
Fix hitsounds not playing before and during taiko drum rolls and swells
 2023-05-23 16:44:04 +09:00
Dean Herbert
c8303d55cd Adjust text and alignment 2023-05-23 16:21:56 +09:00
Dan Balasescu
62d504af92 Fix base implementation of ComputeTotalScore 2023-05-23 15:59:24 +09:00
Dan Balasescu
e1feeded12 Change statistics type, remove overridability 2023-05-23 15:36:34 +09:00
Dan Balasescu
c291d6fc82 Remove catch tiny droplet portion 2023-05-23 15:36:34 +09:00
Dean Herbert
f908545b9b
Merge pull request #23631 from bdach/fix-velocity-undo 
Fix undo/redo not working for slider velocity and sample changes
 2023-05-23 14:46:49 +09:00
Bartłomiej Dach
38b4bd8aef
Fix undo not behaving as expected sometimes 2023-05-22 22:45:39 +02:00
Bartłomiej Dach
e0b7539c2a
Fix sample changes not being applied in patcher 2023-05-22 22:45:23 +02:00
Bartłomiej Dach
2ce150ba2b
Add failing test case for sample undo 2023-05-22 22:23:05 +02:00
Bartłomiej Dach
f253d17a7f
Fix slider velocity changes not being applied in patcher 2023-05-22 22:19:10 +02:00
Bartłomiej Dach
843d2903d2
Add failing test case for slider velocity undo 2023-05-22 22:18:15 +02:00
Dean Herbert
7742904d2a
Merge pull request #23593 from Dimmitsaras/unfocused-notifications 
Always show chat message notifications if window is unfocused
 2023-05-22 14:17:20 +09:00
Dean Herbert
09c66bea8f
Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area 
Fix clicking area of news sidebar post links
 2023-05-22 14:17:08 +09:00
Joseph Madamba
7392109bce
Apply same behavioral changes to NewsCard 2023-05-21 19:28:12 -07:00
Joseph Madamba
2279aad360
Apply NRT to NewsCard 2023-05-21 19:27:20 -07:00
Dean Herbert
3df0eea92d
Merge pull request #23573 from Susko3/use-atomic-ReplaceRange 
Prevent feedback with display resolution bindable by using atomic `.ReplaceRange()`
 2023-05-22 11:26:06 +09:00
Dean Herbert
b3527b92b6 Handle case in tests where current display becomes null 2023-05-22 09:25:44 +09:00
Bartłomiej Dach
19816ae013
Update framework 2023-05-21 20:38:27 +02:00
Bartłomiej Dach
6df1d29862
Merge branch 'master' into use-atomic-ReplaceRange 2023-05-21 20:32:59 +02:00
Joseph Madamba
88c112612f
Remove hardcoded website url 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2023-05-21 10:35:22 -07:00
Bartłomiej Dach
9915fac2c8
Fix sample silence being one level too low 
4a7b011a53 inadvertently unearthed that
nested strong hits could play samples of their own accord, rather than
delegating to `DrumSampleTriggerSource` as they were supposed to. This
was an unfortunate omission due to how the inheritance structure of
`TaikoHitObject` looks like (some irrelevant classes omitted for
brevity):

	DrawableTaikoHitObject
		DrawableTaikoHitObject<TObject> <-- `GetSamples()` was overridden to empty here
			DrawableTaikoStrongableHitObject
				DrawableHit
				DrawableDrumRoll
				DrawableDrumRollTick
			DrawableSwell
			DrawableSwellTick
		DrawableStrongNestedHit <-- all strong nested hits are here => didn't receive `GetSamples()` override
			DrawableHit.StrongNestedHit
			DrawableDrumRoll.StrongNestedHit
			DrawableDrumRollTick.StrongNestedHit

To fix, move the `GetSamples()` override one level higher, to the
non-generic `DrawableTaikoHitObject`, to suppress the spurious sample
playbacks.

The stale reference in the comment was also updated to match current
code.
 2023-05-21 18:58:26 +02:00
Bartłomiej Dach
4a7b011a53
Propagate samples to strong nested hits too 
The rationale is the same as in
6d325651dc. Due to the recursive nature of
`GameplaySampleTriggerSource.GetMostValidObject()`, in the case of
nested hits, drum rolls and drum roll ticks, the nested strong hits
would become the most valid object, and so without propagating
the samples down to that level too, nothing would play.
 2023-05-21 18:58:05 +02:00
Bartłomiej Dach
812df9d652
Add failing test cases for strong object sample playback 2023-05-21 18:57:55 +02:00