72076 Commits

This Branch

This Branch

All Branches

• Fix typo in xmldoc
  Dean Herbert · 2025-03-04 16:15:40 +09:00
  2025.304.0 4a16b4bd98
• Merge pull request #32217 from smoogipoo/fix-mp-channel

  Fix multiplayer not joining correct chat channel

  Dean Herbert · 2025-03-04 16:15:20 +09:00
  667bd6e8f1
• Merge pull request #32075 from Gennadiyev/patch-result-screen-volume-adjust

  Add Alt + mousewheel volume adjustment on result screens

  Dean Herbert · 2025-03-04 16:06:46 +09:00
  c9a492a6eb
• Merge pull request #31866 from smoogipoo/remove-roommanager

  Remove `RoomManager`, centralise listing management to lounge

  Dean Herbert · 2025-03-04 15:52:59 +09:00
  5318c370d4
• Rename RoomsContainer and scope down bindables
  Dean Herbert · 2025-03-04 15:05:12 +09:00
  9e8a611728
• Fix multiplayer not joining correct chat channel
  Dan Balasescu · 2025-03-04 14:45:23 +09:00
  77d5b1d5dd
• LoungePollingComponent -> LoungeListingPoller
  Dean Herbert · 2025-03-04 14:40:55 +09:00
  0696cfa4f2
• Merge branch 'master' into remove-roommanager
  Dean Herbert · 2025-03-04 14:23:51 +09:00
  f3e9d1931c
• Merge pull request #32215 from smoogipoo/fix-broken-test

  Fix broken test

  Dean Herbert · 2025-03-04 14:20:55 +09:00
  45e0446e19
• Fix broken test
  Dan Balasescu · 2025-03-04 14:14:42 +09:00
  b73a872b94
• Merge pull request #32158 from bdach/scaling-crash

  Fix possible crash when scaling objects in editor

  Dean Herbert · 2025-03-04 13:40:41 +09:00
  3fe92fb83c
• Merge pull request #32196 from bdach/disallow-negative-drain-length

  Fix drain length calculation helper method being able to return negative durations

  Dean Herbert · 2025-03-04 13:35:52 +09:00
  57ec2f7228
• Merge branch 'master' into remove-roommanager
  Dan Balasescu · 2025-03-04 13:17:04 +09:00
  446718f929
• Merge pull request #32200 from andy840119/remove-handle-scale-base-method

  Remove unused virtual method after refactor the scale handling.

  Dan Balasescu · 2025-03-04 13:14:14 +09:00
  8c13a86ad1
• Merge pull request #31637 from smoogipoo/room-management-lio

  Create, join, and part multiplayer rooms only via the multiplayer server

  Dean Herbert · 2025-03-04 13:13:55 +09:00
  58a671decb
• Merge pull request #32210 from smoogipoo/fix-multi-join-many-users

  Fix being unable to join multiplayer rooms with many users

  Dean Herbert · 2025-03-04 13:13:15 +09:00
  118f9a3a72
• Merge pull request #32208 from smoogipoo/diffcalc-timed-cancellation

  Cancel difficulty calculation after 10 seconds by default

  Dean Herbert · 2025-03-04 12:52:18 +09:00
  63cd93a9a8
• Merge pull request #32204 from Joehuu/team-label-web-string

  Use web localisable string for team channel label

  Dan Balasescu · 2025-03-04 12:37:21 +09:00
  b1069048bb
• Fix unable to join multiplayer rooms with many users
  Dan Balasescu · 2025-03-04 12:34:11 +09:00
  3024a98658
• Add failing test
  Dan Balasescu · 2025-03-04 12:34:11 +09:00
  963df165df
• Merge pull request #32209 from smoogipoo/fix-intermittent-test

  Fix intermittent score panel test

  Dean Herbert · 2025-03-04 12:23:17 +09:00
  a9bf096201
• Fix intermittent score panel test
  Dan Balasescu · 2025-03-04 11:38:25 +09:00
  df25734834
• Cancel difficulty calculation after 10 seconds by default
  Dan Balasescu · 2025-03-04 11:22:47 +09:00
  550ff85550
• Use web localisable string for team channel label
  Joseph Madamba · 2025-03-03 14:23:39 -08:00
  cab849b5d9
• Merge pull request #32197 from peppy/zoom-to-centre-always

  Always zoom timeline to centre rather than focus point

  Bartłomiej Dach · 2025-03-03 20:12:28 +01:00
  c30f334cf9
• This method is not being used anymore.

  see:
  https://github.com/ppy/osu/pull/26643

  andy840119 · 2025-03-03 22:10:41 +08:00
  23a5d6dc40
• Update failing assertions

  Change in behaviour is expected in this case.

  Bartłomiej Dach · 2025-03-03 13:53:42 +01:00
  d7d5eec58c
• Merge pull request #32135 from zihadmahiuddin/fix/settings-show-at-visibility

  Fix settings control not visible because of previous search

  Bartłomiej Dach · 2025-03-03 13:29:26 +01:00
  a33e76717c
• Merge pull request #32162 from nekodex/kiai-sfx

  Add SFX for kiai/star fountain activation

  Dean Herbert · 2025-03-03 19:05:05 +09:00
  6aaec144c8
• Update resources
  Dean Herbert · 2025-03-03 18:54:46 +09:00
  f32a8e8741
• Always zoom timeline to centre rather than focus point

  Closes https://github.com/ppy/osu/issues/32183.

  Dean Herbert · 2025-03-03 18:53:41 +09:00
  52860def6c
• Fix drain length calculation helper method being able to return negative durations

  This is the principal failure behind
  https://github.com/ppy/osu-server-beatmap-submission/issues/40.

  Bartłomiej Dach · 2025-03-03 09:35:46 +01:00
  87fb8da351
• Add failing test case
  Bartłomiej Dach · 2025-03-03 09:32:27 +01:00
  0a50fb1dfa
• Add guards to prevent clamp calls with invalid bounds
  Bartłomiej Dach · 2025-03-03 08:40:51 +01:00
  47747aed3e
• Merge pull request #32152 from peppy/song-select-v2-test

  Make `TestSceneSongSelect` work with local database

  Dan Balasescu · 2025-03-03 16:21:11 +09:00
  9c28ac4a72
• Merge pull request #32153 from peppy/carousel-design-fixes

  Apply first wave blanket fixes to new beatmap carousel design

  Bartłomiej Dach · 2025-03-03 08:13:43 +01:00
  8539745667
• Merge pull request #32192 from smoogipoo/more-beatmap-load-cancellations

  Cancel beatmap load in more loops

  Dean Herbert · 2025-03-03 16:10:06 +09:00
  8b04b75d27
• Cancel ApplyDefaults() when requested

  Also didn't notice a particular case here, but if all code passes up
  until we get to the `foreach (var h in nestedHitObjects)` below, then we
  could end up stuck here for quite a while.

  Dan Balasescu · 2025-03-03 14:46:13 +09:00
  033952029e
• Cancel slider generation when requested

  Didn't notice a particular case with this one, just came up as I was
  looking through code.

  Dan Balasescu · 2025-03-03 14:19:43 +09:00
  52dad09b20
• Exit loop when cancellation requested

  The following manages to create all hitobjects but proceeds to get stuck
  in this method:
  
  `dotnet run -- difficulty 1607040 -r:2`

  Dan Balasescu · 2025-03-03 14:19:19 +09:00
  ad9a963bd0
• Add SFX for kiai/star fountain activation
  Jamie Taylor · 2025-03-01 01:51:37 +09:00
  881534eb7f
• Adjust set panel display and animations slightly
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  38de3566b1
• Remove unused container level
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  4beac64bdb
• Fix activation flash being applied twice (and adjust duration)
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  29c35529d2
• Stop using padding for panel x offsets
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  8032b68932
• use Bindable.SetDefault for clearing search text
  Zihad · 2025-02-28 19:04:47 +06:00
  0d7c00ae09
• make SettingsPanel.SearchTextBox's setter private
  Zihad · 2025-02-28 19:03:39 +06:00
  88089fb014
• Mark MathHelper.Clamp() as banned API

  See previous commit for partial rationale.
  
  There's an argument to be made about the `NaN`-spreading semantics being
  desirable because at least something will loudly fail in that case, but
  I'm not so sure about that these days. It feels like either way if
  `NaN`s are produced, then things are outside of any control, and chances
  are the game can probably continue without crashing. And, this move
  reduces our dependence on osuTK, which has already been living on
  borrowed time for years now and is only awaiting someone brave to go
  excise it.

  Bartłomiej Dach · 2025-02-28 13:48:22 +01:00
  35b0ff80bb
• Fix possible crash when scaling objects in editor

  The specific fail case here is when `s.{X,Y}` is 0, and
  `s{Lower,Upper}Bound` is `Infinity`. Because IEEE math is IEEE math,
  `0 * Infinity` is `NaN`.
  
  `MathHelper.Clamp()` is written the following way:
  
  	https://github.com/ppy/osuTK/blob/af742f1afd01828efc7bc9fe77536b54aab8b419/src/osuTK/Math/MathHelper.cs#L284-L306
  
  `Math.{Min,Max}` are both documented as reporting `NaN` when any of
  their operands are `NaN`:
  
  	https://learn.microsoft.com/en-us/dotnet/api/system.math.min?view=net-8.0#system-math-min(system-single-system-single)
  	https://learn.microsoft.com/en-us/dotnet/api/system.math.max?view=net-8.0#system-math-max(system-single-system-single)
  
  which means that if a `NaN` happens to sneak into the bounds, it will
  start spreading outwards in an uncontrolled manner, and likely crash
  things.
  
  In contrast, the standard library provided `Math.Clamp()` is written
  like so:
  
  	https://github.com/dotnet/runtime/blob/577c36cee56480dec4d4610b35605b5d5836888b/src/libraries/System.Private.CoreLib/src/System/Math.cs#L711-L729
  
  With this implementation, if either bound is `NaN`, it will essentially
  not be checked (because any and all comparisons involving `NaN` return
  false). This prevents the spread of `NaN`s, all the way to positions
  of hitobjects, and thus fixes the crash.

  Bartłomiej Dach · 2025-02-28 13:34:00 +01:00
  ffef6ae185
• Merge pull request #32109 from smoogipoo/results-beatmap-lookup

  Fix multiplayer results screen displaying same beatmap for all users

  Bartłomiej Dach · 2025-02-28 12:36:28 +01:00
  c4e37a1566