1179 Commits

• Implement ranked play (#36819)

  I don't really have much to say here. Instead, I'll give a brief history
  rundown that lists many pages of documentation you can read, if
  interested.
  
  - Started off as BTMC + Happy24 (Vivi)'s ["The
  Vision"](https://docs.google.com/document/d/1p1IpPmd2RICp8G4OqkCSs7u8Ug8FbFv8qqP0mfSrHf0/edit?tab=t.0#heading=h.fol093d9f9xi)
  - Initial
  [designs](https://www.figma.com/design/f5qqC57t9jFlgpzhRqUNVX/The-Vision?node-id=0-1&p=f)
  were led by Vivi.
  - Designs
  [morphed](https://www.figma.com/design/vtFmLrXKvWNyYiRjTezFTM/Untitled--Copy-?node-id=0-1&p=f)
  during development into what's currently present, led by @minetoblend.
  - There is some more ongoing work creating a [game design
  document](https://docs.google.com/document/d/1iffJFCsIBfYF0D4ogItSBEj6YBmbp-rdCpItAeaJiTA/edit?tab=t.0).
  
  **tl;dr:** Create something with the mechanics of a trading card game
  within osu!. The name of this is "ranked play".
  
  ---
  
  To be frank, a lot of stuff is missing here. Some of it I don't want to
  mention, because the point of this exercise is to get the system into
  the hands of players, gather feedback especially around mechanics, and
  discuss any further direction with the team.
  
  I am expecting a blanket approval on all of the new code, with
  particular attention to changes in existing components that I'll point
  out in a self review.
  
  There is also some [ongoing
  work](https://github.com/smoogipoo/osu/pulls) that may arrive in this
  branch prior to being merged.
  
  ---------
  
  Co-authored-by: maarvin <minetoblend@gmail.com>
  Co-authored-by: Marvin <m.schuerz@hautzy.com>
  Co-authored-by: Jamie Taylor <me@nekodex.net>
  Co-authored-by: ArijanJ <arijanj@proton.me>
  Co-authored-by: Dean Herbert <pe@ppy.sh>
  Co-authored-by: Tim Oliver <git@tim.dev>
  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
  Co-authored-by: nil <25884226+voidstar0@users.noreply.github.com>
  Co-authored-by: Ботников Максим <mr.botnikoff@ya.ru>
  Co-authored-by: Denis Titovets <den232titovets@yandex.ru>
  Co-authored-by: Michael Middlezong <119022671+mmiddlezong@users.noreply.github.com>
  Co-authored-by: SupDos <6813986+SupDos@users.noreply.github.com>
  Co-authored-by: failaip12 <86018517+failaip12@users.noreply.github.com>

  Dan Balasescu · 2026-03-07 02:30:50 +09:00
  0988552567
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Refactor TestSceneScreenFooter to test entire OsuScreens (#36718)

  Part of the `ScreenFooter` refactor, which intends to move the footer
  content handling to `OsuScreen`. This commit updates the `ScreenFooter`
  test to operate on entire `OsuScreen`s, in order to better test the
  entire flow of pushing a screen, and having it create and add its own
  content to the footer.
  
  This should be 80-90% identical to the original test case structure
  wise, just that instead of manually manipulating the footer with
  `SetButtons()`, various screens with the appropriate buttons are being
  moved around the screen stack.
  
  Additionally this adds some more tests handling common use cases, as
  well as removes `TestLoadOverlayAfterFooterIsDisplayed()`, since as far
  as I understand the behaviour described in it doesn't actually happen in
  production code. From what I can see, Screens instantiate their overlays
  in `load()`, and then register them in `LoadComplete()`. There seems to
  be no case where a `ShearedOverlayContainer` is created in the middle of
  a screen's lifecycle.

  Krzysztof Gutkowski · 2026-03-01 22:36:07 +09:00
  b88cba0829
• Migrate sheared overlay tests to ScreenTestScene (#36736)

  Part of the screen footer refactor.
  
  Once footer content is being managed by `OsuScreen`, the current tests
  which simply create the tested overlay and `ScreenFooter` in a container
  will no longer work.
  
  This PR refactors them to use `ScreenTestScene` with the setup being
  creating a dedicated testing `OsuScreen` which does the bare minimum to
  create the tested overlay and necessary components (eg.
  `FooterButtonFreeModsV2` for `TestSceneFreeModsOverlay`).
  
  Most of the changes here can be described as
  `%s/<...>Overlay/screen.Overlay/g`, with some minor touchups as
  necessary, given that we're now testing a more complete flow which
  checks more things that were previously not handled by the tests.
  
  ## [Move footer to front in
  ScreenTestScene](https://github.com/ppy/osu/commit/f8740e0403b3c0badd60d394c737f2aa912a9ed6)
  
  Self-explanatory. Without it the footer would show below the actual
  overlay, breaking tests depending on manual input. For the sake of tests
  not breaking in CI, both #36718 and this have this included - would
  prefer the former to be merged first since it was already reviewed
  there.
  
  ## `TestSceneModSelectOverlay`
  
  There were a few tests (`TestColumnHidingOnIsValidChange`,
  `TestColumnHidingOnTextFilterChange`, and
  `TestHidingOverlayClearsTextSearch`) that would create a custom overlay
  instance instead of the globally provided one. I've tested both and the
  tests run fine with the default overlay, so they're now using that
  instead.
  
  ## `TestSceneFreeModSelectOverlay`
  
  Updated to use footer v2.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-02-28 04:22:58 +09:00
  105342e5bf
• Add type parameter to pool retrieval method
  Dan Balasescu · 2026-01-28 13:42:58 +09:00
  c1fc1edd9c
• Add metadata endpoint to refresh friend listing (#36386)

  Alternative to / closes https://github.com/ppy/osu/pull/36341
  See also: https://github.com/ppy/osu-server-spectator/pull/415
  
  This is a simple solution by adding a spectator endpoint to refresh the
  friend listing. A more complicated form of this is to make
  adding/removing friends only via spectator, but that would require
  osu-web changes too.

  Dan Balasescu · 2026-01-19 18:34:00 +09:00
  e62a01cf77
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-12-17 13:33:34 +09:00
  67e0348fa8
• Adjust vote-to-skip to be explicit about states
  Dan Balasescu · 2025-12-06 13:23:16 +09:00
  2be50d917a
• Fix failing tests after disallowing object placements before first timing point
  Bartłomiej Dach · 2025-12-05 09:52:32 +01:00
  66ebce8c12
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-11-18 14:08:12 +09:00
  a30f08be80
• Suffix introp methods with "Intro"
  Dan Balasescu · 2025-11-04 11:05:41 +09:00
  f4049c7ec1
• Resolve CI inspections
  Dan Balasescu · 2025-10-31 21:48:24 +09:00
  a9ca4634fc
• Add simple multiplayer skip overlay
  Dan Balasescu · 2025-10-31 21:39:41 +09:00
  b20a41c1e8
• Add support for vote-to-skip in multiplayer
  Dan Balasescu · 2025-10-31 21:39:41 +09:00
  373162df02
• Add interop models
  Dan Balasescu · 2025-10-30 19:04:49 +09:00
  a435dfe93e
• Add very simple countdown timer for quick play stages (#35433)
  Dean Herbert · 2025-10-24 23:07:04 +09:00
  1af462b692
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  4be29425a0
• Add initial screen + test structure
  Dan Balasescu · 2025-10-17 09:16:46 +09:00
  bfa45a23ce
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-16 20:37:24 +09:00
  c80fe7ab82
• Merge pull request #35251 from smoogipoo/fix-broken-tests

  Fix test failures during individual runs

  Dean Herbert · 2025-10-09 17:09:01 +09:00
  2136d95087
• Fix test failures during individual runs
  Dan Balasescu · 2025-10-09 16:34:55 +09:00
  6eaf91d31a
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add ability to jump in quick play
  Dan Balasescu · 2025-09-30 18:38:30 +09:00
  e636a09e0f
• Fix incorrect default room types
  Dan Balasescu · 2025-09-24 14:28:04 +09:00
  83dafb4ef9
• Add stage-changing helper, use in test scenes
  Dan Balasescu · 2025-09-24 14:28:01 +09:00
  9df3bd9a98
• Set initial matchmaking room state
  Dan Balasescu · 2025-09-24 13:42:55 +09:00
  597a06ac38
• Attempt to fix intermittent test
  Dan Balasescu · 2025-09-23 15:09:45 +09:00
  3789010dd5
• Merge branch 'master' into matchmaking
  Dean Herbert · 2025-09-11 15:11:01 +09:00
  619a6e7321
• Query for available pools for selection (#131)
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  e0c11504a2
• Separate IMatchmakingClient and IMultiplayerClient

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  3786efaa5e
• Add matchmaking
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  111b98ef8e
• Replace old-skin with retro skin in tests
  clayton · 2025-09-05 21:21:52 +09:00
  3c1c537b1b
• Add matchmaking model types required for server-side deploy
  Dan Balasescu · 2025-09-04 18:26:56 +09:00
  815bf9c37b
• Merge branch 'master' into pinned-rooms
  Dean Herbert · 2025-09-01 16:01:50 +09:00
  4e976cff6a
• Move footer to ScreenTestScene
  Dan Balasescu · 2025-08-29 17:49:48 +09:00
  04ba5aa575
• Update tests
  Bartłomiej Dach · 2025-08-22 12:44:08 +02:00
  03e7e2b0d8
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Fix leak due to missing Game disposal
  Dan Balasescu · 2025-07-09 03:37:02 +09:00
  74516a1eaa
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Fix flaky tests due to async disposal
  Dan Balasescu · 2025-06-27 19:43:26 +09:00
  c53a7aa2fc
• Attempt to fix flaky tests by removing finaliser
  Dan Balasescu · 2025-06-03 18:02:37 +09:00
  b152b786a5
• Add failing test case
  Bartłomiej Dach · 2025-05-16 12:45:47 +02:00
  8854db0264
• Add test cases covering correct legacy replay playback with respect to hitwindow treatment

  This continues on https://github.com/ppy/osu/pull/32770 via adding test
  cases which cover treatment of hit windows in stable in osu!, taiko, and
  mania. The test cases are exportable to beatmap `.osu` files and replay
  `.osr` files for stable crosscheck by setting `ExportLocation` on the
  test scene classes to a non-null path.
  
  For the most part, osu! and taiko ground truth matches previous findings
  - hit windows in those rulesets are floored to the nearest integer.
  The real "star" of this diff is mania, because:
  
  - The hit windows in mania depend on:
    - overall difficulty (as expected)
    - whether Score V2 is active
    - if Score V2 is not active, the hit windows also depend on whether
      the map was converted from another ruleset or not
  
  - Regardless of all aforementioned factors, mania hitwindows are *not
    symmetrical*. Due to what *appears* to be a straight-up bug, it is
    *not possible to achieve a MEH / 50 hit result when hitting late*.
    There is specific code that coerces late hits beyond 100 hit window
    range to full misses:
  
       https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L737-L751
  
  Note that despite the fact that I'm PRing these test cases, none of this
  is a promise that all of stable behaviours will be returning unchanged
  when I PR something to actually do something about this and the other
  issue of replay instability. This is just coverage, to be used for
  awareness of what's still broken. The extent of how much stable is going
  to be humored here going forward will be subject to negotiation.

  Bartłomiej Dach · 2025-04-15 13:22:06 +02:00
  82b2a92894
• Abstractify test scene

  I think in this case it's genuinely reasonable to use abstracts to
  reduce boilerplate.

  Bartłomiej Dach · 2025-04-11 12:09:53 +02:00
  30bb8e335c
• Clone countdown objects in test client

  Beyond isolation, this stuff is also used to test (de-)serialisation.
  Much-of-a-muchness in this case since it isn't too thoroughly tested,
  but best do it anyway.

  Dan Balasescu · 2025-04-08 18:42:25 +09:00
  874ec49590
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618
• Replace RoomID change with test-local fixes
  Dan Balasescu · 2025-03-31 16:32:32 +09:00
  74d234a7de
• Add tests for multiplayer implementation
  Dan Balasescu · 2025-03-25 16:03:56 +09:00
  a1894c9193
• Split tracker into per-system implementations
  Dan Balasescu · 2025-03-25 14:56:12 +09:00
  53ece9396a
• Refactor tracker to be a bit more stateless

  Removes storage of `selectedBeatmap` that was referenced through
  multiple class-level methods.
  
  To expound a bit, this structure felt better (or otherwise passing
  `APIBeatmap` through methods) alongside removal of the `#nullable
  disable`, otherwise each method would check `selectedBeatmap != null`.

  Dan Balasescu · 2025-03-25 14:23:05 +09:00
  72b56146ee