Bartłomiej Dach
359ae31204
Fix catch distance snap grid not moving
...
Regressed in https://github.com/ppy/osu/pull/25154 .
Specifically, in 013b5fa91674b86349d5
2023-10-26 15:42:50 +02:00
Bartłomiej Dach
5e059a362f
Merge pull request #25223 from peppy/prompt-before-save-for-export
...
Fix editor not prompting before saving beatmap for export
2023-10-25 12:03:26 +02:00
Bartłomiej Dach
4c80413551
Merge pull request #25222 from peppy/update-taiko-argon-barlines
...
Apply same changes to "argon" osu!taiko barline design that were applies to osu!mania
2023-10-25 11:56:52 +02:00
Bartłomiej Dach
9c9000027a
Merge pull request #25221 from peppy/fix-repeat-dim
...
Fix repeat circles on sliders not correctly getting dimmed
2023-10-25 11:43:46 +02:00
Dean Herbert
7dd11fc5bf
Fix null check
2023-10-25 17:55:55 +09:00
Bartłomiej Dach
2a075065d8
Merge pull request #25217 from peppy/update-country-codes
...
Update country code names to match database
2023-10-25 08:31:28 +02:00
Dean Herbert
a648b32519
Merge pull request #25191 from frenzibyte/velocity-based-ball-animation
...
Apply velocity into legacy slider ball animation rate
2023-10-25 14:45:24 +09:00
Dean Herbert
6934e045df
Fix editor not prompting before saving beatmap for export
2023-10-25 14:39:46 +09:00
Dean Herbert
2886d2d4c2
Apply same changes to "argon" osu!taiko barline design that were applied to osu!mania
2023-10-25 14:20:43 +09:00
Dean Herbert
74f794a549
Fix repeat circles on sliders not correctly getting dimmed
2023-10-25 14:01:55 +09:00
Dean Herbert
23ea128f30
Merge branch 'master' into velocity-based-ball-animation
2023-10-25 14:01:19 +09:00
Dean Herbert
121fa6f165
Simplify pre-checks in HitObjectApplied delegate
2023-10-25 13:53:20 +09:00
Dean Herbert
da07066a74
Add note about CountryCode being at parity with osu_countries
2023-10-25 13:03:03 +09:00
Dean Herbert
d9ec030cc8
Remove missing country
2023-10-25 13:02:15 +09:00
Dean Herbert
cd8b068f4c
Add fallback case to CountryExtensions.GetAcronym
2023-10-25 13:01:23 +09:00
Dean Herbert
34505b3933
Merge pull request #25185 from bdach/minimum-sample-volume
2023-10-24 22:04:43 +09:00
Dean Herbert
bf313cc732
Merge pull request #25216 from bdach/spinner-tick-lifetime
...
Fix spinner ticks not playing samples correctly sometimes
2023-10-24 19:12:49 +09:00
Bartłomiej Dach
19be0055d5
Merge pull request #24921 from Pasi4K5/diff-name-search
...
Add ability to search for difficulty names using square brackets
2023-10-24 12:07:02 +02:00
Bartłomiej Dach
966decb008
Remove redundant explicit array type specification
2023-10-24 11:25:37 +02:00
Dean Herbert
68397f0e81
Remove unused using
2023-10-24 18:01:24 +09:00
Bartłomiej Dach
a0c8158033
Remove unnecessary LifetimeEnd specification
2023-10-24 10:42:03 +02:00
Dean Herbert
c9161a7bfc
Remove incorrect copy paste fail
2023-10-24 17:32:01 +09:00
Bartłomiej Dach
abfe2ce0fe
Fix comment
2023-10-24 10:05:20 +02:00
Bartłomiej Dach
b4cc12ab5a
Fix formatting
2023-10-24 10:00:58 +02:00
Dean Herbert
fcb366af4d
Add diff= support for more advanced usages
2023-10-24 16:09:05 +09:00
Dean Herbert
6865d8894d
Simplify implementation and remove unsupported test coverage
2023-10-24 16:01:32 +09:00
Bartłomiej Dach
05d7516479
Merge pull request #25182 from peppy/song-select-scroll-improvemets
...
Improve mouse interactions at song select
2023-10-24 08:26:20 +02:00
Dean Herbert
794c3a2473
Add a couple more tests for sanity
2023-10-24 15:22:27 +09:00
Dean Herbert
b16ece32f4
Put tests in more correct place
2023-10-24 15:14:30 +09:00
Bartłomiej Dach
0e5a521695
Merge pull request #25157 from peppy/spinner-anti-cheese-final
...
Fix spinner cheese by accounting for spin directionality
2023-10-24 08:13:32 +02:00
Dean Herbert
383d715378
Fix incorrectly named test
2023-10-24 14:59:21 +09:00
Dean Herbert
1274829193
Block scroll and click operations on the left side of song select
2023-10-24 14:51:40 +09:00
Dean Herbert
17070707b5
Update and add remaining country codes to match database
2023-10-24 14:46:58 +09:00
Dean Herbert
11c949d091
Sort countries alphabetically
2023-10-24 14:45:25 +09:00
Dean Herbert
ded99c4097
Simplify calculation
2023-10-24 14:32:03 +09:00
Dean Herbert
1591246afb
Update country code names to match database
...
Required for ASS / osu-web cross-compatibility
2023-10-24 13:53:31 +09:00
Salman Ahmed
ff66b74b0e
Refactor logic to support DHO pooling
2023-10-24 02:24:00 +03:00
Pasi4K5
c5339f440e
Apply code review suggestions
2023-10-23 23:30:54 +02:00
Bartłomiej Dach
cfd8d05fde
Fix spinner ticks not playing samples correctly sometimes
...
Noticed this during work on https://github.com/ppy/osu/pull/25185 .
In some circumstances, it seemed that spinner bonus ticks (and mostly
them specifically) would not always play with the correct volume.
Hours of debugging later pointed at a trace at
`DrawableAudioWrapper.refreshLayoutFromParent()` not firing sometimes.
Initially I thought it to be some sort of framework bug, but after
preparing a diff and running final checks, I noticed that sometimes
the sample was being played *by a `PoolableSkinnableSample` that wasn't
loaded*. And determining why *that* is the case turned out with this
diff.
As it happens, spinner ticks get assigned a start time proportionally,
i.e. the 1st of 10 ticks is placed at 10% of the duration, the 2nd
at 20%, and so on. The start time generally shouldn't matter,
because the spinner is manually judging the ticks. *However*, the ticks
*still* receive a lifetime start / end in the same way normal objects
do, which means that in some cases they can *not be alive* when they're
hit, which means that the `DrawableAudioWrapper` flow *hasn't had
a chance to run*, and rightly so.
To fix, ensure that all spinner ticks are alive throughout the entirety
of the spinner's duration.
2023-10-23 21:29:55 +02:00
Dean Herbert
baf4130f3a
Fix test clock no longer accounting for rate changes
2023-10-23 22:28:40 +09:00
Bartłomiej Dach
4649d281ab
Merge pull request #25202 from EVAST9919/comments-image-size
...
Limit image size in `CommentMarkdownContainer`
2023-10-23 13:29:48 +02:00
Dean Herbert
d08ba764dd
Add extended testing of rewind
2023-10-23 20:29:46 +09:00
Dean Herbert
15c1fcbf96
Set ManualClock rate to 0 to avoid interpolation causing test errors
2023-10-23 20:29:36 +09:00
Dean Herbert
08b7c3d5ad
Remove test which makes less sense with new algorith
2023-10-23 20:01:23 +09:00
Andrei Zavatski
b18a5e63b7
Remove nullable disable
2023-10-23 13:29:46 +03:00
Andrei Zavatski
ac1783fa94
Fix comment
2023-10-23 13:26:59 +03:00
Andrei Zavatski
1dbdbd6de6
Merge branch 'master' into comments-image-size
2023-10-23 13:22:31 +03:00
Salman Ahmed
0cf572d029
Use existing property and fix nullability
2023-10-23 11:46:21 +03:00
Dean Herbert
4e057b446a
Rename accumulated rotation variable
2023-10-23 16:46:15 +09:00
Dean Herbert
fc1254ba47
Update resources
2023-10-23 16:15:56 +09:00
