1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 16:47:46 +08:00

Remove unnecessary LifetimeEnd specification

This commit is contained in:
Bartłomiej Dach 2023-10-24 10:42:03 +02:00
parent cfd8d05fde
commit a0c8158033
No known key found for this signature in database

View File

@ -5,7 +5,6 @@
using osu.Framework.Graphics;
using osu.Game.Rulesets.Objects;
using osu.Game.Rulesets.Objects.Drawables;
namespace osu.Game.Rulesets.Osu.Objects.Drawables
{
@ -37,16 +36,6 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
LifetimeStart = DrawableSpinner.HitObject.StartTime;
}
protected override void UpdateHitStateTransforms(ArmedState state)
{
base.UpdateHitStateTransforms(state);
// the tick can be theoretically judged at any point in the spinner's duration,
// so it must be alive throughout the spinner's entire lifetime (or until hit, whichever applies).
// this mostly matters for correct sample playback.
LifetimeEnd = (Result?.IsHit == true ? Result.TimeAbsolute : DrawableSpinner.HitObject.GetEndTime()) + (Samples?.Length ?? 0);
}
/// <summary>
/// Apply a judgement result.
/// </summary>