1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-07 16:07:25 +08:00
Commit Graph

37381 Commits

Author SHA1 Message Date
Bartłomiej Dach
2e63c2ce20 Fix selection box operation hotkeys not registering in change handler
Could lead to crashes after reversing a note cluster and playing it
back.

The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.

Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.
2021-03-17 22:17:42 +01:00
Dan Balasescu
5a7e416495
Merge pull request #12027 from peppy/new-beatmap-empty-fields
Don't fill beatmap metadata with template values on creating a new beatmap
2021-03-17 19:36:21 +09:00
Dean Herbert
822d469b2c
Merge pull request #12024 from peppy/fix-editor-startup-threading-crash 2021-03-17 18:02:48 +09:00
Dean Herbert
d0e61e5b4d Put back the label 2021-03-17 17:14:04 +09:00
Dean Herbert
3b6a1180b6 Remove non-accessed field 2021-03-17 17:02:11 +09:00
Dean Herbert
5adc675862 Focus artist textbox on entering song setup if fields are empty 2021-03-17 16:57:14 +09:00
Dean Herbert
26d6f96c4e Fix LabelledTextBox not correctly forwarding focus to its underlying TextBox component 2021-03-17 16:56:58 +09:00
Dean Herbert
eda891223c Start the editor with empty artist/creator/difficulty name fields 2021-03-17 16:47:12 +09:00
Dean Herbert
c7740d1181 Fix opening the editor occasionally causing a hard crash due to incorrect threading logic
Setting one of the global screen `Bindable`s (in this case, `Beatmap`)
is not valid from anywhere but the update thread. This changes the order
in which things happen during the editor startup process to ensure
correctness.

Closes #11968.
2021-03-17 15:52:25 +09:00
Dan Balasescu
891e7aadb6
Merge pull request #12015 from Joehuu/fix-mouse-disable-default-indicator
Fix disable mouse buttons setting not showing default indicator when using keybind
2021-03-16 11:51:53 +09:00
smoogipoo
b495504cae Merge branch 'master' into fix-mouse-disable-default-indicator 2021-03-16 10:58:56 +09:00
smoogipoo
da3dc61aae Remove newline 2021-03-16 10:58:42 +09:00
Bartłomiej Dach
712038f771
Merge pull request #12017 from Joehuu/remove-skype
Remove skype handle from user profile overlay
2021-03-15 19:55:37 +01:00
Joehu
393f1fbd3f Remove skype 2021-03-15 10:07:50 -07:00
Dean Herbert
f3faad74d5
Merge pull request #12003 from UselessToucan/ef_core_5 2021-03-15 15:05:32 +09:00
Joehu
3dd72d6f7d Fix disable mouse buttons setting not showing default indicator when using keybind 2021-03-14 22:47:05 -07:00
Dean Herbert
712e7bc7bf
Merge pull request #12014 from peppy/fix-eap7-inspections
Fix a couple of new inspections introduced in Rider EAPs
2021-03-15 14:26:36 +09:00
Dean Herbert
1e519f0d31 Fix seemingly innocent logic change causing breakage in score imports 2021-03-15 14:20:59 +09:00
Dean Herbert
6d4c1ba2ae Fix a couple of new inspections introduced in Rider EAPs 2021-03-15 13:35:08 +09:00
Dean Herbert
fce21f23d6 Add comments marking workarounds required for EFcore 5 2021-03-15 13:29:26 +09:00
Dean Herbert
2904f479c6 Share file lookup workaround in ArchiveModelManager with workaround extensions class 2021-03-15 13:26:14 +09:00
Dean Herbert
79d3379f55 Reformat application of configuration 2021-03-15 13:20:22 +09:00
Dean Herbert
1573298e68 Update remaining package references to point to efcore5 2021-03-15 13:12:10 +09:00
Dean Herbert
8a35533889 Add fall-through case to catch a potential requery for unsupported model type 2021-03-15 13:11:58 +09:00
Dean Herbert
2bdffd1004 Move skin requery logic into extension methods 2021-03-15 13:11:58 +09:00
Dean Herbert
900da7b891 Rename and refactor extenion methods to be easier to read 2021-03-15 13:11:58 +09:00
Roman Kapustin
28ef64b62a Explicitly specify SingleQuery behavior 2021-03-14 21:43:27 +03:00
Roman Kapustin
61d5a6cc57 Simplify Microsoft.EntityFrameworkCore.Design PackageReference 2021-03-14 19:47:14 +03:00
Roman Kapustin
0a1e325fc7 Extract requerying of navigational properties from DbContext 2021-03-14 19:34:53 +03:00
Bartłomiej Dach
716b9048c1
Merge pull request #12008 from Joehuu/user-hide-toolbar-forever 2021-03-13 18:03:25 +01:00
Bartłomiej Dach
6438a7ee12
Merge branch 'master' into user-hide-toolbar-forever 2021-03-13 17:31:37 +01:00
Bartłomiej Dach
27f51ac588
Merge pull request #12009 from peppy/fix-changelog 2021-03-13 15:53:05 +01:00
Dean Herbert
a227b0a581 Build on xmldoc with rationale 2021-03-13 23:29:47 +09:00
Dean Herbert
e70ba2d005 Remove unnecessary second variable 2021-03-13 23:29:01 +09:00
Dean Herbert
4afbccfcff Fix initial operation potentially running before DI is completed 2021-03-13 19:30:40 +09:00
Dean Herbert
b13f193c8d Fix incorrect task being returned for changelog continuations 2021-03-13 19:26:38 +09:00
Joehu
0ba5312a40 Move blocking show logic to UpdateState 2021-03-13 00:05:26 -08:00
Joehu
5999e4ba33 Add xmldoc for hiddenbyuser bool 2021-03-12 20:18:32 -08:00
Joehu
62f2a823f6 Hide toolbar forever when the user hides it 2021-03-12 15:48:50 -08:00
Joehu
6c0734a09f Handle global action in toolbar instead of osugame 2021-03-12 15:48:49 -08:00
Joehu
d0644221ff Add test showing toolbar behavior change 2021-03-12 15:48:49 -08:00
Dean Herbert
9b5e35565b
Merge pull request #11975 from frenzibyte/legacy-spinner-placements
Adjust legacy spinner components placements to match osu!stable
2021-03-12 23:12:43 +09:00
Dean Herbert
e3813ab828
Merge branch 'master' into legacy-spinner-placements 2021-03-12 19:47:34 +09:00
Dan Balasescu
6e7bb87977
Merge pull request #12005 from peppy/fix-settings-reset-button-tooltips
Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing
2021-03-12 16:06:38 +09:00
Dean Herbert
e7707eee94 Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing 2021-03-12 15:23:11 +09:00
Roman Kapustin
a60ff80c04 Use expression body in ModsJson get accessor 2021-03-12 00:02:29 +03:00
Roman Kapustin
5a4b0174b1 Ignore MultipleCollectionIncludeWarning 2021-03-11 22:40:35 +03:00
Roman Kapustin
d2f943395d Hotfix importing scores from stable 2021-03-11 22:12:47 +03:00
Roman Kapustin
c6c616f244 Actualize tests 2021-03-11 21:02:40 +03:00
Roman Kapustin
47b80d2474 Workaround InvalidOperation exceptions 2021-03-11 20:51:54 +03:00