568 Commits

• Fix typo
  Bartłomiej Dach · 2025-06-30 11:03:06 +02:00
  a8e3ce9af1
• Refactor distance-between-panels implementation

  The new version wasn't really working as expected, because the Y
  position measurement only considered visible panels, while it was being
  divided over all panels (including non-expanded groups or sets).
  
  Rather than trying to divide across all panels, just choose a sane
  number for the "highest pitch" sound and work with that as a constant.

  Dean Herbert · 2025-06-30 16:21:41 +09:00
  d7b7640055
• Play error sound when random selection fails
  Dean Herbert · 2025-06-30 16:20:32 +09:00
  bf8b6754dc
• Fix random sound effect not playing correctly
  Dean Herbert · 2025-06-30 16:09:23 +09:00
  9155f566ec
• Rewrite and add commentary to selection debounce logic

  Hopefully a bit easier to maintain going forward? Not sure.

  Dean Herbert · 2025-06-25 17:58:54 +09:00
  49a9652fa5
• Merge pull request #33773 from peppy/fix-carousel-random-not-respecting-group

  SongSelectV2: Refine random selection to currently open group (and support difficulty split panels better)

  Bartłomiej Dach · 2025-06-24 14:37:09 +02:00
  a797c46d75
• Ensure expanded group is cleared when grouping is turned off
  Bartłomiej Dach · 2025-06-24 13:38:32 +02:00
  8781901d6b
• Expand test to cover more potential weirdness and fix said weirdness
  Dean Herbert · 2025-06-24 19:21:04 +09:00
  7b6ecbd10b
• Merge pull request #33679 from bdach/truncate-sr

  Floor star rating to 2 decimal places rather than rounding

  Dan Balasescu · 2025-06-24 19:04:56 +09:00
  6057c6c4d4
• Fix potential crash when attempting random selection after changing grouping mode
  Dean Herbert · 2025-06-24 17:48:38 +09:00
  a1ec71e677
• Merge pull request #33832 from Molla7605/adjust-beatmap-panel-margin-and-padding

  Increase margin and padding in beatmap panel to make it easier on the eyes

  Dean Herbert · 2025-06-24 17:29:09 +09:00
  c41df30349
• Merge pull request #33828 from frenzibyte/fix-nullability

  Fix null reference in metadata wedge when accessing beatmap tags

  Dean Herbert · 2025-06-24 15:21:38 +09:00
  40ac1fa634
• Merge pull request #33664 from peppy/footer-metrics

  Remove fade from footer display transition

  Bartłomiej Dach · 2025-06-24 07:45:29 +02:00
  02ce399150
• Use padding instead of margin in PanelBeatmap
  jyc76 · 2025-06-23 23:49:49 +09:00
  96db5677ca
• Fix top and bottom spacing of the local rank display
  jyc76 · 2025-06-23 23:31:20 +09:00
  a9347ff8c3
• Increase margin in PanelBeatmap to improve legibility
  jyc76 · 2025-06-23 17:24:26 +09:00
  cef6445e2b
• Fix null reference in metadata wedge when accessing beatmap tags
  Salman Alshamrani · 2025-06-23 00:41:12 +03:00
  ef9fed47a9
• Remove remaining excess MarginPadding
  diquoks · 2025-06-21 21:06:20 +03:00
  71e4f4129f
• Add localisation usage to BeatmapStatistic and revert ShowDetailsMappedBy
  diquoks · 2025-06-21 21:01:48 +03:00
  cad4382350
• Add new strings to SongSelectStrings.cs
  diquoks · 2025-06-21 18:23:50 +03:00
  4661cb4818
• Add localisation to Collections string on SongSelect
  diquoks · 2025-06-21 14:05:20 +03:00
  3192eaa2a2
• Use MarginPadding instead of leading space, change incorrect LocalisableString
  diquoks · 2025-06-21 12:35:02 +03:00
  acc4267a2d
• Use localised strings for SSV2
  diquoks · 2025-06-20 18:40:21 +03:00
  fd27d43814
• Fix incorrectly named variable
  Dean Herbert · 2025-06-20 20:18:47 +09:00
  f3f137dbd4
• Merge pull request #33765 from frenzibyte/autoplay-retain-mod-settings

  Fix incompatible mods not retaining settings after selecting autoplay via ctrl+enter

  Dean Herbert · 2025-06-20 18:58:59 +09:00
  21eb4a6260
• Merge pull request #33668 from peppy/ssv2-group-key-bindings
  Bartłomiej Dach · 2025-06-19 17:35:28 +02:00
  267a6a0ac7
• Fix global beatmap validity potentially being checked on a stale beatmap

  Noticed in a flaky test with the changes to random, where the debounce
  may be delayed to the point of thinking the selection is invalid even
  though it's valid (timing woes, I cannot explain in words but I would
  highly recommend smiling and nodding approach).

  Dean Herbert · 2025-06-19 17:29:42 +09:00
  873d622918
• SongSelectV2: Fix random selection not working as expected when displaying individual difficulties

  Previously, random selection would always be done at a *set* level. The
  final operation of a random action would be "select the user's
  recommended difficulty from this randomly selected set".
  
  This makes no sense when sets are not grouped together at song select.
  In fact, it is completely broken with the previous commit which adds
  group-isolated random support – if we're grouping by difficulty and the
  user's recommendation is not in the current group it would throw the
  user into another group unexpectedly.
  
  This fixes the issue by splitting out the random implementation into two
  separate pathways depending on the carousel display mode.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  f676206331
• SongSelectV2: Fix random button not respecting open group

  Closes https://github.com/ppy/osu/issues/33569.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  d200a59902
• Deep clone mods when temporarily activating autoplay
  Salman Alshamrani · 2025-06-18 19:27:32 +03:00
  ce498c9062
• Fix skin layer not hiding when revealing background
  Dean Herbert · 2025-06-17 14:41:27 +09:00
  36b5da3bd0
• Fix crash when random and rewind are run on the same frame
  Dean Herbert · 2025-06-16 20:17:07 +09:00
  10c07fdf50
• Add localisation support to difficulty range slider
  Salman Alshamrani · 2025-06-14 15:05:05 +03:00
  977c26d02f
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Add support for toggling current group expansion using shift-enter

  Closes https://github.com/ppy/osu/issues/33617.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  52ba22ca1f
• Fix textbox shift-left/right conflicting with new group changing bindings
  Dean Herbert · 2025-06-12 20:36:02 +09:00
  f82cb6d767
• Add support for traversing between groups using shift-left/right

  Closes https://github.com/ppy/osu/issues/33599.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  3816c5d95f
• Merge pull request #33629 from peppy/ssv2-reveal-background

  Add ability to reveal background when long pressing in empty space

  Bartłomiej Dach · 2025-06-12 11:09:01 +02:00
  66c80ccb16
• Fix carousel drags being incorrectly handled as background reveal
  Dean Herbert · 2025-06-12 16:48:29 +09:00
  968b5b0082
• Merge pull request #33639 from peppy/ssv2-renames

  Move and rename next/previous "group" selection keybindings to make way for group-specific bindings

  Bartłomiej Dach · 2025-06-12 08:42:11 +02:00
  37e8cc9afc
• Disable when using touch input
  Dean Herbert · 2025-06-11 22:28:50 +09:00
  fc5ea7f3f2
• Move and rename next/previous "group" selection keybindings to make way for group-specific bindings
  Dean Herbert · 2025-06-11 21:02:52 +09:00
  b9e1b6969e
• Remove outer grid container to avoid masked-away issues
  Salman Alshamrani · 2025-06-11 14:51:21 +03:00
  9a9cbcdd26
• Add ability to reveal background when long pressing in empty space

  As touched on in https://github.com/ppy/osu/discussions/33624.
  
  Maybe fine as a bit of an easter egg?

  Dean Herbert · 2025-06-11 17:19:33 +09:00
  edf62baae8
• Add back scrollbar padding in new beatmap carousel

  Closes https://github.com/ppy/osu/issues/33447. Implementation copied
  from previous carousel.

  Dean Herbert · 2025-06-11 16:34:04 +09:00
  cfd73cc900
• Merge pull request #33598 from peppy/ssv2-difficulty-traversal-selection

  Allow changing difficulties using up and down arrows when sets are grouped

  Bartłomiej Dach · 2025-06-11 08:34:10 +02:00
  932ba3d590
• Merge pull request #33607 from peppy/ssv2-show-full-mod-details-footer

  SongSelectV2: Show full mod details in footer

  Bartłomiej Dach · 2025-06-10 11:21:50 +02:00
  97e6187f0d
• Fix tooltip not being displayed around edges of text content
  Dean Herbert · 2025-06-10 17:17:48 +09:00
  599b4c8236
• Merge pull request #33605 from peppy/ssv2-remove-update-button-shear

  Remove shear on update button to match non-sheared panel design

  Bartłomiej Dach · 2025-06-10 08:54:52 +02:00
  f59df15bf8
• SongSelectV2: Show full mod details in footer

  User feedback is that it's no longer possible to see the applied rate
  adjust change when it's non-default without hovering. This fixes that
  issue.
  
  I've adjusted the visuals a bit so you can still get a hint at which
  mods are displayed, even when they are overflowing.

  Dean Herbert · 2025-06-10 15:34:03 +09:00
  f16a7309f8