35692 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into fix-user-lookup-failure-crashes
  Bartłomiej Dach · 2020-12-28 12:15:06 +01:00
  20ae84a466
• Merge pull request #11339 from peppy/update-fastlane
  Bartłomiej Dach · 2020-12-28 11:06:55 +01:00
  cf29d0c5ef
• Merge branch 'master' into update-fastlane
  Bartłomiej Dach · 2020-12-28 10:32:43 +01:00
  d5b02e6f27
• Merge pull request #11340 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2020-12-28 10:09:23 +01:00
  e33dd04282
• Update framework
  Dean Herbert · 2020-12-28 16:52:54 +09:00
  2e3537e966
• Update fastlane and dependencies
  Dean Herbert · 2020-12-28 16:51:45 +09:00
  bdbc210f6d
• Allow null users to still be displayed in the participant list

  The fix here is correcting the access of `user.Country`. The deicision
  to have null users display is because this is the best we can do (if
  osu-web could not resolve the user). We still want the users in the
  lobby to be aware of this user's presence, rather than hiding them from
  view.
  
  osu-stable does a similar thing, showing these users as `[Loading]`. I
  decided to go with blank names instead because having *any* text there
  causes confusion. We can iterate on this in future design updates.

  Dean Herbert · 2020-12-28 15:03:44 +09:00
  046a76cb1d
• Fix lookup cache throwing a null reference if no matches were successful
  Dean Herbert · 2020-12-28 15:03:44 +09:00
  4d61c143db
• Merge pull request #11307 from bdach/fix-account-creation-overlay-after-logout

  Fix account creation overlay not showing up the first time after a log-out

  Dean Herbert · 2020-12-28 11:52:48 +09:00
  69fab7de77
• Merge pull request #11314 from bdach/changelog-refactor

  Refactor changelog code after migrating away from production web instance

  Dean Herbert · 2020-12-28 11:39:48 +09:00
  092b22708a
• Merge branch 'master' into changelog-refactor
  Dean Herbert · 2020-12-28 11:00:14 +09:00
  1b7c72f03b
• Merge pull request #11320 from peppy/fix-quit-user-showing-in-leaderboard
  Bartłomiej Dach · 2020-12-27 13:35:28 +01:00
  70a2ab824a
• Merge branch 'master' into fix-quit-user-showing-in-leaderboard
  Bartłomiej Dach · 2020-12-27 13:02:40 +01:00
  2ff49f4758
• Explicitly use discard in value changed callback
  Bartłomiej Dach · 2020-12-27 13:00:27 +01:00
  f75dccc9e4
• Rename method to be less misleading

  As it doesn't only change colour, but also width.

  Bartłomiej Dach · 2020-12-27 12:58:37 +01:00
  6b6b1514e2
• Merge pull request #11323 from bdach/fix-gameplay-leaderboard-clickable-avatars

  Fix gameplay leaderboard avatars being clickable

  Dean Herbert · 2020-12-27 20:40:47 +09:00
  7dd572fe9e
• Merge branch 'master' into fix-gameplay-leaderboard-clickable-avatars
  Dean Herbert · 2020-12-27 19:00:38 +09:00
  3b5260fd67
• Remove dignostics using
  Dean Herbert · 2020-12-27 16:57:23 +09:00
  1b34f2115f
• Remove assert for now
  Dean Herbert · 2020-12-27 16:42:20 +09:00
  d14a8d24b5
• Move quit colour change implementation to updateColour for better coverage
  Dean Herbert · 2020-12-27 13:40:02 +09:00
  fa0576f47f
• Fix gameplay leaderboard avatars being clickable
  Bartłomiej Dach · 2020-12-26 14:35:14 +01:00
  15948de2f0
• Move load-complete fade specification inside
  Bartłomiej Dach · 2020-12-26 14:35:14 +01:00
  8ec7970b6a
• Bring back DrawableAvatar as a simple sprite
  Bartłomiej Dach · 2020-12-26 14:35:14 +01:00
  e8f96b2401
• Rename {Drawable -> Clickable}Avatar
  Bartłomiej Dach · 2020-12-26 14:35:11 +01:00
  0b42b4b955
• Merge pull request #11319 from Neuheit/patch/11310
  Bartłomiej Dach · 2020-12-26 13:57:59 +01:00
  6849eabf2c
• Merge branch 'master' into patch/11310
  Bartłomiej Dach · 2020-12-26 13:19:13 +01:00
  a1af749b4b
• Merge pull request #11318 from peppy/fix-ready-button-crash
  Bartłomiej Dach · 2020-12-26 13:18:40 +01:00
  3e06f592a1
• Merge branch 'master' into fix-ready-button-crash
  Bartłomiej Dach · 2020-12-26 12:41:47 +01:00
  b059b5d616
• Merge pull request #11316 from peppy/multiplayer-client-threading-fixes

  Fix join room failures on large lobbies

  Dean Herbert · 2020-12-26 20:38:47 +09:00
  36dfff64c8
• Don't copy spotlight category
  Dean Herbert · 2020-12-26 20:13:28 +09:00
  b9d725ab49
• Allow all StatefulMultiplayerClient schedules to run inline

  Fixes test failures due to not allowing to do so, therefore inverting
  execution order in some cases - for example, calling
  
          JoinRoom(room);
          LeaveRoom();
  
  on the update thread would invert execution order due to the first being
  unscheduled but the second being scheduled.

  Bartłomiej Dach · 2020-12-26 12:04:10 +01:00
  04d54c40db
• Run user list copy inline if possible

  `getRoomUsers()` was not safe to call from the update thread, as
  evidenced by the test failures. This was due to the fact that the added
  reset event could never actually be set from within the method, as the
  wait was blocking the scheduled set from ever proceeding.
  
  Resolve by allowing the scheduled copy & set to run inline if on the
  update thread already.

  Bartłomiej Dach · 2020-12-26 12:03:03 +01:00
  dae27fefe4
• Ensure the previous leaderboard is removed
  Dean Herbert · 2020-12-26 17:55:24 +09:00
  966a2151e3
• Add test coverage
  Dean Herbert · 2020-12-26 12:11:19 +09:00
  2599e95335
• Mark user as quit visually on the leaderboard
  Dean Herbert · 2020-12-26 12:11:09 +09:00
  71dcbeaf7c
• Add flow for marking user as quit for further handling
  Dean Herbert · 2020-12-26 11:35:51 +09:00
  116acc2b5e
• Fix multiplayer leaderboard not unsubscribing from quit users
  Dean Herbert · 2020-12-26 11:35:31 +09:00
  ff57562956
• fix(osu.Game): Ensure Category property is copied in Room.
  Neuheit · 2020-12-25 21:07:33 -05:00
  e7339d6959
• Don't fail if the local user is not present in room users when updating ready button state
  Dean Herbert · 2020-12-26 10:49:22 +09:00
  fe1bbb1cac
• Rename OnRoomChanged to OnRoomUpdated to avoid confusion
  Dean Herbert · 2020-12-26 10:49:02 +09:00
  f9900720d5
• Fix non-safe thread access to room users on room join
  Dean Herbert · 2020-12-26 10:25:16 +09:00
  5ce5b6cec0
• Fix user population happening in single file
  Dean Herbert · 2020-12-26 09:48:13 +09:00
  e0198c36ae
• Merge pull request #11312 from bdach/online-play-namespace

  Rename Multi namespace to OnlinePlay

  Dean Herbert · 2020-12-26 09:01:08 +09:00
  ff811e9a88
• Schedule all of setup to avoid headless test fail
  Bartłomiej Dach · 2020-12-25 21:06:03 +01:00
  09b0a57290
• Improve test scene coverage of corner cases
  Bartłomiej Dach · 2020-12-25 21:06:03 +01:00
  c32fc05f69
• Extract changelog entry component
  Bartłomiej Dach · 2020-12-25 21:06:03 +01:00
  0aedc720f2
• Handle all changelog entry types correctly
  Bartłomiej Dach · 2020-12-25 21:06:03 +01:00
  3ac618778f
• Fix tests failing due to base logic firing

  It turns out that the changelog code was semi-intentionally relying on
  the request to get release streams to be slow to initially show the
  listing of all streams.
  
  Locally suppress the base tab control logic to fix this.

  Bartłomiej Dach · 2020-12-25 21:06:03 +01:00
  5f43299d37
• Decouple changelog test scene from web
  Bartłomiej Dach · 2020-12-25 21:06:03 +01:00
  dacf6d5a34
• Refactor update stream colour mapping code
  Bartłomiej Dach · 2020-12-25 21:06:03 +01:00
  0bd9f68cbd