1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 07:17:51 +08:00
Commit Graph

59723 Commits

Author SHA1 Message Date
Joseph Madamba
af389b1107
Replace all hardcoded 50 horizontal padding with const 2023-04-02 20:50:18 -07:00
Joseph Madamba
7a0edabd5d
Normalise overlay horizontal padding const 2023-04-02 20:24:13 -07:00
Dean Herbert
daf9f19b29
Merge pull request #23098 from Joehuu/update-vote-pill-hover
Update comment vote pill in line with web
2023-04-03 12:01:46 +09:00
Dean Herbert
8932668f77 Update framework 2023-04-03 10:31:47 +09:00
Joseph Madamba
63ea17f10e
Update comment vote pill in line with web 2023-04-02 18:17:40 -07:00
Bartłomiej Dach
bc0538a7f6
Merge pull request #23089 from Susko3/fix-window-mode-dropdown
Fix window mode dropdown not showing
2023-04-02 20:24:32 +02:00
Susko3
c3a6a58169 Fix window mode dropdown not showing 2023-04-02 19:23:18 +02:00
Dean Herbert
ea42e7f3fa
Merge pull request #23034 from peppy/fix-ruleset-shader-caching
Fix stutters during gameplay due to shaders not correctly using cache
2023-04-03 00:20:48 +09:00
Dean Herbert
1e0b64c9e8 Update framework (again) 2023-04-02 23:07:40 +09:00
cdwcgt
d949ef3ca4
make guestMapperContainer private
tests don't use it
2023-04-02 22:53:15 +09:00
cdwcgt
2cf8636366
show guest diff author in BeatmapPicker 2023-04-02 22:25:58 +09:00
Dean Herbert
4c2b7e7788 Fix random inspection showing up only in CI 2023-04-02 21:05:20 +09:00
Dean Herbert
e66569b394 Update ruleset dependency tests in line with nullable changes 2023-04-02 21:04:44 +09:00
Dean Herbert
cf5acbf66e Update usage of SupportedWindowModes 2023-04-02 20:16:14 +09:00
Dean Herbert
0f0dd9f2dc Update resources 2023-04-02 20:07:33 +09:00
Dean Herbert
7f9bf09e03 Update framework 2023-04-02 20:07:31 +09:00
Dean Herbert
327e284db2
Merge pull request #23053 from peppy/fix-catch-caught-size
Fix circle-size based scale being applied twice to caught fruit
2023-03-31 20:25:12 +09:00
Dean Herbert
4b294278d6 Merge branch 'master' into fix-ruleset-shader-caching 2023-03-31 20:04:55 +09:00
Dan Balasescu
e78d6c861f
Merge pull request #23050 from peppy/debug-use-en-localisation-fallbacks
Always use `LocalisableString` fallbacks when deploying debug and viewing english
2023-03-31 18:26:03 +09:00
Dean Herbert
1277c8eb5a
Merge branch 'master' into debug-use-en-localisation-fallbacks 2023-03-31 17:26:56 +09:00
Dan Balasescu
4b7d44c329
Remove unused using 2023-03-31 16:23:56 +09:00
Dan Balasescu
28f31ef379
Adjust comment slightly 2023-03-31 16:23:37 +09:00
Dan Balasescu
d5b8a45541
Always use fallback strings for English
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-03-31 16:20:16 +09:00
Dean Herbert
8fbb3d50d9
Merge pull request #23048 from peppy/fix-fail-progression-to-results
Fix game incorrectly reaching results screen when saving failed replay on beatmap with video
2023-03-31 13:18:40 +09:00
Dean Herbert
db71db8491 Update README bounty/compensation section in line with changes applied to osu-web 2023-03-31 13:07:14 +09:00
Bartłomiej Dach
bfbb5ab96b
Merge branch 'master' into fix-fail-progression-to-results 2023-03-30 21:40:49 +02:00
Dean Herbert
796cd9c916 Rewrite comment explaining early return on checkScoreCompleted given new usages 2023-03-31 02:36:17 +09:00
Dean Herbert
b25a59fd14 Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed 2023-03-31 02:30:04 +09:00
Bartłomiej Dach
ea7bf3586d
Merge pull request #23049 from peppy/fix-newlines-in-notification
Fix localisation for audio device error containing incorrect newline escaping
2023-03-29 22:30:01 +02:00
Dean Herbert
836c884aae Fix circle-size based scale being applied twice to caught fruit
Closes #22968.
2023-03-29 18:03:22 +09:00
Dean Herbert
72c5c9848f Always use LocalisableString fallbacks when deploying debug and viewing english
This allows changes to `xxxStrings.cs` files to immediately reflect in
the UI, which is (at least for me) an expectation.
2023-03-29 14:44:43 +09:00
Dean Herbert
c7003434b2 Fix localisation for audio device error containing incorrect newline escaping 2023-03-29 14:33:10 +09:00
Dean Herbert
4dd0c2c7a5 Add assert ensuring we don't ever get to the results screen with an F rank
Intentionally an assertion as I want tests to fail, but I don't want
this to cause crashes for an end user if it does happen to occur.
2023-03-29 14:11:58 +09:00
Dean Herbert
a8bb2e33ac Ensure all preconditions are checked before progressing to results screen after storyboard ends 2023-03-29 14:00:11 +09:00
Dean Herbert
9b45591c2f Add failing test coverage of saving failed replay causing progression to results 2023-03-29 14:00:11 +09:00
Dean Herbert
aad540629f Remove duplicate load rule from ShaderPrecompiler 2023-03-29 12:36:56 +09:00
Bartłomiej Dach
c0e60a0699
Merge pull request #23037 from peppy/no-spinner-fade-extension
Fix spinners being selectable for too long after they fade in the editor
2023-03-28 22:56:22 +02:00
Bartłomiej Dach
22bc5dff4e
Merge pull request #23036 from peppy/fix-account-reg-warning-bypass
Fix web account registration not bypassing the URL warning
2023-03-28 22:14:58 +02:00
Dean Herbert
45e3e3623b Fix spinners being selectable for too long after they fade in the editor
The actual visual extension is only applied to `HitCircle`s (which does include slider
start / end), and should not be applied to spinners in the first place.

Addresses https://github.com/ppy/osu/discussions/22949.
2023-03-28 18:49:59 +09:00
Dean Herbert
8c1df3c8d9 Fix web account registration not bypassing the URL warning 2023-03-28 15:38:19 +09:00
Dean Herbert
5c82d1f777
Merge pull request #22995 from Joehuu/fix-select-beatmap-keyboard-highlight
Fix select beatmap button not highlighting when creating a multiplayer room using keyboard
2023-03-28 15:34:47 +09:00
Dean Herbert
e9fd17461b
Merge pull request #23024 from bdach/mania-argon-explosion-upscroll
Fix hit lighting misalignment on argon skin with upscroll
2023-03-28 15:05:15 +09:00
Dean Herbert
0d77ec013a Fix ruleset-local shader manager not correctly falling back to existing cached shaders 2023-03-28 15:00:49 +09:00
Dean Herbert
5dfac02b11 Preload triangle shader on startup 2023-03-28 14:15:38 +09:00
Dean Herbert
c742b3f0a8 Update DrawableRulesetDependencies xmldoc to read more correctly 2023-03-28 14:15:19 +09:00
Bartłomiej Dach
8fc1fbc145
Merge branch 'master' into mania-argon-explosion-upscroll 2023-03-28 06:22:09 +02:00
Bartłomiej Dach
2b525b626c
Revert to previous conditional style 2023-03-28 06:22:00 +02:00
Dean Herbert
c50f457b13
Merge pull request #23018 from VoltrexKeyva/actions-tweaks
github: update workflows and make tweaks
2023-03-28 12:53:08 +09:00
Bartłomiej Dach
c54934cb45
Fix hit lighting misalignment on argon skin with upscroll 2023-03-27 18:15:01 +02:00
Bartłomiej Dach
f31e77dce5
Add direction switching to TestSceneManiaPlayer
To test upscroll easier, and with all parts in conjunction.
`ManiaSkinnableTestScene`s already had the capability to switch
directions, but they did not show all parts together, which meant
regressions were missed.
2023-03-27 18:08:14 +02:00