414 Commits

• Add failing test coverage for toggling mod overlay with hotkey
  Bartłomiej Dach · 2022-05-05 22:16:56 +02:00
  8f65e0e60f
• Allow right-clicking to rewind on random button
  Salman Ahmed · 2022-04-29 10:12:24 +03:00
  856ca96b66
• Add inputting test coverage
  Salman Ahmed · 2022-04-29 04:14:09 +03:00
  294340279e
• Fix failing string comparison tests
  Joseph Madamba · 2022-04-20 16:52:24 -07:00
  0146949ad6
• Update further tests to cache using IDialogOverlay
  Salman Ahmed · 2022-04-18 21:04:22 +03:00
  3cbc6cd297
• Merge pull request #17555 from peppy/remove-source-from-wedge

  Remove song source from main wedge display

  Dan Balasescu · 2022-03-30 18:57:25 +09:00
  cb1ee05539
• Remove song source from main wedge display

  This was definitely added at someone's request, since I wouldn't have
  put it here. But it's displayed below in the details section already and
  also not displayed in the updated "wedge" in the new design.
  
  See https://github.com/ppy/osu/discussions/17537 for discussion.

  Dean Herbert · 2022-03-30 17:59:40 +09:00
  bc0b982102
• Add test coverage
  Salman Ahmed · 2022-03-30 01:08:22 +03:00
  b7ae431252
• Merge pull request #17170 from peppy/fix-top-local-rank-test-failures-realm-callback

  Refactor top local rank test method to be more resilient to slow realm callbacks

  Dan Balasescu · 2022-03-09 11:14:37 +09:00
  810cbd745d
• Fix TestSceneTopLocalRank.TestHighScoreSet not waiting for potentially slow realm callback

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.

  Dean Herbert · 2022-03-09 01:22:01 +09:00
  233c8232d3
• Refactor multiple TestScenePlaySongSelect test methods to be resilient to slow realm callbacks
  Dean Herbert · 2022-03-09 01:18:53 +09:00
  286bafe326
• Add specific placeholder message for custom rulesets rather than showing network error
  Dean Herbert · 2022-03-02 14:10:59 +09:00
  c342030b2c
• Merge pull request #16890 from peppy/beatmap-decoder-ruleset-store

  Fix `LegacyBeatmapDecoder` not populating correct rulesets

  Dan Balasescu · 2022-02-25 19:03:43 +09:00
  3a03833912
• Merge scoreboard and leaderboard implementations together
  dekrain · 2022-02-19 20:47:02 +01:00
  15ed9ec4fa
• Add tests for timerefs
  dekrain · 2022-02-17 10:38:29 +01:00
  f4d1e6f600
• Update existing usages to point to RealmRulesetStore
  Dean Herbert · 2022-02-16 17:13:54 +09:00
  0138f22c8d
• Add test coverage checking carousel panel visual state after ruleset filter change
  Dean Herbert · 2022-02-11 15:21:01 +09:00
  f012f64fd1
• Fix TestSelectingFilteredRuleset failing under visual tests due to using local database
  Dean Herbert · 2022-02-03 16:04:05 +09:00
  41aa4b8cca
• Revert mod flow changes and add visual test coverage showing an overflow case
  Dean Herbert · 2022-02-02 09:13:19 +09:00
  35b7653290
• Add test scores in BeatmapLeaderboard test scene with more mods
  Dean Herbert · 2022-02-01 16:35:25 +09:00
  3ca2c90684
• Track loading via state as well
  Dean Herbert · 2022-01-31 01:12:03 +09:00
  f8939af5e6
• Disallow setting "NoScores" externally as it is handled internally
  Dean Herbert · 2022-01-30 16:18:19 +09:00
  04dbb5d3c6
• Consolidate flows of Set operations, either result or error
  Dean Herbert · 2022-01-30 16:16:00 +09:00
  acc1199add
• Also refactor placeholder logic to make more sense
  Dean Herbert · 2022-01-30 10:50:32 +09:00
  c401629dd8
• Fix null beatmap in test scene
  Dean Herbert · 2022-01-30 03:02:56 +09:00
  06660ff960
• Fix assertions to work in both directions
  Dean Herbert · 2022-01-30 02:54:51 +09:00
  d21464ea61
• Change test exposure to property instead of method
  Dean Herbert · 2022-01-30 02:29:51 +09:00
  51acf79935
• Remove pointless tests that no longer show anything valid
  Dean Herbert · 2022-01-30 00:03:22 +09:00
  9861c50b33
• Make score setter private
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  661fec7c8a
• Merge branch 'master' into song-select-scroll-position-during-delete
  Bartłomiej Dach · 2022-01-27 20:46:19 +01:00
  04d6ca59a3
• Merge pull request #16648 from peppy/fix-song-select-tests

  Fix song select tests not waiting for beatmap imports to arrive

  Dean Herbert · 2022-01-27 23:00:58 +09:00
  e872877185
• Move nulling of previous songSelect to SetUpSteps instead
  Dean Herbert · 2022-01-27 21:59:44 +09:00
  fae4f8bd8e
• Fix song select tests not waiting for beatmap imports to arrive

  After the change to realm, notification fires could take a frame or two.
  We aren't accounting for this.
  
  Fixes test failures like
  https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true

  Dean Herbert · 2022-01-27 19:35:42 +09:00
  831fa44433
• Add failing test coverage showing carousel deletions don't keep scroll position
  Dean Herbert · 2022-01-27 16:52:02 +09:00
  f2cecad83b
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Use more correct method of deletion in TestScenePlaySongSelect
  Dean Herbert · 2022-01-25 17:55:39 +09:00
  c0ed308016
• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Fix cases of Access instead of Realm
  Dean Herbert · 2022-01-25 12:58:15 +09:00
  3e5c9e8436
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Merge pull request #16497 from peppy/top-local-rank-optimisation

  Rewrite `TopLocalRank` to use realm subscriptions

  Dan Balasescu · 2022-01-19 14:22:12 +09:00
  581873f944
• Merge pull request #16505 from peppy/remove-base-difficulty-usage

  Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)

  Dan Balasescu · 2022-01-19 13:53:55 +09:00
  3e5d29ed00
• Add comprehensive test coverage for TopLocalRank
  Dean Herbert · 2022-01-19 13:48:00 +09:00
  201f2d7813
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Fix incorrect realm (non-isolated instance) being used in two test scenes
  Dean Herbert · 2022-01-17 14:55:23 +09:00
  5dc7425b2c
• Remove outdated comment
  Dean Herbert · 2022-01-14 21:40:35 +09:00
  9900a3f408
• Update one more mismatched test implementation
  Dean Herbert · 2022-01-14 21:39:42 +09:00
  289ae7c72f
• Add local ContextFactory caching to all remaining test scenes that create local managers
  Dean Herbert · 2022-01-14 19:59:21 +09:00
  a59dcccab7
• Fix CI reported warnings
  Dean Herbert · 2022-01-12 22:39:00 +09:00
  51251e3204
• Add missing ruleset in test scores
  Dean Herbert · 2022-01-12 18:51:30 +09:00
  38cc1ce098