schiavoanto
9cd7f2b5d4
Use LocalisableDescription for skin editor layers dropdown
2024-10-12 01:38:52 +02:00
schiavoanto
1e7e2e0b1c
Add more localisation in skin editor
2024-10-12 00:55:33 +02:00
OliBomby
9f73a45580
Explicitly assert specific grid type
2024-10-11 23:57:26 +02:00
Dean Herbert
8b046f60f0
Update test
2024-10-12 02:23:43 +09:00
Dean Herbert
b62d9f8696
Fix bindings being clobbered
2024-10-12 02:19:02 +09:00
Dean Herbert
05c8b3cbce
Simplify cycle logic
2024-10-12 02:18:36 +09:00
Dean Herbert
d07a2fbb57
Change shortcut to Shift+G
2024-10-12 02:18:08 +09:00
Dean Herbert
3a8ed889b5
Merge pull request #30215 from bdach/fix-music-controller
...
Fix track restarting when trying to switch track change direction with shuffle active
2024-10-12 01:41:44 +09:00
Bartłomiej Dach
4e8e4a34bd
Fix scale popover doing things when both scale axes are turned off
...
Spotted in passing when reviewing https://github.com/ppy/osu/pull/30080 .
The popover would very arbitrarily revert to scaling by Y axis if both
checkboxes were checked off.
Not sure how this passed review.
2024-10-11 15:18:43 +02:00
Bartłomiej Dach
5db1f05953
Merge branch 'master' into clamp-scale2
2024-10-11 15:13:54 +02:00
Bartłomiej Dach
d1da1d4079
Rename methods to fit new changes better
2024-10-11 15:03:30 +02:00
Bartłomiej Dach
07d15cc35a
Add positive assertion for conclusion notification being present too
2024-10-11 14:31:30 +02:00
Bartłomiej Dach
968835bb44
Do not show daily challenge conclusion notification on disconnection
...
Closes https://github.com/ppy/osu/issues/30194 .
2024-10-11 14:18:19 +02:00
Bartłomiej Dach
9d1eb842a7
Add failing test
2024-10-11 14:16:24 +02:00
OliBomby
550e575221
Rename "Cycle grid display mode" to "Cycle grid spacing"
...
The "display mode" is easy to confuse with grid type, so I renamed it to literally the grid property it affects.
2024-10-11 14:09:50 +02:00
OliBomby
56bfcde446
Update grid placement tool test
...
I somehow missed this test when splitting up PRs so here it is now
2024-10-11 14:09:50 +02:00
OliBomby
ada20d230a
Fix grid type cycling not taking into account the radio button selection
2024-10-11 14:09:50 +02:00
OliBomby
b93bc21e45
Add back the old keybind for cycling grid spacing
2024-10-11 14:09:50 +02:00
OliBomby
e56a9d2ad4
Add TestGridFromPoints
2024-10-11 14:09:50 +02:00
OliBomby
bfe78ff3a0
fix grid test
2024-10-11 14:09:50 +02:00
OliBomby
d98cc7fe66
use G to change grid type
2024-10-11 14:09:50 +02:00
Bartłomiej Dach
4a16341a94
Fix crash when switching tracks back and forth with shuffle on
2024-10-11 12:45:14 +02:00
Bartłomiej Dach
1a25e9d179
Add another failing test case for crash
2024-10-11 12:45:03 +02:00
Bartłomiej Dach
47cb696b69
Fix switching direction when changing tracks with shuffle on restarting the same track
...
Closes https://github.com/ppy/osu/issues/30190 .
2024-10-11 12:40:45 +02:00
Bartłomiej Dach
0882f1bb70
Add failing test case
2024-10-11 12:33:43 +02:00
WitherFlower
da376c534b
Filter out unranked/unsubmitted beatmaps when using the ranked/submitted search filters
2024-10-11 09:49:47 +02:00
Dan Balasescu
616c2aeefc
Merge pull request #30206 from minetoblend/fix/selection-box-buttons-stuck
...
Fix SelectionBox buttons freezing when button is triggered via key event
2024-10-11 12:02:58 +09:00
Marvin Schürz
af55585dc8
Make TriggerAction public
2024-10-10 20:50:47 +02:00
Marvin Schürz
fc7ad96fcd
Move circle flash to TriggerAction
2024-10-10 20:20:02 +02:00
Marvin Schürz
9cc6ee2ebc
Fix SelectionBox buttons freezing when button is triggered via key event
2024-10-10 20:14:11 +02:00
Dan Balasescu
c545269eec
Merge pull request #30198 from bdach/thank-you-discord-once-more
...
Fix discord RPC complaining yet again if given a single space character as activity state / details
2024-10-11 01:15:56 +09:00
Dean Herbert
14ecd56913
Merge pull request #30195 from bdach/advanced-stats-stupid-shenanigans
...
Fix crashes when attempting to change from a custom ruleset with mods selected to another
2024-10-11 00:57:28 +09:00
WitherFlower
eb2f1d09f8
Improve regex readability by using character set
2024-10-10 17:42:43 +02:00
WitherFlower
6b532824b1
Fix code quality and formatting issues
2024-10-10 17:41:29 +02:00
Dan Balasescu
245d05a2e2
Merge pull request #30199 from bdach/no-song-progress-tooltip-during-gameplay
...
Fix argon song progress bar tooltip showing during active gameplay
2024-10-11 00:03:27 +09:00
Bartłomiej Dach
938c3d78ce
Fix argon song progress bar tooltip showing during active gameplay
...
Closes https://github.com/ppy/osu/issues/30197 .
Pretty bad one, might be worth a hotfix...
2024-10-10 14:36:28 +02:00
Bartłomiej Dach
687bdad389
Remove no-longer-required cache-over hack
...
This is now removable after `AdvancedStats` has been weaned off the
global mods bindable. I think this is a win all things considered?
2024-10-10 14:22:20 +02:00
Bartłomiej Dach
f1842d781e
Decouple AdvancedStats from global mods
...
Closes https://github.com/ppy/osu/issues/30163 .
If I'm to be blunt, the decoupled stuff in song select makes my head
spin. I spent a solid 20 minutes thinking how I was going to fix this
one but then finally realised that generally most of the cause there
was the fact that `AdvancedStats` was seeing the new rulesets *before*
the "ensure global selected mods are valid for current ruleset" logic,
and so decided to just _delay_ that until the decoupled transfer
thingamajig happens.
I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
`Mods` into one property on `AdvancedStats`. I figured I'd rather not
push my luck and try the baseline version first, but I honestly think
that direction is going to be required at some point to properly corral
all of the decoupled madness taking place in song select.
2024-10-10 14:22:16 +02:00
Bartłomiej Dach
a7fcfd5f0d
Fix discord RPC complaining yet again if given a single space character as activity state / details
...
Closes https://github.com/ppy/osu/issues/30178 .
Really, discord?
2024-10-10 13:59:18 +02:00
Bartłomiej Dach
cab97a96ab
Merge pull request #30189 from OliBomby/fix-splittable
...
Fix split control point context menu option not showing up on newly created control points
2024-10-10 11:37:24 +02:00
OliBomby
9936ec579f
Fix isSplittable depending on unreliable order of path control point pieces
2024-10-09 23:31:12 +02:00
Dean Herbert
a6f56036a2
Merge pull request #30164 from bdach/am-i-fired-this-time
...
Fix game deadlocking on startup when set to single thread mode
2024-10-09 19:55:01 +09:00
Bartłomiej Dach
baa64d1486
Migrate MusicController to Live<T> to fix broken migrations instead
2024-10-09 11:59:04 +02:00
Bartłomiej Dach
081d87fe6d
Revert 'Fix any and all migration attempts dying on MusicController'
...
This reverts commit 310eec69fc
2024-10-09 11:55:59 +02:00
Dean Herbert
270c4c4f12
Merge pull request #30151 from bdach/migration-is-completely-fucked
...
Fix several breakages with migration operation
2024-10-09 14:24:34 +09:00
Dean Herbert
d836dba982
Rename and xmldoc RealmResetEmptySet
2024-10-09 14:18:34 +09:00
Dean Herbert
48dacd1c15
Remove unused property
2024-10-09 13:45:35 +09:00
Dean Herbert
7ccb770009
Update framework
2024-10-09 12:36:51 +09:00
Dean Herbert
68ebf64b2d
Fix dependabot line endings
2024-10-09 12:36:44 +09:00
Dean Herbert
4a84c6e778
Merge pull request #30153 from ppy/dependabot/nuget/osu.Desktop/System.IO.Packaging-8.0.1
...
Bump System.IO.Packaging from 8.0.0 to 8.0.1 in /osu.Desktop
2024-10-09 12:13:56 +09:00
