osu-lazer

Fix a few flaky tests

See failures on https://github.com/ppy/osu/runs/66073876886#r3s1.

Dean Herbert · 2026-03-07 23:19:13 +09:00

14ae2312ff

Fix potential crash due to handling scores in leaderboard post-disposal (#36860 )

Closes https://github.com/ppy/osu/issues/36858. Classic.

Dean Herbert · 2026-03-07 04:40:25 +09:00

2026.307.0-tachyon c4402e9ce5

Fix LoadingLayer centering

oops.

Dean Herbert · 2026-03-07 02:51:50 +09:00

de9cf751d2

Implement ranked play (#36819 )

I don't really have much to say here. Instead, I'll give a brief history
rundown that lists many pages of documentation you can read, if
interested.

- Started off as BTMC + Happy24 (Vivi)'s ["The
Vision"](https://docs.google.com/document/d/1p1IpPmd2RICp8G4OqkCSs7u8Ug8FbFv8qqP0mfSrHf0/edit?tab=t.0#heading=h.fol093d9f9xi)
- Initial
[designs](https://www.figma.com/design/f5qqC57t9jFlgpzhRqUNVX/The-Vision?node-id=0-1&p=f)
were led by Vivi.
- Designs
[morphed](https://www.figma.com/design/vtFmLrXKvWNyYiRjTezFTM/Untitled--Copy-?node-id=0-1&p=f)
during development into what's currently present, led by @minetoblend.
- There is some more ongoing work creating a [game design
document](https://docs.google.com/document/d/1iffJFCsIBfYF0D4ogItSBEj6YBmbp-rdCpItAeaJiTA/edit?tab=t.0).

**tl;dr:** Create something with the mechanics of a trading card game
within osu!. The name of this is "ranked play".

---

To be frank, a lot of stuff is missing here. Some of it I don't want to
mention, because the point of this exercise is to get the system into
the hands of players, gather feedback especially around mechanics, and
discuss any further direction with the team.

I am expecting a blanket approval on all of the new code, with
particular attention to changes in existing components that I'll point
out in a self review.

There is also some [ongoing
work](https://github.com/smoogipoo/osu/pulls) that may arrive in this
branch prior to being merged.

---------

Co-authored-by: maarvin <minetoblend@gmail.com>
Co-authored-by: Marvin <m.schuerz@hautzy.com>
Co-authored-by: Jamie Taylor <me@nekodex.net>
Co-authored-by: ArijanJ <arijanj@proton.me>
Co-authored-by: Dean Herbert <pe@ppy.sh>
Co-authored-by: Tim Oliver <git@tim.dev>
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Co-authored-by: nil <25884226+voidstar0@users.noreply.github.com>
Co-authored-by: Ботников Максим <mr.botnikoff@ya.ru>
Co-authored-by: Denis Titovets <den232titovets@yandex.ru>
Co-authored-by: Michael Middlezong <119022671+mmiddlezong@users.noreply.github.com>
Co-authored-by: SupDos <6813986+SupDos@users.noreply.github.com>
Co-authored-by: failaip12 <86018517+failaip12@users.noreply.github.com>

Dan Balasescu · 2026-03-07 02:30:50 +09:00

0988552567

Consider comments in wiki's front matter YAML (#36758 )

This PR makes front matter items with comments able to be parsed
correctly by the client, for example:

```markdown
---
tags:
  - keyboard
  - tap
  - hybrid
  - play style
needs_cleanup: true  # https://github.com/ppy/osu-wiki/issues/9919
---

# Hybrid

...
```

The front matter YAML used by osu!wiki not complicated, so simply
splitting with `#` is possible.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

复予 · 2026-03-07 01:41:59 +09:00

0fd0bd3580

Allow changing addition bank button state when objects are selected even if the selection has no addition sounds (#36808 )

Before:


https://github.com/user-attachments/assets/d87bd7e3-37f8-4634-9e6a-5859d5bade57

After:


https://github.com/user-attachments/assets/4de940af-1e30-4266-9aac-5ccd12f38742

---

The title is convoluted but basically I'm angling to close
https://github.com/ppy/osu/issues/36705 with this.

The point is that on current `master`, the keyboard-hotkey-based toggles
on the left of the screen get disabled if you select a range of objects
which contains no addition samples. The report linked above finds this
annoying because it means you basically always need to add an addition
sound *first* and *then* pick a bank.

This is not necessary, and this commit changes the behaviour such that
the bank selection toggles are no longer blocked when you select a range
of objects without additions. Choosing an addition bank when there are
no additions still does nothing to the selected object, *but* adding a
sound *after* that bank preselection will use the preselected bank
rather than auto.

Bartłomiej Dach · 2026-03-07 00:47:35 +09:00

16bc1de9fd

Fix rotation of certain objects breaking change states (#36852 )

Closes https://github.com/ppy/osu/issues/36830.

This is a regression from https://github.com/ppy/osu/pull/36681.

Due to the aforementioned pull request's changes, rotating an object
that could not scale on the X or Y axis (due to having that dimension
zero) would trigger `CanScale{X,Y}` to change as said rotated object's
width or height became not zero. This in turn would cause `SelectionBox`
to *fully recreate* all of its handles and buttons, *including* the
rotation handle that initiated the rotation operation, therefore
dropping the ongoing rotation operation completely and leaving the
editor in a half-broken state.

The suggested solution here is to recreate handles more granularly to
prevent this from happening. (I've probably not improved it as much as I
could have, but this is as far as I'm willing to go for now unless
review finds it unpalatable.)

Bartłomiej Dach · 2026-03-07 00:20:10 +09:00

0d74983551

Fix loading spinner not being centered correctly (#36849 )

One of those things you can't un-see.

Closes https://github.com/ppy/osu/issues/36832.

Dean Herbert · 2026-03-06 12:11:16 +01:00

b46656e7d3

Fix "no tablet" settings display not updating after language change (#36848 )

Closes https://github.com/ppy/osu/issues/36833.

Schedule is unfortunate but I'm not really wanting to go down a rabbit
hole right now.

Dean Herbert · 2026-03-06 12:11:04 +01:00

482d31d598

Remove "copy labels from linked issues" github workflow (#36854 )

[It still doesn't
work.](https://github.com/ppy/osu/actions/runs/22759488243/job/66012293202)

Looking at the [job
output](https://github.com/ppy/osu/actions/runs/22759488243/job/66012293202#step:1:21)
it appears that the permissions of the `GITHUB_TOKEN` are
*automatically* constrained to `read` even if you request more scopes.
Would be nice if that was *actually documented* somewhere!

Also given supply-chain attacks that people are running on github [via
*issue titles* these
days](https://grith.ai/blog/clinejection-when-your-ai-tool-installs-another)
I'm not sure we want any automation near where it can reach code. Sure,
much of the fault in the aforementioned attack was the fault of meatbags
trusting clankers *WAY* too much, which is a mistake we *would not* do,
but given everpresent software degradation *from unknown sources and for
unknown reasons* let's not ~~COPILOT~~ *ahem* tempt fate...

Bartłomiej Dach · 2026-03-06 19:54:44 +09:00

f9e863af01

Allow editor 100% background dim (#36847 )

Whatever at this point.

https://github.com/ppy/osu/discussions/30421

Dean Herbert · 2026-03-06 19:32:34 +09:00

04767f44bb

Adjust padding and text size in editor inspector (#36843 )

It was taking up way too much vertical space previously.

I'm using the same font specs that are in the new dropdown header, which
seem to work quite well. Negative padding because without it everything
is way too vertically sparse.

Why? I was looking at [this
discussion](https://github.com/ppy/osu/discussions/36708) and like "we
need to have SV visible here" but there's really not much room with all
this text in the way.

Dean Herbert · 2026-03-06 19:32:19 +09:00

8fe63ade31

Only play nightcore hat sounds when tick rate is a multiple of 2 (#36459 )

Closes #13513

Matches stable behavior where hat only plays when the slider tick rate
is a multiple of 2.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Eeli Ogata · 2026-03-06 17:56:14 +09:00

c1555af620

Fix crash when clicking panels during recycling (#36457 )

Closes #36246

This PR overrides `HandlePositionalInput` to reject all positional input
when `Item` is null.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Eeli Ogata · 2026-03-06 09:36:39 +01:00

e911217980

Show first two slider repeats with the rest of the combo in Freeze Frame mod (#36427 )

Before:


https://github.com/user-attachments/assets/95b19bdb-12c5-4ee7-b7e2-f9098aecd2fa

After:


https://github.com/user-attachments/assets/937081c5-92cb-4bea-a774-e53afbdbb1fb

---

This is a subjective diff and can be closed on the spot with no
discussion if deemed incorrect. I mostly just want to get it off my list
of unresolved forum threads.

The catalyst for this change is [this
thread](https://osu.ppy.sh/community/forums/topics/2171493?n=1), wherein
the complaint is that you can get jumpscared by a slider repeat in a
combo because the slider repeats do not fade in with the rest of the
combo. Which means that you don't immediately know whether a slider will
need to be repeated or not and you have to watch out for potential
slider repeats fading in, which could happen at an *arbitrary* time
because it's still dependent on the map's original AR.

This seems pretty anti-user so I made it fade in with the rest of the
combo. The original comment cited "broken layering" which I guess refers
to the fact that sliders can repeat *more* than once and the second
repeat will show *under the slider head*. It's pretty broken, sure, but
I don't think it's *that* bad, and I *do* think that it's better than
the current behaviour.

The reason it shows only the first two repeats is that there's no point
in showing more for reasons that are hopefully obvious.

Bartłomiej Dach · 2026-03-06 15:29:47 +09:00

ba2ae3218e

Refactor ShearedButton to allow easier relative sizing (#36802 )

This commit rearranges the contents of `ShearedButtons` to be more
independent of each other in regards to sizing. Thanks to that, the
custom logic related to enabling autosizing is no longer necessary.
Witdh and height are no longer set via the constructor, and can be
freely configured using the initializer syntax.

Additionally, this allows the button to use relative sizing without
having to resort to any hackery with `Size` (this will come in handy for
me when implementing the new footer on multiplayer screens).

Given that most of the `ShearedButton`s currently in use set their width
explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by
default previously. Instead it is set on the only two such buttons (show
converts/selected mods on ssv2). I suppose it might be a good idea to
have it set that by default if no `Width` is specified, as right now
it'll just not show anything.

Also I've set the margin on the text field by default in all cases
instead of only when autosizing like how it was previously, since
otherwise it would be a pain to set that on each button instance when
needed. I've checked all affected components and could not find any text
overflowing issues that this could cause.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Krzysztof Gutkowski · 2026-03-06 02:09:05 +09:00

b76a7e1bb6

Disable presenting scores in online song selects (#36826 )

RFC. Closes https://github.com/ppy/osu/issues/36815 I guess.

Song select V1 completely disabled the ability to view a score outside
of solo play in ways that are very easy to let fly under the radar:


https://github.com/ppy/osu/blob/5fc836d1f09cebf983313c9b91a5c252890c607a/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs#L26
https://github.com/ppy/osu/blob/46db3ad96d0e1cd6ba4176b9b474cb79a338965d/osu.Game/Screens/Select/PlaySongSelect.cs#L47-L53

therefore the issue this is trying to close would never even manifest
there.

The direct cause of the issue is that the results screen is pushed to
the relevant online screen's *substack* of screens rather than the
game-global parent stack. That means that when the back button is
pressed, the following logic fires:


https://github.com/ppy/osu/blob/6fa4a7152f144ed2524f20ecf7cfd26492bbe61d/osu.Game/Screens/OnlinePlay/OnlinePlayScreen.cs#L174-L189

This logic fires *on the parent screen* even though *the child screen*
is the one the user is attempting to back out of. And none of the
exemptions for the screen substack inside of the above method fire
because the subscreen is not an `IOnlinePlaySubScreen` (it's
`SoloResultsScreen` in this case).

Now the direct cause here is probably fixable, although possibly not
without some significant pulling of footer-shaped teeth. *However*, I
kind of question as to why viewing scores should be permitted on online
song selects in the first place - it kind of distracts from the primary
purpose of the screens which is to *just pick a map already*.

Bartłomiej Dach · 2026-03-06 00:19:10 +09:00

6b10ef8709

Fix subscription leak from composer reloads (#36828 )

The reproduction scenario for the subscription leak is as follows:

1. Switch to a scrolling ruleset (anything but osu! from the standard
ones).
2. Select a beatmap to edit.
3. Load the composer.
4. Go to timing tab.
5. Change a timing point.
6. Go back to the composer.

At this point, `EditorChangeHandler.OnStateChange` will have multiple of
the same delegate in the invocation list.

That in turn is caused by the fact that changing a timing point *does*
incur a full reload of the composer via the following flow:

https://github.com/ppy/osu/blob/15b6e28ebe888b1a87574891be1a0db3b04093b7/osu.Game/Rulesets/Edit/ScrollingHitObjectComposer.cs#L145
https://github.com/ppy/osu/blob/64a29313a852d50095ae4b7ea8f22fde23aa634f/osu.Game/Screens/Edit/Editor.cs#L1137-L1145

This flow is my "fault"; see https://github.com/ppy/osu/pull/28444. The
reason why a full composer reload is used is not clear to my
recollection at this time, but it is likely because it's just the least
likely to fail. A smarter solution that wouldn't require a full reload
would also entail checking that there exists a safe insertion point that
allows replacing timing points in a way that will reflect everywhere it
must. Including all of the `IScrollingAlgorithm` machinery and such.

In general it is not uncommon in the codebase to not bother to clean up
some event callbacks if it is implicitly or explicitly guaranteed that
both objects bound by the callback will always get disposed in tandem at
the same time. This *was* true with this particular flow to a point,
which was until that full composer reload was implemented.

<details>
<summary>To address the elephant in the room</summary>

Someone will inevitably notice https://github.com/ppy/osu/pull/36824
which was a clanked pull request pointing out this leak. And then
someone will inevitably call this "AI discrimination"! *Gasp!*

So first of all, let me stop you right there. Yes, as far as I am
_personally_ concerned, it is "AI discrimination". I invoke the full
force of the Butlerian Jihad.

The clank army's goal is to eradicate my job and make me work in an
Amazon warehouse instead. Or, if not that, at least my job is to be rid
of all remnants of fun I still get from it and for me to be reduced to
that one guy from the meme "i guess we're doin circles now". You know
the one.

I resent this. You attack me directly. I do not perceive the need to
meet you halfway or be civil.

That said, I have too much respect for the users of this software to
leave reports of potentially real issues unchecked. So I did check, and
it was real. And you know what? Good job to the clanker. It did what it
was designed to do: it parsed a code file, recognised a hole in a
pattern it was designed to recognise, and invoked forms of language
given to it to communicate this to the meatbag that opened that PR.

And here's the thing: my primary issue is with that meatbag that opened
that PR. That meatbag served no functional purpose in any of this. The
meatbag took a hose that spews 90% water and 10% raw sewage at random
intervals and pointed it at my house directly, claiming that they just
want to clean it. At no point did the meatbag appear to have the common
decency to pull out a container, pour some magic liquid out, check if
there's sewage in it, and filter it out if there is any. But no, that
would take *effort* and *thought*, would it not? The *effort* and
*thought* that is required of *me* to *review* the clanker's work?

The PR had no reproduction scenario, and had testing checkboxes that
were presumably meant for *me* to check off. Why is it *my* job to
figure all of this out rather than the submitter meatbag's?

I do *not* have obligations towards spew-hose-pointing meatbags. Point
that hose at your own backyard at your peril.

If you *actually manage* to get the clanker to filter out *all* of the
spew without fail itself, my only win condition is gone. But it is not
yet that time. So at least have the decency to check for the spew
yourself, rather than telling the clanker to put checkboxes in the PR
descriptions telling *me* to check for it.
</details>

Bartłomiej Dach · 2026-03-05 22:37:50 +09:00

43897457fb

Update resources

Dean Herbert · 2026-03-05 14:58:12 +09:00

2026.305.0-lazer bb289363a2

Use web localisation on LeaderboardScopeSelector to match osu-web (#36814 )

- regressed in
https://github.com/ppy/osu/commit/1f052bb195bfc5a2681b1b324bf34764641a1c40
- also see https://github.com/ppy/osu/pull/34074#discussion_r2211853662

did it by analogy with
https://github.com/ppy/osu/blob/a0ecbd7c8704d6beee3e5c54c2ccb5f735872fb0/osu.Game/Overlays/BeatmapSet/Scores/NoScoresPlaceholder.cs#L27-L49

| master | pr | `osu-web` |
|-|-|-|
| <img width="1625" height="188" alt="osu_2026-03-04_18-26-44"
src="https://github.com/user-attachments/assets/9bd2690a-2ddf-4f03-9ca6-22003efbd895"
/> |
![osu_2026-03-04_18-36-12](https://github.com/user-attachments/assets/1498c4a9-7188-4e97-a6bd-3553b9befa5e)
| <img width="990" height="139" alt="Снимок экрана 2026-03-04 182558"
src="https://github.com/user-attachments/assets/1bf14bee-3097-478d-936b-6ecb7d912be2"
/> |

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Denis Titovets · 2026-03-05 13:40:31 +09:00

28a18f768c

Return tooltips to footer buttons on MultiplayerMatchSongSelect (#36817 )

- reported by @Loreos7 in
https://discord.com/channels/188630481301012481/188630652340404224/1478809956076491006
- probably regressed in https://github.com/ppy/osu/pull/36752

Denis Titovets · 2026-03-05 13:01:33 +09:00

45945e3bb1

Reduce online user list panel churn on initial display (#36811 )

Yes this is a funny way of doing it, but it works and is better than
what we have for the initial release.

Don't expect this to stay around forever.

Dean Herbert · 2026-03-05 00:44:03 +09:00

2026.304.0-tachyon cab50e94c8

Unimplement legacy compatibility method (#36812 )

The spectator server invokes both legacy and non-legacy methods to keep
compatibility with older clients:


https://github.com/ppy/osu-server-spectator/blob/fe0dad324587c8a12a2f203fd8289ce64182c2d9/osu.Server.Spectator/Hubs/Multiplayer/Matchmaking/Queue/MatchmakingQueueBackgroundService.cs#L292-L299

I thought that it'd be a good idea to implement the legacy method here,
but it turns out to not be such a good idea because it means ranked-play
clients will assume they're receiving a quick play invitation.

Dan Balasescu · 2026-03-05 00:31:43 +09:00

ae032622ac

Merge pull request #36798 from bdach/tags-broken

Fix a bunch of breakage around user tags

Dean Herbert · 2026-03-04 21:16:38 +09:00

a0ecbd7c87

Merge branch 'master' into tags-broken

Dean Herbert · 2026-03-04 19:50:33 +09:00

459d5e8a45

Only show user tags above threshold by default

Bartłomiej Dach · 2026-03-04 10:34:35 +01:00

9b55e1dfdb

Merge pull request #36752 from peppy/song-select-v1-salute

Remove remnants of song select v1 and move v2 to final resting location

Bartłomiej Dach · 2026-03-04 10:27:07 +01:00

4c873787c1

Remove outdated xmldoc

Bartłomiej Dach · 2026-03-04 08:44:31 +01:00

43af89f75c

Merge branch 'master' into song-select-v1-salute

Bartłomiej Dach · 2026-03-04 08:39:58 +01:00

f74a21c1e1

Fix loose spacers at top of leaderboard score context menu (#36799 )

Closes https://github.com/ppy/osu/issues/36777.

Bartłomiej Dach · 2026-03-03 23:40:08 +09:00

a028f0ba4a

Fix code quality

Bartłomiej Dach · 2026-03-03 13:38:23 +01:00

1aa42a73b1

Add bool flag for checking tag vote threshold & utilise as required

Closes https://github.com/ppy/osu/issues/36453.

My omission was in assuming that web was going to start filtering out
the tags below the threshold from API responses, which is not the case.

Whether or not the consumers want or not to display tags below threshold
is subjective. I figured that the matchmaking card tooltip might want to
display below threshold but I dunno.

Bartłomiej Dach · 2026-03-03 13:03:33 +01:00

d9e182230d

Move constant closer to helper

Bartłomiej Dach · 2026-03-03 13:03:33 +01:00

65b49137ee

Migrate realm populating online lookup source to use helper method for retrieving tags

To reduce logic duplication.

Bartłomiej Dach · 2026-03-03 13:03:27 +01:00

2f96e96576

Fix beatmap set overlay not showing user tags at all

Regressed in 60d9c358b8.

In general an `APIBeatmap`'s `BeatmapSet` need not be present. In the
usage site of `osu.Game.Overlays.BeatmapSet.Info`, `Beatmap` and
`BeatmapSet` were actually two separate bindables. Moving the logic to a
helper, and therefore implicitly moving `BeatmapSet` from tracking said
separate bindable to instead refer to `Beatmap.BeatmapSet` broke this.

Bartłomiej Dach · 2026-03-03 12:44:29 +01:00

e64e0f0ca9

Merge pull request #36796 from Joehuu/standardise-play-favourite-order

Standardise display order of playcount / favourites

Bartłomiej Dach · 2026-03-03 11:22:51 +01:00

2026.303.0 d37f59430b

Merge pull request #36795 from peppy/carousel-scrollbar-state-capture

Fix song select carousel state capture

Bartłomiej Dach · 2026-03-03 10:40:25 +01:00

d748470754

Merge pull request #36794 from peppy/fix-tooltips-not-displaying-custom

Fix offset slider no longer showing explanatory tooltip correctly

Bartłomiej Dach · 2026-03-03 10:32:15 +01:00

2539bd90fa

Final attempt to make copy labels work

Dean Herbert · 2026-03-03 17:24:29 +09:00

317be21569

Update framework

Dean Herbert · 2026-03-03 17:20:14 +09:00

b1044b6b2d

Move v2 files to final location

This contains only renames and namespace updates.

Dean Herbert · 2026-03-03 16:45:15 +09:00

c28c64940a

Add special not regarding collection dropdown

Dean Herbert · 2026-03-03 16:45:15 +09:00

b4f40639a1

Update TestSceneDeleteLocalScore to use newer leaderboard

Dean Herbert · 2026-03-03 16:45:14 +09:00

7e7421e1ea

Remove all song select v1 files

This contains no code changes (that would need review), only file
deletion and extraction where required in a few odd cases.

Dean Herbert · 2026-03-03 16:45:14 +09:00

1a8d2855d4

Move leaderboards classes to gameplay namespace for now

Dean Herbert · 2026-03-03 16:45:13 +09:00

54a1417dd8

Move components only used by beatmap set overlay local to namespace

Dean Herbert · 2026-03-03 16:45:13 +09:00

ce542b03db

Update filter matching tests to be independent of old song select classes

Dean Herbert · 2026-03-03 16:45:12 +09:00

f20d182775

Fix a few remaining references to old song select

Dean Herbert · 2026-03-03 16:45:12 +09:00

a7e6286396

Remove now unused footer buttons

Dean Herbert · 2026-03-03 16:25:58 +09:00

521a40d860

Add tooltips to beatmap info overlay statistics

Joseph Madamba · 2026-03-02 22:53:09 -08:00

564b6ebd0c

76632 Commits