75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #31746 from mcendu/taiko-legacy-spinner

  Add legacy taiko swell (spinner)

  Dean Herbert · 2025-02-12 23:06:17 +09:00
  7490bca17f
• Remove SelectedRoom abstraction from OnlinePlayTestScene
  Dan Balasescu · 2025-02-12 22:55:19 +09:00
  205d6ecffb
• Refactor polling components (namespace/namings)
  Dan Balasescu · 2025-02-12 22:22:17 +09:00
  24cc77287e
• Fix android build again

  Another month, another freak android build failure.
  
  From what I can tell, this time the build is broken because the second-
  -to-last workaround applied to fix it, namely explicitly specifying
  the version of workloads to install, stopped working, presumably because
  github pushed a new .NET SDK version to runners, and microsoft didn't
  actually put up a set of workload packages whose version matches the
  .NET SDK version 1:1.
  
  Thankfully, the fix to the *last* android build breakage (which caused
  the workload installation to completely and irrecoverably fail), appears
  to be rolling out this week, and *also* fix that same second-last issue,
  so both workarounds of specifying the workload version and pinning the
  image to `windows-2019` appear to no longer be required.
  
  Note that the newest image version, 20250209.1.0, is still not fully
  rolled out yet, thus rather than just fix all builds, this will fix like
  20% of builds until the newest image is fully rolled out. But I guess
  a 20% passing build is better than a 0% passing build, in a sense...?

  Bartłomiej Dach · 2025-02-12 14:18:03 +01:00
  ee6dcbd808
• Remove remaining bindables
  Dan Balasescu · 2025-02-12 22:11:56 +09:00
  43928c94db
• Encapsulate RoomsContainer scroll a bit better
  Dan Balasescu · 2025-02-12 21:57:18 +09:00
  74ccac37ae
• Remove selected room leasing, make bindables private

  I believe once upon a time the `SelectedRoom` bindable used to be bound
  to `RoomManager.JoinedRoom` or similar. But now it's effectively private
  to the lounge subscreen and so a lease is unnecessary.

  Dan Balasescu · 2025-02-12 21:48:59 +09:00
  1b07b6d16f
• Remove RoomManager and related components
  Dan Balasescu · 2025-02-12 21:37:34 +09:00
  f146a7d116
• Fix clear sample potentially playing multiple times simultaneously
  Bartłomiej Dach · 2025-02-12 13:25:46 +01:00
  d87a775e71
• Add missing animation of warning sprite
  Bartłomiej Dach · 2025-02-12 13:25:46 +01:00
  e385848edc
• Fix transforms from swell progress being cleared on completion by not using transforms
  Bartłomiej Dach · 2025-02-12 13:25:42 +01:00
  0ac08158e3
• Adjust things further
  Bartłomiej Dach · 2025-02-12 13:20:04 +01:00
  96db6964df
• Move room tracking to lounge subscreen
  Dan Balasescu · 2025-02-12 21:10:21 +09:00
  068a66e7d4
• Rename classes for better discoverability / grouping
  Dean Herbert · 2025-02-12 19:34:42 +09:00
  554884710c
• Mark Action as init only
  Dean Herbert · 2025-02-12 19:24:30 +09:00
  151101be70
• Remove unnecessary V2 suffixes
  Dean Herbert · 2025-02-12 19:22:57 +09:00
  3a0464299a
• Update height specification for playlist screen too
  Dean Herbert · 2025-02-12 18:45:00 +09:00
  c049ae6937
• Merge branch 'master' into freestyle-mods
  Dean Herbert · 2025-02-12 18:32:01 +09:00
  bc94ffe21e
• Flash footer freemod/freestyle buttons when active
  Dean Herbert · 2025-02-12 18:30:34 +09:00
  218151bb3c
• Change free mods button to show "all" when freestyle is enabled
  Dean Herbert · 2025-02-12 18:27:10 +09:00
  9c3e9e7c55
• Adjust some paddings and text

  Mostly trying to give more space to the queue as we add more vertical
  elements to the middle area of multiplayer / playerlists. This whole UI
  will likely change – this is just a stop-gap fix.

  Dean Herbert · 2025-02-12 17:43:49 +09:00
  9aef95c381
• Fix layout of user setting areas when aspect ratio is vertically tall
  Dean Herbert · 2025-02-12 17:31:55 +09:00
  b92e9f515b
• Fix weird follow circle display when rewinding through sliders in editor

  Closes https://github.com/ppy/osu/issues/31812.

  Dean Herbert · 2025-02-12 16:33:23 +09:00
  84b5ea3dbf
• Avoid binding directly to DHO's bindable
  Dean Herbert · 2025-02-12 16:28:14 +09:00
  f97708e6b3
• Rename ParentObject to DrawableObject

  It's not a parent. The follow circle is directly part of the slider
  itself.

  Dean Herbert · 2025-02-12 16:14:12 +09:00
  ffd8bd7bf4
• Merge pull request #31861 from minetoblend/chore/globalaction-enum-comment

  Add comment warning about enum entry order in `GlobalAction`

  Dan Balasescu · 2025-02-12 10:52:08 +09:00
  0612c0af9d
• Add comment warning about enum entry order in GlobalAction
  Marvin Schürz · 2025-02-11 18:04:23 +01:00
  a8f07ae7b1
• Merge pull request #22932 from peppy/collection-counts

  Show count of beatmaps in collections in manage dialog

  Bartłomiej Dach · 2025-02-11 15:43:22 +01:00
  46e8187d48
• Adjust things to be closer to stable (but not close enough yet)
  Bartłomiej Dach · 2025-02-11 15:29:53 +01:00
  231988bc9d
• Merge branch 'master' into room-management-lio
  Dean Herbert · 2025-02-11 22:36:01 +09:00
  d3f6f0953a
• Merge pull request #31682 from frenzibyte/mania-fix-judgements-on-scroll-up

  Fix osu!mania judgement position not shifted on flipped scroll direction

  Dean Herbert · 2025-02-11 22:13:09 +09:00
  1203c85d30
• Fix remaining hit counter scaling in the incorrect direction
  Bartłomiej Dach · 2025-02-11 14:01:32 +01:00
  be035538c2
• Merge pull request #31846 from bdach/fix-missing-rank-on-results

  Fix score position not being displayed in solo results screen

  Dan Balasescu · 2025-02-11 21:55:35 +09:00
  693ef8f538
• Fix test
  Dan Balasescu · 2025-02-11 21:28:21 +09:00
  8c85616d1c
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-11 21:19:32 +09:00
  38cd4fa56a
• Fix potential bad realm access to collection name
  Dean Herbert · 2025-02-11 20:05:48 +09:00
  b9c4e23595
• Merge pull request #31854 from peppy/editor-test-button-scale-disable

  Disable scale animation when holding editor "test" button

  Bartłomiej Dach · 2025-02-11 09:58:07 +01:00
  58d040112b
• Use more neutral terminology to avoid contentious 'beatmap' term
  Bartłomiej Dach · 2025-02-11 09:17:11 +01:00
  d8b3c28c2e
• Add basic brighten animation instead
  Dean Herbert · 2025-02-11 17:13:34 +09:00
  b9ed217308
• Remove completely unnecessary subscriptions per collection
  Bartłomiej Dach · 2025-02-11 09:13:08 +01:00
  884fa20b28
• Disable scale animation when holding editor "test" button
  Dean Herbert · 2025-02-11 17:11:20 +09:00
  1fa8d53232
• Merge pull request #31848 from bdach/open-beatmap-in-browser-from-editor

  Add menu items to open beatmap info & discussion pages in browser from editor

  Dean Herbert · 2025-02-11 16:55:02 +09:00
  9bb108311f
• Merge branch 'master' into collection-counts
  Bartłomiej Dach · 2025-02-11 08:54:24 +01:00
  18965fe0a2
• Update xmldoc
  Bartłomiej Dach · 2025-02-11 16:14:47 +09:00
  7db0a6f817
• Reword copy to be less verbose
  Bartłomiej Dach · 2025-02-11 08:06:12 +01:00
  daf0130b23
• Fix inspection

  Interestingly, this is not a compiler error nor does R# warn about it.
  No problem, because this is just restoring the original code anyway.

  Dan Balasescu · 2025-02-11 14:23:51 +09:00
  e51c09ec3d
• Refactor RoomSubScreen update
  Dan Balasescu · 2025-02-11 12:43:54 +09:00
  748c2eb390
• Refactor with a bit more null safety

  In particular I don't like the non-null assert around
  `GetCurrentItem()`, because there's no reason why it _couldn't_ be
  `null`.
  Consider, for example, if these panels are used in matchmaking where
  there are no items initially present in the playlist.
  
  The ruleset nullability part is debatable, but I've chosen to restore
  the original code here.

  Dan Balasescu · 2025-02-11 12:20:09 +09:00
  78e5e0eddd
• Merge pull request #31844 from bdach/fix-mp-players-appearing-as-spectators

  Fix spectator list showing other users in multiplayer room even if they're not spectating

  Dean Herbert · 2025-02-10 21:49:06 +09:00
  8dc616738c
• Space out comment
  Dean Herbert · 2025-02-10 21:48:27 +09:00
  310700b4e7