75266 Commits

This Branch

This Branch

All Branches

• Ensure correct global leaderboard state when presenting scores

  With `ReplayPlayer` now consuming the `LeaderboardManager`'s global
  state, flows such as presenting a score need to set the global state up
  correctly to avoid accidentally showing a leaderboard from a completely
  different score.
  
  This also incidentally closes https://github.com/ppy/osu/issues/27609.

  Bartłomiej Dach · 2025-04-10 10:19:04 +02:00
  31b98ac7b9
• Update scores request to move away from old endpoint
  Bartłomiej Dach · 2025-04-10 09:46:46 +02:00
  17bcc28429
• Actually use leaderboard manager in players

  This was supposed to be the case all along, but I guess in all of the
  rewrite attempts I forgot?
  
  With this, https://github.com/ppy/osu/issues/29861 is actually fixed
  again - and additionally, so is https://github.com/ppy/osu/issues/26716.

  Bartłomiej Dach · 2025-04-10 09:46:44 +02:00
  42ff312ece
• Merge pull request #32755 from bdach/tournament-client-window-title

  Use more distinctive window title for tournament client

  Dean Herbert · 2025-04-10 16:44:25 +09:00
  fe1b8c8346
• Fix another missing disposal

  This one probably doesn't matter as much because it's used as a single
  instance in `TaikoPlayfield` (so its lifetime should end around the same
  time as the `HealthProcessor`).

  Dan Balasescu · 2025-04-10 16:09:47 +09:00
  d0dddcde78
• Merge pull request #32744 from peppy/star-rating-fixed-width

  Fix `StarRatingDisplay` not using fixed width text

  Bartłomiej Dach · 2025-04-10 09:07:45 +02:00
  9412334f12
• Use more distinctive window title for tournament client

  This is in response to feedback in
  https://discord.com/channels/188630481301012481/1097318920991559880/1359117234257268747.
  The long and short of it is that without a unique title it's a bit hard
  to tell in software like OBS which window is the game and which window
  is the tournament client if wanting to run both, which I can agree with.

  Bartłomiej Dach · 2025-04-10 09:07:05 +02:00
  05dc113c70
• Fix progressively worsening performance on taiko argon skin
  Dan Balasescu · 2025-04-10 15:53:14 +09:00
  92c0b3cae2
• Fix code quality
  Bartłomiej Dach · 2025-04-10 07:47:31 +02:00
  fb326c6afd
• Allow classic mod in freestyle
  Dan Balasescu · 2025-04-10 13:05:17 +09:00
  c6e368d3ea
• Update test with stricter assertions
  Dan Balasescu · 2025-04-10 13:04:40 +09:00
  69630263a8
• Merge mod validity checks to closer match osu!web
  Dan Balasescu · 2025-04-10 13:02:25 +09:00
  05e70cd938
• Merge pull request #32749 from Joehuu/show-success-rate-unranked

  Fix success rate / points of failure not showing for unranked beatmaps on beatmap info overlay

  Dan Balasescu · 2025-04-10 12:35:03 +09:00
  e1d112ce3d
• Fix success rate / points of failure not showing for unranked beatmaps on beatmap info overlay
  Joseph Madamba · 2025-04-09 11:41:20 -07:00
  bfc6d61e5d
• Remove manual handling of autosize now that we are using fixed width display
  Dean Herbert · 2025-04-10 01:46:44 +09:00
  962edbdf78
• Fix StarRatingDisplay not using fixed width text
  Dean Herbert · 2025-04-09 19:38:58 +09:00
  0c7c791fb5
• Merge pull request #32729 from peppy/fix-mouse-down-leakage

  Fix slider placement not working correctly with UI button clicks

  Bartłomiej Dach · 2025-04-09 11:53:26 +02:00
  110b124cb6
• Merge pull request #32680 from smoogipoo/mp-history-results

  Allow viewing results of historical multiplayer items

  Bartłomiej Dach · 2025-04-09 10:42:39 +02:00
  8672435afa
• Fix editor click-through issues on bottom bar too
  Bartłomiej Dach · 2025-04-09 10:28:06 +02:00
  7ab428f18c
• Merge pull request #32741 from smoogipoo/fix-playlists-mod-stats

  Fix difficulty stats not showing in playlists

  Bartłomiej Dach · 2025-04-09 09:41:11 +02:00
  8e2fa5d9c8
• Merge pull request #32742 from smoogipoo/fix-exception

  Fix exception cancelling disposed cancellation token

  Bartłomiej Dach · 2025-04-09 09:32:37 +02:00
  00044cbbef
• Merge pull request #32723 from sineplusx/fix-multi-chat-hint

  Use actual keybind in multiplayer chat hint

  Bartłomiej Dach · 2025-04-09 09:29:12 +02:00
  c5eda87ac3
• Move key binding string retrieval to RealmKeyBindingStore
  Dean Herbert · 2025-04-09 15:23:55 +09:00
  9e90f80ab5
• Fix exception cancelling disposed cancellation token
  Dan Balasescu · 2025-04-09 15:12:02 +09:00
  3fe967e4d7
• Block all mouse events at BeatDivisorControl and revert animated button change
  Dean Herbert · 2025-04-09 14:56:30 +09:00
  27edee477d
• Fix difficulty stats not showing in playlists
  Dan Balasescu · 2025-04-09 14:55:38 +09:00
  4978903ba5
• Fix various weirdness around refetching
  Bartłomiej Dach · 2025-04-08 13:35:24 +02:00
  68b5f9a314
• Simplify code further
  Bartłomiej Dach · 2025-04-08 13:08:11 +02:00
  9aaa1fe5f4
• Fix test failures
  Bartłomiej Dach · 2025-04-08 13:03:35 +02:00
  f3d9f21e71
• Merge branch 'master' into mp-history-results
  Dan Balasescu · 2025-04-08 19:58:44 +09:00
  0b51cec77c
• Merge branch 'master' into freestyle-mods
  Dan Balasescu · 2025-04-08 19:57:28 +09:00
  1c060f986c
• Merge branch 'master' into yet-another-leaderboard-rewrite-attempt
  Bartłomiej Dach · 2025-04-08 12:54:27 +02:00
  567c7cb798
• Merge pull request #32669 from smoogipoo/refactor-match-subscreen

  Rewrite match subscreen to remove bindables

  Bartłomiej Dach · 2025-04-08 12:51:36 +02:00
  b3626bfb48
• Clone countdown objects in test client

  Beyond isolation, this stuff is also used to test (de-)serialisation.
  Much-of-a-muchness in this case since it isn't too thoroughly tested,
  but best do it anyway.

  Dan Balasescu · 2025-04-08 18:42:25 +09:00
  874ec49590
• Fix crash when trying to start countdown
  Dan Balasescu · 2025-04-08 18:35:51 +09:00
  5769292daf
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618
• Merge pull request #32733 from peppy/beatmap-name-in-load-failure-error

  Include beatmap details in logs when load fails

  Bartłomiej Dach · 2025-04-08 09:23:04 +02:00
  5be7b00562
• Merge pull request #32732 from peppy/vertex-selection-increase

  Increase range of vertex selection in polygon generation popover

  Bartłomiej Dach · 2025-04-08 09:07:49 +02:00
  b1b8601105
• Merge pull request #32731 from peppy/adjust-menu-positioning

  Adjust menu tips and supporter display to not overlap

  Bartłomiej Dach · 2025-04-08 09:00:57 +02:00
  5094b34159
• Remove obsoleted overload of ApplyResult
  Dean Herbert · 2025-04-08 15:47:30 +09:00
  5d572e1ab2
• Include beatmap details in logs when load fails

  See
  https://github.com/ppy/osu/discussions/32682#discussioncomment-12760059
  for ambiguous logs.

  Dean Herbert · 2025-04-08 15:33:43 +09:00
  d31ffd9014
• Merge pull request #32730 from peppy/fix-keyboard-steps

  Fix editor setup screen sliders not having correct keyboard steps

  Bartłomiej Dach · 2025-04-08 08:32:37 +02:00
  99ee5767cb
• Increase range of vertex selection in polygon generation popover

  Addresses https://github.com/ppy/osu/discussions/32703.

  Dean Herbert · 2025-04-08 15:26:41 +09:00
  e990099cd9
• Merge pull request #32665 from peppy/fix-editor-metadata-save-without-commit

  Fix saving via ctrl+s while metadata textbox is focused not saving changes

  Bartłomiej Dach · 2025-04-08 08:21:03 +02:00
  5f168b9b9f
• Adjust menu tips and supporter display to not overlap

  Closes https://github.com/ppy/osu/issues/32684.
  
  Also did a very brief pass on timings and animations.

  Dean Herbert · 2025-04-08 15:12:28 +09:00
  38608360b5
• Merge pull request #32718 from minetoblend/feature/tag-vote-count-transition

  Add transition when vote-count changes in user tag control

  Bartłomiej Dach · 2025-04-08 07:46:12 +02:00
  ef63f623a3
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Fix mouse down actions being leaked through buttons
  Dean Herbert · 2025-04-08 14:28:48 +09:00
  e42301058f
• Merge pull request #32726 from peppy/fix-health-bar-ki-sizing

  Fix incorrect sizing of legacy health display "ki" markers

  Dan Balasescu · 2025-04-08 14:21:19 +09:00
  4bd405ab10
• Hook up LocalConfig functions in OsuGameBase to make work in tests
  Dean Herbert · 2025-04-08 14:15:42 +09:00
  5fc80dbddb