75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #32967 from Stedoss/fix-taglib-mime-type-culture-variance

  Fix culture variance for MIME type resolution in TagLib file creation

  Bartłomiej Dach · 2025-04-28 10:26:00 +02:00
  ced12d90e8
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Fix ID3 metadata half-applying on audio file switch

  Should be self-explanatory (feedback loop between `reloadMetadata()`
  changing text box current, and text box current changing calling
  `applyMetadata()`).

  Bartłomiej Dach · 2025-04-28 09:41:38 +02:00
  8ea89b9d52
• Use another property when reading artist as fallback

  I was testing with mp3s ripped via Apple Music and for whatever reason
  the artist was in `JoinedPerformers` rather than `JoinedAlbumArtist`.
  I'm not about to go down and do research on id3 so I'm just going to try
  this and see if anyone complains.

  Bartłomiej Dach · 2025-04-28 09:40:34 +02:00
  16b658b322
• Adjust mod icon test scene to show overlapping versions too
  Dean Herbert · 2025-04-28 16:37:56 +09:00
  da827f0cd6
• Ban culture-unsafe taglib APIs
  Bartłomiej Dach · 2025-04-28 09:26:39 +02:00
  dad04d1661
• Add tests with mods with adjusted settings
  Dean Herbert · 2025-04-28 16:14:12 +09:00
  d907719aa8
• Fix missing disposal of TagLib.File in ChangeAudioTrack
  Dean Herbert · 2025-04-28 15:52:55 +09:00
  aab2df1704
• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Merge pull request #32968 from peppy/user-tag-scale-effect-fix

  Fix user tags potentially re-flowing on mouse down

  Bartłomiej Dach · 2025-04-28 08:48:11 +02:00
  136f951d91
• Fix user tags potentially re-flowing on mouse down

  Closes https://github.com/ppy/osu/issues/32954.

  Dean Herbert · 2025-04-28 14:48:05 +09:00
  4dcc63df9d
• Split UserTagControl out into partial classes
  Dean Herbert · 2025-04-28 14:36:43 +09:00
  61b77f9dd1
• Add manual MIME type resolution for TagLib file creation
  Stedoss · 2025-04-28 13:38:38 +09:00
  c2efda20d7
• Fix playcount statistic hiding on local diff instead of showing -
  Salman Alshamrani · 2025-04-27 02:56:01 +03:00
  5ea1654f1d
• Add test coverage
  Salman Alshamrani · 2025-04-27 02:56:01 +03:00
  395510c2c6
• Merge pull request #32956 from frenzibyte/metdata-fix-transition

  Fix metadata subwedges pop out transition being back-to-front

  Dean Herbert · 2025-04-27 00:40:21 +09:00
  296ea031f8
• Fix metadata subwedges pop out transition back to front
  Salman Alshamrani · 2025-04-26 17:33:46 +03:00
  230daf7289
• Merge branch 'master' into song-select-v2-wedges-leaderboard
  Dean Herbert · 2025-04-26 06:49:12 +09:00
  f3ac93d66c
• Merge pull request #32896 from bdach/more-hit-window-testing

  Add more test cases covering correct legacy replay playback with respect to hitwindow treatment with mods active

  Dean Herbert · 2025-04-26 06:22:29 +09:00
  d26c94cfac
• Merge pull request #32938 from bdach/ruleset-skin-combo-testing

  Add test scene coverage of HUD layouts on various ruleset/skin combinations

  Dean Herbert · 2025-04-26 05:48:26 +09:00
  4d3631cf96
• Adjust variables for legibility

  I found the previous way things were written a bit awkward. Easier to
  just enforce non-null here.

  Dean Herbert · 2025-04-26 05:18:24 +09:00
  0301463810
• Fix TriangleSkin not always returning a container for GlobalSkinnableContainerLookup

  We have other safeties which mean that this is not an issue during
  gameplay, but in the new `TestSceneHUDOverlayRulesetLayouts` it became
  apparent that allowing this to fallback (via `null` return) could lead
  to weirdness.

  Dean Herbert · 2025-04-26 05:14:36 +09:00
  54e0e1420f
• Fix filename not matching test scene
  Dean Herbert · 2025-04-26 04:51:03 +09:00
  0287ca285c
• Exclude non-user-playable mods from mod filter in beatmap leaderboard

  For easier understanding, substitute "non-user-playable" with
  "autoplay".
  
  The reason that I'm bothering to do this is that if you put autoplay on
  and turn on the "Selected Mods" filter, the request will actually go
  through and hit web, and web will obviously return no scores. On song
  select that's *maybe* fine, even though probably unintended still, but
  now with the leaderboard state being global this also means gameplay
  gets impacted. Which also means that if you Ctrl-Enter to start a map in
  autoplay you're not going to get any gameplay leaderboard scores at all.

  Bartłomiej Dach · 2025-04-25 13:06:01 +02:00
  3eb1ae225d
• Add test coverage of new behaviour of solo gameplay leaderboard
  Bartłomiej Dach · 2025-04-25 12:45:28 +02:00
  7822412c42
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Yet another forgotten initialiser
  Bartłomiej Dach · 2025-04-25 10:44:52 +02:00
  ea759f0c77
• Fix some weirdness around forced multiplayer elements

  - Naming wasn't adjusted
  - When the chat collapsed, the team score display broke due to zero
    width
  
  Partial revert of
  https://github.com/ppy/osu/commit/da1fc1013e07b8dafb0c409354f9d1cef971e449.

  Bartłomiej Dach · 2025-04-25 10:42:04 +02:00
  6d65b68100
• Merge pull request #32946 from bdach/new-combo-collapsed
  Dean Herbert · 2025-04-25 17:40:08 +09:00
  3cbdf2b890
• Merge pull request #32845 from nekodex/bss-audio-feedback

  Add audio feedback to the BSS process

  Dean Herbert · 2025-04-25 17:25:12 +09:00
  85a5033454
• Remove unnecessary try-finally usage
  Dean Herbert · 2025-04-25 17:22:25 +09:00
  c6a11a56a3
• Update resources
  Dean Herbert · 2025-04-25 16:35:34 +09:00
  40f6283fb5
• Add test mode which allow more realistic testing of samples
  Dean Herbert · 2025-04-25 16:25:27 +09:00
  032459ea4e
• Attempt to improve appearance of new combo toggle / combo colour control when contracted

  Follow-up to
  https://discord.com/channels/188630481301012481/188630652340404224/1364909125812617258.
  
  Not sure if better, but an attempt was made?

  Bartłomiej Dach · 2025-04-25 08:52:59 +02:00
  bc03a2a930
• Fix one more test failure
  Bartłomiej Dach · 2025-04-25 08:14:12 +02:00
  ae8fb2ce08
• Merge pull request #32941 from peppy/user-cover-delayed-load-failure
  Bartłomiej Dach · 2025-04-24 15:23:13 +02:00
  8023bbd5e7
• Merge pull request #32674 from smoogipoo/freestyle-mods

  Allow mods/freemods in combination with freestyle

  Bartłomiej Dach · 2025-04-24 14:51:04 +02:00
  d8a69e462c
• Delete no-longer-relevant test
  Bartłomiej Dach · 2025-04-24 14:50:09 +02:00
  242f1bf68f
• Fix user covers not loading if one corner is off-screen
  Dean Herbert · 2025-04-24 21:40:20 +09:00
  4bf5e9a4dd
• Fix user covers not loading if one corner is off-screen
  Dean Herbert · 2025-04-24 21:35:54 +09:00
  18060d30af
• Update 404ing cover image URLs
  Dean Herbert · 2025-04-24 21:27:30 +09:00
  c149a6efd6
• Update 404ing cover image URLs
  Dean Herbert · 2025-04-24 21:27:26 +09:00
  6cdbfe0647
• Begin to fix BeatmapLeaderboardWedge code quality
  Dean Herbert · 2025-04-24 21:14:31 +09:00
  bd58aac9cc
• Rework logic to use a looping sample for progress instead
  Jamie Taylor · 2025-04-24 20:38:15 +09:00
  9c56ee3e19
• Fix the same test that I forget to update every time
  Bartłomiej Dach · 2025-04-24 13:32:51 +02:00
  75140ddee6
• Remove (currently) unused resolved dependency
  Bartłomiej Dach · 2025-04-24 13:23:00 +02:00
  9818f859cb
• Fix code quality
  Bartłomiej Dach · 2025-04-24 13:18:35 +02:00
  330f213460
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Add test scene coverage of HUD layouts on various ruleset/skin combinations

  As time goes on, default skin layouts are getting more and more
  complicated because of per-ruleset overrides. This was already sort of
  apparent in https://github.com/ppy/osu/pull/31527, and I'm about to make
  it worse, so before I do, this is a test scene that is supposed to make
  it easier to check all possible combinations at a glance.

  Bartłomiej Dach · 2025-04-24 12:50:34 +02:00
  33f45b0a6d
• Merge pull request #32937 from bdach/ternary-selection-fixes

  Fix multiple issues with editor ternary toggle state management

  Dean Herbert · 2025-04-24 19:23:00 +09:00
  a0044116f3