75266 Commits

This Branch

This Branch

All Branches

• Remove setup screen controls that do nothing useful

  Before I go with a hammer to redesign these, I want to remove stuff that
  does nothing first.
  
  Hard-breaks API to allow rulesets to specify an enumerable of custom
  sections rather than two specific weird ones.
  
  For specific rulesets:
  
  - osu!:
    - Stack leniency slider merged into difficulty section.
  - osu!taiko:
    - Approach rate and circle size sliders removed.
    - Colours section removed.
  - osu!catch:
    - No functional changes.
  - osu!mania:
    - Special style toggle merged into difficulty section.
    - Colours section removed.

  Bartłomiej Dach · 2024-07-10 14:53:16 +02:00
  c8a64c5950
• Extend behaviour to sample edit popover
  Salman Ahmed · 2024-07-10 15:16:10 +03:00
  ce93455aa8
• Select all text when focusing a number box
  Salman Ahmed · 2024-07-10 15:16:10 +03:00
  94f51c92e0
• Merge pull request #28803 from peppy/fix-break-overlay-visuals

  Fix break overlay progress bar becoming a pancake near end of break

  Bartłomiej Dach · 2024-07-10 13:31:09 +02:00
  d879527329
• Merge pull request #28802 from peppy/fix-download-progress-bar-visuals

  Fix beatmap card progress bar becoming pancake when starting

  Bartłomiej Dach · 2024-07-10 13:25:02 +02:00
  d9e285395d
• Fix back-to-front exit blocking conditionals
  Dean Herbert · 2024-07-10 20:00:34 +09:00
  b6741ee4ea
• Fix break overlay progress bar becoming a pancake near end of break
  Dean Herbert · 2024-07-10 19:28:37 +09:00
  75344f9c5c
• Fix(?) xmldoc
  Dean Herbert · 2024-07-10 19:22:49 +09:00
  6cee0210c3
• Merge pull request #28801 from bdach/break-generation-caching

  Improve performance of automatic break regeneration

  Dean Herbert · 2024-07-10 19:21:16 +09:00
  1381b3c0c5
• Fix beatmap card progress bar becoming pancake when starting
  Dean Herbert · 2024-07-10 19:19:49 +09:00
  2ba1ebe410
• Pool summary timeline break visualisations to reduce allocations
  Bartłomiej Dach · 2024-07-10 11:42:28 +02:00
  b881c25b17
• Do not regenerate breaks unless meaningful change to object start/end times is detected

  Tangentially found when profiling https://github.com/ppy/osu/pull/28792.
  
  For reproduction, import https://osu.ppy.sh/beatmapsets/972#osu/9007,
  move any object on the playfield, and observe a half-second freeze
  when ending the drag.

  Bartłomiej Dach · 2024-07-10 11:42:25 +02:00
  343090e3b1
• More xmldoc across new methods and classes
  Dean Herbert · 2024-07-10 18:34:48 +09:00
  704e7e843f
• Add test coverage of difficulty being retained
  Dean Herbert · 2024-07-10 18:34:47 +09:00
  106d558147
• Add test coverage of external editing
  Dean Herbert · 2024-07-10 18:34:47 +09:00
  aa16c72e06
• Simplify editor navigation tests
  Dean Herbert · 2024-07-10 18:34:47 +09:00
  72091b43df
• Attempt to stay on correct difficulty
  Dean Herbert · 2024-07-10 18:34:46 +09:00
  3beca64cc5
• Add loading segments and tidy things up
  Dean Herbert · 2024-07-10 18:34:46 +09:00
  27ab54882b
• Improve UX and styling of external edit screen
  Dean Herbert · 2024-07-10 18:34:45 +09:00
  74aa05fa6e
• Add sub screen to limit user interactions
  Dean Herbert · 2024-07-10 18:34:45 +09:00
  118162c631
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Fix loading (but not showing) a sheared overlay hiding displayed footer content

  Identified by tests. See https://github.com/ppy/osu/actions/runs/9869382635/job/27253010485 & https://github.com/ppy/osu/actions/runs/9869382635/job/27253009622.
  
  This change also prevents the initial `PopOut` call in overlays from calling `clearActiveOverlayContainer`, since it's not in the update thread and it's never meant to be called at that point anyway (it's supposed to be accompanied by a previous `PopIn` call adding the footer content).

  Salman Ahmed · 2024-07-10 11:56:35 +03:00
  337f05f9a4
• Add failing test case for edge case
  Salman Ahmed · 2024-07-10 11:51:49 +03:00
  f0a7a3f856
• Ask for VisibilityContainer explicitly
  Salman Ahmed · 2024-07-10 11:14:22 +03:00
  002679ebb0
• Merge pull request #28789 from peppy/fix-deletes-reappearing

  Fix deleted beatmap sets potentially reappearing due to pending update requests

  Bartłomiej Dach · 2024-07-10 09:14:10 +02:00
  95783bd6c2
• Merge branch 'master' into footer-v2-integration
  Dean Herbert · 2024-07-10 15:33:05 +09:00
  9a88281ab0
• Merge pull request #28682 from frenzibyte/footer-v2-overlay-content

  Add implementation for `ScreenFooter` to house footer content of sheared overlays

  Dean Herbert · 2024-07-10 15:08:00 +09:00
  4fe3f39d22
• Merge pull request #28740 from bdach/daily-challenge/better-results

  Improve results displays in daily challenge screen

  Dean Herbert · 2024-07-10 14:17:21 +09:00
  cd9973b6f9
• Merge pull request #28796 from Joehuu/fix-preview-persisting-after-leaving

  Fix preview track persisting to play after entering multi/playlists gameplay

  Dean Herbert · 2024-07-10 14:07:49 +09:00
  9c1dcbcdda
• Rename method to match provided argument
  Dean Herbert · 2024-07-10 14:00:15 +09:00
  f281019358
• Migrate ShearedOverlayContainer to NRT
  Dean Herbert · 2024-07-10 13:54:27 +09:00
  4e1240c349
• Fix preview track persisting to play after leaving multi/playlists room
  Joseph Madamba · 2024-07-09 14:36:24 -07:00
  8c81ba3357
• Snap to stack in osu! composer when dragging to any of the items on it

  Previously it would be required to drag to the starting position of the
  stack which feels weird.

  Bartłomiej Dach · 2024-07-09 13:58:58 +02:00
  9cc0e0137b
• Run stacking when performing movement in osu! composer

  Closes https://github.com/ppy/osu/issues/28635.

  Bartłomiej Dach · 2024-07-09 13:52:36 +02:00
  ec9040798f
• Add similar special case for insert after removal
  Dean Herbert · 2024-07-09 20:44:55 +09:00
  123d3d2ff8
• Add failing test case showing editor save then delete failure
  Dean Herbert · 2024-07-09 20:41:22 +09:00
  0e2e44a2f5
• Merge branch 'master' into footer-v2-integration
  Salman Ahmed · 2024-07-09 13:48:40 +03:00
  ed1f3a1eb4
• Merge branch 'master' into footer-v2-overlay-content
  Salman Ahmed · 2024-07-09 13:41:44 +03:00
  b17af86491
• Make hit object and sample point seek keybinds configurable
  OliBomby · 2024-07-09 12:28:23 +02:00
  306dc37ab5
• Remove unused using
  Bartłomiej Dach · 2024-07-09 10:57:21 +02:00
  ca4c0aa7e2
• Merge pull request #28786 from Joehuu/sort-direction-caret-transition

  Add caret transition to beatmap listing sort tab items

  Bartłomiej Dach · 2024-07-09 10:52:11 +02:00
  13c8370823
• Fix deleted beatmap sets potentially reappearing due to pending update requests
  Dean Herbert · 2024-07-09 17:08:26 +09:00
  920c0e4d25
• Ensure beatmap set is always detached when updating

  Slight performance improvement by doing the detach as early as possible.

  Dean Herbert · 2024-07-09 17:08:25 +09:00
  63b4327978
• Merge pull request #28787 from peppy/adjust-editor-fades

  Adjust editor transparent tweens to be less "flashy"

  Bartłomiej Dach · 2024-07-09 10:08:14 +02:00
  877ade3053
• Merge pull request #28785 from peppy/fix-realm-callbacks

  Ensure realm subscriptions always fire initial callback with null `ChangeSet`

  Dan Balasescu · 2024-07-09 16:52:38 +09:00
  e734cdfee5
• Redesign bottom timeline pieces to match stable better
  Bartłomiej Dach · 2024-07-09 09:25:22 +02:00
  5d5dd0de00
• Slim down bottom timeline

  This removes the BPM display, which is commonly cited to have
  no functional purpose by users, and reduces the height of the bottom bar
  in exchange for more space for the playfield.

  Bartłomiej Dach · 2024-07-09 09:25:22 +02:00
  29b8948609
• Ensure timeline ticks aren't hidden by other pieces

  Addresses https://github.com/ppy/osu/issues/28667.

  Bartłomiej Dach · 2024-07-09 09:25:22 +02:00
  50818da166
• Adjust editor transparent tweens to be less "flashy"

  Touched on in https://github.com/ppy/osu/discussions/28581.
  
  After a bit more usage of the editor I do agree with this and think that
  making the fades a bit more gentle helps a lot.

  Dean Herbert · 2024-07-09 16:16:19 +09:00
  aadcc5384d
• Inhibit original callback from firing when sending initial changeset
  Dean Herbert · 2024-07-09 16:05:58 +09:00
  ee9e329db3