48098 Commits

• Merge pull request #32764 from peppy/font-colour-icon-specs

  Add new icons, font templates, statistics naming changes and colour updates

  Dean Herbert · 2025-04-11 23:32:06 +09:00
  93c148f05b
• Avoid performing colour fades when pill is not visible in the first place
  Dean Herbert · 2025-04-11 21:19:26 +09:00
  4b9873f03e
• Fix some incorrect/lacking comments
  Dean Herbert · 2025-04-11 21:14:56 +09:00
  c4cfd3a148
• Remove conditional in difficulty spectrum retrieval function

  Wiil be handled locally instead using the diff in https://github.com/ppy/osu/pull/32764#discussion_r2039384833

  Salman Alshamrani · 2025-04-11 07:45:10 -04:00
  08c17bdf9e
• Define standard font sizes
  Salman Alshamrani · 2025-04-11 20:13:53 +09:00
  74227e7b79
• Abstractify test scene

  I think in this case it's genuinely reasonable to use abstracts to
  reduce boilerplate.

  Bartłomiej Dach · 2025-04-11 12:09:53 +02:00
  30bb8e335c
• Add test exercising osu! replay playback stability after encode
  Bartłomiej Dach · 2025-04-11 12:09:51 +02:00
  ac36e228b8
• Update difficulty spectrum retrieval function
  Dean Herbert · 2025-04-11 17:58:27 +09:00
  c52dc9ffe8
• Merge branch 'master' into fix-carousel-bleed
  Bartłomiej Dach · 2025-04-11 08:23:37 +02:00
  4398479846
• Remove redundant initialisers
  Bartłomiej Dach · 2025-04-11 08:01:34 +02:00
  5c54e57d6d
• Add specifications for new song select icons
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  36a11d4bf7
• Add DarkOrange colour set
  Salman Alshamrani · 2025-04-11 02:25:12 +09:00
  55dc64e5b6
• Update API beatmap model to include user play count
  Salman Alshamrani · 2025-04-11 02:24:38 +09:00
  6bb84e4364
• Revert "Use median for statistic display"

  This reverts commit fa06643bb6.
  
  Revert "Remove mean hit error calculation"
  
  This reverts commit b3c578e545.

  Dean Herbert · 2025-04-11 02:12:40 +09:00
  ba5932c1dd
• Remove previous beatmap wedge implementation
  Salman Alshamrani · 2025-04-11 01:55:36 +09:00
  430b22b383
• Fix carousel handling of bleed areas

  The idea of specifying "bleed" is to make the carousel aware of its
  vertical display area. The top bleed is under the filter control; bottom
  beneath the toolbar. At the end of the day, the point of panel X offset
  incursion, and the scroll target for current selection, should be at the
  centre of the screen.
  
  The fixes match code which already exists in the previous
  implementation. Basically, without incorporating `BleedTop` into
  calculations a second time, the centre position would not match
  expectations (of being the centre including bleed).

  Dean Herbert · 2025-04-11 00:05:51 +09:00
  f9112066d3
• Allow displaying "unknown" status in status pill
  Dean Herbert · 2025-04-10 23:42:29 +09:00
  57033fc180
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Rename to passed
  Dan Balasescu · 2025-04-10 18:44:44 +09:00
  3dc8a4c1ed
• Add display to show completed playlist items
  Dan Balasescu · 2025-04-10 18:07:10 +09:00
  34180c62eb
• Ensure correct global leaderboard state when presenting scores

  With `ReplayPlayer` now consuming the `LeaderboardManager`'s global
  state, flows such as presenting a score need to set the global state up
  correctly to avoid accidentally showing a leaderboard from a completely
  different score.
  
  This also incidentally closes https://github.com/ppy/osu/issues/27609.

  Bartłomiej Dach · 2025-04-10 10:19:04 +02:00
  31b98ac7b9
• Update scores request to move away from old endpoint
  Bartłomiej Dach · 2025-04-10 09:46:46 +02:00
  17bcc28429
• Actually use leaderboard manager in players

  This was supposed to be the case all along, but I guess in all of the
  rewrite attempts I forgot?
  
  With this, https://github.com/ppy/osu/issues/29861 is actually fixed
  again - and additionally, so is https://github.com/ppy/osu/issues/26716.

  Bartłomiej Dach · 2025-04-10 09:46:44 +02:00
  42ff312ece
• Merge pull request #32744 from peppy/star-rating-fixed-width

  Fix `StarRatingDisplay` not using fixed width text

  Bartłomiej Dach · 2025-04-10 09:07:45 +02:00
  9412334f12
• Fix code quality
  Bartłomiej Dach · 2025-04-10 07:47:31 +02:00
  fb326c6afd
• Allow classic mod in freestyle
  Dan Balasescu · 2025-04-10 13:05:17 +09:00
  c6e368d3ea
• Merge mod validity checks to closer match osu!web
  Dan Balasescu · 2025-04-10 13:02:25 +09:00
  05e70cd938
• Fix success rate / points of failure not showing for unranked beatmaps on beatmap info overlay
  Joseph Madamba · 2025-04-09 11:41:20 -07:00
  bfc6d61e5d
• Remove manual handling of autosize now that we are using fixed width display
  Dean Herbert · 2025-04-10 01:46:44 +09:00
  962edbdf78
• Fix StarRatingDisplay not using fixed width text
  Dean Herbert · 2025-04-09 19:38:58 +09:00
  0c7c791fb5
• Merge pull request #32729 from peppy/fix-mouse-down-leakage

  Fix slider placement not working correctly with UI button clicks

  Bartłomiej Dach · 2025-04-09 11:53:26 +02:00
  110b124cb6
• Merge pull request #32680 from smoogipoo/mp-history-results

  Allow viewing results of historical multiplayer items

  Bartłomiej Dach · 2025-04-09 10:42:39 +02:00
  8672435afa
• Fix editor click-through issues on bottom bar too
  Bartłomiej Dach · 2025-04-09 10:28:06 +02:00
  7ab428f18c
• Merge pull request #32741 from smoogipoo/fix-playlists-mod-stats

  Fix difficulty stats not showing in playlists

  Bartłomiej Dach · 2025-04-09 09:41:11 +02:00
  8e2fa5d9c8
• Merge pull request #32742 from smoogipoo/fix-exception

  Fix exception cancelling disposed cancellation token

  Bartłomiej Dach · 2025-04-09 09:32:37 +02:00
  00044cbbef
• Merge pull request #32723 from sineplusx/fix-multi-chat-hint

  Use actual keybind in multiplayer chat hint

  Bartłomiej Dach · 2025-04-09 09:29:12 +02:00
  c5eda87ac3
• Move key binding string retrieval to RealmKeyBindingStore
  Dean Herbert · 2025-04-09 15:23:55 +09:00
  9e90f80ab5
• Fix exception cancelling disposed cancellation token
  Dan Balasescu · 2025-04-09 15:12:02 +09:00
  3fe967e4d7
• Block all mouse events at BeatDivisorControl and revert animated button change
  Dean Herbert · 2025-04-09 14:56:30 +09:00
  27edee477d
• Fix difficulty stats not showing in playlists
  Dan Balasescu · 2025-04-09 14:55:38 +09:00
  4978903ba5
• Fix various weirdness around refetching
  Bartłomiej Dach · 2025-04-08 13:35:24 +02:00
  68b5f9a314
• Simplify code further
  Bartłomiej Dach · 2025-04-08 13:08:11 +02:00
  9aaa1fe5f4
• Fix test failures
  Bartłomiej Dach · 2025-04-08 13:03:35 +02:00
  f3d9f21e71
• Merge branch 'master' into mp-history-results
  Dan Balasescu · 2025-04-08 19:58:44 +09:00
  0b51cec77c
• Merge branch 'master' into freestyle-mods
  Dan Balasescu · 2025-04-08 19:57:28 +09:00
  1c060f986c
• Merge branch 'master' into yet-another-leaderboard-rewrite-attempt
  Bartłomiej Dach · 2025-04-08 12:54:27 +02:00
  567c7cb798
• Merge pull request #32669 from smoogipoo/refactor-match-subscreen

  Rewrite match subscreen to remove bindables

  Bartłomiej Dach · 2025-04-08 12:51:36 +02:00
  b3626bfb48
• Clone countdown objects in test client

  Beyond isolation, this stuff is also used to test (de-)serialisation.
  Much-of-a-muchness in this case since it isn't too thoroughly tested,
  but best do it anyway.

  Dan Balasescu · 2025-04-08 18:42:25 +09:00
  874ec49590
• Fix crash when trying to start countdown
  Dan Balasescu · 2025-04-08 18:35:51 +09:00
  5769292daf
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618