55 Commits

• Fix storyboard videos not displaying

  Regressed with 102085668f because the
  stupid magic alpha transform addition was also implicitly changing the
  value of `IsDrawable` from false to true because that property checks
  for presence of any commands.
  
  Apparently past me, in his infinite wisdom, did not decide it pertinent
  to test that change against, you know, *a beatmap with a storyboard*.
  Great job, past me, good show all around.

  Bartłomiej Dach · 2025-04-18 14:23:43 +02:00
  2761ee005d
• Fix video offset start time regression with StartTime calculation changes
  Dean Herbert · 2025-04-03 18:03:23 +09:00
  102085668f
• Fix test failures due to StoryboarVideo having a weird initialisation flow
  Dean Herbert · 2025-03-26 19:42:16 +09:00
  dd7026f7c7
• Fix storyboards with no-op alpha operations causing extended drawable lifetimes

  Test with https://osu.ppy.sh/beatmapsets/139525#osu/348550. See
  https://github.com/ppy/osu/issues/32453#issuecomment-2742562780 (and
  inline comments) for explanation.
  
  Closes https://github.com/ppy/osu/issues/32453.

  Dean Herbert · 2025-03-25 16:14:33 +09:00
  203e294e49
• Merge branch 'master' into storyboard-loops-v2
  Salman Ahmed · 2024-05-01 23:46:38 +03:00
  895c09d4d1
• Revert "Merge pull request #27454 from EVAST9919/sb-lifetime-improvements"

  This reverts commit 0881e7c8c1, reversing
  changes made to 29a37e3585.

  Dan Balasescu · 2024-04-05 14:45:49 +09:00
  7b92c725b1
• Remove extra end line
  Salman Ahmed · 2024-03-08 23:09:50 +03:00
  9f71eac1db
• Fix merge conflicts
  Salman Ahmed · 2024-03-08 20:22:26 +03:00
  a85be2a46d
• Merge branch 'master' into storyboard-loops-v2
  Salman Ahmed · 2024-03-08 20:22:19 +03:00
  8d3e502262
• Fix refactor error on EndTimeForDisplay

  Not sure when this happened >.>

  Salman Ahmed · 2024-03-08 03:08:03 +03:00
  79da6d8613
• Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences

  *sigh*

  Salman Ahmed · 2024-03-08 03:07:39 +03:00
  fa9b2f0cd5
• Support applying initial values of storyboard commands
  Salman Ahmed · 2024-03-08 02:02:48 +03:00
  b450abb687
• Fix incorrect start time calculations

  `LoopStartTime` is now baked into each `IStoryboardCommand`.

  Salman Ahmed · 2024-03-08 02:01:02 +03:00
  87b065b8c3
• Apply major refactor to the storyboard commands flow structrure
  Salman Ahmed · 2024-03-08 01:10:09 +03:00
  585ab59768
• Move optimisation to isolated method
  Dean Herbert · 2024-03-06 19:25:13 +08:00
  5b6703ec0d
• Remove blank lines
  Andrei Zavatski · 2024-03-06 00:17:56 +03:00
  1c8ede854d
• Implement StoryboardElementWithDuration
  Andrei Zavatski · 2024-03-06 00:16:06 +03:00
  8b03acd27b
• Make use of framework's transform loops
  Andrei Zavatski · 2024-03-03 21:47:03 +03:00
  7193ec66a4
• Use more direct way to apply transforms
  Andrei Zavatski · 2024-03-03 20:50:28 +03:00
  c05007804f
• Improve sb sprite end time guessing
  Andrei Zavatski · 2024-03-01 22:30:44 +03:00
  77b3055978
• Add second definition of EndTime for storyboard elements to account for loops in lifetime
  Dean Herbert · 2023-04-25 15:22:11 +09:00
  e330052852
• Apply NRT to some storyboard classes
  Dean Herbert · 2023-04-25 14:30:01 +09:00
  3919400be2
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Remove unnecessary virtual spec
  Dean Herbert · 2022-09-12 14:20:48 +09:00
  bbf906ee06
• Fix storyboard animations not starting their animation playback from the correct point in time
  Dean Herbert · 2022-09-12 14:05:16 +09:00
  24138b65a7
• Fix typo in LoopStartTime addition
  Dean Herbert · 2022-09-06 17:46:03 +09:00
  a3de5f808e
• Rewrite logic using a list
  Dean Herbert · 2022-09-06 16:58:51 +09:00
  677708c5e4
• Refactor alpha check to not overwrite sourced overrides with values from later commands
  Dean Herbert · 2022-09-06 16:41:32 +09:00
  d667f46830
• Handle earliest-alpha-start-time logic in StoryboardSprite itself
  Dean Herbert · 2022-09-06 16:16:58 +09:00
  bea42d2862
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use longer form to read better

  Using `l.StartTime` reads like a coding issue, even though if you go
  down the call chain looks to be correct.

  Dean Herbert · 2021-12-14 17:41:09 +09:00
  79dd9674fc
• Fix storyboard sprites sometimes starting too early
  Dan Balasescu · 2021-12-14 13:13:12 +09:00
  357a661379
• Rename parameter to repeatCount and add guards
  Dean Herbert · 2021-10-01 18:26:29 +09:00
  3faafd7200
• Implement Duration via the interface
  Dean Herbert · 2021-05-04 16:04:59 +09:00
  ffc88db47a
• Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field
  Christine Chen · 2021-04-18 20:20:14 -04:00
  98460c8feb
• Move storyboard outro logic to DrawableStoryboard
  Christine Chen · 2021-04-16 00:59:10 -04:00
  b15838b220
• Add IHasDuration interface with EndTime for storyboard elements to implement
  Christine Chen · 2021-04-15 17:17:02 -04:00
  0e545e1ed9
• Fix storyboard commands occurring before the earliest point of visibility delaying gameplay

  In osu-stable, storyboard intros start from the first command, but in
  the case of storyboard drawables which have an initial hidden state, all
  commands before the time at which they become visible (ie. the first
  command where `Alpha` increases to a non-zero value) are ignored.
  
  This brings lazer in line with that behaviour. It also removes several
  unnecessary LINQ calls.
  
  Note that the alpha check being done in its own pass is important, as
  it must be the "minimum present alpha across all command groups,
  including loops". This is what makes the implementation slightly
  complex.
  
  Closes #11981.

  Dean Herbert · 2021-03-09 15:55:12 +09:00
  8aaba32431
• Apply remaining uncaught changes
  Dean Herbert · 2020-01-20 23:59:21 +09:00
  740bdee125
• Improve performance of storyboard loading
  smoogipoo · 2019-12-19 00:52:50 +09:00
  f38853d229
• Fix storyboard vectorscale and scale cross-pollution
  smoogipoo · 2019-12-18 17:21:38 +09:00
  602ce698d5
• Apply other styles.
  Huo Yaoyuan · 2019-11-11 20:27:04 +08:00
  e9b8cbb516
• Apply brace style.
  Huo Yaoyuan · 2019-11-11 20:13:13 +08:00
  ccc8aa6fa4
• Update framework
  Dean Herbert · 2019-08-21 13:29:50 +09:00
  48716f8f2b
• Apply newline additions
  Dean Herbert · 2019-04-01 12:16:32 +09:00
  612db31c38
• Merge branch 'master' into use-pattern-matching
  Dean Herbert · 2019-02-28 14:53:07 +09:00
  2dbf7d122c
• Use pattern matching wherever possible
  Dean Herbert · 2019-02-28 14:35:00 +09:00
  e2c6a8bc07
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7