osu-lazer

Sort scores immediately for good measure

Dean Herbert · 2025-08-26 17:51:14 +09:00

3f179e3903

Fix playlist leaderboard provider potentially inserting local user in wrong order

Due to `Perform` being used from a BDL method in conjunction with
`Success` (which is scheduled to the *update* thread), there was a
chance that the order of execution would be not quite as intended.

To rectify, let's not use `Success` and just continue with synchronous
flow.

Dean Herbert · 2025-08-26 17:51:02 +09:00

196b28115e

Localise Sort dropdown

Denis Titovets · 2025-07-28 20:48:46 +03:00

6fbb3294fe

Merge branch 'master' into ssv2-localisation

Denis Titovets · 2025-07-28 19:12:34 +03:00

6936533522

Rename {-> Max}Combo sort mode

I have a feeling this is going to save asses in an indeterminate future.

Bartłomiej Dach · 2025-07-28 11:38:17 +02:00

f489ffdfd7

Merge branch 'master' into local-score-sorting-v2

Bartłomiej Dach · 2025-07-28 11:32:59 +02:00

c620d58bc2

Merge branch 'master' into ssv2-localisation

Denis Titovets · 2025-07-25 11:36:52 +03:00

4b73afd195

Fix playlists leaderboard provider not being thread safe

Should close https://github.com/ppy/osu/issues/34222.

I haven't exactly managed to reproduce the issue myself but I'm
relatively confident in the imagined mode of failure here. See

	https://github.com/ppy/osu/blob/861a7e1db4b72ccfec67ef5f9a6a19faa0978d3f/osu.Game/Screens/OnlinePlay/Playlists/PlaylistsPlayer.cs#L25-L37
	https://github.com/ppy/osu/blob/861a7e1db4b72ccfec67ef5f9a6a19faa0978d3f/osu.Game/Screens/OnlinePlay/Playlists/PlaylistsPlayer.cs#L53

Bartłomiej Dach · 2025-07-21 10:49:56 +02:00

fae5c0e7bb

Make edits based on reviews

Denis Titovets · 2025-07-13 23:59:59 +03:00

b120608ec5

Fully localise SSV2

Denis Titovets · 2025-07-09 15:07:07 +03:00

1f052bb195

RankingsSort -> LeaderboardSortMode

Dani211e · 2025-06-26 19:03:49 +02:00

c1a34d8c6a

Add sorting dropdown

Only use sorting when on local scope otherwise hide

Dani211e · 2025-06-25 05:01:40 +02:00

ad35dad46d

Add support for showing leaderboard in playlists and daily challenge

As touched on in https://github.com/ppy/osu/pull/33581.

Bartłomiej Dach · 2025-06-11 11:21:26 +02:00

4810c7c847

Disallow placing gameplay leaderboard in skins outside player

Closes https://github.com/ppy/osu/issues/33542.

For a diff this simple this took much more hemming and hawing because
things are a bit annoying here from a few angles:

- The only way that is considered idiomatic right now for a skin
  component to not be applicable to a screen is to require a dependency
  from DI that is only provided by applicable screens.
  `DrawableGameplayLeaderboard` has a few of those dependencies, but the
  scope of all the usages makes it so that the only really viable one to
  use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
  and also the usage of multiplayer spectator, where the leaderboard is
  *not* under a player instance).

- The smelly part of this is that the `Player` inheritance hierarchy
  must ensure that *every* non-abstract class has an
  `IGameplayLeaderboardProvider` cached. It is not trivial - if not
  straight up impossible - to force this via some `Player` level
  abstract method, because such a method would need to somehow
  accommodate all possible leaderboard providers. That however also
  means that every possible future `Player` implementor *must inherently
  know* to also cache a leaderboard provider lest it die at runtime. I
  don't love that, but I also don't see better alternatives.

- Speaking of which, I also noticed that solo spectator and playlists
  don't have gameplay leaderboards. At all. Which I don't believe to be
  something that I broke with the leaderboard work - I'm pretty sure
  that was the pre-existing state - however I don't see any reason why
  they *couldn't* receive gameplay leaderboards. I'm not doing that
  here, though, just leaving TODOs for later.

Bartłomiej Dach · 2025-06-09 13:11:29 +02:00

6416f59c7b

Fix general confusion in which combo should be read on which gameplay leaderboard

Closes https://github.com/ppy/osu/issues/33455.

The fundamental misunderstanding and source of confusion in
https://github.com/ppy/osu/pull/33062 is that solo wants to show
*maximum combo*, and multiplayer wants to show *current combo*, for
their own, valid reasons. Which is spelled out explicitly in this
change.

Bartłomiej Dach · 2025-06-06 10:08:01 +02:00

a92a659662

Fix extreme Drawable thrashing on initial leaderboard population

Dan Balasescu · 2025-06-05 23:01:31 +09:00

218d8290cb

Remove redundant public specfications in interfaces

Rider EAP being noisy about this now (smoogi will be happy :D).

Dean Herbert · 2025-05-26 17:14:41 +09:00

cb0592d711

Fix gameplay leaderboard score reading off wrong combo property

Closes https://github.com/ppy/osu/issues/33006.

Broke in c231571f06.

The fact that this mistake can be made at all is... something, but it
was made.

Bartłomiej Dach · 2025-05-07 13:50:11 +02:00

8af687f751

Cross-reference copies of similar logic

Bartłomiej Dach · 2025-04-30 10:25:05 +02:00

b2032f95ff

Merge pull request #32947 from bdach/use-actual-score-positions-in-gameplay-leaderboard

Use actual score positions in gameplay leaderboard

Dean Herbert · 2025-04-30 17:20:12 +09:00

1b5553a2d8

Remove redundant initialiser

Bartłomiej Dach · 2025-04-28 12:21:46 +02:00

6b298abf88

Exclude non-user-playable mods from mod filter in beatmap leaderboard

For easier understanding, substitute "non-user-playable" with
"autoplay".

The reason that I'm bothering to do this is that if you put autoplay on
and turn on the "Selected Mods" filter, the request will actually go
through and hit web, and web will obviously return no scores. On song
select that's *maybe* fine, even though probably unintended still, but
now with the leaderboard state being global this also means gameplay
gets impacted. Which also means that if you Ctrl-Enter to start a map in
autoplay you're not going to get any gameplay leaderboard scores at all.

Bartłomiej Dach · 2025-04-25 13:06:01 +02:00

3eb1ae225d

Use actual score positions in gameplay leaderboard

Intends to close https://github.com/ppy/osu/issues/32859.

The difference between this and https://github.com/ppy/osu/pull/32942 is
that this PR takes the approach of completely moving the score sorting
behaviour to `IGameplayLeaderboardProvider` implementations.

This is going to be helpful for further work - to be precise, I am
looking to add a leaderboard position indicator in the bottom right of
multiplayer player to match stable, and having the position in the
provider will make the implementation of that *much* easier.

Bartłomiej Dach · 2025-04-25 12:40:55 +02:00

06dc4235f0

Always refresh leaderboard for now

Dean Herbert · 2025-04-23 14:51:00 +09:00

f945abb72e

Remove LeaderboardManager return value and simplify flow further

The rationale for this change is that the return value was mostly
useless, and at worst, misleading.

When using `LeaderboardManager`, it's assumed that a consumer will bind
to the global `Scores` list to ensure they receive updates for things
like local score changes via the internal realm subscription. If one
decides to instead use the return value of the task, it will be a static
snapshot that potentially becomes stale in the future.

I fell into this trap when refactoring the new leaderboard component
(while attempting to assert correctness that the values we are
displaying were in fact from the fetch operation we requested).

In the interest of keeping things simple, removing the return value
seems to be the best path forward.

Dean Herbert · 2025-04-22 19:31:02 +09:00

f7d1809cb7

Avoid clearing global cache on entering song select

Dean Herbert · 2025-04-22 19:29:09 +09:00

7e6e082bac

Move bindable list population to load complete to fix threading woes

Bartłomiej Dach · 2025-04-21 09:05:54 +02:00

4d08c81e8d

Merge branch 'master' into leaderboards/gameplay-provider

Bartłomiej Dach · 2025-04-21 09:03:24 +02:00

6b0567e882

Fix gameplay leaderboard showing scores from wrong beatmaps

Kind of a big oversight this. In wanting to get the leaderboard
refactors to move forward I sort of didn't realise the fact that all of
the error handling related to online status and such in
`BeatmapLeaderboard` kind of... can't stay there...

It's also an all-or-nothing business too - moving this stuff can't
really be done only in part.

Not sure whether tests are warranted if it's more or less moving logic
across?

Bartłomiej Dach · 2025-04-18 20:37:02 +02:00

c29f59fcdb

Remove unnecessary interface

Bartłomiej Dach · 2025-04-18 12:12:21 +02:00

6d258d4ed5

Add clarification to IsPartial xmldoc

Bartłomiej Dach · 2025-04-18 12:02:21 +02:00

006670c442

Attempt to fix tests

Bartłomiej Dach · 2025-04-17 14:26:34 +02:00

d546bbaf8f

Separate gameplay leaderboard data management from display

This is a prerequisite for supporting skinning of leaderboards.

- New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
  interfaces are introduced. They are strictly concerned with supplying
  leaderboard data.

- Logic of managing display, which was previously jammed into the
  inheritance hierarchy of `GameplayLeaderboard`, is now moved into
  `IGameplayLeaderboardProvider` implementations. Solo play,
  multiplayer, and multiplayer spectator get their own implementation of
  the interface.

- The inheritance hierarchy of `GameplayLeaderboard` and per-player
  overriding of the implementation of the gameplay leaderboard is gone.
  Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
  allowed to display the leaderboards, across all modes of play.

Bartłomiej Dach · 2025-04-16 14:46:55 +02:00

c231571f06

Fix local leaderboards not showing when starting game offline

Broke in https://github.com/ppy/osu/pull/32494. Oops.

Bartłomiej Dach · 2025-04-16 10:27:33 +02:00

cf2f6d7233

Fix various weirdness around refetching

Bartłomiej Dach · 2025-04-08 13:35:24 +02:00

68b5f9a314

Extract leaderboard fetch logic from song select beatmap leaderboard drawable

RFC. Another attempt at this.

- Supersedes https://github.com/ppy/osu/pull/31881
- Supersedes / closes https://github.com/ppy/osu/pull/31355
- Closes https://github.com/ppy/osu/issues/29861

This is a weird diff because I am feeling rather boxed in by all the
constraints, namely that:

- Leaderboard state should be global state
- But the global state is essentially managed by song select and namely
  `BeatmapLeaderboard` itself. That's because trying to e.g. not have
  `BeatmapLeaderboard` pass the beatmap and the ruleset to the global
  leaderboard manager is worse, as it essentially introduces two
  parallel paths of execution that need to be somehow merged into one
  (as in I'd have to somehow sync `LeaderboardManager` responding to
  beatmap/ruleset changes with `BeatmapLeaderboard` which is inheritance
  hell)
- Also local leaderboard fetching is data-push (as in the scores can
  change under the leaderboard manager), and online leaderboard fetching
  is data-pull (as in the scores do not change unless the leaderboard
  manager does something). Also online leaderboard fetching can fail.
  Which is why I need to still have the weird setup wherein there's a
  `FetchWithCriteriaAsync()` (because I need to be able to respond to
  online requests taking time, or failing), but also the
  `BeatmapLeaderboard` only uses the public `Scores` bindable to
  actually read the scores (because it needs to respond to new local
  scores arriving).
- Another thing to think about here is what happens when a retrieval
  fails because e.g. the user requested friend leaderboards without
  having supporter. With how this diff is written, that special
  condition is handled to `BeatmapLeaderboard`, and
  `LeaderboardManager`'s state will remain as whatever it was before
  that scope change was requested, which may be considered good or it
  may not (I imagine it's better to show scores in gameplay than not in
  this case, but maybe I'm wrong?)

Bartłomiej Dach · 2025-03-21 12:06:16 +01:00

0209129618

Use localisable string

Bartłomiej Dach · 2025-03-13 08:37:02 +01:00

c18764d764

Remove unused using

Bartłomiej Dach · 2025-03-13 08:36:19 +01:00

3515f9a8f8

Add support for team beatmap leaderboards

Dean Herbert · 2025-03-13 16:28:20 +09:00

b0cf5e8bff

Add helper methods to check whether beatmap leaderboard scope requires supporter