501 Commits

• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Merge pull request #34231 from bdach/user-tag-search-wip

  Add initial support for filtering by user tags in song select

  Dean Herbert · 2025-07-21 14:52:47 +09:00
  b4466aa7a2
• Fixed issue #34101 for both Select menus.
  emkodelirdi · 2025-07-18 21:45:54 +03:00
  c9ff57fe72
• Add initial support for filtering by user tags in song select

  The way that this works is that it plugs into the online request to
  retrieve the beatmap set that the client is already performing, and
  stores user tag data to the local realm database.
  
  This means that for now user tags will only populate for beatmaps that
  the user has displayed on song select which is obviously subpar. I plan
  to follow this change up by adding user tag state dumps to `online.db`
  and using that data for initial tag population to make the majority case
  (ranked beatmaps) work.
  
  Note that several decisions were made here that are potential discussion
  points:
  
  - `RealmPopulatingOnlineLookupSource` is set up such that it can be the
    middle man / redirection point for similar flows that we need and we
    are currently missing, such as storing guest difficulty information,
    or storing the user's current best score on a beatmap (handy for rank
    achieved sorting / filtering / etc.)
  
  - The user tags are stored in `BeatmapMetadata` which breaks the
    longstanding assumption that you can arbitrarily pull out a metadata
    instance from any of the beatmaps in a set and get essentially the
    same object back.
  
    I've attempted to constrain this some by not adding user tags to
    the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
    exposes metadata further, but I warn in advance that this is
    a temporary state of affairs and I will make it worse in the future
    when `BeatmapMetadata.Author` becomes `Authors` plural in order to
    support guest mapper display (and direct guest difficulty submission).
  
  - The syntax for searching via user tags is chosen to mostly match web -
    it's `tag=`, with support for all of the string matching modes song
    select already has (bare word for substring, `""` quotes for phrase
    isolated by whitespace, `""!` for exact full match).

  Bartłomiej Dach · 2025-07-15 11:09:40 +02:00
  8cb81974eb
• Disallow hiding beatmap difficulties if only one difficulty remains
  Dean Herbert · 2025-07-10 17:57:45 +09:00
  789ddcf395
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Add debounce to difficulty calculation operations in churn scenarios
  Dean Herbert · 2025-05-19 16:16:33 +09:00
  192a1642d4
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Rename localised string to something slightly more correct
  Dean Herbert · 2025-03-18 00:12:13 +09:00
  43d7918548
• Change CopyUrlToClipboard to CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:02:41 +01:00
  f72de39e4d
• Perform client side validation that the selected beatmap and ruleset have valid online IDs

  This is local to playlists, since in multiplayer the validation is
  already provided by `osu-server-spectator`.

  Dean Herbert · 2025-01-21 19:51:55 +09:00
  459847cb80
• Merge branch 'master' into multiplayer-free-style
  Dean Herbert · 2025-01-21 17:49:21 +09:00
  c68a0bc7e3
• Initial support for free style selection
  Dan Balasescu · 2024-12-23 20:12:25 +09:00
  638d959c5c
• Implement ability to mark beatmap as played

  Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.
  
  Would you believe it that this button that has been there for literal
  years never did anything?
  
  Implemented at a per-beatmap level. Also additionally added to context
  menu (at @peppy's suggestion), and also copy reworded from "Delete from
  unplayed" to "Mark as played" because double negation hurt my tiny
  brain.

  Bartłomiej Dach · 2024-12-16 10:49:19 +09:00
  a6e00d6eac
• Some Carousel classes can be abstract
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  de31a48beb
• Add missing source query filter in song select
  Joseph Madamba · 2024-11-15 22:53:23 -08:00
  465cc716d3
• Reduce semi-opaque layers at song select

  I made these changes while working on
  https://github.com/ppy/osu/pull/30579. Basically, it's hard to fix the
  ranks not loading while underneath the footer, and the transparency both
  looks bad, and is going away in the redesign.
  
  I've chosen values here that are moving *in the direction* of the new
  design without overhauling everything.
  
  - I know that there's still some transparency. I did this because it
  helps keep all current elements / colours contrasting without too much
  effort.
  - I completely removed the transparency adjustments on the beatmap
  panels. This always looked bad due to being applied per-layer, and I
  don't think it added much.

  Dean Herbert · 2024-11-11 17:57:23 +09:00
  f84ee3996f
• Extract "copy link" text to common localisation
  Bartłomiej Dach · 2024-11-04 13:59:48 +01:00
  51f26993fa
• Filter out unranked/unsubmitted beatmaps when using the ranked/submitted search filters
  WitherFlower · 2024-10-11 09:49:47 +02:00
  da376c534b
• Implement ranked and submitted date filtering
  WitherFlower · 2024-10-08 13:56:55 +02:00
  2369e98cfc
• Use for with exposed IReadOnlyList rather than making internal container public
  Dean Herbert · 2024-09-04 15:25:36 +09:00
  dfe11dc68a
• Fix per-frame allocations in BeatmapCarousel
  Dean Herbert · 2024-09-04 14:31:59 +09:00
  421f245c31
• Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu

  Allow copying beatmap link in song select carousel context menu

  Bartłomiej Dach · 2024-08-22 14:03:39 +02:00
  bd6943ebc2
• Add missing user ruleset to link copying for beatmap panels
  Dean Herbert · 2024-08-22 19:18:41 +09:00
  58552e9768
• Move copy-to-url method to OsuGame to centralise toast popup support
  Dean Herbert · 2024-08-22 14:03:41 +09:00
  f068b7a521
• Remove one unused parameter
  Dean Herbert · 2024-08-22 02:17:11 +09:00
  ac5a3a0959
• Move URL implementation to extension methods and share with other usages
  Dean Herbert · 2024-08-22 02:08:01 +09:00
  87123d99bf
• Use "link" instead of "URL"
  Dean Herbert · 2024-08-22 01:45:43 +09:00
  18a3ab2ffd
• Fix null reference
  jkh675 · 2024-08-21 16:21:49 +08:00
  3d5b57454e
• Implement copy url in beatmap and beatmap set carousel
  jkh675 · 2024-08-20 22:48:11 +08:00
  8e273709f1
• Fix beatmap carousel panels not blocking hover of other panels in song select
  Joseph Madamba · 2024-08-17 11:45:54 -07:00
  6dd08e9a96
• Reduce length of fade-out when hiding beatmap panels
  Dean Herbert · 2024-06-26 12:01:38 +09:00
  e84daedbea
• Add mods to FilterCriteria, pass to ruleset method
  Dan Balasescu · 2024-03-28 23:03:26 +09:00
  9fd6449fd8
• Add ability to query key count with mods
  Dan Balasescu · 2024-03-28 22:51:12 +09:00
  10edb54614
• Use title as tiebreaker when sorting beatmap carousel by artist

  Closes https://github.com/ppy/osu/issues/27548.
  
  Reference: https://github.com/peppy/osu-stable-reference/blob/e53980dd76857ee899f66ce519ba1597e7874f28/osu!/GameplayElements/Beatmaps/BeatmapTreeManager.cs#L341-L347

  Bartłomiej Dach · 2024-03-22 08:41:10 +01:00
  a1880e89c2
• Merge branch 'master' into multiplayer-difficulty-tooltip
  Bartłomiej Dach · 2024-02-22 12:08:29 +01:00
  46c8560ca5
• Substitute two jank interdependent bool flags for single tri-state enums
  Bartłomiej Dach · 2024-02-22 12:05:50 +01:00
  d06c67ad8f
• Use DEFAULT instead of INSTANCE or static field

  Matches other similar comparers.

  Dean Herbert · 2024-02-21 21:02:20 +08:00
  fb593470d5
• Use custom comparer in beatmap carousel for expected sort behaviour
  Bartłomiej Dach · 2024-02-21 12:43:18 +01:00
  929858226a
• Merge pull request #26895 from vmfunc/ordinal-sorting

  Consider case sensitivity when sorting beatmaps in song select

  Dean Herbert · 2024-02-18 04:05:22 +08:00
  6960f87509
• Define aggregate max delegates as static to further reduce allocations
  Dean Herbert · 2024-02-15 11:40:50 +08:00
  674ee91bb5
• Avoid some further enumerator allocations
  Dean Herbert · 2024-02-15 09:45:24 +08:00
  80abf6aab3
• Redice allocations during aggregate beatmap sort
  Andrei Zavatski · 2024-02-15 00:01:55 +03:00
  6e1b4152c0
• Merge branch 'master' into add-last-played-filter
  Bartłomiej Dach · 2024-02-14 15:36:19 +01:00
  1113355753
• use ordinal sorting on each method
  syscats · 2024-02-01 14:03:59 +01:00
  0407b5d84a
• Use ordinal sorting for artist string comparison
  syscats · 2024-01-31 15:49:31 +01:00
  7165511754
• Avoid using .Children for enumeration in other locations
  Dean Herbert · 2024-01-23 05:32:11 +09:00
  02bb506cce
• Restore comment regarding usage of MinBy
  Dean Herbert · 2024-01-09 01:08:47 +09:00
  51bd32bf7e