osu-lazer

Show user tags on beatmap set overlay

Resolves one part of
https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928

A few caveats:

- Layout is slightly different than web intentionally. Web does things
  that I think will be difficult to reproduce or just plain look bad in
  client, such as:

  - On web, the metadata info box has 200px min height and 300px max
    height. I just hardcoded 300 units.

  - On web, user tags and mapper tags are individually scrollable, and
    the amount of space taken up by each is calculated in a way that
    is - as far as I can tell - indeterminate, and probably influenced
    by some flexbox magic. I just made the entire thing scrollable
    instead.

- Because song select shares controls with the beatmap set overlay, now
  song select says "Mapper Tags" in the header instead of just "Tags"
  too. I think this is fine, because people asked for user tags to be
  shown in song select too.

- Search query syntax lifted from
  https://github.com/ppy/osu-web/pull/12047.

- Using hardcoded English strings for now, will update to the
  translations after the next osu-resources localisations update.

Bartłomiej Dach · 2025-03-27 14:58:03 +01:00

7bb97d5796

Apply padding to GridContainers directly

Andrei Zavatski · 2024-02-20 23:18:37 +03:00

2543a48ac8

Apply proposed changes

Dean Herbert · 2023-12-20 12:42:06 +09:00

85e5d74a16

Tidy up visual look

Dean Herbert · 2023-12-19 19:28:02 +09:00

3b848e8503

Move advanced stats to a more permanent location on song select

Dean Herbert · 2023-12-19 19:10:43 +09:00

07bb0805e9

Link new song select wedge title and artist to search text box

Joseph Madamba · 2023-09-06 14:41:10 -07:00

97bd90c0ff

Rename Text to Metadata

Joseph Madamba · 2022-12-23 11:11:15 -08:00

494886ef92

Refactor MetadataSection to use generics and inheritance

Joseph Madamba · 2022-12-21 10:18:47 -08:00

1d39e8d0ce

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Only expose bindable string rather than full textbox

Dean Herbert · 2022-07-15 18:01:35 +09:00

e12e480393

Enable NRT on BeatmapDetails

Salman Ahmed · 2022-07-15 06:52:06 +03:00

86d019c2b2

Fix beatmap details source and tags not filtering on song select

Salman Ahmed · 2022-07-15 06:51:50 +03:00

97c3eea3aa

Update parameter discards

Dean Herbert · 2022-06-24 21:26:19 +09:00

31a447fda0

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Use existing web localisation for most hardcoded strings

Joseph Madamba · 2022-04-20 16:31:11 -07:00

5e5c8e78a6

Clean up unused resolved properties

Dean Herbert · 2021-12-03 18:49:49 +09:00

1eed2436e6

Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface

Dean Herbert · 2021-11-12 17:46:24 +09:00

6a098a8634

Remove BeatmapSetInfo.OnlineInfo and all usages

Dean Herbert · 2021-11-04 15:23:04 +09:00

9c926e5514

Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet

Dean Herbert · 2021-10-29 18:50:55 +09:00

a16c8f1ebc

Apply batch fixing of built-in types using var

Dean Herbert · 2021-10-27 13:04:41 +09:00

6944151486

Rename BeatmapMetrics to APIFailTimes

Dean Herbert · 2021-10-25 15:34:41 +09:00

2c308f3008

Move online metrics out of BeatmapInfo model

Dean Herbert · 2021-10-25 15:32:18 +09:00

20baae9094

Move online metrics out of BeatmapSetInfo model

Dean Herbert · 2021-10-25 15:12:39 +09:00

045dd94a6e

Rename all remaining cases

Dean Herbert · 2021-10-03 00:55:29 +09:00

ec61c3c5ee

Rename BeatmapInfo variables which were named beatmap for clarity

Dean Herbert · 2021-10-02 12:45:34 +09:00

973c31132b

Move to more friendly namespace

Dean Herbert · 2021-07-02 18:09:16 +09:00

362816492f

Move shared types into their own classes

Dean Herbert · 2021-07-02 18:05:00 +09:00

eacf867073

Fix a couple of merge oversights

Dean Herbert · 2021-07-01 19:45:17 +09:00

0522500a57

Merge branch 'master' into linkify-metadata

Dean Herbert · 2021-07-01 19:41:33 +09:00

31dbc7798b

Don't attempt to load content when not online

Dean Herbert · 2021-04-06 17:12:00 +09:00

3113eefcf6

Move loading layer up one level to correct padding

Dean Herbert · 2021-04-06 17:09:51 +09:00

899d708dac

Fix loading layer being in the wrong place

Dean Herbert · 2021-04-06 16:30:47 +09:00

1934e8e1fe

Remove unnecessary online state logic

Dean Herbert · 2021-04-06 16:23:27 +09:00

59e6c46644

Refactor BeatmapDetails to use GridContainer to keep a consistent layout

Dean Herbert · 2021-04-06 16:21:20 +09:00

dafa8bbe4e

Fix code style

PercyDan54 · 2021-04-02 21:15:28 +08:00

a5a19319cc

Use OnlineViewContainer

PercyDan54 · 2021-04-02 20:14:31 +08:00

1ff77754fd

Refactor LoadingLayer to avoid applying effects to external drawables

In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.

This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.

The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).

I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.

Dean Herbert · 2021-01-05 17:31:45 +09:00

54982dcdd7

Fix "bounce" when metadata container text is empty