3312 Commits

• Adjust BPM filtering at song select to be less precise

  Closes https://github.com/ppy/osu/issues/34942.

  Dean Herbert · 2025-09-09 15:02:57 +09:00
  f94d5004ea
• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Sort scores immediately for good measure
  Dean Herbert · 2025-08-26 17:51:14 +09:00
  3f179e3903
• Fix playlist leaderboard provider potentially inserting local user in wrong order

  Due to `Perform` being used from a BDL method in conjunction with
  `Success` (which is scheduled to the *update* thread), there was a
  chance that the order of execution would be not quite as intended.
  
  To rectify, let's not use `Success` and just continue with synchronous
  flow.

  Dean Herbert · 2025-08-26 17:51:02 +09:00
  196b28115e
• Merge branch 'master' into notequaloperator
  Salman Alshamrani · 2025-08-15 14:30:55 +03:00
  1741142673
• Fix incorrect parsing
  Bartłomiej Dach · 2025-08-15 11:12:10 +02:00
  5a9592a769
• Simplify multi-valued not-equal enum filter implementation (and cover with tests)
  Bartłomiej Dach · 2025-08-13 11:54:52 +02:00
  0475fe3215
• Improve xmldoc
  Bartłomiej Dach · 2025-08-13 11:50:35 +02:00
  844704212d
• Refactor string filter not-equal implementation to not make my eyes bleed
  Bartłomiej Dach · 2025-08-13 11:45:56 +02:00
  da69cdfa2a
• Reduce code duplication
  Bartłomiej Dach · 2025-08-13 11:42:26 +02:00
  b356e3bee3
• Fix date range filter being inexplicably implemented a little different than the equality filter

  Why???

  Bartłomiej Dach · 2025-08-13 11:35:38 +02:00
  7a2b032b00
• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Fix keyword filters potentially being wrongly merged together due to regex wildcard greedy matching

  Because of greedy matching, a filter of
  
      tag="style/clean"! tag="song representation/simple"!
  
  would not parse into 2 separate filters like
  
      (tag, =, "style/clean"!)
      (tag, =, "song representation/simple"!)
  
  but rather a single one like
  
      (tag, =, "style/clean"! tag="song representation/simple"!)
  
  This sort of matches what web did in
  https://github.com/ppy/osu-web/pull/12044, except web does some stuff
  with quote escaping that I'd rather not, and also the search syntax
  seems to slightly deviate because web seems to be using single quotes
  and double quotes to open the value part of the filter. I'm not sure
  what the difference is and I'd rather not go into all that right now.

  Bartłomiej Dach · 2025-08-13 10:21:10 +02:00
  08a0025e31
• Fix code quality

  Fix code quality 2
  
  code quality fix 3
  
  Fix code quality 4
  
  Add empty line

  Valerus9 · 2025-08-13 14:59:29 +09:00
  bd90ef1bf4
• Add tests coverage for filters with not equal
  Valerus9 · 2025-08-13 14:59:20 +09:00
  997b8a0bba
• Simplify logic of IsInRange()
  Valerus9 · 2025-08-13 14:59:20 +09:00
  cc970ffd80
• Rename ExludeIfInRange to InvertRange, add xmldox to InvertRange
  Valerus9 · 2025-08-13 14:59:19 +09:00
  3a78cfc627
• Implement not equal operator

  Added blank lines

  Valerus9 · 2025-08-13 14:59:19 +09:00
  3162478172
• Merge branch 'master' into rank-achieved-grouping
  Dean Herbert · 2025-08-12 14:28:20 +09:00
  e7f9f629a4
• Arrange SortMode in alphabetical order
  Denis Titovets · 2025-08-08 16:58:18 +03:00
  ea9a0b52d5
• Add "Rank Achieved" grouping mode
  Salman Alshamrani · 2025-08-07 19:16:04 +09:00
  3e9df00bdc
• Add "My Maps" grouping mode
  Salman Alshamrani · 2025-08-06 13:08:42 +03:00
  e0706dd700
• Allow showing additional metrics when hovering over beatmap attributes
  Bartłomiej Dach · 2025-08-01 11:06:40 +02:00
  c68cbc5360
• Move "attribute adjusted" tooltips to individual attribute displays

  Pre-requisite for displaying additional information regarding the impact
  of particular attributes on various beatmap metrics.

  Bartłomiej Dach · 2025-08-01 11:05:54 +02:00
  cb73717a34
• Add support for grouping beatmaps by collections

  Takes changes in https://github.com/ppy/osu/pull/34233 and removes *all*
  of the complexity.
  
  Supersedes and closes #34233.
  
  Contains same caveat that we can only display one beatmap once in the
  carousel; this will be addressed separately.

  Dean Herbert · 2025-08-01 16:23:26 +09:00
  c3396a93a6
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Fix test
  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  1319a5499b
• Migrate other usages of GetAdjustedDisplayDifficulty() to use GetBeatmapAttributesForDisplay() instead

  This ensures parity between all beatmap attribute displays that used the
  former method.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  a952e3704e
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Localise Sort dropdown
  Denis Titovets · 2025-07-28 20:48:46 +03:00
  6fbb3294fe
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-28 19:12:34 +03:00
  6936533522
• Rename {-> Max}Combo sort mode

  I have a feeling this is going to save asses in an indeterminate future.

  Bartłomiej Dach · 2025-07-28 11:38:17 +02:00
  f489ffdfd7
• Merge branch 'master' into local-score-sorting-v2
  Bartłomiej Dach · 2025-07-28 11:32:59 +02:00
  c620d58bc2
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-25 11:36:52 +03:00
  4b73afd195
• Fix playlists leaderboard provider not being thread safe

  Should close https://github.com/ppy/osu/issues/34222.
  
  I haven't exactly managed to reproduce the issue myself but I'm
  relatively confident in the imagined mode of failure here. See
  
  	https://github.com/ppy/osu/blob/861a7e1db4b72ccfec67ef5f9a6a19faa0978d3f/osu.Game/Screens/OnlinePlay/Playlists/PlaylistsPlayer.cs#L25-L37
  	https://github.com/ppy/osu/blob/861a7e1db4b72ccfec67ef5f9a6a19faa0978d3f/osu.Game/Screens/OnlinePlay/Playlists/PlaylistsPlayer.cs#L53

  Bartłomiej Dach · 2025-07-21 10:49:56 +02:00
  fae5c0e7bb
• Merge pull request #34231 from bdach/user-tag-search-wip

  Add initial support for filtering by user tags in song select

  Dean Herbert · 2025-07-21 14:52:47 +09:00
  b4466aa7a2
• Fixed issue #34101 for both Select menus.
  emkodelirdi · 2025-07-18 21:45:54 +03:00
  c9ff57fe72
• Merge branch 'ppy:master' into ssv2-localisation
  Denis Titovets · 2025-07-16 11:59:47 +03:00
  021ef6d727
• Add initial support for filtering by user tags in song select

  The way that this works is that it plugs into the online request to
  retrieve the beatmap set that the client is already performing, and
  stores user tag data to the local realm database.
  
  This means that for now user tags will only populate for beatmaps that
  the user has displayed on song select which is obviously subpar. I plan
  to follow this change up by adding user tag state dumps to `online.db`
  and using that data for initial tag population to make the majority case
  (ranked beatmaps) work.
  
  Note that several decisions were made here that are potential discussion
  points:
  
  - `RealmPopulatingOnlineLookupSource` is set up such that it can be the
    middle man / redirection point for similar flows that we need and we
    are currently missing, such as storing guest difficulty information,
    or storing the user's current best score on a beatmap (handy for rank
    achieved sorting / filtering / etc.)
  
  - The user tags are stored in `BeatmapMetadata` which breaks the
    longstanding assumption that you can arbitrarily pull out a metadata
    instance from any of the beatmaps in a set and get essentially the
    same object back.
  
    I've attempted to constrain this some by not adding user tags to
    the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
    exposes metadata further, but I warn in advance that this is
    a temporary state of affairs and I will make it worse in the future
    when `BeatmapMetadata.Author` becomes `Authors` plural in order to
    support guest mapper display (and direct guest difficulty submission).
  
  - The syntax for searching via user tags is chosen to mostly match web -
    it's `tag=`, with support for all of the string matching modes song
    select already has (bare word for substring, `""` quotes for phrase
    isolated by whitespace, `""!` for exact full match).

  Bartłomiej Dach · 2025-07-15 11:09:40 +02:00
  8cb81974eb
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Make edits based on reviews
  Denis Titovets · 2025-07-13 23:59:59 +03:00
  b120608ec5
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-12 10:37:17 +03:00
  0065331659
• Disallow hiding beatmap difficulties if only one difficulty remains
  Dean Herbert · 2025-07-10 17:57:45 +09:00
  789ddcf395
• Remove duplicate `LocalisableString's
  Denis Titovets · 2025-07-09 16:31:51 +03:00
  7c9c2061ad
• Fix incorrect description
  Denis Titovets · 2025-07-09 15:31:42 +03:00
  2f324e3881
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-09 15:22:42 +03:00
  6fc5fa74cd
• Fully localise SSV2
  Denis Titovets · 2025-07-09 15:07:07 +03:00
  1f052bb195
• Merge pull request #33889 from frenzibyte/source-grouping

  Add mode for grouping beatmaps by their source

  Dean Herbert · 2025-07-08 17:09:45 +09:00
  3406303060
• Remove Song Select v1 implementation and update auxiliary usages
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  1048bd9ede