3312 Commits

• Use floored star rating in BeatmapCarouselFilterGrouping and AdvancedStats

  This commit changes BeatmapCarouselFilterGrouping to now use floored star
  rating when determining which group a beatmap belongs to,
  to be consistent with changes introduced here:
  https://github.com/ppy/osu/pull/33679.
  The AdvancedStats section of the original song select is also
  updated to show the floored star rating (rather than rounded).

  Chris Ehmann · 2025-06-30 19:50:11 -07:00
  32d478e19c
• RankingsSort -> LeaderboardSortMode
  Dani211e · 2025-06-26 19:03:49 +02:00
  c1a34d8c6a
• Add source grouping mode
  Salman Alshamrani · 2025-06-26 09:59:12 +03:00
  b4833d80d1
• Add sorting dropdown

  Only use sorting when on local scope otherwise hide

  Dani211e · 2025-06-25 05:01:40 +02:00
  ad35dad46d
• Merge pull request #33679 from bdach/truncate-sr

  Floor star rating to 2 decimal places rather than rounding

  Dan Balasescu · 2025-06-24 19:04:56 +09:00
  6057c6c4d4
• Fix in song select v1 too for good measure
  Dean Herbert · 2025-06-19 19:08:18 +09:00
  ef5638b6b3
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Move and rename next/previous "group" selection keybindings to make way for group-specific bindings
  Dean Herbert · 2025-06-11 21:02:52 +09:00
  b9e1b6969e
• Add support for showing leaderboard in playlists and daily challenge

  As touched on in https://github.com/ppy/osu/pull/33581.

  Bartłomiej Dach · 2025-06-11 11:21:26 +02:00
  4810c7c847
• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Fix general confusion in which combo should be read on which gameplay leaderboard

  Closes https://github.com/ppy/osu/issues/33455.
  
  The fundamental misunderstanding and source of confusion in
  https://github.com/ppy/osu/pull/33062 is that solo wants to show
  *maximum combo*, and multiplayer wants to show *current combo*, for
  their own, valid reasons. Which is spelled out explicitly in this
  change.

  Bartłomiej Dach · 2025-06-06 10:08:01 +02:00
  a92a659662
• Fix extreme Drawable thrashing on initial leaderboard population
  Dan Balasescu · 2025-06-05 23:01:31 +09:00
  218d8290cb
• Merge branch 'master' into song-select-v2-polish-2
  Bartłomiej Dach · 2025-05-30 11:07:11 +02:00
  4915e4d266
• Hide all unsupported grouping modes for now
  Dean Herbert · 2025-05-30 17:02:52 +09:00
  27fe9485bd
• Adjust filter control copy and spacing to fit text better
  Dean Herbert · 2025-05-30 02:20:57 +09:00
  b1a11061f4
• SongSelectV2: Read/write last active tab in details area from/to local configuration
  Bartłomiej Dach · 2025-05-29 14:16:41 +02:00
  8a3d979032
• SongSelectV2: Fix incorrect conditional being used for "split out" check

  🤦
  
  Have inlined the v1 usage so we don't accidentally do this again.

  Dean Herbert · 2025-05-29 01:22:22 +09:00
  ef8fd7b5d7
• remove grouping by date submitted to reduce clutter

  i doubt it would get much use anyway

  WitherFlower · 2025-05-27 21:09:24 +02:00
  80664d9b92
• add grouping support for ranked and submitted date
  WitherFlower · 2025-05-27 18:49:59 +02:00
  e6f933c1c0
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Remove obsoleted flow by using a new configuration variable

  The old one wasn't used anyway.

  Dean Herbert · 2025-05-24 01:01:17 +09:00
  cd44cab3ff
• Fix typo in comment
  Dean Herbert · 2025-05-23 19:37:22 +09:00
  ff48c4a047
• Merge branch 'master' into carousel-grouping
  Dean Herbert · 2025-05-23 19:03:09 +09:00
  0a5fbb35c5
• Add debounce to difficulty calculation operations in churn scenarios
  Dean Herbert · 2025-05-19 16:16:33 +09:00
  192a1642d4
• Tidy up GroupMode enum
  Salman Alshamrani · 2025-05-18 01:28:56 +03:00
  25a3ac2c00
• Expose general song select operations
  Salman Alshamrani · 2025-05-14 15:43:44 +03:00
  8fe422c35a
• Update framework
  Dean Herbert · 2025-05-12 17:28:20 +09:00
  b31e685380
• Update no results placeholder design to feel better alongside new song select
  Dean Herbert · 2025-05-09 02:16:56 +09:00
  f3de345d47
• Fix gameplay leaderboard score reading off wrong combo property

  Closes https://github.com/ppy/osu/issues/33006.
  
  Broke in c231571f06.
  
  The fact that this mistake can be made at all is... something, but it
  was made.

  Bartłomiej Dach · 2025-05-07 13:50:11 +02:00
  8af687f751
• Cross-reference copies of similar logic
  Bartłomiej Dach · 2025-04-30 10:25:05 +02:00
  b2032f95ff
• Merge pull request #32947 from bdach/use-actual-score-positions-in-gameplay-leaderboard

  Use actual score positions in gameplay leaderboard

  Dean Herbert · 2025-04-30 17:20:12 +09:00
  1b5553a2d8
• Remove redundant initialiser
  Bartłomiej Dach · 2025-04-28 12:21:46 +02:00
  6b298abf88
• Exclude non-user-playable mods from mod filter in beatmap leaderboard

  For easier understanding, substitute "non-user-playable" with
  "autoplay".
  
  The reason that I'm bothering to do this is that if you put autoplay on
  and turn on the "Selected Mods" filter, the request will actually go
  through and hit web, and web will obviously return no scores. On song
  select that's *maybe* fine, even though probably unintended still, but
  now with the leaderboard state being global this also means gameplay
  gets impacted. Which also means that if you Ctrl-Enter to start a map in
  autoplay you're not going to get any gameplay leaderboard scores at all.

  Bartłomiej Dach · 2025-04-25 13:06:01 +02:00
  3eb1ae225d
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Always refresh leaderboard for now
  Dean Herbert · 2025-04-23 14:51:00 +09:00
  f945abb72e
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7
• Avoid clearing global cache on entering song select
  Dean Herbert · 2025-04-22 19:29:09 +09:00
  7e6e082bac
• Move bindable list population to load complete to fix threading woes
  Bartłomiej Dach · 2025-04-21 09:05:54 +02:00
  4d08c81e8d
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Fix gameplay leaderboard showing scores from wrong beatmaps

  Kind of a big oversight this. In wanting to get the leaderboard
  refactors to move forward I sort of didn't realise the fact that all of
  the error handling related to online status and such in
  `BeatmapLeaderboard` kind of... can't stay there...
  
  It's also an all-or-nothing business too - moving this stuff can't
  really be done only in part.
  
  Not sure whether tests are warranted if it's more or less moving logic
  across?

  Bartłomiej Dach · 2025-04-18 20:37:02 +02:00
  c29f59fcdb
• Remove unnecessary interface
  Bartłomiej Dach · 2025-04-18 12:12:21 +02:00
  6d258d4ed5
• Add clarification to IsPartial xmldoc
  Bartłomiej Dach · 2025-04-18 12:02:21 +02:00
  006670c442
• Attempt to fix tests
  Bartłomiej Dach · 2025-04-17 14:26:34 +02:00
  d546bbaf8f
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Merge pull request #32815 from peppy/global-shear

  Change global shear definition to be a `Vector2`

  Dean Herbert · 2025-04-16 18:34:39 +09:00
  572bc6d8b4
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Fix local leaderboards not showing when starting game offline

  Broke in https://github.com/ppy/osu/pull/32494. Oops.

  Bartłomiej Dach · 2025-04-16 10:27:33 +02:00
  cf2f6d7233
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f