888 Commits

• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Allow adjusting beatmap offset automatically based on last play
  Salman Alshamrani · 2025-08-11 10:37:31 +03:00
  de0eb7ccf3
• Ensure that task source is not left hanging if work never completes

  This could be the case if the results screen goes away and is no longer
  running the update/scheduler loop.

  Dean Herbert · 2025-08-04 17:01:27 +09:00
  0353b1461f
• Assert that FetchWithCriteria is called from the update thread
  Salman Alshamrani · 2025-08-04 17:01:27 +09:00
  c09f40a8cf
• Always fetch leaderboard with score sort mode in solo results

  This is borderline pedantic and mostly irrelevant but I think it makes
  some sense for a bit of extra safety. It definitely does not fix any
  bugs (that I'm aware of).

  Bartłomiej Dach · 2025-07-31 10:20:03 +02:00
  7a263efaa2
• Add test coverage of read-only scenario
  Dean Herbert · 2025-07-29 16:46:07 +09:00
  988f1a4e76
• Merge branch 'master' into NotStirred/master
  Dean Herbert · 2025-07-29 16:36:37 +09:00
  2dde5b1eaf
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-28 19:12:34 +03:00
  6936533522
• Merge branch 'master' into local-score-sorting-v2
  Bartłomiej Dach · 2025-07-28 11:32:59 +02:00
  c620d58bc2
• Fully localise SSV2
  Denis Titovets · 2025-07-09 15:07:07 +03:00
  1f052bb195
• Explicitly explain to users that failed plays do not give pp on results screen

  Addresses https://osu.ppy.sh/community/forums/topics/2096912.

  Bartłomiej Dach · 2025-06-27 13:24:45 +02:00
  360ba548dc
• RankingsSort -> LeaderboardSortMode
  Dani211e · 2025-06-26 19:03:49 +02:00
  c1a34d8c6a
• Fix user tags moving in the control after voting

  Closes https://github.com/ppy/osu/issues/33877.
  
  Most likely regressed when the user tags were changed such that the
  loading spinner that shows on adding/removing a vote was introdiced to
  every individual tag separately. This in turn means that the
  `LoadingLayer` responsible for showing the spinner also briefly consumes
  all input when visible, which also means that the control briefly
  becomes unhovered, breaking the logic.
  
  This probably doesn't work on mobile because mobile input sucks. On iOS
  simulator it looks somewhat fine in that the tags don't move until you
  touch the screen anywhere else which seems okay if that's what actually
  what happens on device as well. And if it isn't I'm not sure I can do
  anything sane about it anyway.

  Bartłomiej Dach · 2025-06-25 11:16:18 +02:00
  7975120d5d
• Add failing test case
  Bartłomiej Dach · 2025-06-25 11:01:53 +02:00
  ee2a247c66
• Persist sorting between results screen and song select
  Dani211e · 2025-06-25 05:01:40 +02:00
  d04094a2c4
• Calculate pp difference post-rounding everywhere
  Bartłomiej Dach · 2025-06-24 11:46:40 +02:00
  b1e86aa92f
• Address review comments
  Tom Martin · 2025-06-11 04:34:13 +01:00
  33905f2e70
• Merge pull request #33610 from bdach/solo-results-show-local

  Fix results screen not showing local scores on results screen for some beatmap statuses

  Dean Herbert · 2025-06-10 21:50:39 +09:00
  a5ad09385f
• Do not attempt to add displayed score to list of sorted scores more than once

  This is a very dodgy fix, but it fixes an edge case that has so far - to
  my knowledge - not been reported by users in the wild, only by me trying
  to break things, so my hope is that we can do this and move on for now.

  Bartłomiej Dach · 2025-06-10 12:32:03 +02:00
  c84988a2ec
• Fix results screen not showing local scores on results screen for some beatmap statuses

  Closes https://github.com/ppy/osu/issues/33609.
  
  Case of leftover code that should have been removed.
  
  This condition is still active in the online leaderboards path via
  
  	https://github.com/ppy/osu/blob/4dcc928c7e46e020c62f4d60e7b859ba18c9142f/osu.Game/Online/Leaderboards/LeaderboardManager.cs#L91-L95
  
  Not sure trying to add test coverage is a productive use of time? Will
  do on request though.

  Bartłomiej Dach · 2025-06-10 10:51:30 +02:00
  de57daeb3c
• Fix presenting another user's score hiding local user's score on results screen

  Closes https://github.com/ppy/osu/issues/33567.

  Bartłomiej Dach · 2025-06-09 11:11:16 +02:00
  19114c7415
• Always allow a map's user-tags to be read
  Tom Martin · 2025-06-07 22:51:13 +01:00
  934e529eca
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Do not show previous best score on solo results screen if the local user just beat it

  Closes https://github.com/ppy/osu/issues/33109.

  Bartłomiej Dach · 2025-05-13 10:17:09 +02:00
  a5ea24e37b
• Cross-reference copies of similar logic
  Bartłomiej Dach · 2025-04-30 10:25:05 +02:00
  b2032f95ff
• Fix badly phrased comment
  Bartłomiej Dach · 2025-04-30 09:57:30 +02:00
  be91392760
• Use more correct accounting of positions on results screen
  Bartłomiej Dach · 2025-04-29 12:58:30 +02:00
  82a866e475
• Use leaderboard criteria set in song select on results screen too
  Bartłomiej Dach · 2025-04-29 12:58:01 +02:00
  6ee282dadc
• Fix user tags potentially re-flowing on mouse down

  Closes https://github.com/ppy/osu/issues/32954.

  Dean Herbert · 2025-04-28 14:48:05 +09:00
  4dcc63df9d
• Split UserTagControl out into partial classes
  Dean Herbert · 2025-04-28 14:36:43 +09:00
  61b77f9dd1
• Revert "Use median for statistic display"

  This reverts commit fa06643bb6.
  
  Revert "Remove mean hit error calculation"
  
  This reverts commit b3c578e545.

  Dean Herbert · 2025-04-11 02:12:40 +09:00
  ba5932c1dd
• Simplify animation application and remove autosizeduration hack
  Dean Herbert · 2025-04-08 14:02:59 +09:00
  0bb085bce6
• Add transition when vote-count changes in UserTagControl
  Marvin Schürz · 2025-04-07 16:37:25 +02:00
  7f52952840
• Close popovers on hiding the statistics view

  Now that the tagging popover is back,
  https://github.com/ppy/osu/issues/32630 actually needs fixing.

  Bartłomiej Dach · 2025-04-07 14:48:26 +02:00
  11e48f9f8e
• Allow tag control popover to attach to bottom too

  Looks bad when trying to tag on a replay otherwise.

  Bartłomiej Dach · 2025-04-07 14:45:38 +02:00
  cded1311c8
• Cache aquamarine colour provider at results screen

  To fix the user tag control.
  
  I would have done it locally to the user tag control, but it was pissing
  me off because I wanted the add button to be aquamarine (as it's closer
  to the accents the screen is already using), but the popover on open was
  for whatever reason purple and I just want consistency where possible.

  Bartłomiej Dach · 2025-04-07 14:39:37 +02:00
  23c711d1bc
• Allow multiple in-flight requests
  Dean Herbert · 2025-04-07 20:28:45 +09:00
  b874eea0c5
• Move loading inline to individual tags
  Dean Herbert · 2025-04-07 20:22:49 +09:00
  f8d063a394
• Switch to using a popover again
  Dean Herbert · 2025-04-07 20:14:08 +09:00
  43ee43c9e2
• Remove flow animations

  They don't look great, so let's just get something out which doesn't
  involve things flying everywhere to start with.

  Dean Herbert · 2025-04-03 19:19:34 +09:00
  769e0bd4ff
• Adjust mouse down animation in a better way (and apply to small tag buttons too)
  Dean Herbert · 2025-04-03 19:19:06 +09:00
  2a3241fd48
• Merge branch 'master' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-03 11:59:16 +02:00
  375beae8a9
• Merge pull request #32657 from bdach/ruleset-specific-user-tags

  Add support for ruleset-specific user tags

  Dean Herbert · 2025-04-03 18:58:05 +09:00
  42a7094f9c
• Merge branch 'ruleset-specific-user-tags' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-02 13:28:28 +02:00
  ad334b2bf4
• Add support for ruleset-specific user tags

  Follow-up from https://github.com/ppy/osu-web/pull/12059

  Bartłomiej Dach · 2025-04-02 13:12:49 +02:00
  22f2c6f7b9
• Adjust glow
  Bartłomiej Dach · 2025-04-01 14:35:28 +02:00
  e4147f4f0b
• Adjust font weights
  Bartłomiej Dach · 2025-04-01 14:34:24 +02:00
  33c4c142b7
• Fix corner radii not matching
  Bartłomiej Dach · 2025-04-01 14:30:30 +02:00
  b614887e26
• Compromise between popover and persistent view with a slideout
  Bartłomiej Dach · 2025-04-01 14:29:50 +02:00
  ffed666b97